Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Cleanup the discovery realm/world after new extension components are found. 

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587690 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
John Dennis Casey 2007-10-23 23:14:28 +00:00
parent efd372c24a
commit 7c1b32bfc0
1 changed files with 72 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

124
maven-core/src/main/java/org/apache/maven/extension/DefaultExtensionManager.java
View File

@ -64,6 +64,7 @@ import org.codehaus.plexus.logging.AbstractLogEnabled;
import org.codehaus.plexus.personality.plexus.lifecycle.phase.Contextualizable; import org.codehaus.plexus.personality.plexus.lifecycle.phase.Contextualizable;
import java.net.MalformedURLException; import java.net.MalformedURLException;
import java.util.Collection;
import java.util.Collections; import java.util.Collections;
import java.util.HashSet; import java.util.HashSet;
import java.util.Iterator; import java.util.Iterator;
@ -291,71 +292,90 @@ public class DefaultExtensionManager
{ {
String projectId = projectSession.getProjectId(); String projectId = projectSession.getProjectId();
// Create an entire new ClassWorld, ClassRealm for discovering ClassWorld discoveryWorld = new ClassWorld();
// the immediate components of the extension artifact, so we don't pollute the
// container with component descriptors or realms that don't have any meaning beyond discovery.
ClassRealm discoveryRealm = new ClassRealm( new ClassWorld(), "discovery", Thread.currentThread().getContextClassLoader() );
try try
{ {
discoveryRealm.addURL( extensionArtifact.getFile().toURL() ); // Create an entire new ClassWorld, ClassRealm for discovering
} // the immediate components of the extension artifact, so we don't pollute the
catch ( MalformedURLException e ) // container with component descriptors or realms that don't have any meaning beyond discovery.
{ ClassRealm discoveryRealm = new ClassRealm( discoveryWorld, "discovery", Thread.currentThread().getContextClassLoader() );
throw new ExtensionManagerException( "Unable to generate URL from extension artifact for local-component discovery: " + extensionArtifact.getFile(), extensionArtifact, projectId, e ); try
}
ComponentDiscoverer discoverer = new DefaultComponentDiscoverer();
discoverer.setManager( new DummyDiscovererManager() );
ClassRealm projectRealm = projectSession.getProjectRealm();
try
{
// Find the extension component descriptors that exist ONLY in the immediate extension
// artifact...this prevents us from adding plexus-archiver components to the mix, for instance,
// when the extension uses that dependency.
List componentSetDescriptors = discoverer.findComponents( container.getContext(), discoveryRealm );
for ( Iterator it = componentSetDescriptors.iterator(); it.hasNext(); )
{ {
ComponentSetDescriptor compSet = (ComponentSetDescriptor) it.next(); discoveryRealm.addURL( extensionArtifact.getFile().toURL() );
for ( Iterator compIt = compSet.getComponents().iterator(); compIt.hasNext(); ) }
catch ( MalformedURLException e )
{
throw new ExtensionManagerException( "Unable to generate URL from extension artifact for local-component discovery: " + extensionArtifact.getFile(), extensionArtifact, projectId, e );
}
ComponentDiscoverer discoverer = new DefaultComponentDiscoverer();
discoverer.setManager( new DummyDiscovererManager() );
ClassRealm projectRealm = projectSession.getProjectRealm();
try
{
// Find the extension component descriptors that exist ONLY in the immediate extension
// artifact...this prevents us from adding plexus-archiver components to the mix, for instance,
// when the extension uses that dependency.
List componentSetDescriptors = discoverer.findComponents( container.getContext(), discoveryRealm );
for ( Iterator it = componentSetDescriptors.iterator(); it.hasNext(); )
{ {
// For each component in the extension artifact: ComponentSetDescriptor compSet = (ComponentSetDescriptor) it.next();
ComponentDescriptor comp = (ComponentDescriptor) compIt.next(); for ( Iterator compIt = compSet.getComponents().iterator(); compIt.hasNext(); )
String implementation = comp.getImplementation();
try
{ {
getLogger().debug( "Importing: " + implementation + "\nwith role: " + comp.getRole() + "\nand hint: " + comp.getRoleHint() + "\nfrom extension realm: " + extensionRealm.getId() + "\nto project realm: " + projectRealm.getId() ); // For each component in the extension artifact:
ComponentDescriptor comp = (ComponentDescriptor) compIt.next();
String implementation = comp.getImplementation();
// Import the extension component's implementation class into the project-level try
// realm. {
projectRealm.importFrom( extensionRealm.getId(), implementation ); getLogger().debug( "Importing: " + implementation + "\nwith role: " + comp.getRole() + "\nand hint: " + comp.getRoleHint() + "\nfrom extension realm: " + extensionRealm.getId() + "\nto project realm: " + projectRealm.getId() );
// Set the realmId to be used in looking up this extension component to the // Import the extension component's implementation class into the project-level
// project-level realm, since we now have a restricted import // realm.
// that allows most of the extension to stay hidden, and the projectRealm.importFrom( extensionRealm.getId(), implementation );
// specific local extension components are still accessible
// from the project-level realm.
comp.setRealmId( projectRealm.getId() );
// Finally, add the extension component's descriptor (with projectRealm // Set the realmId to be used in looking up this extension component to the
// set as the lookup realm) to the container. // project-level realm, since we now have a restricted import
container.addComponentDescriptor( comp ); // that allows most of the extension to stay hidden, and the
} // specific local extension components are still accessible
catch ( NoSuchRealmException e ) // from the project-level realm.
{ comp.setRealmId( projectRealm.getId() );
throw new ExtensionManagerException( "Failed to create import for component: " + implementation + " from extension realm: " + extensionRealm.getId() + " to project realm: " + projectRealm.getId(), extensionArtifact, projectId, e );
// Finally, add the extension component's descriptor (with projectRealm
// set as the lookup realm) to the container.
container.addComponentDescriptor( comp );
}
catch ( NoSuchRealmException e )
{
throw new ExtensionManagerException( "Failed to create import for component: " + implementation + " from extension realm: " + extensionRealm.getId() + " to project realm: " + projectRealm.getId(), extensionArtifact, projectId, e );
}
} }
} }
} }
catch ( PlexusConfigurationException e )
{
throw new ExtensionManagerException( "Unable to discover extension components.", extensionArtifact, projectId, e );
}
catch ( ComponentRepositoryException e )
{
throw new ExtensionManagerException( "Unable to discover extension components from imports added to project-session realm.", extensionArtifact, projectId, e );
}
} }
catch ( PlexusConfigurationException e ) finally
{ {
throw new ExtensionManagerException( "Unable to discover extension components.", extensionArtifact, projectId, e ); Collection realms = discoveryWorld.getRealms();
} for ( Iterator it = realms.iterator(); it.hasNext(); )
catch ( ComponentRepositoryException e ) {
{ ClassRealm realm = (ClassRealm) it.next();
throw new ExtensionManagerException( "Unable to discover extension components from imports added to project-session realm.", extensionArtifact, projectId, e ); try
{
discoveryWorld.disposeRealm( realm.getId() );
}
catch ( NoSuchRealmException e )
{
}
}
} }
} }