mirror of https://github.com/apache/maven.git
[MNG-8294] Consistency checks when loading parent (#383)
This commit is contained in:
Guillaume Nodet
GitHub
parent
2ce2200086
commit
83f034d177
|
|
@ -0,0 +1,116 @@
|
|||
/*
|
||||
* Licensed to the Apache Software Foundation (ASF) under one
|
||||
* or more contributor license agreements. See the NOTICE file
|
||||
* distributed with this work for additional information
|
||||
* regarding copyright ownership. The ASF licenses this file
|
||||
* to you under the Apache License, Version 2.0 (the
|
||||
* "License"); you may not use this file except in compliance
|
||||
* with the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
package org.apache.maven.it;
|
||||
|
||||
import java.io.File;
|
||||
|
||||
import org.apache.maven.shared.verifier.VerificationException;
|
||||
import org.apache.maven.shared.verifier.Verifier;
|
||||
import org.apache.maven.shared.verifier.util.ResourceExtractor;
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertThrows;
|
||||
|
||||
/**
|
||||
* This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-8288">MNG-8288</a>.
|
||||
*/
|
||||
class MavenITmng8294ParentChecksTest extends AbstractMavenIntegrationTestCase {
|
||||
|
||||
MavenITmng8294ParentChecksTest() {
|
||||
super("[4.0.0-beta-5,)");
|
||||
}
|
||||
|
||||
/**
|
||||
* Verify error when mismatch between GAV and relativePath
|
||||
*/
|
||||
@Test
|
||||
void testitbadMismatch() throws Exception {
|
||||
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-8294-parent-checks");
|
||||
|
||||
Verifier verifier = newVerifier(new File(testDir, "bad-mismatch").getAbsolutePath());
|
||||
verifier.addCliArgument("validate");
|
||||
assertThrows(VerificationException.class, verifier::execute);
|
||||
verifier.verifyTextInLog(
|
||||
"at org.apache.maven.its.mng8294:parent instead of org.apache.maven.its.mng8294:bad-parent");
|
||||
}
|
||||
|
||||
/**
|
||||
* Verify error when the parent is not resolvable
|
||||
*/
|
||||
@Test
|
||||
void testitbadNonResolvable() throws Exception {
|
||||
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-8294-parent-checks");
|
||||
|
||||
Verifier verifier = newVerifier(new File(testDir, "bad-non-resolvable").getAbsolutePath());
|
||||
verifier.addCliArgument("validate");
|
||||
assertThrows(VerificationException.class, verifier::execute);
|
||||
verifier.verifyTextInLog(
|
||||
"The following artifacts could not be resolved: org.apache.maven.its.mng8294:parent:pom:0.1-SNAPSHOT");
|
||||
}
|
||||
|
||||
/**
|
||||
* Verify error when a wrong path
|
||||
*/
|
||||
@Test
|
||||
void testitbadWrongPath() throws Exception {
|
||||
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-8294-parent-checks");
|
||||
|
||||
Verifier verifier = newVerifier(new File(testDir, "bad-wrong-path").getAbsolutePath());
|
||||
verifier.addCliArgument("validate");
|
||||
assertThrows(VerificationException.class, verifier::execute);
|
||||
verifier.verifyTextInLog("points at '../foo' but no POM could be found");
|
||||
}
|
||||
|
||||
/**
|
||||
* Verify error when a wrong path
|
||||
*/
|
||||
@Test
|
||||
void testitokUsingEmpty() throws Exception {
|
||||
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-8294-parent-checks");
|
||||
|
||||
Verifier verifier = newVerifier(new File(testDir, "ok-using-empty").getAbsolutePath());
|
||||
verifier.addCliArgument("validate");
|
||||
verifier.execute();
|
||||
verifier.verifyErrorFreeLog();
|
||||
}
|
||||
/**
|
||||
* Verify error when a wrong path
|
||||
*/
|
||||
@Test
|
||||
void testitokUsingGav() throws Exception {
|
||||
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-8294-parent-checks");
|
||||
|
||||
Verifier verifier = newVerifier(new File(testDir, "ok-using-gav").getAbsolutePath());
|
||||
verifier.addCliArgument("validate");
|
||||
verifier.execute();
|
||||
verifier.verifyErrorFreeLog();
|
||||
}
|
||||
/**
|
||||
* Verify error when a wrong path
|
||||
*/
|
||||
@Test
|
||||
void testitokUsingPath() throws Exception {
|
||||
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-8294-parent-checks");
|
||||
|
||||
Verifier verifier = newVerifier(new File(testDir, "ok-using-path").getAbsolutePath());
|
||||
verifier.addCliArgument("validate");
|
||||
verifier.execute();
|
||||
verifier.verifyErrorFreeLog();
|
||||
}
|
||||
}
|
||||
|
|
@ -120,6 +120,7 @@ public class TestSuiteOrdering implements ClassOrderer {
|
|||
* the tests are to finishing. Newer tests are also more likely to fail, so this is
|
||||
* a fail fast technique as well.
|
||||
*/
|
||||
suite.addTestSuite(MavenITmng8294ParentChecksTest.class);
|
||||
suite.addTestSuite(MavenITmng8293BomImportFromReactor.class);
|
||||
suite.addTestSuite(MavenITmng8288NoRootPomTest.class);
|
||||
suite.addTestSuite(MavenITmng8133RootDirectoryInParentTest.class);
|
||||
|
|
|
|||
|
|
@ -0,0 +1,11 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0">
|
||||
<parent>
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>bad-parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
<relativePath>..</relativePath>
|
||||
</parent>
|
||||
|
||||
<artifactId>myArtifact</artifactId>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0" root="true">
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
<packaging>pom</packaging>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,9 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0" root="true">
|
||||
<parent>
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
</parent>
|
||||
<artifactId>myArtifact</artifactId>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,9 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0" root="true">
|
||||
<parent>
|
||||
<relativePath>../foo</relativePath>
|
||||
</parent>
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,5 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0">
|
||||
<parent />
|
||||
<artifactId>myArtifact</artifactId>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0" root="true">
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
<packaging>pom</packaging>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,10 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0">
|
||||
<parent>
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
</parent>
|
||||
|
||||
<artifactId>myArtifact</artifactId>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0" root="true">
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
<packaging>pom</packaging>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,8 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0">
|
||||
<parent>
|
||||
<relativePath>..</relativePath>
|
||||
</parent>
|
||||
|
||||
<artifactId>myArtifact</artifactId>
|
||||
</project>
|
||||
|
|
@ -0,0 +1,7 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<project xmlns="http://maven.apache.org/POM/4.1.0" root="true">
|
||||
<groupId>org.apache.maven.its.mng8294</groupId>
|
||||
<artifactId>parent</artifactId>
|
||||
<version>0.1-SNAPSHOT</version>
|
||||
<packaging>pom</packaging>
|
||||
</project>
|
||||
Loading…
Reference in New Issue