From 867b217a2ce691fc5c89458522d6a6efd6abf13f Mon Sep 17 00:00:00 2001
From: Benjamin Bentmann <bentmann@apache.org>
Date: Sat, 1 Aug 2009 23:14:42 +0000
Subject: [PATCH] [MNG-4274] [regression] Plugins with an undeclared but
 transitive dependency on plexus-utils get wrong version of p-u

o Added IT

git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@799959 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/maven/it/IntegrationTestSuite.java |  1 +
 ...avenITmng4274PluginRealmArtifactsTest.java | 67 ++++++++++++++++++
 .../src/test/resources/mng-4274/pom.xml       | 68 +++++++++++++++++++
 3 files changed, 136 insertions(+)
 create mode 100644 its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4274PluginRealmArtifactsTest.java
 create mode 100644 its/core-it-suite/src/test/resources/mng-4274/pom.xml

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
index 43abb6a11e..ddd3e52dc3 100644
--- a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
+++ b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
@@ -86,6 +86,7 @@ public class IntegrationTestSuite
         // suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class );
         // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137
 
+        suite.addTestSuite( MavenITmng4274PluginRealmArtifactsTest.class );
         suite.addTestSuite( MavenITmng4273RestrictedCoreRealmAccessForPluginTest.class );
         suite.addTestSuite( MavenITmng4270ArtifactHandlersFromPluginDepsTest.class );
         suite.addTestSuite( MavenITmng4269BadReactorResolutionFromOutDirTest.class );
diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4274PluginRealmArtifactsTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4274PluginRealmArtifactsTest.java
new file mode 100644
index 0000000000..d0e4d45933
--- /dev/null
+++ b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4274PluginRealmArtifactsTest.java
@@ -0,0 +1,67 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Properties;
+
+/**
+ * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-4274">MNG-4274</a>.
+ *
+ * @author Benjamin Bentmann
+ */
+public class MavenITmng4274PluginRealmArtifactsTest
+    extends AbstractMavenIntegrationTestCase
+{
+
+    public MavenITmng4274PluginRealmArtifactsTest()
+    {
+        super( "[2.0.6,)" );
+    }
+
+    /**
+     * Verify that plugins with an undeclared dependency on plexus-utils that is brought in as a transitive dependency
+     * of some Maven core artifact get the proper version of plexus-utils. For clarity, the proper version is the
+     * version that the original core artifact specified as dependency, not the version shipped with the current core.
+     */
+    public void testit()
+        throws Exception
+    {
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4274" );
+
+        Verifier verifier = new Verifier( testDir.getAbsolutePath() );
+        verifier.setAutoclean( false );
+        verifier.executeGoal( "validate" );
+        verifier.verifyErrorFreeLog();
+        verifier.resetStreams();
+
+        Properties props = verifier.loadProperties( "target/class.properties" );
+        String prop = props.getProperty( "org.codehaus.plexus.util.Expand.methods", "" );
+        Collection methods = Arrays.asList( prop.split( "," ) );
+        assertTrue( methods.toString(), methods.contains( "normalize" ) );
+        assertTrue( methods.toString(), methods.contains( "resolveFile" ) );
+    }
+
+}
diff --git a/its/core-it-suite/src/test/resources/mng-4274/pom.xml b/its/core-it-suite/src/test/resources/mng-4274/pom.xml
new file mode 100644
index 0000000000..d00719402c
--- /dev/null
+++ b/its/core-it-suite/src/test/resources/mng-4274/pom.xml
@@ -0,0 +1,68 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>org.apache.maven.its.mng4274</groupId>
+  <artifactId>test</artifactId>
+  <version>0.1</version>
+  <packaging>maven-plugin</packaging>
+
+  <name>Maven Integration Test :: MNG-4274</name>
+  <description>
+    Verify that plugins with an undeclared dependency on plexus-utils that is brought in as a transitive dependency
+    of some Maven core artifact get the proper version of plexus-utils. For clarity, the proper version is the
+    version that the original core artifact specified as dependency, not the version shipped with the current core.
+  </description>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.its.plugins</groupId>
+        <artifactId>maven-it-plugin-class-loader</artifactId>
+        <version>2.1-SNAPSHOT</version>
+        <dependencies>
+          <dependency>
+            <!-- NOTE: This depends on plexus-utils:1.0.4 -->
+            <groupId>org.apache.maven</groupId>
+            <artifactId>maven-project</artifactId>
+            <version>2.0</version>
+          </dependency>
+        </dependencies>
+        <configuration>
+          <pluginClassLoaderOutput>target/class.properties</pluginClassLoaderOutput>
+          <!-- NOTE: In newer version of plexus-utils, methods have been removed from this class -->
+          <classNames>org.codehaus.plexus.util.Expand</classNames>
+        </configuration>
+        <executions>
+          <execution>
+            <id>test</id>
+            <phase>validate</phase>
+            <goals>
+              <goal>load</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>