Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PR: MNG-764 

Submitted by: Edwin Punzalan
validation error if aggregator containing modules is not of the right packaging


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@330003 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Brett Leslie Porter 2005-11-01 07:37:57 +00:00
parent 76a0f452c2
commit 87dc3a9e16
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
maven-project/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
View File

@ -54,6 +54,12 @@ public class DefaultModelValidator
validateId( "artifactId", result, model.getArtifactId() ); validateId( "artifactId", result, model.getArtifactId() );
validateStringNotEmpty( "packaging", result, model.getPackaging() ); validateStringNotEmpty( "packaging", result, model.getPackaging() );
if ( !model.getModules().isEmpty() && !"pom".equals( model.getPackaging() ) )
{
result.addMessage( "Packaging '" + model.getPackaging() + "' is invalid. Aggregator projects " +
"require 'pom' as packaging." );
}
validateStringNotEmpty( "version", result, model.getVersion() ); validateStringNotEmpty( "version", result, model.getVersion() );

10
maven-project/src/test/java/org/apache/maven/project/validation/DefaultModelValidatorTest.java
View File

@ -96,6 +96,16 @@ public class DefaultModelValidatorTest
assertEquals( "'version' is missing.", result.getMessage( 0 ) ); assertEquals( "'version' is missing.", result.getMessage( 0 ) );
} }
public void testInvalidAggregatorPackaging()
throws Exception
{
ModelValidationResult result = validate( "invalid-aggregator-packaging-pom.xml" );
assertEquals( 1, result.getMessageCount() );
assertTrue( result.getMessage( 0 ).indexOf( "Aggregator projects require 'pom' as packaging." ) > -1 );
}
public void testMissingDependencyArtifactId() public void testMissingDependencyArtifactId()
throws Exception throws Exception