Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

o adding method to get a list of plugins that correspond to a lifecycle for configuration merging by the builder 

git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@769214 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Jason van Zyl 2009-04-28 00:48:53 +00:00
parent e10d95d4e1
commit 93e27192b7
3 changed files with 53 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java
View File

@ -19,8 +19,10 @@ import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.StringTokenizer;
import org.apache.maven.execution.MavenSession;
@ -41,11 +43,13 @@ import org.codehaus.plexus.component.annotations.Requirement;
import org.codehaus.plexus.logging.Logger;
import org.codehaus.plexus.personality.plexus.lifecycle.phase.Initializable;
import org.codehaus.plexus.personality.plexus.lifecycle.phase.InitializationException;
import org.codehaus.plexus.util.StringUtils;
//TODO: The configuration for the lifecycle needs to be externalized so that I can use the annotations
// properly for the wiring and reference and external source for the lifecycle configuration.
//TODO: Inside an IDE we are replacing the notion of our reactor with a workspace. In both of these cases
// we need to layer these as local repositories.
//TODO: Cache the lookups of the PluginDescriptors
/**
* @author Jason van Zyl
@ -69,6 +73,8 @@ public class DefaultLifecycleExecutor
// @Configuration(source="org/apache/maven/lifecycle/lifecycles.xml")
private List<Lifecycle> lifecycles;
private Map<String,Lifecycle> lifecycleMap;
private Map<String, Lifecycle> phaseToLifecycleMap;
public void execute( MavenSession session )
@ -186,7 +192,29 @@ public class DefaultLifecycleExecutor
}
}
}
public Set<Plugin> lifecyclePlugins( String lifecycleId, String packaging )
{
Set<Plugin> plugins = new LinkedHashSet<Plugin>();
Lifecycle lifecycle = lifecycleMap.get( lifecycleId );
LifecycleMapping lifecycleMappingForPackaging = lifecycleMappings.get( packaging );
Map<String, String> lifecyclePhasesForPackaging = lifecycleMappingForPackaging.getLifecycles().get( lifecycleId ).getPhases();
for ( String s : lifecyclePhasesForPackaging.values() )
{
String[] p = StringUtils.split( s, ":" );
Plugin plugin = new Plugin();
plugin.setGroupId( p[0] );
plugin.setArtifactId( p[1] );
plugins.add( plugin );
}
return plugins;
}
// 1. Find the lifecycle given the phase (default lifecycle when given install)
// 2. Find the lifecycle mapping that corresponds to the project packaging (jar lifecycle mapping given the jar packaging)
// 3. Find the mojos associated with the lifecycle given the project packaging (jar lifecycle mapping for the default lifecycle)
@ -293,14 +321,9 @@ public class DefaultLifecycleExecutor
{
String s = plugin.getGroupId() + ":" + plugin.getArtifactId() + ":" + plugin.getVersion() + ":" + goal;
MojoDescriptor md = getMojoDescriptor( s, session, project );
boolean include = lifecycle.getPhases().contains( md.getPhase() );
// System.out.println( ">>> " + goal );
// System.out.println( ">>> " + md.getPhase() );
// System.out.println( ">>> " + include );
// need to know if this plugin belongs to a phase in the lifecycle that's running
if ( md.getPhase() != null && include )
if ( md.getPhase() != null && lifecycle.getPhases().contains( md.getPhase() ) )
{
phaseToMojoMapping.get( md.getPhase() ).add( s );
}
@ -423,17 +446,19 @@ public class DefaultLifecycleExecutor
return mojoDescriptor;
}
public void initialize()
throws InitializationException
{
lifecycleMap = new HashMap<String,Lifecycle>();
// If people are going to make their own lifecycles then we need to tell people how to namespace them correctly so
// that they don't interfere with internally defined lifecycles.
phaseToLifecycleMap = new HashMap<String,Lifecycle>();
for ( Lifecycle lifecycle : lifecycles )
{
{
for ( String phase : lifecycle.getPhases() )
{
// The first definition wins.
@ -442,6 +467,8 @@ public class DefaultLifecycleExecutor
phaseToLifecycleMap.put( phase, lifecycle );
}
}
lifecycleMap.put( lifecycle.getId(), lifecycle );
}
}

5
maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutor.java
View File

@ -20,11 +20,14 @@ package org.apache.maven.lifecycle;
*/
import java.util.List;
import java.util.Set;
import org.apache.maven.BuildFailureException;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.model.Plugin;
import org.apache.maven.plugin.MojoFailureException;
import org.apache.maven.plugin.descriptor.MojoDescriptor;
import org.apache.maven.project.MavenProject;
/**
* @author Jason van Zyl
@ -44,6 +47,8 @@ public interface LifecycleExecutor
List<MojoDescriptor> calculateLifecyclePlan( String lifecyclePhase, MavenSession session )
throws LifecycleExecutionException;
Set<Plugin> lifecyclePlugins( String lifecycleId, String packaging );
void execute( MavenSession session )
throws LifecycleExecutionException, MojoFailureException;
}

11
maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java
View File

@ -1,10 +1,13 @@
package org.apache.maven.lifecycle;
import java.io.File;
import java.util.ArrayList;
import java.util.List;
import java.util.Set;
import org.apache.maven.AbstractCoreMavenComponentTestCase;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.model.Plugin;
import org.apache.maven.plugin.MojoExecution;
import org.apache.maven.plugin.PluginManager;
import org.apache.maven.plugin.descriptor.MojoDescriptor;
@ -79,4 +82,12 @@ public class LifecycleExecutorTest
assertEquals( "1.0", session.getCurrentProject().getVersion() );
lifecycleExecutor.execute( session );
}
public void testLifecyclePluginsRetrievalForDefaultLifecycle()
throws Exception
{
List<Plugin> plugins = new ArrayList<Plugin>( lifecycleExecutor.lifecyclePlugins( "default", "jar" ) );
assertEquals( 6, plugins.size() );
}
}