Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PR: MNG-1043 

Submitted by: Ken Weiner
Reviewed by:  Brett Porter
configure the target JDK in PMD report plugin

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@292390 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Brett Leslie Porter 2005-09-29 05:35:26 +00:00
parent 793b8002cd
commit 94468725f6
1 changed files with 40 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
maven-plugins/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
View File

@ -22,7 +22,9 @@ import net.sourceforge.pmd.Report;
import net.sourceforge.pmd.RuleContext; import net.sourceforge.pmd.RuleContext;
import net.sourceforge.pmd.RuleSet; import net.sourceforge.pmd.RuleSet;
import net.sourceforge.pmd.RuleSetFactory; import net.sourceforge.pmd.RuleSetFactory;
import net.sourceforge.pmd.TargetJDK1_3;
import net.sourceforge.pmd.TargetJDK1_4;
import net.sourceforge.pmd.TargetJDK1_5;
import org.apache.maven.project.MavenProject; import org.apache.maven.project.MavenProject;
import org.apache.maven.reporting.AbstractMavenReport; import org.apache.maven.reporting.AbstractMavenReport;
import org.apache.maven.reporting.MavenReportException; import org.apache.maven.reporting.MavenReportException;
@ -45,11 +47,10 @@ import java.util.ResourceBundle;
/** /**
* Implement the PMD report. * Implement the PMD report.
* *
* @goal pmd
*
* @todo needs to support the multiple source roots
* @author Brett Porter * @author Brett Porter
* @version $Id: PmdReport.java,v 1.3 2005/02/23 00:08:53 brett Exp $ * @version $Id: PmdReport.java,v 1.3 2005/02/23 00:08:53 brett Exp $
* @goal pmd
* @todo needs to support the multiple source roots
*/ */
public class PmdReport public class PmdReport
extends AbstractMavenReport extends AbstractMavenReport
@ -74,6 +75,11 @@ public class PmdReport
*/ */
private MavenProject project; private MavenProject project;
/**
* @parameter expression="${targetJdk}
*/
private String targetJdk;
/** /**
* @see org.apache.maven.reporting.MavenReport#getName(java.util.Locale) * @see org.apache.maven.reporting.MavenReport#getName(java.util.Locale)
*/ */
@ -122,7 +128,7 @@ public class PmdReport
{ {
Sink sink = getSink(); Sink sink = getSink();
PMD pmd = new PMD(); PMD pmd = getPMD();
RuleContext ruleContext = new RuleContext(); RuleContext ruleContext = new RuleContext();
Report report = new Report(); Report report = new Report();
// TODO: use source roots instead // TODO: use source roots instead
@ -193,6 +199,34 @@ public class PmdReport
reportSink.endDocument(); reportSink.endDocument();
} }
/**
* Constructs the PMD class, passing it an argument
* that configures the target JDK.
*
* @return the resulting PMD
*/
public PMD getPMD()
{
PMD pmd;
if ( "1.5".equals( targetJdk ) )
{
pmd = new PMD( new TargetJDK1_5() );
}
else if ( "1.4".equals( targetJdk ) )
{
pmd = new PMD( new TargetJDK1_4() );
}
else if ( "1.3".equals( targetJdk ) )
{
pmd = new PMD( new TargetJDK1_3() );
}
else
{
pmd = new PMD();
}
return pmd;
}
/** /**
* @see org.apache.maven.reporting.MavenReport#getOutputName() * @see org.apache.maven.reporting.MavenReport#getOutputName()
*/ */
@ -229,6 +263,6 @@ public class PmdReport
private static ResourceBundle getBundle( Locale locale ) private static ResourceBundle getBundle( Locale locale )
{ {
return ResourceBundle.getBundle("pmd-report", locale, PmdReport.class.getClassLoader() ); return ResourceBundle.getBundle( "pmd-report", locale, PmdReport.class.getClassLoader() );
} }
} }