o trying to get a grasp of the entire profile mechanism, especially in relation to how they deal with repositories.

here i am just collecting all the profile code into one place as it's scattered over several packages and is
  hard to determine what the profile system as a whole is doing. the first task i would like to do is decouple
  the profile system from the Settings. this can be done at the front-end i.e the profile information from Settings
  can be fed into the profile manager up front.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573325 13f79535-47bb-0310-9956-ffa450edef68

maven-core/src/main/java/org/apache/maven/DefaultMaven.java

@@ -40,7 +40,7 @@ import org.apache.maven.lifecycle.TaskValidationResult;
 import org.apache.maven.monitor.event.DefaultEventDispatcher;
 import org.apache.maven.monitor.event.EventDispatcher;
 import org.apache.maven.monitor.event.MavenEvents;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.profiles.activation.ProfileActivationException;
 import org.apache.maven.project.DuplicateProjectException;
 import org.apache.maven.project.MavenProject;

maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java

@@ -21,7 +21,7 @@ package org.apache.maven.execution;
 
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.monitor.event.EventMonitor;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.settings.Settings;
 import org.apache.maven.wagon.events.TransferListener;
 

maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java

@@ -22,7 +22,7 @@ package org.apache.maven.execution;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.artifact.repository.ArtifactRepositoryPolicy;
 import org.apache.maven.monitor.event.EventMonitor;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.settings.Settings;
 import org.apache.maven.wagon.events.TransferListener;
 import org.codehaus.plexus.logging.Logger;

maven-core/src/main/java/org/apache/maven/extension/BuildExtensionScanner.java

@@ -20,7 +20,7 @@ package org.apache.maven.extension;
  */
 
 import org.apache.maven.artifact.repository.ArtifactRepository;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 
 import java.io.File;
 import java.util.List;

maven-core/src/main/java/org/apache/maven/extension/DefaultBuildExtensionScanner.java

@@ -28,7 +28,7 @@ import org.apache.maven.model.Build;
 import org.apache.maven.model.Extension;
 import org.apache.maven.model.Model;
 import org.apache.maven.model.Parent;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.profiles.activation.CustomActivatorAdvice;
 import org.apache.maven.project.MavenProject;
 import org.apache.maven.project.MavenProjectBuilder;

maven-embedder/src/main/java/org/apache/maven/embedder/MavenEmbedder.java

@@ -54,8 +54,8 @@ import org.apache.maven.plugin.PluginNotFoundException;
 import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
 import org.apache.maven.plugin.version.PluginVersionNotFoundException;
 import org.apache.maven.plugin.version.PluginVersionResolutionException;
-import org.apache.maven.profiles.DefaultProfileManager;
+import org.apache.maven.profiles.manager.DefaultProfileManager;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.project.MavenProject;
 import org.apache.maven.project.MavenProjectBuilder;
 import org.apache.maven.project.MavenProjectBuildingResult;

maven-embedder/src/main/java/org/apache/maven/embedder/execution/DefaultMavenExecutionRequestPopulator.java

@@ -30,8 +30,8 @@ import org.apache.maven.embedder.MavenEmbedderException;
 import org.apache.maven.execution.MavenExecutionRequest;
 import org.apache.maven.monitor.event.DefaultEventMonitor;
 import org.apache.maven.plugin.Mojo;
-import org.apache.maven.profiles.DefaultProfileManager;
+import org.apache.maven.profiles.manager.DefaultProfileManager;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.settings.Mirror;
 import org.apache.maven.settings.Proxy;
 import org.apache.maven.settings.Server;

maven-embedder/src/test/projects/complex-project/maven-project/src/main/resources/META-INF/plexus/components.xml

@@ -53,9 +53,9 @@ under the License.
     </component>
 
     <component>
-      <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+      <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
       <role-hint>default</role-hint>
-      <implementation>org.apache.maven.project.build.profile.DefaultProfileAdvisor</implementation>
+      <implementation>org.apache.maven.profiles.build.DefaultProfileAdvisor</implementation>
       <requirements>
         <requirement>
           <role>org.apache.maven.MavenTools</role>
@@ -64,7 +64,7 @@ under the License.
           <role>org.apache.maven.profiles.MavenProfilesBuilder</role>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.injection.ProfileInjector</role>
+          <role>org.apache.maven.profiles.injection.ProfileInjector</role>
         </requirement>
       </requirements>
     </component>
@@ -78,7 +78,7 @@ under the License.
       <implementation>org.apache.maven.project.build.model.DefaultModelLineageBuilder</implementation>
       <requirements>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
@@ -135,8 +135,8 @@ under the License.
      |
      -->
     <component>
-      <role>org.apache.maven.project.injection.ProfileInjector</role>
+      <role>org.apache.maven.profiles.injection.ProfileInjector</role>
-      <implementation>org.apache.maven.project.injection.DefaultProfileInjector</implementation>
+      <implementation>org.apache.maven.profiles.injection.DefaultProfileInjector</implementation>
     </component>
 <!--
      |
@@ -152,7 +152,7 @@ under the License.
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>

maven-embedder/src/test/projects/complex-project/maven-project/src/test/resources/org/apache/maven/project/ProjectClasspathTest.xml

@@ -34,14 +34,14 @@ under the License.
     </component>
     -->
     <component>
-      <role>org.apache.maven.project.injection.ProfileInjector</role>
+      <role>org.apache.maven.profiles.injection.ProfileInjector</role>
       <role-hint>test</role-hint>
       <implementation>org.apache.maven.project.injection.TestProfileInjector</implementation>
     </component>
     <component>
-      <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+      <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
       <role-hint>default</role-hint>
-      <implementation>org.apache.maven.project.build.profile.DefaultProfileAdvisor</implementation>
+      <implementation>org.apache.maven.profiles.build.DefaultProfileAdvisor</implementation>
       <requirements>
         <requirement>
           <role>org.apache.maven.MavenTools</role>
@@ -50,7 +50,7 @@ under the License.
           <role>org.apache.maven.profiles.MavenProfilesBuilder</role>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.injection.ProfileInjector</role>
+          <role>org.apache.maven.profiles.injection.ProfileInjector</role>
           <role-hint>test</role-hint>
         </requirement>
       </requirements>
@@ -85,7 +85,7 @@ under the License.
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>

maven-embedder/src/test/projects/complex-project/maven-project/src/test/resources/org/apache/maven/project/canonical/CanonicalProjectBuilderTest.xml

@@ -34,7 +34,7 @@ under the License.
     </component>
     -->
     <component>
-      <role>org.apache.maven.project.injection.ProfileInjector</role>
+      <role>org.apache.maven.profiles.injection.ProfileInjector</role>
       <role-hint>test</role-hint>
       <implementation>org.apache.maven.project.injection.TestProfileInjector</implementation>
     </component>
@@ -57,9 +57,9 @@ under the License.
       </requirements>
     </component>
     <component>
-      <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+      <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
       <role-hint>default</role-hint>
-      <implementation>org.apache.maven.project.build.profile.DefaultProfileAdvisor</implementation>
+      <implementation>org.apache.maven.profiles.build.DefaultProfileAdvisor</implementation>
       <requirements>
         <requirement>
           <role>org.apache.maven.MavenTools</role>
@@ -68,7 +68,7 @@ under the License.
           <role>org.apache.maven.profiles.MavenProfilesBuilder</role>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.injection.ProfileInjector</role>
+          <role>org.apache.maven.profiles.injection.ProfileInjector</role>
           <role-hint>test</role-hint>
         </requirement>
       </requirements>
@@ -83,7 +83,7 @@ under the License.
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>

maven-project/src/main/java/org/apache/maven/profiles/build/DefaultProfileAdvisor.java

@@ -1,4 +1,4 @@
-package org.apache.maven.project.build.profile;
+package org.apache.maven.profiles.build;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -26,14 +26,14 @@ import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.model.Model;
 import org.apache.maven.model.Profile;
 import org.apache.maven.model.Repository;
-import org.apache.maven.profiles.DefaultProfileManager;
+import org.apache.maven.profiles.manager.DefaultProfileManager;
 import org.apache.maven.profiles.MavenProfilesBuilder;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.profiles.ProfilesConversionUtils;
 import org.apache.maven.profiles.ProfilesRoot;
 import org.apache.maven.profiles.activation.ProfileActivationException;
 import org.apache.maven.project.ProjectBuildingException;
-import org.apache.maven.project.injection.ProfileInjector;
+import org.apache.maven.profiles.injection.ProfileInjector;
 import org.codehaus.plexus.PlexusConstants;
 import org.codehaus.plexus.PlexusContainer;
 import org.codehaus.plexus.context.Context;

maven-project/src/main/java/org/apache/maven/profiles/build/ProfileAdvisor.java

@@ -1,4 +1,4 @@
-package org.apache.maven.project.build.profile;
+package org.apache.maven.profiles.build;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -20,7 +20,7 @@ package org.apache.maven.project.build.profile;
  */
 
 import org.apache.maven.model.Model;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.project.ProjectBuildingException;
 
 import java.io.File;

maven-project/src/main/java/org/apache/maven/profiles/injection/DefaultProfileInjector.java

@@ -1,4 +1,4 @@
-package org.apache.maven.project.injection;
+package org.apache.maven.profiles.injection;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one

maven-project/src/main/java/org/apache/maven/profiles/injection/ProfileInjector.java

@@ -1,4 +1,4 @@
-package org.apache.maven.project.injection;
+package org.apache.maven.profiles.injection;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one

maven-project/src/main/java/org/apache/maven/profiles/manager/DefaultProfileManager.java

@@ -1,4 +1,4 @@
-package org.apache.maven.profiles;
+package org.apache.maven.profiles.manager;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -49,19 +49,7 @@ public class DefaultProfileManager
     private List defaultIds = new ArrayList();
 
     private Map profilesById = new LinkedHashMap();
-    
-    // default fallback..
-    private Properties systemProperties = System.getProperties();
 
-    /**
-     * @deprecated without passing in the system properties, the SystemPropertiesProfileActivator will not work correctly
-     * in embedded envirnments.
-     */
-    public DefaultProfileManager( PlexusContainer container )
-    {
-        this( container, (Settings)null);
-    }
-    
     /**
      * the properties passed to the profile manager are the props that
      * are passed to maven, possibly containing profile activator properties
@@ -94,24 +82,15 @@ public class DefaultProfileManager
         this.container = container;
 
         loadSettingsProfiles( settings );
-        
-        if ( props != null )
-        {
-            systemProperties = props;
-        }
     }
     
-    public Properties getSystemProperties() {
-        return systemProperties;
-    }
-
     public Map getProfilesById()
     {
         return profilesById;
     }
 
     /* (non-Javadoc)
-    * @see org.apache.maven.profiles.ProfileManager#addProfile(org.apache.maven.model.Profile)
+    * @see org.apache.maven.profiles.manager.ProfileManager#addProfile(org.apache.maven.model.Profile)
     */
     public void addProfile( Profile profile )
     {
@@ -135,7 +114,7 @@ public class DefaultProfileManager
     }
 
     /* (non-Javadoc)
-    * @see org.apache.maven.profiles.ProfileManager#explicitlyActivate(java.lang.String)
+    * @see org.apache.maven.profiles.manager.ProfileManager#explicitlyActivate(java.lang.String)
     */
     public void explicitlyActivate( String profileId )
     {
@@ -148,7 +127,7 @@ public class DefaultProfileManager
     }
 
     /* (non-Javadoc)
-    * @see org.apache.maven.profiles.ProfileManager#explicitlyActivate(java.util.List)
+    * @see org.apache.maven.profiles.manager.ProfileManager#explicitlyActivate(java.util.List)
     */
     public void explicitlyActivate( List profileIds )
     {
@@ -161,7 +140,7 @@ public class DefaultProfileManager
     }
 
     /* (non-Javadoc)
-    * @see org.apache.maven.profiles.ProfileManager#explicitlyDeactivate(java.lang.String)
+    * @see org.apache.maven.profiles.manager.ProfileManager#explicitlyDeactivate(java.lang.String)
     */
     public void explicitlyDeactivate( String profileId )
     {
@@ -174,7 +153,7 @@ public class DefaultProfileManager
     }
 
     /* (non-Javadoc)
-    * @see org.apache.maven.profiles.ProfileManager#explicitlyDeactivate(java.util.List)
+    * @see org.apache.maven.profiles.manager.ProfileManager#explicitlyDeactivate(java.util.List)
     */
     public void explicitlyDeactivate( List profileIds )
     {
@@ -187,7 +166,7 @@ public class DefaultProfileManager
     }
 
     /* (non-Javadoc)
-    * @see org.apache.maven.profiles.ProfileManager#getActiveProfiles()
+    * @see org.apache.maven.profiles.manager.ProfileManager#getActiveProfiles()
     */
     public List getActiveProfiles()
         throws ProfileActivationException
@@ -295,7 +274,7 @@ public class DefaultProfileManager
     }
 
     /* (non-Javadoc)
-     * @see org.apache.maven.profiles.ProfileManager#addProfiles(java.util.List)
+     * @see org.apache.maven.profiles.manager.ProfileManager#addProfiles(java.util.List)
      */
     public void addProfiles( List profiles )
     {

maven-project/src/main/java/org/apache/maven/profiles/manager/ProfileManager.java

@@ -1,4 +1,4 @@
-package org.apache.maven.profiles;
+package org.apache.maven.profiles.manager;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -28,7 +28,6 @@ import java.util.Map;
 
 public interface ProfileManager
 {
-
     void addProfile( Profile profile );
 
     void explicitlyActivate( String profileId );

maven-project/src/main/java/org/apache/maven/project/DefaultMavenProjectBuilder.java

@@ -49,9 +49,8 @@ import org.apache.maven.model.Model;
 import org.apache.maven.model.Plugin;
 import org.apache.maven.model.ReportPlugin;
 import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
-import org.apache.maven.profiles.DefaultProfileManager;
 import org.apache.maven.profiles.MavenProfilesBuilder;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.profiles.activation.ProfileActivationException;
 import org.apache.maven.project.artifact.InvalidDependencyVersionException;
 import org.apache.maven.project.build.ProjectBuildCache;
@@ -60,7 +59,7 @@ import org.apache.maven.project.build.model.DefaultModelLineage;
 import org.apache.maven.project.build.model.ModelLineage;
 import org.apache.maven.project.build.model.ModelLineageBuilder;
 import org.apache.maven.project.build.model.ModelLineageIterator;
-import org.apache.maven.project.build.profile.ProfileAdvisor;
+import org.apache.maven.profiles.build.ProfileAdvisor;
 import org.apache.maven.project.inheritance.ModelInheritanceAssembler;
 import org.apache.maven.project.injection.ModelDefaultsInjector;
 import org.apache.maven.project.interpolation.ModelInterpolationException;

maven-project/src/main/java/org/apache/maven/project/MavenProjectBuilder.java

@@ -40,9 +40,7 @@ package org.apache.maven.project;
 
 import org.apache.maven.artifact.Artifact;
 import org.apache.maven.artifact.repository.ArtifactRepository;
-import org.apache.maven.artifact.resolver.ArtifactNotFoundException;
+import org.apache.maven.profiles.manager.ProfileManager;
-import org.apache.maven.artifact.resolver.ArtifactResolutionException;
-import org.apache.maven.profiles.ProfileManager;
 import org.apache.maven.wagon.events.TransferListener;
 
 import java.io.File;

maven-project/src/main/java/org/apache/maven/project/build/model/DefaultModelLineageBuilder.java

@@ -31,10 +31,10 @@ import org.apache.maven.context.BuildContextManager;
 import org.apache.maven.model.Model;
 import org.apache.maven.model.Parent;
 import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.project.ProjectBuildingException;
 import org.apache.maven.project.build.ProjectBuildCache;
-import org.apache.maven.project.build.profile.ProfileAdvisor;
+import org.apache.maven.profiles.build.ProfileAdvisor;
 import org.codehaus.plexus.logging.LogEnabled;
 import org.codehaus.plexus.logging.Logger;
 import org.codehaus.plexus.logging.console.ConsoleLogger;

maven-project/src/main/java/org/apache/maven/project/build/model/ModelLineageBuilder.java

@@ -20,7 +20,7 @@ package org.apache.maven.project.build.model;
  */
 
 import org.apache.maven.artifact.repository.ArtifactRepository;
-import org.apache.maven.profiles.ProfileManager;
+import org.apache.maven.profiles.manager.ProfileManager;
 import org.apache.maven.project.ProjectBuildingException;
 
 import java.io.File;

maven-project/src/main/resources/META-INF/plexus/components.xml

@@ -53,9 +53,9 @@ under the License.
     </component>
 
     <component>
-      <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+      <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
       <role-hint>default</role-hint>
-      <implementation>org.apache.maven.project.build.profile.DefaultProfileAdvisor</implementation>
+      <implementation>org.apache.maven.profiles.build.DefaultProfileAdvisor</implementation>
       <requirements>
         <requirement>
           <role>org.apache.maven.MavenTools</role>
@@ -64,7 +64,7 @@ under the License.
           <role>org.apache.maven.profiles.MavenProfilesBuilder</role>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.injection.ProfileInjector</role>
+          <role>org.apache.maven.profiles.injection.ProfileInjector</role>
         </requirement>
       </requirements>
     </component>
@@ -78,7 +78,7 @@ under the License.
       <implementation>org.apache.maven.project.build.model.DefaultModelLineageBuilder</implementation>
       <requirements>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
@@ -135,8 +135,8 @@ under the License.
      |
      -->
     <component>
-      <role>org.apache.maven.project.injection.ProfileInjector</role>
+      <role>org.apache.maven.profiles.injection.ProfileInjector</role>
-      <implementation>org.apache.maven.project.injection.DefaultProfileInjector</implementation>
+      <implementation>org.apache.maven.profiles.injection.DefaultProfileInjector</implementation>
     </component>
 <!--
      |
@@ -152,7 +152,7 @@ under the License.
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>

maven-project/src/test/java/org/apache/maven/profiles/injection/DefaultProfileInjectorTest.java

@@ -1,4 +1,4 @@
-package org.apache.maven.project.injection;
+package org.apache.maven.profiles.injection;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -28,6 +28,7 @@ import org.apache.maven.model.PluginContainer;
 import org.apache.maven.model.PluginExecution;
 import org.apache.maven.model.Profile;
 import org.apache.maven.model.Repository;
+import org.apache.maven.profiles.injection.DefaultProfileInjector;
 import org.codehaus.plexus.util.xml.Xpp3Dom;
 
 import java.util.Collections;

maven-project/src/test/java/org/apache/maven/profiles/manager/DefaultProfileManagerTest.java

@@ -1,4 +1,4 @@
-package org.apache.maven.profiles;
+package org.apache.maven.profiles.manager;
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -27,6 +27,8 @@ import org.apache.maven.model.ActivationOS;
 import org.apache.maven.model.ActivationProperty;
 import org.apache.maven.model.Profile;
 import org.apache.maven.profiles.activation.ProfileActivationException;
+import org.apache.maven.profiles.manager.ProfileManager;
+import org.apache.maven.profiles.manager.DefaultProfileManager;
 import org.codehaus.plexus.PlexusTestCase;
 
 import java.util.List;

maven-project/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java

@@ -22,7 +22,7 @@ package org.apache.maven.project;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.artifact.repository.DefaultArtifactRepository;
 import org.apache.maven.artifact.repository.layout.ArtifactRepositoryLayout;
-import org.apache.maven.profiles.DefaultProfileManager;
+import org.apache.maven.profiles.manager.DefaultProfileManager;
 import org.codehaus.plexus.PlexusTestCase;
 
 import java.io.File;

maven-project/src/test/java/org/apache/maven/project/DefaultMavenProjectBuilderTest.java

@@ -22,18 +22,12 @@ package org.apache.maven.project;
 import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.artifact.repository.DefaultArtifactRepository;
 import org.apache.maven.artifact.repository.layout.ArtifactRepositoryLayout;
-import org.apache.maven.model.Profile;
-import org.apache.maven.model.Repository;
-import org.apache.maven.profiles.DefaultProfileManager;
-import org.apache.maven.profiles.ProfileManager;
-import org.codehaus.plexus.PlexusTestCase;
 import org.codehaus.plexus.util.FileUtils;
 
 import java.io.File;
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
-import java.util.Properties;
 
 public class DefaultMavenProjectBuilderTest
     extends AbstractMavenProjectTestCase

maven-project/src/test/java/org/apache/maven/project/injection/TestProfileInjector.java

@@ -21,6 +21,7 @@ package org.apache.maven.project.injection;
 
 import org.apache.maven.model.Model;
 import org.apache.maven.model.Profile;
+import org.apache.maven.profiles.injection.ProfileInjector;
 
 public class TestProfileInjector
     implements ProfileInjector

maven-project/src/test/resources/org/apache/maven/project/ProjectClasspathTest.xml

@@ -34,14 +34,14 @@ under the License.
     </component>
     -->
     <component>
-      <role>org.apache.maven.project.injection.ProfileInjector</role>
+      <role>org.apache.maven.profiles.injection.ProfileInjector</role>
       <role-hint>test</role-hint>
       <implementation>org.apache.maven.project.injection.TestProfileInjector</implementation>
     </component>
     <component>
-      <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+      <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
       <role-hint>default</role-hint>
-      <implementation>org.apache.maven.project.build.profile.DefaultProfileAdvisor</implementation>
+      <implementation>org.apache.maven.profiles.build.DefaultProfileAdvisor</implementation>
       <requirements>
         <requirement>
           <role>org.apache.maven.MavenTools</role>
@@ -50,7 +50,7 @@ under the License.
           <role>org.apache.maven.profiles.MavenProfilesBuilder</role>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.injection.ProfileInjector</role>
+          <role>org.apache.maven.profiles.injection.ProfileInjector</role>
           <role-hint>test</role-hint>
         </requirement>
       </requirements>
@@ -85,7 +85,7 @@ under the License.
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>

maven-project/src/test/resources/org/apache/maven/project/canonical/CanonicalProjectBuilderTest.xml

@@ -34,7 +34,7 @@ under the License.
     </component>
     -->
     <component>
-      <role>org.apache.maven.project.injection.ProfileInjector</role>
+      <role>org.apache.maven.profiles.injection.ProfileInjector</role>
       <role-hint>test</role-hint>
       <implementation>org.apache.maven.project.injection.TestProfileInjector</implementation>
     </component>
@@ -57,9 +57,9 @@ under the License.
       </requirements>
     </component>
     <component>
-      <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+      <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
       <role-hint>default</role-hint>
-      <implementation>org.apache.maven.project.build.profile.DefaultProfileAdvisor</implementation>
+      <implementation>org.apache.maven.profiles.build.DefaultProfileAdvisor</implementation>
       <requirements>
         <requirement>
           <role>org.apache.maven.MavenTools</role>
@@ -68,7 +68,7 @@ under the License.
           <role>org.apache.maven.profiles.MavenProfilesBuilder</role>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.injection.ProfileInjector</role>
+          <role>org.apache.maven.profiles.injection.ProfileInjector</role>
           <role-hint>test</role-hint>
         </requirement>
       </requirements>
@@ -83,7 +83,7 @@ under the License.
           <role-hint>default</role-hint>
         </requirement>
         <requirement>
-          <role>org.apache.maven.project.build.profile.ProfileAdvisor</role>
+          <role>org.apache.maven.profiles.build.ProfileAdvisor</role>
           <role-hint>default</role-hint>
         </requirement>
         <requirement>