Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

improved javadoc to explain actual version comparison rules 

git-svn-id: https://svn.apache.org/repos/asf/maven/maven-3/trunk@819160 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Herve Boutemy 2009-09-26 16:07:44 +00:00
parent ab6fd434b1
commit 9ead685350
1 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
maven-compat/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
View File

@ -30,8 +30,28 @@ import java.util.Properties;
import java.util.Stack; import java.util.Stack;
/** /**
* Generic implementation of version comparison. * Generic implementation of version comparison. Features:
* <ul>
* <li>mixing of '<code>-</code>' (dash) and '<code>.</code>' (dot) separators,</li>
* <li>transition between characters and digits also constitutes a separator:
* <code>1.0alpha1 =&gt; [1, 0, alpha, 1]</code></li>
* <li>unlimited number of version components,</li>
* <li>version components in the text can be digits or strings</li>
* <li>strings are checked for well-known qualifiers and the qualifier ordering is used for version ordering.
* Well-known qualifiers (case insensitive):<ul>
* <li><code>snapshot</code></li>
* <li><code>alpha</code> or <code>a</code></li>
* <li><code>beta</code> or <code>b</code></li>
* <li><code>milestone</code> or <code>m</code></li>
* <li><code>rc</code> or <code>cr</code></li>
* <li><code>(the empty string)</code> or <code>ga</code> or <code>final</code></li>
* <li><code>sp</code></li>
* </ul>
* </li>
* <li>a dash usually precedes a qualifier, and is always less important than something preceded with a dot.</li>
* </ul>
* *
* @see <a href="http://docs.codehaus.org/display/MAVEN/Versioning">"Versioning" on Maven Wiki</a>
* @author <a href="mailto:kenney@apache.org">Kenney Westerhof</a> * @author <a href="mailto:kenney@apache.org">Kenney Westerhof</a>
* @author <a href="mailto:hboutemy@apache.org">Herve Boutemy</a> * @author <a href="mailto:hboutemy@apache.org">Herve Boutemy</a>
* @version $Id$ * @version $Id$
@ -279,21 +299,21 @@ public class ComparableVersion
case LIST_ITEM: case LIST_ITEM:
Iterator left = iterator(); Iterator left = iterator();
Iterator right = ( (ListItem) item ).iterator(); Iterator right = ( (ListItem) item ).iterator();
while ( left.hasNext() || right.hasNext() ) while ( left.hasNext() || right.hasNext() )
{ {
Item l = left.hasNext() ? (Item) left.next() : null; Item l = left.hasNext() ? (Item) left.next() : null;
Item r = right.hasNext() ? (Item) right.next() : null; Item r = right.hasNext() ? (Item) right.next() : null;
// if this is shorter, then invert the compare and mul with -1 // if this is shorter, then invert the compare and mul with -1
int result = l == null ? -1 * r.compareTo( l ) : l.compareTo( r ); int result = l == null ? -1 * r.compareTo( l ) : l.compareTo( r );
if ( result != 0 ) if ( result != 0 )
{ {
return result; return result;
} }
} }
return 0; return 0;
default: default:
@ -370,7 +390,7 @@ public class ComparableVersion
if ( isDigit ) if ( isDigit )
{ {
list.normalize(); // 1.0-* = 1-* list.normalize(); // 1.0-* = 1-*
if ( ( i + 1 < version.length() ) && Character.isDigit( version.charAt( i + 1 ) ) ) if ( ( i + 1 < version.length() ) && Character.isDigit( version.charAt( i + 1 ) ) )
{ {
// new ListItem only if previous were digits and new char is a digit, // new ListItem only if previous were digits and new char is a digit,