[MNG-6492] - Minor improvement on Array construction, conversion performance

maven-compat/src/main/java/org/apache/maven/project/ModelUtils.java

@@ -313,12 +313,8 @@ private static void mergePluginExecutionDefinitions( PluginExecution child, Plug
 
     public static List<Repository> mergeRepositoryLists( List<Repository> dominant, List<Repository> recessive )
     {
-        List<Repository> repositories = new ArrayList<>();
 
-        for ( Repository repository : dominant )
+        List<Repository> repositories = new ArrayList<>( dominant );
-        {
-            repositories.add( repository );
-        }
 
         for ( Repository repository : recessive )
         {

maven-compat/src/main/java/org/apache/maven/repository/metadata/DefaultClasspathTransformation.java

@@ -139,7 +139,7 @@ protected void visit( MetadataGraphVertex node ) // , String version, String art
 
             if ( exits != null && exits.size() > 0 )
             {
-                MetadataGraphEdge[] sortedExits = exits.toArray( new MetadataGraphEdge[exits.size()] );
+                MetadataGraphEdge[] sortedExits = exits.toArray( new MetadataGraphEdge[0] );
                 Arrays.sort( sortedExits
                         ,
                         new Comparator<MetadataGraphEdge>()

maven-core/src/main/java/org/apache/maven/project/ProjectModelResolver.java

@@ -49,6 +49,7 @@
 import org.eclipse.aether.resolution.VersionRangeResolutionException;
 import org.eclipse.aether.resolution.VersionRangeResult;
 
+
 /**
  * A model resolver to assist building of projects. This resolver gives priority to those repositories that have been
  * declared in the POM.
@@ -91,9 +92,7 @@ public ProjectModelResolver( RepositorySystemSession session, RequestTrace trace
         this.resolver = resolver;
         this.remoteRepositoryManager = remoteRepositoryManager;
         this.pomRepositories = new ArrayList<>();
-        List<RemoteRepository> externalRepositories = new ArrayList<>();
+        this.externalRepositories = Collections.unmodifiableList( new ArrayList<>( repositories ) );
-        externalRepositories.addAll( repositories );
-        this.externalRepositories = Collections.unmodifiableList( externalRepositories );
         this.repositories = new ArrayList<>();
         this.repositories.addAll( externalRepositories );
         this.repositoryMerging = repositoryMerging;

maven-core/src/main/java/org/apache/maven/toolchain/DefaultToolchainManagerPrivate.java

@@ -69,7 +69,7 @@ public ToolchainPrivate[] getToolchainsForType( String type, MavenSession contex
             }
         }
 
-        return toRet.toArray( new ToolchainPrivate[toRet.size()] );
+        return toRet.toArray( new ToolchainPrivate[0] );
     }
 
     @Override

maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/MojoExecutorStub.java

@@ -50,10 +50,7 @@ public void execute( MavenSession session, MojoExecution mojoExecution, ProjectI
     public void execute( MavenSession session, List<MojoExecution> mojoExecutions, ProjectIndex projectIndex )
         throws LifecycleExecutionException
     {
-        for ( MojoExecution mojoExecution : mojoExecutions )
+        executions.addAll(mojoExecutions);
-        {
-            executions.add( mojoExecution );
-        }
     }
 
 

maven-embedder/src/main/java/org/apache/maven/cli/CleanArgument.java

@@ -115,7 +115,7 @@ public static String[] cleanArgs( String[] args )
         }
         else
         {
-            cleanArgs = cleaned.toArray( new String[cleanedSz] );
+            cleanArgs = cleaned.toArray( new String[0] );
         }
 
         return cleanArgs;

maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java

@@ -384,7 +384,7 @@ void cli( CliRequest cliRequest )
                     }
                 }
 
-                mavenConfig = cliManager.parse( args.toArray( new String[args.size()] ) );
+                mavenConfig = cliManager.parse( args.toArray( new String[0] ) );
                 List<?> unrecongized = mavenConfig.getArgList();
                 if ( !unrecongized.isEmpty() )
                 {
@@ -1196,7 +1196,7 @@ else if ( userSuppliedConfigurationProcessorCount > 1 )
                     sb.append( String.format( "%s\n", configurationProcessor.getClass().getName() ) );
                 }
             }
-            sb.append( String.format( "\n" ) );
+            sb.append( "\n" );
             throw new Exception( sb.toString() );
         }
     }

maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java

@@ -263,9 +263,8 @@ else if ( Map.class.isAssignableFrom( type ) )
                             fields.add( new ObjectField( currentField ) );
                         }
                     }
-
                 }
-                this.fields = fields.toArray( new CacheField[fields.size()] );
+                this.fields = fields.toArray( new CacheField[0] );
 
             }
 

maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultModelResolver.java

@@ -89,9 +89,7 @@ class DefaultModelResolver
         this.versionRangeResolver = versionRangeResolver;
         this.remoteRepositoryManager = remoteRepositoryManager;
         this.repositories = repositories;
-        List<RemoteRepository> externalRepositories = new ArrayList<>();
+        this.externalRepositories = Collections.unmodifiableList( new ArrayList<>( repositories ) );
-        externalRepositories.addAll( repositories );
-        this.externalRepositories = Collections.unmodifiableList( externalRepositories );
 
         this.repositoryIds = new HashSet<>();
     }