Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MNG-4543] Cleanup tmp files created by DefaultWagonManager 

Issue id: MNG-4543


git-svn-id: https://svn.apache.org/repos/asf/maven/maven-3/trunk@902298 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Olivier Lamy 2010-01-22 22:38:34 +00:00
parent 97d25dc1d9
commit cc05cc6320
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java
View File

@ -22,6 +22,7 @@ package org.apache.maven.repository.legacy;
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.security.NoSuchAlgorithmException; import java.security.NoSuchAlgorithmException;
import java.util.ArrayList;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
@ -486,6 +487,8 @@ public class DefaultWagonManager
checksums.put( CHECKSUM_IDS[i], addChecksumObserver( wagon, CHECKSUM_ALGORITHMS[i] ) ); checksums.put( CHECKSUM_IDS[i], addChecksumObserver( wagon, CHECKSUM_ALGORITHMS[i] ) );
} }
List<File> temporaryFiles = new ArrayList<File>();
try try
{ {
try try
@ -517,6 +520,7 @@ public class DefaultWagonManager
temp.deleteOnExit(); temp.deleteOnExit();
FileUtils.fileWrite( temp.getAbsolutePath(), "UTF-8", sums.get( extension ) ); FileUtils.fileWrite( temp.getAbsolutePath(), "UTF-8", sums.get( extension ) );
temporaryFiles.add( temp );
wagon.put( temp, remotePath + "." + extension ); wagon.put( temp, remotePath + "." + extension );
} }
} }
@ -542,6 +546,9 @@ public class DefaultWagonManager
} }
finally finally
{ {
// MNG-4543
cleanupTemporaryFiles( temporaryFiles );
// Remove every checksum listener // Remove every checksum listener
for ( String aCHECKSUM_IDS : CHECKSUM_IDS ) for ( String aCHECKSUM_IDS : CHECKSUM_IDS )
{ {
@ -558,6 +565,24 @@ public class DefaultWagonManager
} }
} }
private void cleanupTemporaryFiles(List<File> files)
{
for ( File file : files )
{
// really don't care if it failed here only log warning
try
{
file.delete();
}
catch ( Exception e )
{
logger.warn( "skip failed to delete temporary file : " + file.getAbsolutePath() + " , message "
+ e.getMessage() );
}
}
}
private ChecksumObserver addChecksumObserver( Wagon wagon, String algorithm ) private ChecksumObserver addChecksumObserver( Wagon wagon, String algorithm )
throws TransferFailedException throws TransferFailedException
{ {