Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MNG-6631] documented the performance intent

This commit is contained in:
Hervé Boutemy 2019-04-27 18:22:32 +02:00
parent 44ad1aafa6
commit d34e8fbdc0
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
View File

@ -221,12 +221,14 @@ public class DefaultArtifactVersion
private static Integer tryParseInt( String s )
{
// for performance, check digits instead of relying later on catching NumberFormatException
if ( !isDigits( s ) )
{
return null;
}
try
{
if ( !isDigits( s ) )
{
return null;
}
long longValue = Long.parseLong( s );
if ( longValue > Integer.MAX_VALUE )
{
@ -236,6 +238,7 @@ public class DefaultArtifactVersion
}
catch ( NumberFormatException e )
{
// should never happen since checked isDigits(s) before
return null;
}
}