From fd02254df15f084d48e8993259b0085971317d7d Mon Sep 17 00:00:00 2001
From: Benjamin Bentmann <bentmann@apache.org>
Date: Fri, 6 Feb 2009 23:20:30 +0000
Subject: [PATCH] [MNG-4023] Profiles from parent POM are injected multiple
 times if parent is part of reactor build

o Added IT

git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@741780 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/maven/it/IntegrationTestSuite.java |  1 +
 ...4023ParentProfileOneTimeInjectionTest.java | 66 ++++++++++++++++++
 .../src/test/resources/mng-4023/pom.xml       | 68 +++++++++++++++++++
 .../src/test/resources/mng-4023/sub/pom.xml   | 60 ++++++++++++++++
 4 files changed, 195 insertions(+)
 create mode 100644 its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4023ParentProfileOneTimeInjectionTest.java
 create mode 100644 its/core-it-suite/src/test/resources/mng-4023/pom.xml
 create mode 100644 its/core-it-suite/src/test/resources/mng-4023/sub/pom.xml

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
index 61398f7655..1bd314e0fa 100644
--- a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
+++ b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
@@ -90,6 +90,7 @@ public class IntegrationTestSuite
         // suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class );
         // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137
 
+        suite.addTestSuite( MavenITmng4023ParentProfileOneTimeInjectionTest.class );
         suite.addTestSuite( MavenITmng4016PrefixedPropertyInterpolationTest.class );
         suite.addTestSuite( MavenITmng4009InheritProfileEffectsTest.class );
         suite.addTestSuite( MavenITmng4008MergedFilterOrderTest.class );
diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4023ParentProfileOneTimeInjectionTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4023ParentProfileOneTimeInjectionTest.java
new file mode 100644
index 0000000000..7356246cf5
--- /dev/null
+++ b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4023ParentProfileOneTimeInjectionTest.java
@@ -0,0 +1,66 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.Properties;
+
+/**
+ * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-4023">MNG-4023</a>.
+ * 
+ * @author Benjamin Bentmann
+ * @version $Id$
+ */
+public class MavenITmng4023ParentProfileOneTimeInjectionTest
+    extends AbstractMavenIntegrationTestCase
+{
+
+    public MavenITmng4023ParentProfileOneTimeInjectionTest()
+    {
+        super( "[2.0.11,2.1.0-M1),[2.1.0-M2,)" );
+    }
+
+    /**
+     * Verify that profiles in a parent are only injected once during a reactor build that include the parent
+     * itself. The parent being part of the reactor makes it subject to project caching and proper use of the
+     * cache is crucial here.
+     */
+    public void testitMNG4023()
+        throws Exception
+    {
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4023" );
+
+        Verifier verifier = new Verifier( testDir.getAbsolutePath() );
+        verifier.setAutoclean( false );
+        verifier.deleteDirectory( "sub/target" );
+        verifier.executeGoal( "validate" );
+        verifier.verifyErrorFreeLog();
+        verifier.resetStreams();
+
+        Properties props = verifier.loadProperties( "sub/target/config.properties" );
+        assertEquals( "1", props.getProperty( "stringParams" ) );
+        assertEquals( "test", props.getProperty( "stringParams.0" ) );
+        assertEquals( null, props.getProperty( "stringParams.1" ) );
+    }
+
+}
diff --git a/its/core-it-suite/src/test/resources/mng-4023/pom.xml b/its/core-it-suite/src/test/resources/mng-4023/pom.xml
new file mode 100644
index 0000000000..5dbac6ab5c
--- /dev/null
+++ b/its/core-it-suite/src/test/resources/mng-4023/pom.xml
@@ -0,0 +1,68 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>org.apache.maven.its.mng4023</groupId>
+  <artifactId>parent</artifactId>
+  <version>1.0-SNAPSHOT</version>
+  <packaging>pom</packaging>
+
+  <name>Maven Integration Test :: MNG-4023</name> 
+  <description>
+    Verify that profiles in a parent are only injected once during a reactor build that include the parent
+    itself. The parent being part of the reactor makes it subject to project caching and proper use of the
+    cache is crucial here.
+  </description>
+
+  <modules>
+    <module>sub</module>
+  </modules>
+
+  <profiles>
+    <profile>
+      <id>maven-core-it</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>
+      </activation>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.its.plugins</groupId>
+            <artifactId>maven-it-plugin-configuration</artifactId>
+            <version>2.1-SNAPSHOT</version>
+            <configuration>
+              <propertiesFile>target/config.properties</propertiesFile>
+              <!--
+              NOTE: combine.children="append" is the essential point here, i.e. the profile injection has additive
+              effects on the model and as such must not happen multiple times.
+              -->
+              <stringParams combine.children="append">
+                <stringParam>test</stringParam>
+              </stringParams>
+            </configuration>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+  </profiles>
+</project>
diff --git a/its/core-it-suite/src/test/resources/mng-4023/sub/pom.xml b/its/core-it-suite/src/test/resources/mng-4023/sub/pom.xml
new file mode 100644
index 0000000000..6a1690a495
--- /dev/null
+++ b/its/core-it-suite/src/test/resources/mng-4023/sub/pom.xml
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+  <modelVersion>4.0.0</modelVersion>
+
+  <parent>
+    <groupId>org.apache.maven.its.mng4023</groupId>
+    <artifactId>parent</artifactId>
+    <version>1.0-SNAPSHOT</version>
+  </parent>
+
+  <groupId>org.apache.maven.its.mng4023</groupId>
+  <artifactId>child</artifactId>
+  <version>1.0-SNAPSHOT</version>
+
+  <name>Maven Integration Test :: MNG-4023</name> 
+  <description>
+    Verify that profiles in a parent are only injected once during a reactor build that include the parent
+    itself. The parent being part of the reactor makes it subject to project caching and proper use of the
+    cache is crucial here.
+  </description>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.its.plugins</groupId>
+        <artifactId>maven-it-plugin-configuration</artifactId>
+        <version>2.1-SNAPSHOT</version>
+        <executions>
+          <execution>
+            <id>test</id>
+            <phase>validate</phase>
+            <goals>
+              <goal>config</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>