Commit Graph

730 Commits

Author SHA1 Message Date
Arturo Bernal d61fcf7da1 [MNG-7288] Remove redundant local variables
Closes #569
2021-10-10 12:42:12 +02:00
Arturo Bernal b9fb762215 [MNG-7292] Unnecessarily escaped character
Closes #573
2021-10-10 12:18:15 +02:00
Arturo Bernal 4fafe44112 MNG-7296 - Remove redundant 'if' statement 2021-10-10 10:53:58 +02:00
Arturo Bernal e50d65d228 MNG-7295 - Remove redundant/unused import statements. 2021-10-09 16:26:14 +02:00
Tamas Cservenak c3962c1a6c
[MNG-7278] Clean up core logging (#562)
We had all kind of Loggers in Core, some Plexus
injected, some acquired using SLF4J LoggerFactory,
some static, some final, etc.

This PR aligns all those uses to SLF4J finals.

Notices:
* maven-core does NOT use Plexus Logger anymore
* did not touch maven-compat
2021-10-02 20:33:55 +02:00
Tamas Cservenak d141957ff5
[MNG-7055] Fix G level metadata handling (#555)
Maven Artifact Transfer silently prevents group level metadata to reach Resolver and causes metadata loss on install/deploy. Fix is to "bridge" this from maven-resolver-provider (and core) by reusing the actual metadata that m-plugin-p:addPluginArtifactMetadata mojo adds, but m-a-t filters out.
2021-10-02 15:22:32 +02:00
Guillaume Nodet 35e5a4d71d [MNG-5577] Use JSR 330 constructor injection
# Conflicts:
#	maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecyclePluginAnalyzer.java
2021-10-02 12:26:22 +02:00
Sungpeo Kook b7182873e9 Default value of checksumPolicy depends on the Maven version
This closes #529
2021-09-24 21:25:25 +02:00
Sungpeo Kook 98b69beced deleted duplication in checksum description 2021-09-24 21:25:05 +02:00
Sungpeo Kook 9539227201 set "fail" as a default option for checksumPolicy in documents 2021-09-24 21:25:05 +02:00
Sungpeo Kook 9735fffd98 added an "ignore" option for checksumPolicy in documents 2021-09-24 21:25:05 +02:00
Guoxiong Li 5fd536853f [MNG-7248] Fix warnings issued by dependency:analyze
This changeset does intentionally not touch Guice and its dependencies
as well as test-scoped dependencies.

This closes #546
2021-09-24 20:55:03 +02:00
Michael Osipov 6b6589bf1c [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies 2021-09-14 19:21:08 +02:00
Michael Osipov a2a3df3d02 [MNG-7203] Introduce a long option --verbose and deprecate --debug
This closes #519
2021-08-01 22:33:33 +02:00
Michael Osipov 78fc3734f9 Trim trailing whitespace 2021-07-02 18:47:10 +02:00
rfscholte 12f3e7e878 Remove maven-test-support in favor of plexus-testing 2021-05-28 18:26:03 +02:00
Hervé Boutemy 1ab29f5485 [MNG-7128] keep blocked attribute from mirrors in artifact repositories 2021-03-27 03:00:25 +01:00
Hervé Boutemy 3b21386c3f [MNG-7116] add support for mirrorOf external:http:* 2021-03-19 20:35:50 +01:00
Hervé Boutemy 0e75baae25 improve and fix javadoc 2021-03-05 21:23:44 +01:00
Guillaume Nodet 48fc10889e [MNG-7077] Use JUnit 5 extension
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-02-12 17:21:59 +01:00
Guillaume Nodet bb916d0784 [MNG-7035] Migrate unit tests to Unit 5
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-01-15 15:07:06 +01:00
Sylwester Lachiewicz 0e34b35947 [MNG-6909] Convert to JSR330 in tests - maven-compat 2021-01-08 03:55:24 +01:00
Michael Osipov 8eda091d4e Replace tabs with proper count of spaces 2020-12-24 19:50:27 +01:00
Michael Osipov 673a7d1fef Trim trailing whitespace 2020-12-24 19:09:10 +01:00
Nicolas Juneau 95ee890837 [MNG-5728] Switch the default checksum policy from "warn" to "fail"
Signed-off-by: rfscholte <rfscholte@apache.org>
Signed-off-by: Michael Osipov <michaelo@apache.org>
2020-12-02 20:49:46 +01:00
Robert Scholte 251ba225c6 Revert "[MNG-5728] Switch the default checksum policy from "warn" to "fail"" 2020-12-02 20:28:04 +01:00
rfscholte 2bdc0c5424 remove unused imports 2020-12-02 20:01:55 +01:00
Nicolas Juneau d8ad76b9cb [MNG-5728] Switch the default checksum policy from "warn" to "fail"
Signed-off-by: rfscholte <rfscholte@apache.org>
Signed-off-by: Michael Osipov <michaelo@apache.org>
2020-11-30 21:12:14 +01:00
rfscholte 3736be9c15 Updating version in preparation for Maven 4 2020-11-27 12:22:47 +01:00
Michael Osipov 72688805c4 [MNG-6754] Set the same timestamp in multi module builds
Reuse MavenExecutionRequest#getStartTime() throughout for snapshot versions,
last updated fields in metadata consistently for local and remote repositories
for the entire reactor and its modules.

This closes #381
2020-11-11 23:09:49 +01:00
Sylwester Lachiewicz b4725dbe06 Fix maven-checkstyle-plugin 3.1.1 reported error
- with maven-shared-resources v3
2020-06-11 20:53:36 +02:00
Olivier Lamy af1bf4c8b4
[MNG-6886] upgrade plexus-cipher to 1.8 and update changed groupId (#335)
Signed-off-by: olivier lamy <olamy@apache.org>
2020-04-10 09:17:25 +10:00
Joseph Walton d4207748a8 [MNG-5577] Don't use LegacyRepositoryLayout in tests.
This class was deleted, but retained in tests. We don't need
it anymore, so drop it.
2020-04-01 19:40:53 +02:00
Joseph Walton b962ff361a [MNG-5577] Simplify tests to reduce use of wiring.
- Reduce the use of wiring in unit tests
- Enable class scanning for tests that require it.
- Remove test and wiring that's not used.
2020-04-01 19:40:37 +02:00
Sylwester Lachiewicz ace32fdbe0 [MNG-6855] Simplify code - computeIfAbsent() 2020-01-26 11:13:09 +01:00
Rostislav Krasny 1697e7a06b [MNG-6855] Simplify code
- use Integer/Long.compare()
- use List.removeIf()
- remove unused imports
- redundant .toString()

Closes #319
2020-01-26 11:12:53 +01:00
Artem Krosheninnikov ddb454ac83 [MNG-6831] Replace Anonymous classes by lambdas
Closes #303
2020-01-25 22:52:20 +01:00
Rostislav Krasny ce35eff448 [MNG-6853] - Don't box primitives where it's not needed
Closes #318
2020-01-25 20:13:27 +01:00
Artem Krosheninnikov 39492281b2 [MNG-6847] Explicit type can be replaced by the diamond operator
This closes #315
2020-01-13 20:57:35 +01:00
Rostislav Krasny f620bb714d [MNG-6844] Remove outdated TODOs
Relates to the 735b72fcf1 commit.
2020-01-10 10:22:54 +01:00
Artem Krosheninnikov 735b72fcf1 [MNG-6844] Use StandardCharsets and remove outdated @SuppressWarnings
This closes #312
2020-01-09 18:09:44 +01:00
Artem Krosheninnikov 1ad780143c [MNG-6827] Replace deprecated StringUtils#defaultString() from Plexus Utils
This closes #302
2019-12-22 12:57:34 +01:00
Artem Krosheninnikov 3332f4dbcc [MNG-6816] Prefer System.lineSeparator() over system properties
This closes #300
2019-12-10 09:43:47 +01:00
rfscholte ead06d23d4 [maven-release-plugin] prepare for next development iteration 2019-11-19 20:17:36 +01:00
rfscholte cecedd3430 [maven-release-plugin] prepare release maven-3.6.3 2019-11-19 20:17:06 +01:00
Hervé Boutemy 53ccee3486 [MNG-6778] use https for schema location 2019-11-09 13:45:14 +01:00
Christian Wansart 0c7c69f78b [MNG-6778] - Use https for maven schemaLocations 2019-11-07 16:16:39 +01:00
rfscholte 38efe8444c Fix checkstyle reported errors 2019-09-10 18:51:18 +02:00
Dezhi Cai d09bc7437f [refactor] use utility method of Objects to simplify code (#284)
* [refactor] use utility method of Objects to simplify code

* [refactor] use utility method of Objects to simplify code
2019-09-10 16:22:22 +10:00
Enrico Olivelli d9a0eee7fe [maven-release-plugin] prepare for next development iteration 2019-08-27 16:59:23 +02:00
Enrico Olivelli 40f5233313 [maven-release-plugin] prepare release maven-3.6.2 2019-08-27 16:59:01 +02:00
Michael Osipov 2d0c3bc75b [MNG-6704] MavenRepositorySystemUtils.newSession() misses assignment 2019-07-25 21:58:26 +02:00
Joseph Walton 353d3eaa8f [MNG-6685] Convert Maven Model Builder to JSR 330
This closes #256
2019-06-23 00:20:54 +02:00
Karl Heinz Marbaise 5222f03d05
[maven-release-plugin] prepare for next development iteration 2019-04-04 20:56:37 +02:00
Karl Heinz Marbaise d66c9c0b31
[maven-release-plugin] prepare release maven-3.6.1 2019-04-04 20:56:16 +02:00
Karl Heinz Marbaise 6e376d424e
[maven-release-plugin] prepare for next development iteration 2018-10-24 20:38:30 +02:00
Karl Heinz Marbaise 97c98ec64a
[maven-release-plugin] prepare release maven-3.6.0 2018-10-24 20:38:06 +02:00
HoaPhan ba74b96633
[MNG-6492] - Minor improvement on Array construction, conversion performance 2018-10-24 18:07:13 +02:00
Christian Schulte 44826ab446 [MNG-6164] Collections inconsistently immutable
Make non-empty collections returned immutable just like those returned by
java.util.Collections.
2018-10-09 22:12:50 +02:00
Sylwester Lachiewicz 27864904fe Fixed typo in exception logging LegacyRepositorySystem
Fixes #170
2018-10-08 20:14:53 +02:00
Stephen Connolly bf0bd6350e Master is now on 3.6.0-SNAPSHOT 2018-06-17 22:38:49 +01:00
Stephen Connolly 1efd571b0a [maven-release-plugin] prepare for next development iteration 2018-06-17 19:29:56 +01:00
Stephen Connolly 1edded0938 [maven-release-plugin] prepare release maven-3.5.4 2018-06-17 19:29:25 +01:00
Michael Osipov 9021d66e53 Move ArtifactUtilsTest and friends from maven-compat to maven-artifact 2018-05-08 00:18:49 +02:00
kevin-canadian 14365baabe [MNG-6403] Artifact#VERSION_FILE_PATTERN does not escape period between date and time
This closes #112
2018-05-08 00:14:09 +02:00
Michael Osipov 8e0efaa107 [MNG-6386] ${project.baseUri} is not a valid URI (according to RFC 3986)
File#toURI()#toString() produces a non-compliant URI making tools like
Subversion or Git to choke on those URIs. Whereas Path#toUri()#toASCIIString()
does the right job.
2018-05-07 22:35:43 +02:00
Stephen Connolly 85b4e3d8e8 [maven-release-plugin] prepare for next development iteration 2018-02-24 19:29:56 +00:00
Stephen Connolly 3383c37e1f [maven-release-plugin] prepare release maven-3.5.3 2018-02-24 19:29:21 +00:00
Sylwester Lachiewicz d925081794 Reduce number of global checkstyle rule violations
Fix code for following checkstyle rules:
ConstantName, FileLength, InnerAssignment, JavadocType, MagicNumber, MethodLength, MethodName, NewlineAtEndOfFile, ParameterNumber, RedundantThrows, VisibilityModifier

Fixes #149
2018-02-11 11:41:16 +01:00
Hervé Boutemy 0dc70cc691 upgrade m-site-p to 3.7 + Fluido 1.7 + edit button 2018-02-10 11:42:33 +01:00
Stephen Connolly 3d0efa3696 [maven-release-plugin] prepare for next development iteration 2017-10-18 08:55:05 +01:00
Stephen Connolly 138edd61fd [maven-release-plugin] prepare release maven-3.5.2 2017-10-18 08:54:47 +01:00
Stephen Connolly 312eb53502 [maven-release-plugin] prepare for next development iteration 2017-09-10 12:51:43 +01:00
Stephen Connolly 094e4e31a5 [maven-release-plugin] prepare release maven-3.5.1 2017-09-10 12:51:26 +01:00
Michael Osipov ecef59f1cb [MNG-6167] Clean up dependency mess (reported by dependency:analyze)
Clean up compile and runtime dependencies. Test dependencies have not been
touched because their seem to be false positives due to DI.
2017-05-16 15:27:22 +02:00
Michael Osipov f7d4bce233 [MNG-6149] MetadataResolutionResult#getGraph() never resolves request type 'test' 2017-04-21 22:57:53 +02:00
Stephen Connolly a4b0b63b62 [maven-release-plugin] prepare for next development iteration 2017-04-03 20:35:47 +01:00
Stephen Connolly ff8f5e7444 [maven-release-plugin] prepare release maven-3.5.0 2017-04-03 20:35:30 +01:00
Stephen Connolly fd29ddebf9 [maven-release-plugin] prepare for next development iteration 2017-03-20 16:55:53 +00:00
Stephen Connolly 214540c2ae [maven-release-plugin] prepare release maven-3.5.0-beta-1 2017-03-20 16:55:36 +00:00
Stephen Connolly b12905ce02 [MNG-6176] Fix javadoc *errors* in maven-compat 2017-03-18 12:34:45 +00:00
rfscholte 0e7e3eeb59 [MNG-6176] Javadoc errors prevent release with Java 8
Upgrade to modello-1.9.1
Fix javadoc errors in tests
2017-03-18 12:55:05 +01:00
Karl Heinz Marbaise 51cc76c326 [MNG-6090] CI friendly properties break submodule builds
[MNG-6057] Problem with CI friendly usage of ${..} reactor order is changed
 o Based on the missing replacement of the versions ${revision}
   ${changelist} or ${sha1} within the parent element the order
   of the reactor changes.
[MNG-5895] Problem with CI friendly usage of ${..} which is already
defined via property in pom file.
2017-03-13 22:08:51 +01:00
Karl Heinz Marbaise 809ba34055 Code improvement. 2017-03-11 20:53:18 +01:00
rfscholte 587317b009 [MNG-6176] Javadoc errors prevent release with Java 8
Upgrade modello to 1.9.0
Fix invalid Javadoc
2017-03-10 16:17:28 +01:00
Stephen Connolly e652882757 [maven-release-plugin] prepare for next development iteration 2017-02-23 14:56:31 +00:00
Stephen Connolly 8e6bbc4d4a [maven-release-plugin] prepare release maven-3.5.0-alpha-1 2017-02-23 14:56:21 +00:00
August Shi e6217a4555 Fixing misspellings in test names 2017-02-18 18:29:19 +01:00
Michael Osipov b66bdb9cbc [MNG-6150] Javadoc improvements for 3.5.0
* Remove duplicate plugin configuration
* Add workaround for Javadoc locale
* Clean up errors reported by Javadoc 7

Note: Javadoc 8 fails immediately because Modello generates invalid
Javadoc
2017-02-15 17:30:46 +01:00
Alex Henrie 8d91726f78 [MNG-5934] String handling issues identified by PMD 2017-02-11 14:08:24 +01:00
Josh Soref 1be7ea893e [MNG-6165] Deprecate and replace incorrectly spelled public API
Spelling fixes:

* spelling: collector
* spelling: executions
* spelling: repositories
* spelling: workspace

This closes #101
2017-02-06 20:36:38 +01:00
Josh Soref 1740265984 [MNG-6146] Several small stylistic and spelling improvements to code and documentation
Spelling fixes:

* system
* tokenizer
* toolchain
* trailing
* transitive
* unsupported
* version
* artifact
* attachment
* codehaus
* colleagues
* comparison
* concurrency
* configure
* creation
* dependency
* descriptor
* downstream
* efficient
* e.g.
* elements
* encountered
* encounters
* environments
* executed
* explicitly
* happens
* hierarchical
* hierarchy
* ignore
* implemented
* implementers
* independence
* indicates
* inheritance
* inherited
* inherits
* install
* interface
* javascript
* laziness
* management
* maven
* metadata
* mgmt
* minimalist
* nonexistent
* objects
* overridden
* print
* project
* properties
* recessive
* referring
* repository
* representation
* retrieval
* retrieve
* rigorous
* should
* spontaneously
* subsequent

Literal fixes:

*  use static final values

Style fixes:

* use the proper term for char U+002D (-) hyphen(-minus) instead of dash

This closes #100
2017-02-03 10:12:28 +01:00
Christian Schulte 8972072e32 [MNG-6110] renamed 'maven-aether-provider' to 'maven-resolver-provider' 2017-02-01 07:59:53 +01:00
Harald Wellmann 4d6c9292c4 [MNG-6110] Upgrade Aether to Maven Resolver 1.0.3 2017-02-01 07:59:52 +01:00
Christian Schulte a3cdfbbbe9 [MNG-5368] UnsupportedOperationException thrown when version range is not correct in dependencyManagement definitions
o Updated to log an error message for any caught 'InvalidVersionSpecificationException's.
2017-01-31 22:44:59 +01:00
Michael Osipov f53f1547a1 [MNG-6147] MetadataResolutionResult#getGraph() contains duplicate if clause 2017-01-28 17:09:30 +01:00
Michael Osipov 920f10a561 [MNG-6144] DefaultWagonManagerTest#testGetMissingJarForced() passed incorrect value
This closes #86
2017-01-28 17:09:30 +01:00
Christian Schulte a99a78984c o Updated to remove errors reported by Checkstyle. 2017-01-25 08:09:30 +01:00
Hervé Boutemy 60e4fa650f updated notice 2017-01-25 00:08:12 +01:00
Hervé Boutemy cfbad56f65 point to our documentation on plugins dependencies upgrade 2017-01-24 23:50:10 +01:00