Commit Graph

3208 Commits

Author SHA1 Message Date
Guillaume Nodet 1d473233f2 [MNG-6727] Using version range in parent and CI Friendly Version fails 2022-02-01 14:35:07 +01:00
Guillaume Nodet 6b607109d3 [MNG-7349] Limit relocation warning message to direct dependencies only
# Conflicts:
#	maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
2022-01-24 07:57:43 +01:00
Guillaume Nodet 9d4b2b23f0
[MNG-7345] Fix exported packages (#618) 2022-01-18 10:42:47 +01:00
Falko Modler ab4fec0a33 [MNG-7381] Shorten parallel builder thread name to artifactId, conditionally with groupId
This closes #662
2022-01-17 20:39:11 +01:00
Falko Modler 18725ec1e0 [MNG-7380] Don't log non-threadsafe warning if only building a single module
This closes #655
2022-01-11 15:30:52 +01:00
Guillaume Nodet faf5d5d274
[MNG-7347] SessionScoped beans should be singletons for a given session (#621) 2022-01-10 08:19:33 +01:00
Hervé Boutemy c229278477 rework javadoc 2022-01-08 17:27:28 +01:00
Hervé Boutemy f30a0ab4dd [MNG-7267] update artifact handlers documentation 2022-01-08 16:03:57 +01:00
Hervé Boutemy 8bde888dc8 [MNG-7267] update lifecycle documentation after switch from Plexus XML 2022-01-08 15:57:39 +01:00
Hervé Boutemy e617d51bd4 [MNG-7264] packaging plugins bindings cannot be empty 2022-01-08 15:25:54 +01:00
Tamas Cservenak 7180d68a18 Proposal to change abstract provider
Changes:
* validate input
* do not modify loop invariant within loop body
2022-01-08 15:25:54 +01:00
Hervé Boutemy a53083db6c [MNG-7264] refactor packaging bindings providers to ease maintenance 2022-01-08 15:25:54 +01:00
Hervé Boutemy a7375a0eff [MNG-7263] use constants instead of copy/paste 2022-01-08 15:25:13 +01:00
Hervé Boutemy 94af1d99f8 [MNG-7263] improve AbstractLifecycleProvider 2022-01-08 15:25:13 +01:00
Hervé Boutemy 711d5fbbf2 [MNG-7263] introduce AbstractLifecycleProvider 2022-01-08 15:25:13 +01:00
Hervé Boutemy e5b0831c10 [MNG-7263] refactor lifecycle providers to ease documentation
- lifecycle id
- phases
- default plugins bindings
2022-01-08 15:25:13 +01:00
Michael Osipov 2670c00751 [MNG-5561] Plugin relocation loses configuration
Previously, to locate plugin configuration in a project the plugin descriptor
was read first and then the GA were extracted. This always worked because the
GA from the model and the GA from plugin descriptor (plugin.xml) were identical.
When a plugin is relocated the target artifact is read, thus its plugin
descriptor as well. Naturally, the GA of new (relocated) does not correspond to
the old (static) one in the model. Therefore, the configuration is not found.
New approach is to use the original plugin GA to locate the configuration in
the model regardless of the relocation.

This closes #642
2022-01-06 16:54:03 +01:00
Hervé Boutemy d6b9108f58 [MNG-6917] upgrade maven-wrapper-plugin to 3.1.0 2022-01-05 00:09:35 +01:00
Guillaume Nodet 33aedfc28b
[MNG-7156][MNG-7285] Add locking in MojoExecutor (#627) 2021-12-17 09:18:40 +01:00
Guillaume Nodet ae8aebea19
[MNG-7182] Use the MX xpp parser instead of a STAX transformation (#486) 2021-11-29 13:31:55 +01:00
Michael Osipov 8784812cf6 [MNG-7312] Revert ThreadLocal approach from MNG-6843 and MNG-7251
Revert "[MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project"

This reverts commit a6e462b53a.

Revert "[MNG-6843] Parallel build fails due to missing JAR artifacts in compilePath"

This reverts commit 73e00ed85d.

===

This closes #594
2021-10-22 21:57:09 +02:00
Karl Heinz Marbaise 965aaa53da
[MNG-7314] - Refactoring - Remove unused MavenExecutionResult 2021-10-18 20:47:55 +02:00
Hervé Boutemy f46a9131d5 fix javadoc errors 2021-10-17 12:07:50 +02:00
Arturo Bernal 274388fc0f [MNG-7303] - Replace Throwable.initCause() with constructor. 2021-10-13 22:52:02 +02:00
Giovanni van der Schelde ffc2b99e3e [MNG-6389] Move the toolchains model to a separate artifactId
Closes #586
2021-10-13 16:10:22 +02:00
Arturo Bernal 0080e84588
[MNG-7297] Remove redundant type arguments (#581) 2021-10-11 20:58:38 +02:00
Arturo Bernal 4daa48e0f6 [MNG-7287] Simplify assertion with simpler and equivalent calls
Closes #576
2021-10-10 22:34:07 +02:00
Arturo Bernal b31f3aeef3
[MNG-7291] Avoid String concatenation in loops (#572) 2021-10-10 22:12:41 +02:00
Arturo Bernal 16afe061c9 [MNG-7290] Java8 improvements
Closes #571
2021-10-10 12:50:42 +02:00
Arturo Bernal d61fcf7da1 [MNG-7288] Remove redundant local variables
Closes #569
2021-10-10 12:42:12 +02:00
Arturo Bernal b9fb762215 [MNG-7292] Unnecessarily escaped character
Closes #573
2021-10-10 12:18:15 +02:00
Arturo Bernal 4fafe44112 MNG-7296 - Remove redundant 'if' statement 2021-10-10 10:53:58 +02:00
Arturo Bernal e50d65d228 MNG-7295 - Remove redundant/unused import statements. 2021-10-09 16:26:14 +02:00
Tamas Cservenak 3017b85141
Refactor MavenSession#getPluginContext to be thread safe (#575)
This PR introduce no API change, merely refactors MavenSession
getPluginContext method to truly thread-safe.

Also added Javadoc to affected field and method.
2021-10-09 12:11:36 +02:00
Tamas Cservenak d75bea4154
[MNG-7279] Drop deprecated constructor (#564)
This constructor was deprecated in Maven 3.0-RC1 (!!!).
Removal also means that Maven4 will NOT work with
(Maven2 compatible) m-enforcer-p 2.x, only with
modern m-enforcer-p 3.x line.
2021-10-04 11:56:09 +02:00
Tamas Cservenak 69ee0c8b59
[MNG-7103] VersionScheme provider (#563)
This PR makes VersionScheme a component, is injected where needed
(instead of ad-hoc instantiation), but provides room for
different schemas, as GenericVersionScheme is "default"
but now nothing stops to add other schemes as well.
2021-10-04 11:55:18 +02:00
Tamas Cservenak c3962c1a6c
[MNG-7278] Clean up core logging (#562)
We had all kind of Loggers in Core, some Plexus
injected, some acquired using SLF4J LoggerFactory,
some static, some final, etc.

This PR aligns all those uses to SLF4J finals.

Notices:
* maven-core does NOT use Plexus Logger anymore
* did not touch maven-compat
2021-10-02 20:33:55 +02:00
Tamas Cservenak af9c64f80d
[MNG-6898] Drop plexus-component-metadata plugin from maven-core (#554)
Now that Plexus XMLs (and components) are out, no need
for this plugin in maven-core module anymore.

Changes:
* convert DefaultLifecyclePluginAnalyzer to JSR330 (last plexus component in core)
* drop dependency on plexus-component-annotations (note: it is still there but only as transitive dep of plexus-shim, needed to boot up Plexus Shim in tests)
* remove plexus-component-metadata plugin from build
* drop unused test Plexus XML
2021-10-02 15:40:58 +02:00
Tamas Cservenak d141957ff5
[MNG-7055] Fix G level metadata handling (#555)
Maven Artifact Transfer silently prevents group level metadata to reach Resolver and causes metadata loss on install/deploy. Fix is to "bridge" this from maven-resolver-provider (and core) by reusing the actual metadata that m-plugin-p:addPluginArtifactMetadata mojo adds, but m-a-t filters out.
2021-10-02 15:22:32 +02:00
Karl Heinz Marbaise 71a0a49904
[MNG-7272] - Code Improvement - II 2021-10-02 12:39:52 +02:00
Guillaume Nodet 35e5a4d71d [MNG-5577] Use JSR 330 constructor injection
# Conflicts:
#	maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecyclePluginAnalyzer.java
2021-10-02 12:26:22 +02:00
Karl Heinz Marbaise 25cf1576cc
[MNG-7271] - Code Improvement 2021-09-29 22:27:07 +02:00
Guillaume Nodet c8d5ba3705 [MNG-7235] Speed improvements when calculating the sorted project graph
This closes #532
2021-09-27 20:17:08 +02:00
Tamas Cservenak 6c7d105916
[MNG-7264] Convert maven-core default-bindings to Providers (#550)
This change get rids of Plexus components defined in META-INF/plexus/default-bindings.xml and converts them to Providers.
2021-09-26 13:34:27 +02:00
Tamas Cservenak 6c343136b0
Merge pull request #549 from apache/drop-components-xml
[MNG-7263] Convert maven-core components XML to Providers
2021-09-25 12:29:35 +02:00
Tamas Cservenak 2926f033cb [MNG-7265] Convert maven-core artifact-handlers.xml to Providers
Gets rid of another set of Plexus components defined in XML.

Changes:
* DefaultArtifactHandler was declared as component but it is not needed; not
  a component anymore
* Sanitize DefaultArtifactHandler class but retain Plexus XML provisioning
  compatiblity (as plugins does have it declared in Plexus XML) and update its
  uses within Maven code (be explicit)
* Use new "full" constructors in handler providers for easier comparison and
  inspection (be explicit)

This closes #551
2021-09-24 22:09:23 +02:00
Guoxiong Li 5fd536853f [MNG-7248] Fix warnings issued by dependency:analyze
This changeset does intentionally not touch Guice and its dependencies
as well as test-scoped dependencies.

This closes #546
2021-09-24 20:55:03 +02:00
Tamas Cservenak c647dbc665 Get rid of guava 2021-09-23 21:19:50 +02:00
Tamas Cservenak 4cb8909336 Convert maven-core components XML to Providers
This change get's rid of component.xml in maven-core
2021-09-23 11:13:46 +02:00
George Gastaldi a1ba33069f [MNG-7253] Display relocation message defined in model
Move logging to DefaultArtifactDescriptorReader

This closes #543
2021-09-18 20:39:37 +02:00
Guillaume Nodet 23ffe3349f [MNG-7236] The DefaultPluginVersionResolver should cache results for the session 2021-09-14 20:10:13 +02:00
Michael Osipov 6b6589bf1c [MNG-7219] [Regression] plexus-cipher missing from transitive dependencies 2021-09-14 19:21:08 +02:00
Falko Modler a6e462b53a [MNG-7251] Fix threadLocalArtifactsHolder leaking into cloned project
This closes #535
2021-09-14 17:22:42 +02:00
Tamas Cservenak 406c525ec4 [MNG-7250] Upgrade Sisu Inject/Plexus to 0.3.5
Since we have replaced the old JSR 250 library with javax.annotation library we
go straight to 1.3.2 because Maven Resolver 1.7.0 introduced this already as a
transitive dependency in fc806a25eb.
The only difference between version 1.2 and 1.3.2 is a Java upgrade from 6 to 8.

This closes #539
2021-09-13 22:57:31 +02:00
Tamas Cservenak 067171d28a [MNG-7246] Upgrade Plexus Cipher and Sec Dispatcher to 2.0
Both plexus-cipher and plexus-sec-dispatcher have had a
groupId change, but plexus-cipher change was implemented
for 1.8 version.

Latest versions of artifacts are 2.0. This PR
ups plexus-cipher version and adds proper changes
for plexus-sec-dispatcher groupId change.

This closes #534
2021-09-11 10:52:20 +02:00
Mickael Istria f594c0b916 Add ModelSource test for MNG-5669
This closes #525
2021-08-17 10:59:48 +02:00
Michael Osipov a2a3df3d02 [MNG-7203] Introduce a long option --verbose and deprecate --debug
This closes #519
2021-08-01 22:33:33 +02:00
rfscholte a2f81065ff [MNG-6656] Features must use userProperties instead of systemProperties 2021-07-23 11:21:18 +02:00
Michael Osipov e9a54c6d02 Use proper term: directory 2021-07-19 23:45:50 +02:00
Michael Osipov 78fc3734f9 Trim trailing whitespace 2021-07-02 18:47:10 +02:00
Michael Osipov b551be7445 Document hacks as such 2021-07-02 17:50:44 +02:00
Falko Modler 73e00ed85d [MNG-6843] Parallel build fails due to missing JAR artifacts in compilePath
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-06-25 19:28:40 +02:00
Sylwester Lachiewicz ab95197436 Fix Checkstyle reported issues with maven-shared-resources 3 2021-05-30 12:00:03 +02:00
rfscholte 12f3e7e878 Remove maven-test-support in favor of plexus-testing 2021-05-28 18:26:03 +02:00
Michael Simacek 83e36649c0 [MNG-6294] Convert MavenPluginValidator into a JSR 330 component
Modified by: Guillaume Dufour <guillaume.duff@gmail.com>

This closes #134 and closes #470
2021-05-03 08:09:58 +02:00
Michael Osipov 1a65351b43 Revert "[MNG-6772] Prevent Super POM central entry from overriding"
This reverts commit 2a23d7bf16.
2021-04-22 18:45:57 +02:00
rfscholte d6e70e297a [MNG-6917] Update maven-wrapper-plugin to 3.0.2 2021-04-08 19:41:43 +02:00
Hervé Boutemy b08e4d277e [MNG-6917] add wrapper lifecycle to reference documentation 2021-04-05 19:48:39 +02:00
Hervé Boutemy c4df060c26 fix javadoc 2021-04-05 10:11:39 +02:00
Hervé Boutemy 1b6caed1ea [MNG-6656] rename build+consumer filters to buildToRaw+rawToConsumer 2021-04-04 19:49:51 +02:00
Hervé Boutemy e25cf17d3b [MNG-6656] move to o.a.m.model.transform + .sax 2021-04-04 19:39:05 +02:00
Hervé Boutemy 22954a04ff [MNG-6656] rename maven-xml module to maven-model-transform 2021-04-04 13:24:41 +02:00
Martin Kanters 7c742c298b [MNG-7112] Do not select child modules when --non-recursive is given.
Closes #459
2021-04-02 16:11:49 +02:00
Martin Kanters c4cd93d55f [MNG-7102] Exclude all children of aggregators, even if the aggregator was already removed from the reactor. 2021-03-27 17:38:05 +01:00
Hervé Boutemy 1ab29f5485 [MNG-7128] keep blocked attribute from mirrors in artifact repositories 2021-03-27 03:00:25 +01:00
Maarten Mulders c3cf29438e [MNG-6511] Optional project selection
Closes #446.
2021-03-22 14:41:59 +01:00
Martin Kanters a02834611b [MNG-7102] The child modules of excluded projects are now excluded as well, making the behavior consistent with MNG-6981. 2021-03-22 13:16:42 +01:00
Michael Osipov 1e19805097 [MNG-6075] Increase the model validation level to the next minor level version
This closes #455
2021-03-20 15:09:33 +01:00
Hervé Boutemy 28b4ea92d3 [MNG-7117] add support for blocked mirror 2021-03-19 20:36:00 +01:00
Hervé Boutemy 3b21386c3f [MNG-7116] add support for mirrorOf external:http:* 2021-03-19 20:35:50 +01:00
Michael Osipov a5c68f7a4a Revert "[MNG-7046] Revert MNG-5639 and make repo config static only"
This reverts commit 8c9c303f9c.
2021-03-13 17:09:40 +01:00
Maarten Mulders ad24f599ce [MNG-7051] Return unmodifiable profile lists
This helps deprecation and keeps the code consistent.

Closes #452.
2021-03-08 16:52:28 +01:00
Martin Kanters 9643ac630c [MNG-7051] When an optional profile could not be found, an info message should be thrown instead of a warning. 2021-03-08 16:24:16 +01:00
Hervé Boutemy 0e75baae25 improve and fix javadoc 2021-03-05 21:23:44 +01:00
Romain Manni-Bucau a242c1a912 [MNG-6471] Parallel builder should use the module name as thread name
This closes #177
2021-02-28 19:59:45 +01:00
rfscholte 8ceb6c6e99 [MNG-7063] Infinite loop using Shade plugin and JUnit 5 dependency 2021-02-21 11:23:08 +01:00
Hervé Boutemy 9b5b8d4082 extract AbstractMavenLifecycleParticipant dispatch methods 2021-02-20 19:55:40 +01:00
Hervé Boutemy 441cf73c06 improve documentation 2021-02-20 19:34:43 +01:00
rfscholte 84a1ff2d5c [MNG-7063] Add unittest to ensure rereading a pom won't return the cached Model 2021-02-14 16:56:25 +01:00
Guillaume Nodet 619973b91c [MNG-7063] Infinite loop using Shade plugin and JUnit 5 dependency
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-02-14 15:52:04 +01:00
Guillaume Nodet f820b41aed [MNG-7095] Fix resume for parallel builds
Resolves #444
2021-02-13 11:32:34 +01:00
Guillaume Nodet 48fc10889e [MNG-7077] Use JUnit 5 extension
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-02-12 17:21:59 +01:00
boris-unckel 1e575a2bd7 [MNG-7068] Active dependency management for Google Guice/Guava
This closes #462
2021-02-02 14:17:43 +01:00
Maarten Mulders 8defd16965 [MNG-7051] Optionally skip non-existing profiles and break on missing required profiles. 2021-02-02 08:20:21 +01:00
Michael Osipov 8df10f93be Test for empty value and avoid needless space 2021-01-31 20:20:23 +01:00
Michael Osipov ceb08cfa77 Test for empty locations and avoid printing them 2021-01-30 23:04:46 +01:00
Guillaume Nodet bb916d0784 [MNG-7035] Migrate unit tests to Unit 5
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-01-15 15:07:06 +01:00
Martin Kanters 83dc6909aa [MNG-7071] Remove the profiles.xml warning, since the functionality is ignored since Maven 3. 2021-01-11 19:17:16 +01:00
Sylwester Lachiewicz b877445cb9 [MNG-6909] Convert to JSR330 in tests - maven-core
Closes #346
2021-01-08 03:55:24 +01:00
Michael Osipov a6d5e86155 Use consistent static final loggers 2021-01-05 15:47:20 +01:00