Commit Graph

983 Commits

Author SHA1 Message Date
Jason van Zyl c1f56fc847 o cleaning up more dead code in the hunt for "why the release plugin doesn't work again"
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572877 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 05:30:26 +00:00
Jason van Zyl 4925ac9702 o removing deprecated code in the plugin mechanism
o removing dead code
o examining how plugin version resolution is done, and we have a mix of a desire to use snapshots locally and pull releases
  remotely. if the repositories are mixed a snapshot will be pull automagically. this doesn't happen in practice but snapshots
  for plugin versions should be limited to a local search only.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572872 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 04:38:49 +00:00
Jason van Zyl 8077fb59ac o Why would a plugin be executing in its own POM. I think this is a far out case and you shouldn't be testing your plugin with its own POM. The comment is "I guess...". I don't think this is right.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572868 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 03:44:55 +00:00
Jason van Zyl ae1501b9f6 o collecting all logging/eventing into the core. i posted a list of possible errors that can occur in the core, the stuff we had was only
partially being use and we problems being emitted with messages like:

  NOTE: One or more purely derived expression elements were detected in this expression. 
  If you continue to get this error after any other expression elements are specified correctly
  please report this issue to the Maven development team.

  I think we have to make a very concerted effort to make useful messages because I'm tired of standing behind Maven
  users and being embarrassed when they look at me and ask "what does that mean?". "i actually have no idea."


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572456 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 00:05:04 +00:00
Jason van Zyl 2a241710f0 MNG-3182
MNG-3183

First cleanup of the logging code (it is still a mess), but all the console logging has been removed from the Maven component and pushed back
into the CLI code. As a result we now have a way to log to a file easily.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572408 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 19:33:10 +00:00
Jason van Zyl 441b918f80 o try and start localizing the handling of -f, release poms, and normal poms to the embedder. just too much funk
going on in the core.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572388 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 16:52:37 +00:00
Jason van Zyl cc1ca10d74 o separating out the MavenEmbedderProjectWithExtensionReadingTest which shows that the artifacts handlers must be loaded up-front
in the readProjectWithDependencies method because it is not being done in the core unless projects are executed. So Milos' assertion
  is correct. I'm now looking at a layered approach for project resolution and then execution so that the readProjectWithDependencies
  (which is essential for IDE integration) will yield something that can be pushed into the lifecycle executor. Right now there
  is much duplication which makes the IDE integration crappy.

  Another result of this is trying to create a simple IDE import model that gives back client code the fully resolved, topo sorted
  set of projects which point to binary dependencies outside the reactor, and to source folders inside the reactor. The result will
  be a useful model for all IDE integration, right now everyone is doing their own thing. This model will need hooks for customization
  to take into account turning "workspace resolution" on/off and allow easy overriding of this process.

o Fixed IT0035



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572366 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 15:42:29 +00:00
Jason van Zyl 08ed903945 MNG-1922: Making sure that CLI properties are processed first
o fixing IT0039


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572229 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 03:56:31 +00:00
Jason van Zyl 2425f945fb o adding a validation method to the lifecycle executor so that I can tell users what is wrong before actually trying
to execute the lifecycle. Trying to do this validation shows in detail how tangled some of our code is as I need
  to create the dispatcher in order to create the session which is required to make the reactorManager which 
  is required to get the project required to validate the goal name ... yah.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572214 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 02:35:05 +00:00
Jason van Zyl 5380116b79 MNG-2398: the lifecycle executor exception wasn't being propagated properly.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572210 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 01:39:28 +00:00
Jason van Zyl ed5868ebc7 MNG-3176 Adding a method to create the reactor manager as I want to use it for execution as well as the buildWithDependencies method.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572029 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:51:03 +00:00
Jason van Zyl 43dcac45b6 o get the information about whether a project is present from the request as per MNG-3177
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572023 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:43:20 +00:00
Jason van Zyl c184a161a3 o we assume there is a project and in DefaultMaven we will turn this off if we determine there is not one.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572021 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:39:26 +00:00
Jason van Zyl f6eb49fd0c MNG-3177: capture the presence of a project in the execution request
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572020 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:37:49 +00:00
Jason van Zyl acd024eeca o just expanding "rm" to "reactorManager" so there's some idea as to what it is
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572010 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 15:54:43 +00:00
Jason van Zyl 01fb7027ec o just expanding "rm" to "reactorManager" so there's some idea as to what it is
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572007 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 15:50:33 +00:00
Jason van Zyl 42807d7765 o remove debug output
o we don't need any but the super pom now for getting the initial repositories

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571919 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 02:13:00 +00:00
Jason van Zyl c0ce98d89a o don't need the private method anymore for getting the super pom
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571912 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 01:20:15 +00:00
Jason van Zyl f196fefba4 o as the profile has been removed from the super pom, we do not need to inject or process any profiles
related to it. this great simplifies a lot of code
o caching the super project in the default project builder as it's never going to change now as no profiles
  are inject so it will only have to be constructed once an instance.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571910 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:56:30 +00:00
Jason van Zyl 9dbe865b6e o the profile manager creation now happens up front in the embedder
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571903 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:01:30 +00:00
Jason van Zyl 884f70085e o integrate changes made in maven-artifact for non fail-fast and request/result usage in the embedder for
use in IDE integration to provide as much feedback as possible.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571862 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 19:23:17 +00:00
Brett Leslie Porter 959ce3f30f [MNG-3141] only canonicalize paths on Windows (to prevent path length issues, but not obliterate symlinks on unix)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@567954 13f79535-47bb-0310-9956-ffa450edef68
2007-08-21 04:54:04 +00:00
Brett Leslie Porter 7a8dd28f80 reformat before patch
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@567948 13f79535-47bb-0310-9956-ffa450edef68
2007-08-21 04:37:49 +00:00
John Dennis Casey 8795579469 [MNG-3062] Provide access to MojoExecution instance from plugin parameter expression ${mojoExecution}.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@565811 13f79535-47bb-0310-9956-ffa450edef68
2007-08-14 15:33:33 +00:00
John Dennis Casey c5a74a8242 Fixing a few problems with the model-lineage builder, where it was stubbing models inappropriately and other minor logical problems.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@564761 13f79535-47bb-0310-9956-ffa450edef68
2007-08-10 20:49:14 +00:00
Dennis Lundberg 0ceae1b648 o Minor adjustment to error message.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@562096 13f79535-47bb-0310-9956-ffa450edef68
2007-08-02 12:34:04 +00:00
Jason van Zyl 69a491ba0b o don't ever let the components-api jar through as we have one jar now and this JAR causes CCE all over the place, this will p protect against it ever getting pulled in.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@561193 13f79535-47bb-0310-9956-ffa450edef68
2007-07-31 00:21:04 +00:00
Jason van Zyl 6583991465 o updating to the new version of plexus which is the unified JAR once again. I can now move on
to doxia and attempt to use the same container for the trunk and branch.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@560496 13f79535-47bb-0310-9956-ffa450edef68
2007-07-28 04:57:37 +00:00
John Dennis Casey a87abe2d26 more formats.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559218 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:20:40 +00:00
John Dennis Casey 9c8011386d formatting for the message...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559216 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:18:05 +00:00
John Dennis Casey 8fab1c218a Fixing NPE.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559215 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:17:20 +00:00
John Dennis Casey aaba2df26c Fixing error message coming from a plugin phase-binding that cannot be resolved, or is unspecified.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559209 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:02:25 +00:00
John Dennis Casey f3f3c70321 Fixing infinite recursion when a mojo bound to the lifecycle forks a new phase that contains implies another phase that contains the bound mojo. This was triggered by the assembly:assembly mojo, and should look familiar.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@551696 13f79535-47bb-0310-9956-ffa450edef68
2007-06-28 20:53:55 +00:00
John Dennis Casey f479a38620 Adding a small comment about managed artifact versions in here.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@549970 13f79535-47bb-0310-9956-ffa450edef68
2007-06-22 22:09:22 +00:00
John Dennis Casey fda3badc24 Accumulate remote repositories when scanning for extensions, down the model lineage, starting with the original remote repositories passed in from outside.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@549968 13f79535-47bb-0310-9956-ffa450edef68
2007-06-22 22:02:10 +00:00
Jason van Zyl fc40bd04a6 MNG-3059 Make sure that dependencies listed in plugins are obeyed
Submitted by: Eric Redmond


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@548228 13f79535-47bb-0310-9956-ffa450edef68
2007-06-18 06:10:00 +00:00
Kenney Westerhof 6618c01021 Remove redundant argument - doesn't compile. I hope this is the right fix.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@547172 13f79535-47bb-0310-9956-ffa450edef68
2007-06-14 08:42:26 +00:00
Jason van Zyl a441f3d28a o exclude the rest of the xml classes
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@547149 13f79535-47bb-0310-9956-ffa450edef68
2007-06-14 06:58:56 +00:00
John Dennis Casey 19311574e1 Try to assume that a plugin bound in the POM but not resolved during build-plan-building will be resolvable later.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@545558 13f79535-47bb-0310-9956-ffa450edef68
2007-06-08 16:46:20 +00:00
John Dennis Casey 0c1b689e52 [MNG-3037] Combining plugin dependencies with plugin-level dependencies from the current project PRIOR to resolution, to enable version-conflict resolution to take place between the two sets of dependencies.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@544662 13f79535-47bb-0310-9956-ffa450edef68
2007-06-05 22:38:33 +00:00
Carlos Sanchez Gonzalez d8890819ad Fix path separator for failing test on windows
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@544314 13f79535-47bb-0310-9956-ffa450edef68
2007-06-04 22:26:34 +00:00
Jason van Zyl 9cb7e9af8c MNG-2934 Extensions should not be affected by the project's dependency resolution
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@544249 13f79535-47bb-0310-9956-ffa450edef68
2007-06-04 20:28:04 +00:00
Kenney Westerhof faf0da2430 Add cause to throws. 10 slaps on the wrist! ;)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543941 13f79535-47bb-0310-9956-ffa450edef68
2007-06-03 16:53:46 +00:00
Jason van Zyl 605227abb7 MNG-2860 Don't fly out of control when we encounter <module></module> in a POM
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543797 13f79535-47bb-0310-9956-ffa450edef68
2007-06-02 22:38:40 +00:00
Jason van Zyl 885409f569 o fix typo causing NPE setting properties
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543756 13f79535-47bb-0310-9956-ffa450edef68
2007-06-02 16:53:40 +00:00
Jason van Zyl cc5f2f954b Reverting the package changes
Issue id: MNG-2943


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543753 13f79535-47bb-0310-9956-ffa450edef68
2007-06-02 15:35:57 +00:00
John Dennis Casey 6d3984551c OPEN - issue MNG-2671: Parent/modules relative file path compression
http://jira.codehaus.org/browse/MNG-2671

Applied, with small changes so it will not swallow exceptions. If this causes a problem with broken symlinks, we can address that later.

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543682 13f79535-47bb-0310-9956-ffa450edef68
2007-06-02 00:43:15 +00:00
Carlos Sanchez Gonzalez 6d69087ae9 [MNG-2943] Avoid using package names used in other artifacts: add some comments
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543671 13f79535-47bb-0310-9956-ffa450edef68
2007-06-02 00:06:11 +00:00
Carlos Sanchez Gonzalez d050220b39 [MNG-2943] Avoid using package names used in other artifacts
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543657 13f79535-47bb-0310-9956-ffa450edef68
2007-06-01 23:12:33 +00:00
Jason van Zyl f2f86285a3 MNG-2687 prevent windows from potentially crapping out with long POM names
Submitted by: Stepan Roh


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@543361 13f79535-47bb-0310-9956-ffa450edef68
2007-06-01 02:29:24 +00:00