John Dennis Casey
facb56d1eb
Fixing compilation errors.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613035 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 01:38:37 +00:00
John Dennis Casey
89f482ac37
last of the error-reporting unit tests, and an additional error type to handle modules that are referenced but don't exist, which should stop the build. All tests pass.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613032 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 01:27:23 +00:00
John Dennis Casey
724b3db3c4
Adding more error-reporting unit tests.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612920 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 18:26:35 +00:00
John Dennis Casey
4bcfd7c5a5
more unit tests for error reporting on plugins-as-extensions.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612895 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 18:01:29 +00:00
John Dennis Casey
0c61152546
More unit tests, this time for plugin-related error messages.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612592 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 22:17:56 +00:00
John Dennis Casey
ca169d0262
Refactor management of activated, deactivated, and default-activated profile ids, so the context tracks all of that stuff.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612186 13f79535-47bb-0310-9956-ffa450edef68
2008-01-15 18:34:58 +00:00
John Dennis Casey
6e230d611a
two more unit tests, and a little simplification to take care of duplicated error reporting coverage.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611974 13f79535-47bb-0310-9956-ffa450edef68
2008-01-14 23:59:01 +00:00
John Dennis Casey
c3983894ab
Adding more error-reporting fixes and unit tests.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611945 13f79535-47bb-0310-9956-ffa450edef68
2008-01-14 21:44:59 +00:00
Milos Kleint
e10f025310
Add Thread.getId() to the realm identification, a simple trick to make DefaultMavenRealmManager lifecycle safe for paralel execution.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611615 13f79535-47bb-0310-9956-ffa450edef68
2008-01-13 18:19:35 +00:00
Milos Kleint
fc244926ca
comment on multithreading.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611548 13f79535-47bb-0310-9956-ffa450edef68
2008-01-13 08:41:12 +00:00
John Dennis Casey
25460922d5
More unit tests for error-reporting pointcuts, and some minor adjustments for duplicated handler methods.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611014 13f79535-47bb-0310-9956-ffa450edef68
2008-01-11 01:57:27 +00:00
John Dennis Casey
dc770e321b
Adding some unit tests (mostly stubbed out at the moment) to start testing the pointcuts used to shunt build errors off to the appropriate error-reporter method.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@610618 13f79535-47bb-0310-9956-ffa450edef68
2008-01-10 00:07:48 +00:00
Brian E Fox
c754ccad3a
MNG-2166: enhanced missing goal error info. (fix from 587339:587340 in 2.0.x)
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@609085 13f79535-47bb-0310-9956-ffa450edef68
2008-01-05 02:49:42 +00:00
John Dennis Casey
40c84ecb79
Fixing for windows users everywhere.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@605125 13f79535-47bb-0310-9956-ffa450edef68
2007-12-18 07:58:45 +00:00
John Dennis Casey
fe4363a4c5
Removing the build overlay, as it was causing problems with path translation, and doesn't serve any real purpose.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@605095 13f79535-47bb-0310-9956-ffa450edef68
2007-12-18 05:36:03 +00:00
John Dennis Casey
fbb4833982
Cleaning up reporting some more.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604750 13f79535-47bb-0310-9956-ffa450edef68
2007-12-17 00:15:21 +00:00
John Dennis Casey
b511c734a6
Fixing issues with reports used from the site plugin, where the reports' classloaders had been disconnected from the project/core parent realms, and so couldn't use maven libraries.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604685 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 20:09:43 +00:00
John Dennis Casey
fa0cce4fdb
Fixing case where pluginRealm == projectRealm to avoid setting parent realm == null. This would happen whenever the lifecycle forked, for instance, and would result in weird container classes not being found.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604643 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 16:11:18 +00:00
John Dennis Casey
45729dcafc
Improving binding for PluginParameterException report.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604642 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 16:10:21 +00:00
John Dennis Casey
10a192dfc2
fixing error reporting for when pom file is missing, and adding deprecated-mojo and deprecated-mojo-param warnings.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604538 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 01:28:17 +00:00
John Dennis Casey
5159c0b4b6
Error reporting works properly now.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604401 13f79535-47bb-0310-9956-ffa450edef68
2007-12-15 08:17:21 +00:00
John Dennis Casey
fe523d1151
Basic error reporting (tips aren't available for everything yet) is complete for everything the CLI typically handles directly.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603779 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 23:40:49 +00:00
John Dennis Casey
147f00077b
Fixing broken tests.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603455 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 04:17:58 +00:00
John Dennis Casey
441b096e79
Mapping in most of the rest of the maven-core errors to the error reporter...just need to finish the ExtensionManagerException mappings, then write error reports for the new mappings from today, and we should be in good shape.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603431 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 00:52:26 +00:00
John Dennis Casey
3e081b677a
Fixing the legacy lifecycle mappings back to compatibility with 2.0.x in terms of classname, then mapping them back to a field in the lifecycle executor so the enforcer plugin continues to function.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602972 13f79535-47bb-0310-9956-ffa450edef68
2007-12-10 17:22:33 +00:00
John Dennis Casey
1328959dca
Working on the compat aspect, and changing the DefaultMaven class to implement LogEnabled directly so I can grab the logger instance inside the compat aspect...AbstractLogEnabled is beyond the grasp of this aspect.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602610 13f79535-47bb-0310-9956-ffa450edef68
2007-12-09 02:09:44 +00:00
John Dennis Casey
a104251412
Fixing debug message that snuck in as info log-level.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602156 13f79535-47bb-0310-9956-ffa450edef68
2007-12-07 17:15:58 +00:00
John Dennis Casey
b38e6e2fad
Fixing compat aspect in cases where the Set being passed in is unmodifiable.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@601161 13f79535-47bb-0310-9956-ffa450edef68
2007-12-05 00:05:00 +00:00
John Dennis Casey
103a85a02b
Fixing plugins-as-extensions when brought in from pluginManagement to a module-project's build. Unit test included.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@601013 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 17:22:28 +00:00
John Dennis Casey
1db3b755ab
Fixing problem with new extensions manager code where custom lifecycle definitions are not used in build planning. Unit tests included.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@600792 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 04:32:13 +00:00
John Dennis Casey
f55eb07bda
Adding unit tests for plugin-as-extension in the extension scanner, cleaning up an unneeded call to registerWagons() (controlled by active collection now), and cleaning up a sysout in the embedder unit test.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599707 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 07:11:00 +00:00
John Dennis Casey
2ec256bab6
Removing pluginRepository use (finally), and fixing pluginGroups usage with profiles from the settings and super-POM without an accompanying pom.xml in the project directory...I know, something of a convoluted case.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599692 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 04:26:58 +00:00
John Dennis Casey
b61bb393a8
Cleaning up error reporting some for project building, and attempting to make the error reporter instances propagate to the aspects binding them to the error sources.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599503 13f79535-47bb-0310-9956-ffa450edef68
2007-11-29 16:33:57 +00:00
John Dennis Casey
9732014c53
Fixing case where parent pom has pluginManagement, child does not refer to the plugin, and plugin is used directly on the command line...version from parent-pom pluginManagement should be used. Test case to follow.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599338 13f79535-47bb-0310-9956-ffa450edef68
2007-11-29 08:42:38 +00:00
John Dennis Casey
941a11381c
Adding aspect-bound error reporting for BuildFailureException descendants.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@598900 13f79535-47bb-0310-9956-ffa450edef68
2007-11-28 08:11:49 +00:00
John Dennis Casey
249af52bb5
Wiring plugin-as-extension back into the new extension scanning stuff.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@598720 13f79535-47bb-0310-9956-ffa450edef68
2007-11-27 17:59:22 +00:00
Milos Kleint
deca7349ff
add maven-toolchain to the list of default excludes. necessary for proper retrieval from MavenSession's plugin context.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@597154 13f79535-47bb-0310-9956-ffa450edef68
2007-11-21 17:40:39 +00:00
John Dennis Casey
5fc3d35ce0
Removing maven-build-context, and replacing it with caching aspects for model-lineage stuff and project instances. Still needs caching for artifact resolution, and I have an aspect for this too, but it's not enabled yet, since it's still buggy.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@595215 13f79535-47bb-0310-9956-ffa450edef68
2007-11-15 05:37:55 +00:00
Vincent Siveton
643119482b
o merged r594510 (fixed line size)
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@594511 13f79535-47bb-0310-9956-ffa450edef68
2007-11-13 12:39:55 +00:00
Jason van Zyl
1a286e2325
o adding PomMetadataSource for the changes to maven-artifact
...
o adding in all the artifact handlers here as they are Maven specific and don't belong in maven-artifact
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593857 13f79535-47bb-0310-9956-ffa450edef68
2007-11-11 08:10:35 +00:00
John Dennis Casey
7fcf47aa8c
formats.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593625 13f79535-47bb-0310-9956-ffa450edef68
2007-11-09 19:16:06 +00:00
John Dennis Casey
9c9bcde5f4
[MNG-3193] Adding pointcut and advice to provide backward compat on invalid lifecycle phase names (these bindings will be ignored).
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593310 13f79535-47bb-0310-9956-ffa450edef68
2007-11-08 21:06:31 +00:00
John Dennis Casey
08947e7efb
Working on cleaning up exceptions and reporting (these changes are from before the break I took to work on memory profiling in maven and plexus).
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593294 13f79535-47bb-0310-9956-ffa450edef68
2007-11-08 20:33:27 +00:00
John Dennis Casey
ed568e725f
Make reporting plugin configuration always used (even if mojo in question is not a report), as in 2.0.x
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@592949 13f79535-47bb-0310-9956-ffa450edef68
2007-11-07 23:28:45 +00:00
John Dennis Casey
febce07c90
Adding more context information to existing exceptions, cleaning up construction in exceptions, and adjusting the inheritance hierarchy for exceptions to make them make a little more sense for error reporting. Also, adding improved (but not complete, yet) reporting for BuildFailureExceptions and ProjectBuildingExceptions, with some tests to make sure pertinent information is in the output.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@592859 13f79535-47bb-0310-9956-ffa450edef68
2007-11-07 19:24:30 +00:00
John Dennis Casey
a1f995029a
cleaning up NPE in the realm manager, and adding clear() method calls to the embedder to cleanup the realm manager after it's used, to try to keep the number of open realms to a minimum...
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@592222 13f79535-47bb-0310-9956-ffa450edef68
2007-11-06 01:34:38 +00:00
Brian E Fox
dbd357ffdf
fixed windows test error
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@591922 13f79535-47bb-0310-9956-ffa450edef68
2007-11-05 09:08:40 +00:00
John Dennis Casey
fe8c4071a6
Switching back to selectively import extensions into a project-specific ClassRealm, except this time extension realms will be shared (the origin of the aforementioned imports) to conserve memory tied up by classloading. Similarly, plugin realms are managed using a key produced from g 🅰️ v of the plugin, plus the hashcode of all g 🅰️ v of the plugin-level dependencies aggregated into one string, to distinguish the deploy plugin 2.0 with no deps from the deploy plugin 2.0 with a plugin-level dep on wagon-webdav. Plugin realms have their parent realms managed by the pluginManager now prior to lookup or execution of the mojo instance, and PluginDescriptor.(classRealm|artifacts) attributes are set for each execution. Likewise, the MavenPluginCollector now tracks plugin descriptors with their version information included, instead of just using g:a.
...
Had to bump the plexus-container-default version up to alpha-36 to fix a problem in ClassicSingletonComponentManager. All realms for extensions, plugins, and projects (which contain only imports from extensions) are now managed by the MavenRealmManager.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@591391 13f79535-47bb-0310-9956-ffa450edef68
2007-11-02 16:44:00 +00:00
John Dennis Casey
f87308819f
Bake compat-aspect weaving into the build for all profiles, to alleviate problems with the non-standard embedder creation.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@590803 13f79535-47bb-0310-9956-ffa450edef68
2007-10-31 19:52:38 +00:00
John Dennis Casey
27698689a8
Adding compat trailer to the maven version when it's printed via the cli.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@590758 13f79535-47bb-0310-9956-ffa450edef68
2007-10-31 17:26:37 +00:00