rfscholte
72dca39807
Replace org.apache.commons.lang3.Validate#notNull with java.util.Objects#requireNonNull
2018-07-15 10:36:08 +02:00
Christian Schulte
5b4e173f7d
[MNG-5940] Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
...
This closes #168
2018-06-10 13:12:53 +02:00
Michael Osipov
8e0efaa107
[MNG-6386] ${project.baseUri} is not a valid URI (according to RFC 3986)
...
File#toURI()#toString() produces a non-compliant URI making tools like
Subversion or Git to choke on those URIs. Whereas Path#toUri()#toASCIIString()
does the right job.
2018-05-07 22:35:43 +02:00
Sylwester Lachiewicz
b8c06e61ab
Remove Google Guava usage (move to Java7)
2018-02-11 11:54:17 +01:00
Sylwester Lachiewicz
d925081794
Reduce number of global checkstyle rule violations
...
Fix code for following checkstyle rules:
ConstantName, FileLength, InnerAssignment, JavadocType, MagicNumber, MethodLength, MethodName, NewlineAtEndOfFile, ParameterNumber, RedundantThrows, VisibilityModifier
Fixes #149
2018-02-11 11:41:16 +01:00
Hervé Boutemy
0dc70cc691
upgrade m-site-p to 3.7 + Fluido 1.7 + edit button
2018-02-10 11:42:33 +01:00
Hervé Boutemy
cf7b0a3ec0
fixed new issues reported by Checkstyle 6.18
2018-02-10 11:42:33 +01:00
Hervé Boutemy
085ee9f275
[MNG-5992] Upgrade default version of maven-release-plugin to 2.5.3
...
avoids exposing Git password during release
this fixes #152
2018-02-08 08:02:04 +01:00
Karl Heinz Marbaise
5988085525
[MNG-6342] Emit a WARNING about LATEST/RELEASE in parent
2018-01-19 23:43:59 +01:00
Karl Heinz Marbaise
6b83f7e6bb
[MNG-6305] Validation of CI friendly version incorrect
...
o Followup removed unused declarations.
2017-12-30 22:09:02 +01:00
Karl Heinz Marbaise
2295c17b45
[MNG-6305] Validation of CI friendly version incorrect
...
o Checkin that only the three expression changelist,
revision and sha1 are valid in a version.
o Added some tests.
2017-12-30 21:41:18 +01:00
rfscholte
df5169bdf9
[MNG-6330] Parents relativePath not verified anymore
2017-12-29 10:39:45 +01:00
Karl Heinz Marbaise
8f8c45c990
[MNG-6123] detect self references in POM and fail fast
...
o Added unit test and self referencing pom
2017-08-01 22:01:36 +02:00
dejan2609
12d6471337
[MNG-6207] Create WARNINGs in case of using system scope
...
o display deprecation build warning for dependencies with scope 'system' declaration
o Note about tests: existing 'systemPath' related tests are reused/expanded
(rationale: scope 'system' and 'systemPath' are mutually dependent)
Signed-off-by: Karl Heinz Marbaise <khmarbaise@apache.org>
2017-06-11 13:55:07 +02:00
dejan2609
eb6b212b56
[MNG-6206] display deprecation build warning in case when dependencies
...
use metaversions (LATEST or RELEASE)
Signed-off-by: Karl Heinz Marbaise <khmarbaise@apache.org>
2017-06-04 20:23:02 +02:00
Christian Schulte
8400984ac5
[MNG-6112] Central repository in the 4.0.0 super POM should declare update policy 'never'.
...
This reverts commit 13adc1bc2b
*not changing
anything* just because someone did not react in time when this issue had been
lying around on a branch. If we would set pace for the industrie, everyone would
still be using 5.25" floppy disks and 8 bit hardware and we would tell them
that upgrading to be able to use new software would be too risky and they
better keep theire broken assembly routines until the machine goes up in
smoke.
2017-03-25 20:53:06 +01:00
Christian Schulte
0931bb2cc7
[MNG-6168] Fix unclosed streams
2017-03-24 22:04:37 +01:00
Christian Schulte
13adc1bc2b
[MNG-6112] Central repository in the 4.0.0 super POM should declare update policy 'never'.
2017-03-21 00:30:28 +01:00
Christian Schulte
d54e6f91a8
s/@since 3.5.0-alpha-2/@since 3.5.0/g
2017-03-21 00:21:43 +01:00
Hervé Boutemy
1638280261
[MNG-6189] warn if maven-site-plugin reportPlugins is configured
2017-03-19 21:51:53 +01:00
rfscholte
0e7e3eeb59
[MNG-6176] Javadoc errors prevent release with Java 8
...
Upgrade to modello-1.9.1
Fix javadoc errors in tests
2017-03-18 12:55:05 +01:00
Karl Heinz Marbaise
51cc76c326
[MNG-6090] CI friendly properties break submodule builds
...
[MNG-6057] Problem with CI friendly usage of ${..} reactor order is changed
o Based on the missing replacement of the versions ${revision}
${changelist} or ${sha1} within the parent element the order
of the reactor changes.
[MNG-5895] Problem with CI friendly usage of ${..} which is already
defined via property in pom file.
2017-03-13 22:08:51 +01:00
rfscholte
587317b009
[MNG-6176] Javadoc errors prevent release with Java 8
...
Upgrade modello to 1.9.0
Fix invalid Javadoc
2017-03-10 16:17:28 +01:00
Christian Schulte
ab800b0cfa
[MNG-6182] ModelResolver interface enhancements.
2017-03-08 18:24:18 +01:00
Hervé Boutemy
0db5e32cf5
fixed documentation errors
2017-02-23 19:07:58 +01:00
Hervé Boutemy
985b5985f3
fixed link
2017-02-18 18:13:06 +01:00
Michael Osipov
b66bdb9cbc
[MNG-6150] Javadoc improvements for 3.5.0
...
* Remove duplicate plugin configuration
* Add workaround for Javadoc locale
* Clean up errors reported by Javadoc 7
Note: Javadoc 8 fails immediately because Modello generates invalid
Javadoc
2017-02-15 17:30:46 +01:00
Alex Henrie
8d91726f78
[MNG-5934] String handling issues identified by PMD
2017-02-11 14:08:24 +01:00
Christian Schulte
0514c1b14e
[MNG-2199] Support version ranges in parent elements
...
o Updated to fix parent version range resolution broken since 3.2.3 and to
remove parent version range resolution logic obsolete since Maven
3.2.3 which changed the initialization of MavenProject instances.
o Updated local parent resolution to behave the same way remote parent
resolution behaves. When referencing a parent using version ranges,
inheriting the version or using version expressions should not be supported.
It has been implemented that way for remote parent resolution as it got
introduced in Maven 3.2.2. For local parent resolution the version in parent
declarations had been ignored completely as of Maven 3.3.0 due to commit
be3fb20032
removing all local parent version
validation. Work on fixing this is tracked by MNG-5840 released with Maven
3.3.9. This commit adds the final missing bits to make local and remote parent
resolution behave the same way as much as possible. As an exception, remote
parent resolution still is a bit more strict than local parent resolution due
to a different API in use. When resolving a parent from a repository using
version ranges, the ModelBuilder verifies the range in use to declare an upper
bound. When resolving a parent locally using version ranges, those ranges are
not required to declare an upper bound because the API in use does not support
querying that. Authoring a POM relying on this difference should be considered
a bug.
o Added test cases to maven-core testing parent version range resolution for
local and remote parent models.
2017-02-10 22:46:52 +01:00
Josh Soref
1be7ea893e
[MNG-6165] Deprecate and replace incorrectly spelled public API
...
Spelling fixes:
* spelling: collector
* spelling: executions
* spelling: repositories
* spelling: workspace
This closes #101
2017-02-06 20:36:38 +01:00
Josh Soref
1740265984
[MNG-6146] Several small stylistic and spelling improvements to code and documentation
...
Spelling fixes:
* system
* tokenizer
* toolchain
* trailing
* transitive
* unsupported
* version
* artifact
* attachment
* codehaus
* colleagues
* comparison
* concurrency
* configure
* creation
* dependency
* descriptor
* downstream
* efficient
* e.g.
* elements
* encountered
* encounters
* environments
* executed
* explicitly
* happens
* hierarchical
* hierarchy
* ignore
* implemented
* implementers
* independence
* indicates
* inheritance
* inherited
* inherits
* install
* interface
* javascript
* laziness
* management
* maven
* metadata
* mgmt
* minimalist
* nonexistent
* objects
* overridden
* print
* project
* properties
* recessive
* referring
* repository
* representation
* retrieval
* retrieve
* rigorous
* should
* spontaneously
* subsequent
Literal fixes:
* use static final values
Style fixes:
* use the proper term for char U+002D (-) hyphen(-minus) instead of dash
This closes #100
2017-02-03 10:12:28 +01:00
Hervé Boutemy
9b763cc002
[MNG-5878] added project.directory property to support module name !=
...
artifactId in every calculated URLs
2017-02-01 08:01:11 +01:00
Karl Heinz Marbaise
017dcaf22a
[MNG-5993] Confusing error message in case of missing/empty
...
artifactId/groupId and version in pluginManagement
2017-01-29 21:12:49 +01:00
Guillaume Boué
5b4b8bd94c
[MNG-6105] properties.internal.SystemProperties.addSystemProperties() is not really thread-safe
...
Refactoring the current code setting system properties to synchronize correctly on the given ones: avoids ConcurrentModificationException and NullPointerException if the properties is modified by another thread.
2017-01-28 14:07:59 +01:00
Stephen Connolly
1953284925
[MNG-5840] A regression had crept in and was missed as the intergration tests were not running the MNG-5840 tests
2015-11-02 12:17:23 +00:00
Hervé Boutemy
2f7daeff58
[MNG-5871] refactoring: improved empty urls handling
2015-10-31 12:55:47 +01:00
Jason van Zyl
f684761dee
Fix for urls being empty in the POM and causing an out of bounds exception
2015-10-29 18:33:59 -07:00
Michael Osipov
618e62dd33
[MNG-5649] Use Commons Lang's Validate to intercept invalid input
...
Use wherever possible Validate with consistent messages and exceptions.
2015-10-16 17:32:57 +02:00
Michael Osipov
2ec27257b4
[MNG-5907] org.apache.maven.repository.internal.RemoteSnapshotMetadataTest fails starting at midnight
...
Added missing import.
2015-10-10 16:03:46 +02:00
Michael Osipov
b711de57dc
[MNG-5906] Use canonical name for UTC timezone
2015-10-10 14:39:31 +02:00
Hervé Boutemy
2669980461
[MNG-5887] updated Modello site url
2015-09-14 19:52:21 +02:00
Hervé Boutemy
2877b590f1
use StringBuilder instead of String to avoid temporary String creation
2015-09-06 09:53:24 +02:00
Hervé Boutemy
a2eb2fe3ee
added extensive urls inheritance unit tests, even for most tricky parts
2015-09-02 04:36:00 +02:00
Hervé Boutemy
200d2f9935
MNG-5871 refactoring: put url extrapolation algorithm in inheritance
...
model merger
2015-08-17 21:03:08 +02:00
Robert Scholte
58348a8971
Merging is done before validation, so ensure that artifactId and
...
modelVersion are never inherited
2015-08-15 14:57:24 +02:00
Robert Scholte
7f21ebe055
Add unittests for elements of Model which are neither inherited nor
...
injected.
Ignoring artifactId and modelVersion, these are required elements.
2015-08-12 22:18:00 +02:00
Hervé Boutemy
c5dd16988e
fixed error reported by Checkstyle
2015-08-09 17:25:00 +02:00
Hervé Boutemy
28d284b8c0
improved comments
2015-08-09 16:53:00 +02:00
Hervé Boutemy
33de197133
improved documentation: list urls from POM that are extrapolated with
...
artifact id during inheritence
2015-08-09 16:39:46 +02:00
Hervé Boutemy
fd90ca20fe
updated wiki content link: docs.codehaus.org has shut down
2015-08-03 00:14:51 +02:00
Stephen Connolly
bd87258629
[MNG-5840] The fix for parent version validation caused a regression in the parent version range
...
- With this change we basically unwind MNG-5840 for the rumoured validation in the workspace resolver
when dealing with a parent version range. Not ideal but only way for now to retain the version range feature
2015-07-22 13:02:51 +01:00
Stephen Connolly
ec14b8ad4c
curses upon you IDE for screwing up the formatting
2015-07-22 09:09:31 +01:00
Stephen Connolly
25f5143169
[MNG-5840] The fix for parent version validation caused a regression in the parent version range
...
- With this change we basically unwind MNG-5840 for the rumoured validation in the workspace resolver
when dealing with a parent version range. Not ideal but only way for now to retain the version range feature
2015-07-22 08:38:05 +01:00
Karl Heinz Marbaise
15223116a6
Fixed URL's to issue tracking after transition to
...
Apache Software Foundation.
2015-07-19 09:53:50 +02:00
sugartxy
7f206ef1cc
try-with-resources
...
Reformatted to code style by me. This fixes #53
2015-06-20 14:32:46 +02:00
Kristian Rosenvold
7badeb5b5b
Upgraded to java7 language features
2015-06-20 10:56:07 +02:00
Stephen Connolly
40d5087b6b
[FIXES MNG-5840] if the pom.xml at <relativePath> is the same groupId:artifactId but different version fall back to the repository for parent resolution
2015-06-05 11:26:13 +01:00
Jason van Zyl
be3fb20032
MNG-5775 Make the project graph building code pluggable to allow for new/different implementations.
2015-03-01 12:39:30 -08:00
Joseph Walton
b8dcb08731
MNG-5734: Fail, rather than just warning, on empty '<module>' entries.
...
An incorrect non-blank module is currently treated as an error. Behave
the same way for a blank module, rather than simply warning about
the mistake.
Signed-off-by: Jason van Zyl <jason@tesla.io>
2015-02-21 09:22:27 -05:00
Robert Scholte
786285f1f4
Add @Override on matching methods
2015-01-24 20:45:25 +01:00
Hervé Boutemy
d37fbf6011
improve model building documentation
2014-12-26 18:06:02 +01:00
Robert Scholte
df21509310
Fix violations reported by checkstyle
2014-12-23 16:49:26 +01:00
Robert Scholte
a7ef70181c
[MNG-5740]: Add module maven-builder-support
...
Move Source-code to maven-builder-support and let original classes extend these
2014-12-23 14:09:01 +01:00
Igor Fedorenko
8788c90abe
allow custom Model dependency version validation rules
...
Signed-off-by: Igor Fedorenko <ifedorenko@apache.org>
2014-11-25 19:11:01 -05:00
Michael Osipov
0343c52601
Trimmed trailing whitespace
2014-11-23 13:04:30 +01:00
Hervé Boutemy
366f57c563
updated parent pom (and fixed issues...)
2014-10-24 01:25:49 +02:00
brianf
9216191869
default to ssl for central
2014-08-11 08:41:48 -04:00
markdingram
61c3740425
Fixes MNG-5663 - a regression introduced in 3.2.2 by MNG-5639 that prevents nested import POMs from resolving their dependencies.
...
The cuplrit was the resetRepositories method in tandem with the repository
list instances being shared between ModelResolvers.
- The copy constructor for the ModelResolvers now creates new lists.
- The resetRepositories method has been removed. Instead there is a
'replace' parameter on the addRepository method that allows the
desired parameter replacement of MNG-5639 to take place.
Signed-off-by: Jason van Zyl <jason@tesla.io>
2014-07-18 19:30:32 -04:00
Hervé Boutemy
ffff00e908
fixed errors reported by Checkstyle
2014-06-16 18:30:24 +02:00
Michael Osipov
e9e8a20907
Modified index.apt to reflect output changes from MNG-5176.
2014-06-15 21:03:46 +02:00
Michael Osipov
cdb8ad6dd1
[MNG-5647] ${maven.build.timestamp} uses incorrect ISO datetime
...
separator
- Fully utilize extended ISO timestamp
- Added changes to index.apt
2014-06-15 21:01:55 +02:00
Christian Schulte
045bd1503b
MNG-2199: Version ranges not supported for parent artifacts
...
Fixes #21
Signed-off-by: Jason van Zyl <jason@tesla.io>
2014-06-14 16:47:00 -04:00
Hervé Boutemy
6683e8681f
code formatting
2014-06-14 00:08:07 +02:00
Jason van Zyl
2a4d172600
MNG-5452: ${maven.build.timestamp} should use UTC instead of local timezone (or be configurable)
2014-06-13 10:25:37 -04:00
Mysterion
c6529932f9
Add solution to http://jira.codehaus.org/browse/MNG-4565
...
Signed-off-by: Jason van Zyl <jason@tesla.io>
2014-06-10 16:46:10 -04:00
Mark Ingram
016932edbc
MNG-5639: Support resolution of Import Scope POMs from Repo that contains a ${parameter}
...
Fix up previous
Signed-off-by: Jason van Zyl <jason@tesla.io>
2014-06-10 08:55:24 -04:00
Hervé Boutemy
6d05ac1adc
added raw model validation step
2014-04-19 21:25:34 +02:00
Hervé Boutemy
8e53ed0f65
disable interpolation on full profile activation, not only file based
2014-03-31 21:44:47 +02:00
Hervé Boutemy
c175789747
[MNG-5612] avoid fully interpolated values for file based profile
...
activation values but effective values calculated during activation
2014-03-30 23:46:03 +02:00
Hervé Boutemy
fb27b79250
make warning for ${project.basedir} and ${project.*} different: first
...
should be replaced with ${basedir}, latter is simply not supported
2014-03-30 10:27:44 +02:00
Robert Scholte
06a7d6dd8b
MNG-5608: warn if file-based profile activation uses ${project.basedir} since only ${basedir} is supported
2014-03-29 14:36:14 +01:00
Hervé Boutemy
a74893f246
improved documentation: ${basedir} for profile activation is Maven 3
...
only
2014-03-28 08:20:51 +01:00
Hervé Boutemy
64c4195067
[MNG-5608] added a warning on ${project.basedir} use for profile
...
activation
2014-03-23 19:58:26 +01:00
Hervé Boutemy
3c7744a9a0
[MNG-5590] improved documentation about interpolation on file activation
2014-03-23 16:36:01 +01:00
Hervé Boutemy
4a39c02156
fixed errors reported by Checkstyle
2014-02-08 16:38:31 +01:00
Jason van Zyl
88d0abcd30
MNG-5576 Start allowing continuous delivery friendy versions
2014-02-06 21:55:10 -05:00
Robert Scholte
65c135d529
[MNG-3832] Allow wildcards in dependency exclusions
...
Already supported since M3.0, now adjust warnings
2013-11-21 22:17:43 +01:00
Arnaud Héritier
da48cfff83
Code cleanup - Redundant array creation for calling varargs method
2013-06-11 22:27:26 +02:00
Arnaud Héritier
1f84f8f296
Code cleanup - Maven requires Java 5+ : Replace String.indexOf() by String.contains()
2013-06-11 22:19:20 +02:00
Arnaud Héritier
9e5183f0ad
Code cleanup - Various code simplifications (tests, loops, …)
2013-06-11 22:09:51 +02:00
Arnaud Héritier
87a5532eb9
Code cleanup - Remove useless semi-colons
2013-06-11 22:04:29 +02:00
Arnaud Héritier
96db1abbe9
Code cleanup - Maven requires Java 5+ : Remove unnecessary boxing
2013-06-11 21:43:53 +02:00
Stephen Connolly
c6c6bdc49f
Add ASL license header
2013-05-28 10:19:32 +01:00
Hervé Boutemy
f34b4fbdfc
[MNG-5477] finally removed reporting plugin version validation since a
...
warning is issued in maven-site-plugin in case of missing version. Then
removed reporting plugin version injection too
2013-05-23 18:54:08 +02:00
Hervé Boutemy
4db66fd06c
[MNG-5477] inject pluginManagement and build plugins versions into
...
report plugins to avoid validation warnings
2013-05-21 00:17:25 +02:00
Hervé Boutemy
ed1501ecb5
[MNG-5477] check warning issued when no version in reporting section
2013-05-20 23:10:31 +02:00
Hervé Boutemy
7d359445d1
[MSITE-484] reporting section cannot be deprecated in Maven core for the
...
moment
2013-05-18 12:16:51 +02:00
Hervé Boutemy
9404499ccd
maven-dependency-plugin 2.8 released, now compatible with Eclipse Aether
2013-05-18 08:34:42 +02:00
Hervé Boutemy
42962fa281
code formatting
2013-03-30 09:37:11 +01:00
Hervé Boutemy
e438f1140e
added information about encoding configuration
2013-03-19 01:21:13 +01:00