Commit Graph

485 Commits

Author SHA1 Message Date
Hervé Boutemy 53ccee3486 [MNG-6778] use https for schema location 2019-11-09 13:45:14 +01:00
rfscholte 38efe8444c Fix checkstyle reported errors 2019-09-10 18:51:18 +02:00
Dezhi Cai d09bc7437f [refactor] use utility method of Objects to simplify code (#284)
* [refactor] use utility method of Objects to simplify code

* [refactor] use utility method of Objects to simplify code
2019-09-10 16:22:22 +10:00
Michael Osipov 2d0c3bc75b [MNG-6704] MavenRepositorySystemUtils.newSession() misses assignment 2019-07-25 21:58:26 +02:00
Joseph Walton 353d3eaa8f [MNG-6685] Convert Maven Model Builder to JSR 330
This closes #256
2019-06-23 00:20:54 +02:00
HoaPhan ba74b96633
[MNG-6492] - Minor improvement on Array construction, conversion performance 2018-10-24 18:07:13 +02:00
Christian Schulte 44826ab446 [MNG-6164] Collections inconsistently immutable
Make non-empty collections returned immutable just like those returned by
java.util.Collections.
2018-10-09 22:12:50 +02:00
Sylwester Lachiewicz 27864904fe Fixed typo in exception logging LegacyRepositorySystem
Fixes #170
2018-10-08 20:14:53 +02:00
Michael Osipov 9021d66e53 Move ArtifactUtilsTest and friends from maven-compat to maven-artifact 2018-05-08 00:18:49 +02:00
kevin-canadian 14365baabe [MNG-6403] Artifact#VERSION_FILE_PATTERN does not escape period between date and time
This closes #112
2018-05-08 00:14:09 +02:00
Michael Osipov 8e0efaa107 [MNG-6386] ${project.baseUri} is not a valid URI (according to RFC 3986)
File#toURI()#toString() produces a non-compliant URI making tools like
Subversion or Git to choke on those URIs. Whereas Path#toUri()#toASCIIString()
does the right job.
2018-05-07 22:35:43 +02:00
Sylwester Lachiewicz d925081794 Reduce number of global checkstyle rule violations
Fix code for following checkstyle rules:
ConstantName, FileLength, InnerAssignment, JavadocType, MagicNumber, MethodLength, MethodName, NewlineAtEndOfFile, ParameterNumber, RedundantThrows, VisibilityModifier

Fixes #149
2018-02-11 11:41:16 +01:00
Hervé Boutemy 0dc70cc691 upgrade m-site-p to 3.7 + Fluido 1.7 + edit button 2018-02-10 11:42:33 +01:00
Michael Osipov f7d4bce233 [MNG-6149] MetadataResolutionResult#getGraph() never resolves request type 'test' 2017-04-21 22:57:53 +02:00
Stephen Connolly b12905ce02 [MNG-6176] Fix javadoc *errors* in maven-compat 2017-03-18 12:34:45 +00:00
Karl Heinz Marbaise 51cc76c326 [MNG-6090] CI friendly properties break submodule builds
[MNG-6057] Problem with CI friendly usage of ${..} reactor order is changed
 o Based on the missing replacement of the versions ${revision}
   ${changelist} or ${sha1} within the parent element the order
   of the reactor changes.
[MNG-5895] Problem with CI friendly usage of ${..} which is already
defined via property in pom file.
2017-03-13 22:08:51 +01:00
Karl Heinz Marbaise 809ba34055 Code improvement. 2017-03-11 20:53:18 +01:00
August Shi e6217a4555 Fixing misspellings in test names 2017-02-18 18:29:19 +01:00
Michael Osipov b66bdb9cbc [MNG-6150] Javadoc improvements for 3.5.0
* Remove duplicate plugin configuration
* Add workaround for Javadoc locale
* Clean up errors reported by Javadoc 7

Note: Javadoc 8 fails immediately because Modello generates invalid
Javadoc
2017-02-15 17:30:46 +01:00
Alex Henrie 8d91726f78 [MNG-5934] String handling issues identified by PMD 2017-02-11 14:08:24 +01:00
Josh Soref 1be7ea893e [MNG-6165] Deprecate and replace incorrectly spelled public API
Spelling fixes:

* spelling: collector
* spelling: executions
* spelling: repositories
* spelling: workspace

This closes #101
2017-02-06 20:36:38 +01:00
Josh Soref 1740265984 [MNG-6146] Several small stylistic and spelling improvements to code and documentation
Spelling fixes:

* system
* tokenizer
* toolchain
* trailing
* transitive
* unsupported
* version
* artifact
* attachment
* codehaus
* colleagues
* comparison
* concurrency
* configure
* creation
* dependency
* descriptor
* downstream
* efficient
* e.g.
* elements
* encountered
* encounters
* environments
* executed
* explicitly
* happens
* hierarchical
* hierarchy
* ignore
* implemented
* implementers
* independence
* indicates
* inheritance
* inherited
* inherits
* install
* interface
* javascript
* laziness
* management
* maven
* metadata
* mgmt
* minimalist
* nonexistent
* objects
* overridden
* print
* project
* properties
* recessive
* referring
* repository
* representation
* retrieval
* retrieve
* rigorous
* should
* spontaneously
* subsequent

Literal fixes:

*  use static final values

Style fixes:

* use the proper term for char U+002D (-) hyphen(-minus) instead of dash

This closes #100
2017-02-03 10:12:28 +01:00
Christian Schulte a3cdfbbbe9 [MNG-5368] UnsupportedOperationException thrown when version range is not correct in dependencyManagement definitions
o Updated to log an error message for any caught 'InvalidVersionSpecificationException's.
2017-01-31 22:44:59 +01:00
Michael Osipov f53f1547a1 [MNG-6147] MetadataResolutionResult#getGraph() contains duplicate if clause 2017-01-28 17:09:30 +01:00
Michael Osipov 920f10a561 [MNG-6144] DefaultWagonManagerTest#testGetMissingJarForced() passed incorrect value
This closes #86
2017-01-28 17:09:30 +01:00
Christian Schulte a99a78984c o Updated to remove errors reported by Checkstyle. 2017-01-25 08:09:30 +01:00
Hervé Boutemy 60e4fa650f updated notice 2017-01-25 00:08:12 +01:00
Hervé Boutemy cfbad56f65 point to our documentation on plugins dependencies upgrade 2017-01-24 23:50:10 +01:00
Hervé Boutemy 84085c0a9c updated urls (https, plexus) and license header formatting 2017-01-24 23:50:10 +01:00
Nemo Chen a2358ba7bb [MNG-6081] Log refactoring - Method Invocation Replaced By Variable 2017-01-22 21:37:57 +01:00
Christian Schulte ca1179ce6a [MNG-5629] ClosedChannelException from DefaultUpdateCheckManager.read
o Updated to stop producing 'ClosedChannelException's when reading tracking files.
o Updated to use 'Long.MAX_VALUE' as the size of any locked regions to prevent writing beyond locked regions.
o Updated to support shrinking of tracking files.
2017-01-09 16:07:28 +01:00
Martin Schäf d1dc63844f [MNG-5721] Possible NullPointerException in org.apache.maven.repository.MetadataResolutionResult
Signed-off-by: Michael Osipov <michaelo@apache.org>
2015-10-10 21:25:57 +02:00
Michael Osipov 4ba3b752d6 [MNG-5877] maven-aether-provider/maven-compat does not always generate snapshot versions using Gregorian calendar year
Postfix all repo snapshot handling not just Aether.
2015-10-10 16:43:25 +02:00
Michael Osipov b711de57dc [MNG-5906] Use canonical name for UTC timezone 2015-10-10 14:39:31 +02:00
Karl Heinz Marbaise d4e299acec Cleanup checkstyle reported errors. 2015-09-26 20:19:16 +02:00
Karl Heinz Marbaise 15223116a6 Fixed URL's to issue tracking after transition to
Apache Software Foundation.
2015-07-19 09:53:50 +02:00
Kristian Rosenvold cfd1fbe613 More java7. Bye bye 2006 2015-06-20 15:21:10 +02:00
sugartxy 7f206ef1cc try-with-resources
Reformatted to code style by me. This fixes #53
2015-06-20 14:32:46 +02:00
Kristian Rosenvold 7badeb5b5b Upgraded to java7 language features 2015-06-20 10:56:07 +02:00
Robert Scholte 5c6024219f Add more usage references of plugins 2015-05-17 19:30:58 +02:00
Jason van Zyl a2563b08c6 Don't add header if already present 2015-04-16 08:39:35 -04:00
Jason van Zyl da98af988d MNG-5797: Check to see if the user agent header is set before trying to set it again 2015-04-02 09:39:02 -04:00
Michael Osipov 0343c52601 Trimmed trailing whitespace 2014-11-23 13:04:30 +01:00
Robert Scholte e31c84cb4e [MNG-5696] Remove dependency on Easymock
This closes #25
2014-09-29 20:50:22 +02:00
Igor Fedorenko a5b92f2d03 cleanup: release artifact resolver resources more eagerly
Set resolver executor thread context classloader to null by
default. This allows collection of class realms that triggered
thread creation (one of plugin realms, typically).

Use Disposable#dispose to shutdown resolver executor server,
remove now redundant #finilaze() implementation.

Signed-off-by: Igor Fedorenko <ifedorenko@apache.org>
2014-09-02 08:14:49 -04:00
Igor Fedorenko 0ba8fa1258 enabled JSR330-only components in all unit tests
Signed-off-by: Igor Fedorenko <ifedorenko@apache.org>
2014-08-27 10:15:25 -04:00
Hervé Boutemy 6683e8681f code formatting 2014-06-14 00:08:07 +02:00
Jason van Zyl 0df4c654e3 Add license header. 2014-06-11 23:06:26 -04:00
Jason van Zyl fddade227d MNG-5638: Whitespaces matter in <mirrorOf> configuration can cause the incorrect repo to be selected 2014-06-11 22:26:18 -04:00
Hervé Boutemy 4a39c02156 fixed errors reported by Checkstyle 2014-02-08 16:38:31 +01:00
Stephen Connolly 3929f55c31 Remove redundant casts 2014-01-06 11:23:19 +00:00
Stephen Connolly 5f29be799f Remove dead code (initializers) 2014-01-06 11:21:26 +00:00
Stephen Connolly cefae8d47e Close stream 2014-01-06 11:19:07 +00:00
Stephen Connolly 33c53dcae8 Safer deletes 2014-01-06 11:14:45 +00:00
Stephen Connolly 7267996db8 Simplify logic 2014-01-06 10:49:03 +00:00
Stephen Connolly a6614ebd68 Simplify logic 2014-01-06 10:48:26 +00:00
Stephen Connolly 4ff2d7ef2a document why this is not a NPE 2014-01-06 10:46:44 +00:00
Stephen Connolly 9bec8d7386 Use chained .append calls rather than concatenate strings in arguments to .append 2014-01-06 10:42:20 +00:00
Stephen Connolly 9725c715a5 Should always call super.finalize()... though I do wonder why we are calling a finalizer at all... bad design smell 2014-01-06 10:33:58 +00:00
Stephen Connolly 9a55914061 Remove unnecessary unboxing 2014-01-06 10:32:16 +00:00
Stephen Connolly 71f73b29fa Use for each 2014-01-06 10:30:42 +00:00
rfscholte c9950d777c [MNG-5509] org.apache.maven.repository.legacy.DefaultWagonManager should
set User-Agent
2013-08-31 22:35:02 +02:00
rfscholte bf5366dc46 Add references to m-dependency-p 2013-08-25 20:34:28 +02:00
Hervé Boutemy 6b2db085c0 code formatting 2013-08-21 21:38:01 +02:00
Arnaud Héritier 21907a74e7 Revert "Code cleanup - It's better (for perfs) to use a chain of append() calls than a unique append with several Strings concatenations"
This reverts commit c8e94a5b08.

Decreases too much the code readibility
2013-06-14 10:29:43 +02:00
Arnaud Héritier 456268af61 Code cleanup -  Remove Redundant Cast(s) 2013-06-11 22:28:48 +02:00
Arnaud Héritier da48cfff83 Code cleanup - Redundant array creation for calling varargs method 2013-06-11 22:27:26 +02:00
Arnaud Héritier d92746dc25 Code cleanup - Maven requires Java 5+ : Replace for and while loops by for each 2013-06-11 22:21:54 +02:00
Arnaud Héritier 1f84f8f296 Code cleanup - Maven requires Java 5+ : Replace String.indexOf() by String.contains() 2013-06-11 22:19:20 +02:00
Arnaud Héritier 9e5183f0ad Code cleanup - Various code simplifications (tests, loops, …) 2013-06-11 22:09:51 +02:00
Arnaud Héritier c8e94a5b08 Code cleanup - It's better (for perfs) to use a chain of append() calls than a unique append with several Strings concatenations 2013-06-11 21:58:50 +02:00
Arnaud Héritier c747fbe4c9 Code cleanup - Remove useless .toString() 2013-06-11 21:52:36 +02:00
Arnaud Héritier a2897f86b3 Code cleanup - Maven requires Java 5+ : Remove unnecessary unboxing 2013-06-11 21:47:18 +02:00
Arnaud Héritier 96db1abbe9 Code cleanup - Maven requires Java 5+ : Remove unnecessary boxing 2013-06-11 21:43:53 +02:00
Stephen Connolly c6c6bdc49f Add ASL license header 2013-05-28 10:19:32 +01:00
Jason van Zyl ebf2e4ddea Merge branch 'eclipse-aether' of github.com:tesla/tesla-build into eclipse-aether
Conflicts:
	.gitignore
	pom.xml
2013-03-14 13:03:31 -07:00
olivier lamy 57954042c5 [MNG-5445] Missing PathTranslator @Requirement in org.apache.maven.project.interpolation.StringSearchModelInterpolator
Submitted by Stuart McCulloch.
2013-03-05 22:11:26 +01:00
Kristian Rosenvold 80e01fea5b Reverted 1a1fe6d508 to make things workproperly on java5/windows 2013-02-27 07:27:43 +01:00
Jason van Zyl de40fe19a8 o update for changes in Aether APIs 2013-02-16 22:48:55 -05:00
Jason van Zyl 137cbd8a97 Merge branch 'trunk' into eclipse-aether
Conflicts:
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java
	maven-aether-provider/src/test/java/org/apache/maven/repository/internal/AbstractRepositoryTestCase.java
	maven-aether-provider/src/test/java/org/apache/maven/repository/internal/DefaultVersionResolverTest.java
	maven-core/src/main/java/org/apache/maven/DefaultMaven.java
	maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultLegacySupport.java
	maven-core/src/main/java/org/apache/maven/plugin/prefix/PluginPrefixResult.java
	maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java
	pom.xml
	src/site/site.xml
2013-02-14 22:08:26 -05:00
Jason van Zyl 27ad9858d2 Merge branch 'aether' of github.com:bentmann/maven-3 into eclipse-aether
Conflicts:
	.gitignore
	apache-maven/pom.xml
	maven-aether-provider/pom.xml
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/LocalSnapshotMetadataGenerator.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemSession.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/MavenServiceLocator.java
	maven-aether-provider/src/main/java/org/apache/maven/repository/internal/RemoteSnapshotMetadataGenerator.java
	maven-artifact/pom.xml
	maven-compat/pom.xml
	maven-compat/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
	maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
	maven-core/pom.xml
	maven-core/src/main/java/org/apache/maven/DefaultMaven.java
	maven-core/src/main/java/org/apache/maven/ReactorReader.java
	maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginRealmCache.java
	maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
	maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml
	maven-core/src/test/java/org/apache/maven/AbstractCoreMavenComponentTestCase.java
	maven-core/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
	maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
	maven-core/src/test/java/org/apache/maven/project/PomConstructionTest.java
	maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java
	maven-core/src/test/java/org/apache/maven/settings/PomConstructionWithSettingsTest.java
	maven-embedder/pom.xml
	maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
	maven-model-builder/pom.xml
	maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
	maven-model/pom.xml
	maven-plugin-api/pom.xml
	maven-plugin-api/src/main/mdo/plugin.mdo
	maven-plugin-api/src/site/apt/index.apt
	maven-repository-metadata/pom.xml
	maven-settings-builder/pom.xml
	maven-settings/pom.xml
	pom.xml
	src/site/site.xml
2013-02-14 20:21:50 -05:00
Benjamin Bentmann b5e0532310 Updated for latest ConflictResolver 2013-02-03 20:44:44 +01:00
Benjamin Bentmann 3916201b98 Used improved conflict resolver 2012-12-29 22:25:25 +01:00
Hervé Boutemy 3849bbd46a fixed errors reported by Checkstyle 2012-12-16 21:49:18 +01:00
Hervé Boutemy b63904c9db fixed errors reported by Checkstyle (once again...) 2012-12-03 02:21:58 +01:00
Hervé Boutemy 543870467f fixed errors reported by Checkstyle 2012-12-02 20:22:52 +01:00
Kristian Rosenvold 1a1fe6d508 o Made lower bound of executor threads 0 for artifact resolver
Ideally I think we should just get rid of the whole executor and use new Thread() instead,
which would mean we'd need some way of constraining thread counts.

Freeing the threads mean they also release the classloader
2012-12-01 10:56:53 +01:00
Kristian Rosenvold e8df4ca993 o Restored old context classloader so the threads dont go running around with classloaders that should unload 2012-11-30 07:33:28 +01:00
Herve Boutemy 994a27d004 removed code duplication: maven-core can use base MavenRepositorySystemSession provided by maven-aether-provider as a basis before adding environment configuration
git-svn-id: https://svn.apache.org/repos/asf/maven/maven-3/trunk@1407851 13f79535-47bb-0310-9956-ffa450edef68
2012-11-10 17:14:21 +00:00
Benjamin Bentmann 3df76ee227 Fixed auth retrieval 2012-09-30 21:09:51 +02:00
Benjamin Bentmann 42536ce88f Accounted for refactoring of aether-api 2012-09-30 17:37:09 +02:00
Benjamin Bentmann 2838745156 o Accounted for refactoring of aether-api 2012-09-17 00:05:23 +02:00
Milos Kleint 4fcfcb8f73 MNG-5306 : introduce ModelProblemCollectorRequest and a new ModelProblem property - version which denotes on which validation level the error/warning applies. Additionally move the logic on failing the ModelBuilding from ModelProblemCollector to ModelBuilder's protected method to allow overriding. Default maven behaviour should stay the same.
git-svn-id: https://svn.apache.org/repos/asf/maven/maven-3/trunk@1357589 13f79535-47bb-0310-9956-ffa450edef68
2012-07-05 13:11:15 +00:00
Benjamin Bentmann 02927ead50 o Accounted for refactoring of aether-api 2012-03-11 23:18:43 +01:00
Herve Boutemy a2b01be028 generics
git-svn-id: https://svn.apache.org/repos/asf/maven/maven-3/trunk@1243037 13f79535-47bb-0310-9956-ffa450edef68
2012-02-11 11:55:03 +00:00
Herve Boutemy a7ef4d4da0 improved javadoc: added pointer to equivalent Maven 3 API
git-svn-id: https://svn.apache.org/repos/asf/maven/maven-3/trunk@1243031 13f79535-47bb-0310-9956-ffa450edef68
2012-02-11 11:41:08 +00:00
Benjamin Bentmann 298403bed3 o Accounted for refactoring of aether-api 2012-01-15 18:36:21 +01:00
Benjamin Bentmann 2592e158ad o Accounted for API refactoring 2012-01-01 20:05:13 +01:00
Benjamin Bentmann 18b81002cd o Accounted for API refactoring 2011-12-30 22:16:02 +01:00
Benjamin Bentmann 82b345e009 o Migrated to Eclipse Aether 2011-12-30 21:43:28 +01:00