1698 Commits

Author SHA1 Message Date
Jason van Zyl
44c864a463 o workspace tests
Submitted by: Igor Fedorenko

git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777301 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 22:41:39 +00:00
Jason van Zyl
b54a1b781b o large patch to rework the chained local repository implementations necessary for efficient reactor and IDE workspace resolution
Submitted by: Igor Fedorenko

I've asked Igor to fill out and send in a CLA and I will put him on the Sonatype CCLA



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777298 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 22:35:29 +00:00
Benjamin Bentmann
503cc60cc5 o Fixed explicit profile deactivation
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777246 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:34:33 +00:00
Benjamin Bentmann
40f654d529 o Added generics
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777242 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:26:51 +00:00
Benjamin Bentmann
b2a3374ac6 o Added note about need to tighten model validator with regard to plugin version
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777240 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:14:26 +00:00
Jason van Zyl
48eb55f658 o project with plugin level configuration only
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777239 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:14:22 +00:00
Jason van Zyl
e4d52d6c28 o missing classes
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777234 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 19:54:27 +00:00
Jason van Zyl
a06ce9250d o fix for testitMNG4091_InvalidDescriptor(org.apache.maven.it.MavenITmng4091BadPluginDescriptorTest)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777230 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 19:42:11 +00:00
Benjamin Bentmann
6fe1debb60 o Fixed NPE in case of direct goal invocations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777228 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 19:24:32 +00:00
Benjamin Bentmann
efb59873a5 [MNG-4129] Execution's inherited is not working as expected.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777205 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 18:19:22 +00:00
Jason van Zyl
aaf01a7495 o another point about merging in the default plugin configuration
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777175 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:58:51 +00:00
Jason van Zyl
b6cc908615 o notes on dealing with CLI invocations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777173 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:56:35 +00:00
Jason van Zyl
fde34e8384 o get rid of extraneous goal matching
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777171 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:46:19 +00:00
Benjamin Bentmann
b6d356acab o Removed dead code
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777167 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:25:27 +00:00
Jason van Zyl
9af145d0a7 o take the plugin update registry out of the lifecycle mapping for plugins
o change the way mojo executions are processed and match up the executions when extracting configuration
o give mojo executions originating from the CLI the "default-<goal>" execution id



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777166 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:18:53 +00:00
Benjamin Bentmann
cad43e6b56 o Fixed precedence of plugin groups (request > settings > defaults)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777165 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:17:15 +00:00
Benjamin Bentmann
5eb52b5dee o Prevented duplicates
o Made execution request more robust with regard to NPEs


git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777163 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:04:57 +00:00
Benjamin Bentmann
add87f5f56 o Ensured we eventually work with absolute paths
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777134 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 14:37:03 +00:00
Jason van Zyl
9aae6eaa67 o using mojo executions as the placeholders in the lifecycle instead of string representations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777120 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 14:00:34 +00:00
Benjamin Bentmann
a7cbcb7b39 o Fixed ClassCastException
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777112 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 13:25:41 +00:00
Jason van Zyl
9024112b87 o adding test with multiple executions
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777100 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 12:56:07 +00:00
Jason van Zyl
9efd21d0c9 o restoring several backward compat fixes all the way back to 2.0 ...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776895 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 23:28:39 +00:00
Jason van Zyl
397dc841a7 o have the build plan take into consideration multiple tasks, so the calculation of the build plan can take in any number lifecycle phases, or individual goals and you will get the fully fleshed out configurations
o one thing that's apparent is that it is not possible to only collect the metadata about the plugins that will execute. if the plugin.xml files were actually available in the repository outside of the plugin's JAR then the calculation could be made without having to crack open the JAR. i can't have a real plan per se when i have to grab the plugin JAR anywhere to open it and get the metadata. ideally someone should be able to see the build plan and optimize it and if plugins were removed they those will never have a requirement of being downloaded. Deploying the plugin metadata along side the plugin as an attached artifact or indexing the information and made available for querying would be very useful.

o now that the build plan is calculated and the project dependencies downloading has been decoupled from the plugin manager i can make a proper analysis of all he dependencies for all the project and start making optimized requests for downloading



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776690 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 13:23:56 +00:00
Jason van Zyl
8637701384 o don't need to store plugins
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776561 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 05:27:18 +00:00
Jason van Zyl
d5459955f5 o put the plugin groups in the front-end request populator, the magic plugin groups are no longer buried in the core. could still be
moved from the code in the populator to a configuration file in the maven installation.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776556 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 05:16:09 +00:00
Jason van Zyl
9dfca575c7 o clean lifecycle is handled by defaults populator
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776540 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 04:25:59 +00:00
Jason van Zyl
ed8dbbdc8d o test component implementations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776531 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 03:29:03 +00:00
Jason van Zyl
9be598d351 o injecting the metadata sources results in having to do some trickery to break the circular dependency between the components, this
is visible now in the metadata source which shows we need to do some work there as circular deps are pretty sure sign of poor design
o the ProjectClasspathTest has little stub components so I'm not even sure if it's a decent test but it requires a bunch of custom
  implementations as i tried to get rid of the hand written descriptor and have only annotated tests implementations but somewhere
  an incorrect implementations is being injected.

I'll work on breaking the circular dependency and we need a nicer way to inject test implementations, the way the Module works in
Guice is the way to go. We'll bridge the gap until we can switch over to Guice.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776529 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 03:26:51 +00:00
Jason van Zyl
3a65c9fd76 o moving version resolution when not specified to the lifecycle executor, what goes into the plugin manager will be completely
and entirely resolved.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776494 13f79535-47bb-0310-9956-ffa450edef68
2009-05-19 23:07:08 +00:00
Jason van Zyl
e0298b7c97 o first pass at setting up error handling for each possible error condition
- this resulted in cleaning up some exceptions in plexus so that they might message could be surfaced in Maven
o move the plugin prefix searching to the lifecycle executor and get it out of the plugin manager
o add capability to the RepositorySystem to get plain resources from a repository. I'm going simple with the repository group
  metadata and I will just get the file directly as the only implementation is the plugin group metadata. the system is 
  not easily or generally extensible so i'll just take what I need



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776412 13f79535-47bb-0310-9956-ffa450edef68
2009-05-19 18:53:07 +00:00
Benjamin Bentmann
59224daa9e o Fixed interpolation of system properties
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776073 13f79535-47bb-0310-9956-ffa450edef68
2009-05-18 20:10:06 +00:00
Benjamin Bentmann
b4df2f1bb3 o Fixed injection of repos from settings.xml
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775626 13f79535-47bb-0310-9956-ffa450edef68
2009-05-17 11:13:32 +00:00
Benjamin Bentmann
7afb4637c8 o Fixed resolution of project dependencies (regardless whether we want to resolve the root, the metadata source needs to resolve the root's POM so we better point it at the one we're interested in)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775350 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 21:26:55 +00:00
Benjamin Bentmann
7612c0e020 o Added toString() to ease debugging
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775311 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 20:20:32 +00:00
Benjamin Bentmann
d616f1d873 o Made project cache sensitive to file modifications
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775307 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 20:13:08 +00:00
Benjamin Bentmann
6f57526dfd o Saved clients from NPEs
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775303 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 19:51:27 +00:00
Benjamin Bentmann
b81a59ba3a o Added clear() method to project cache
o Added license headers

git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775290 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 19:17:32 +00:00
Jason van Zyl
392d49db54 o pass the active profile ids and profiles pass into the request
o clean up constructors for project builder configuration


git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775284 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 18:45:48 +00:00
Jason van Zyl
01a13a3ffd o remove the profile manager and profile activation context from public view
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775281 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 18:32:59 +00:00
Jason van Zyl
6fbd31302f o deal with classifiers, igor needs this and I will unify the method later.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775278 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 18:27:20 +00:00
Jason van Zyl
bd4515d9f4 git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775207 13f79535-47bb-0310-9956-ffa450edef68 2009-05-15 16:02:03 +00:00
Jason van Zyl
8f7f0ce1dd o note about signature removal in the project builder
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775181 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 15:10:24 +00:00
Jason van Zyl
107b03a1f7 o getting rid of some dead code in the project builder in preparation for trying to group more of the profile handling code as a test is failing in the embedder related to profiles while everything in the pom construction test is working correctly.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775141 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 14:08:43 +00:00
Jason van Zyl
49a8b628b3 o remove dead method
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@775101 13f79535-47bb-0310-9956-ffa450edef68
2009-05-15 12:23:18 +00:00
Benjamin Bentmann
c456055883 o Restored basedir alignment
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@774925 13f79535-47bb-0310-9956-ffa450edef68
2009-05-14 21:02:10 +00:00
Benjamin Bentmann
f60ebacbd4 o Fixed parsing of lifecycle mappings
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@774886 13f79535-47bb-0310-9956-ffa450edef68
2009-05-14 19:14:25 +00:00
Benjamin Bentmann
3e287c47bb o Made plugin manager bail out if requested mojo can't be loaded to save clients from NPEs
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@774885 13f79535-47bb-0310-9956-ffa450edef68
2009-05-14 19:13:45 +00:00
Jason van Zyl
7ccc3d878e o fixinga bunch of embedder tests, 8 left to fix
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@774768 13f79535-47bb-0310-9956-ffa450edef68
2009-05-14 13:52:03 +00:00
Jason van Zyl
060c6d9784 o all core tests pass again, on to ITs
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@774620 13f79535-47bb-0310-9956-ffa450edef68
2009-05-14 02:47:02 +00:00
Benjamin Bentmann
5d20be91e3 o Fixed resolution of project dependencies
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@774522 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 20:44:43 +00:00