If `%MAVEN_PROJECTBASEDIR%` contained whitespaces, Windows couldn't find the maven-wrapper.jar because the whitespaces were considered as argument separators.
Maven 3.4 snapshots are now being published with invalid
zip files, where the entries are listed before their parent.
So the logic in the Installer is faulty: you have to mkdirs()
on all entries to be sure that the directory exists before you
write the file.
using # in .cmd files as comment issues the following error: `Der Befehl "#" ist entweder falsch geschrieben oder konnte nicht gefunden werden.` aka command not found
The wrapper script has detected a .mvn directory, so it would be
better to assume that this is the location of the wrapper jar,
rather than the current directory (.). This change could be
enhanced by adding a separate detection loop for the jar itself
as opposed to the .mvn directory, but this is the smallest
possible change that fixes the bug.
Fixes gh-5
There was a problem with the logic in the while loop that detects
the base dir - it should first look in the current directory,
otherwise you can't build in a directory with local settings because
it will always climb up and find .mvn in a parent directory (e.g. user's
home).
The properties file was pointing to 3.0.5 of maven, and the
latest version is now 3.2.3. This commit updates to make sure
maven 3.2.3 is downloaded if if doesn't already exist.
Lightly touched to better mesh with current maven builds. (some of which my not have been necessary in hind sight)
Test it out with this build, run: "./mvnw clean install" at the root of this repo
This will download, install, and run maven 3.0.5 (as configured in maven/wrapper/maven-wrapper.properties)
NOTE: windows batch file is NOT tested
TODO:
* Possibly extract these bits out into something both gradle and maven (and others) can use
* Port gradle IT's to this build
* See if anyone is interested in this project