Commit Graph

1085 Commits

Author SHA1 Message Date
John Dennis Casey 84f0cdabdb [MNG-2878] Adding an import from the maven core classrealm into the plugin classrealm, to allow retrieval of default-report.xml using getClass().getResourceAsStream(..) which is used in maven-reporting-impl 2.0...which in turn is used from checkstyle (at least).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@574392 13f79535-47bb-0310-9956-ffa450edef68
2007-09-10 22:34:28 +00:00
John Dennis Casey b1159725a5 fixing formats at top of file (may be other formatting changes...)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@574387 13f79535-47bb-0310-9956-ffa450edef68
2007-09-10 22:20:31 +00:00
Jason van Zyl a05e9f9884 o we don't need to run processProjectLogic on the super pom but we do need to make sure the plugin repositories are populated
for plugins like archetype which have no POM to start with but need repositories.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573736 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 22:29:34 +00:00
Jason van Zyl d72b8bc88a o put the profile manager back into place as the project build is exposed in a ton of plugin. arrrg.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573718 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 21:29:08 +00:00
Jason van Zyl e9b6657f4c o scrub of the settings building, was able to reduce to the need of the build context and use the execution request
directly. eventually i will get it to be the session, along with the profile tools, then all the tools can also 
  share a common interpolator, which can then be shared by other components instead of having 5 interpolators lying
  around causing a great deal of inconsistency.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573494 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 07:54:11 +00:00
Jason van Zyl 28ac7d65cb o remove dead method, the embedder now takes care of all defaulting so we don't need this method anymore.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573478 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 06:42:31 +00:00
Jason van Zyl 357015041a o let the parsing exception surface
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573476 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 06:36:53 +00:00
Jason van Zyl a0439b3e05 o remove dead code, this is being done elsewhere and has been for a while
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573472 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 06:17:55 +00:00
Jason van Zyl 9c8903441f o profiles are now decoupled from settings. so that i don't do this is one huge commit i need to move settings stuff into the core
while i transform the settings components to take a MavenSession. Any component executing within Maven should be able to use
  a session. the session will contain everything required and any new component added to the system should only take the 
  session as a parameter. same pattern for all components. that's the goal. it will take a few hops.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573462 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 05:25:49 +00:00
Jason van Zyl beb0ab7d9a o removing deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573437 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 03:49:48 +00:00
Jason van Zyl 99bd5ac68f o trying to get a grasp of the entire profile mechanism, especially in relation to how they deal with repositories.
here i am just collecting all the profile code into one place as it's scattered over several packages and is
  hard to determine what the profile system as a whole is doing. the first task i would like to do is decouple
  the profile system from the Settings. this can be done at the front-end i.e the profile information from Settings
  can be fed into the profile manager up front.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573325 13f79535-47bb-0310-9956-ffa450edef68
2007-09-06 17:09:36 +00:00
Jason van Zyl 02d205134b o this is in the embedder module now
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573089 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 22:50:17 +00:00
Jason van Zyl c1f56fc847 o cleaning up more dead code in the hunt for "why the release plugin doesn't work again"
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572877 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 05:30:26 +00:00
Jason van Zyl 4925ac9702 o removing deprecated code in the plugin mechanism
o removing dead code
o examining how plugin version resolution is done, and we have a mix of a desire to use snapshots locally and pull releases
  remotely. if the repositories are mixed a snapshot will be pull automagically. this doesn't happen in practice but snapshots
  for plugin versions should be limited to a local search only.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572872 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 04:38:49 +00:00
Jason van Zyl 8077fb59ac o Why would a plugin be executing in its own POM. I think this is a far out case and you shouldn't be testing your plugin with its own POM. The comment is "I guess...". I don't think this is right.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572868 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 03:44:55 +00:00
Jason van Zyl aaaed9cf00 o i'm reworking the error reporting mechanism. i am going to concretely deal with each error we can come up with instead of
the generalization we have.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572463 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 00:34:08 +00:00
Jason van Zyl ae1501b9f6 o collecting all logging/eventing into the core. i posted a list of possible errors that can occur in the core, the stuff we had was only
partially being use and we problems being emitted with messages like:

  NOTE: One or more purely derived expression elements were detected in this expression. 
  If you continue to get this error after any other expression elements are specified correctly
  please report this issue to the Maven development team.

  I think we have to make a very concerted effort to make useful messages because I'm tired of standing behind Maven
  users and being embarrassed when they look at me and ask "what does that mean?". "i actually have no idea."


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572456 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 00:05:04 +00:00
Jason van Zyl 2a241710f0 MNG-3182
MNG-3183

First cleanup of the logging code (it is still a mess), but all the console logging has been removed from the Maven component and pushed back
into the CLI code. As a result we now have a way to log to a file easily.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572408 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 19:33:10 +00:00
Jason van Zyl 441b918f80 o try and start localizing the handling of -f, release poms, and normal poms to the embedder. just too much funk
going on in the core.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572388 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 16:52:37 +00:00
Jason van Zyl cc1ca10d74 o separating out the MavenEmbedderProjectWithExtensionReadingTest which shows that the artifacts handlers must be loaded up-front
in the readProjectWithDependencies method because it is not being done in the core unless projects are executed. So Milos' assertion
  is correct. I'm now looking at a layered approach for project resolution and then execution so that the readProjectWithDependencies
  (which is essential for IDE integration) will yield something that can be pushed into the lifecycle executor. Right now there
  is much duplication which makes the IDE integration crappy.

  Another result of this is trying to create a simple IDE import model that gives back client code the fully resolved, topo sorted
  set of projects which point to binary dependencies outside the reactor, and to source folders inside the reactor. The result will
  be a useful model for all IDE integration, right now everyone is doing their own thing. This model will need hooks for customization
  to take into account turning "workspace resolution" on/off and allow easy overriding of this process.

o Fixed IT0035



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572366 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 15:42:29 +00:00
Jason van Zyl 08ed903945 MNG-1922: Making sure that CLI properties are processed first
o fixing IT0039


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572229 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 03:56:31 +00:00
Jason van Zyl 2425f945fb o adding a validation method to the lifecycle executor so that I can tell users what is wrong before actually trying
to execute the lifecycle. Trying to do this validation shows in detail how tangled some of our code is as I need
  to create the dispatcher in order to create the session which is required to make the reactorManager which 
  is required to get the project required to validate the goal name ... yah.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572214 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 02:35:05 +00:00
Jason van Zyl 5380116b79 MNG-2398: the lifecycle executor exception wasn't being propagated properly.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572210 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 01:39:28 +00:00
Jason van Zyl ed5868ebc7 MNG-3176 Adding a method to create the reactor manager as I want to use it for execution as well as the buildWithDependencies method.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572029 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:51:03 +00:00
Jason van Zyl 43dcac45b6 o get the information about whether a project is present from the request as per MNG-3177
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572023 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:43:20 +00:00
Jason van Zyl c184a161a3 o we assume there is a project and in DefaultMaven we will turn this off if we determine there is not one.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572021 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:39:26 +00:00
Jason van Zyl f6eb49fd0c MNG-3177: capture the presence of a project in the execution request
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572020 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:37:49 +00:00
Jason van Zyl acd024eeca o just expanding "rm" to "reactorManager" so there's some idea as to what it is
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572010 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 15:54:43 +00:00
Jason van Zyl 01fb7027ec o just expanding "rm" to "reactorManager" so there's some idea as to what it is
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572007 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 15:50:33 +00:00
Jason van Zyl 42807d7765 o remove debug output
o we don't need any but the super pom now for getting the initial repositories

git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571919 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 02:13:00 +00:00
Jason van Zyl c0ce98d89a o don't need the private method anymore for getting the super pom
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571912 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 01:20:15 +00:00
Jason van Zyl f196fefba4 o as the profile has been removed from the super pom, we do not need to inject or process any profiles
related to it. this great simplifies a lot of code
o caching the super project in the default project builder as it's never going to change now as no profiles
  are inject so it will only have to be constructed once an instance.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571910 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:56:30 +00:00
Jason van Zyl 9dbe865b6e o the profile manager creation now happens up front in the embedder
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571903 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 00:01:30 +00:00
Jason van Zyl 884f70085e o integrate changes made in maven-artifact for non fail-fast and request/result usage in the embedder for
use in IDE integration to provide as much feedback as possible.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@571862 13f79535-47bb-0310-9956-ffa450edef68
2007-09-01 19:23:17 +00:00
John Dennis Casey 4ea3730eb8 Removing classworlds version so it will be given by the dependencyManagement section at the maven-level.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@570838 13f79535-47bb-0310-9956-ffa450edef68
2007-08-29 15:32:09 +00:00
Brett Leslie Porter 959ce3f30f [MNG-3141] only canonicalize paths on Windows (to prevent path length issues, but not obliterate symlinks on unix)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@567954 13f79535-47bb-0310-9956-ffa450edef68
2007-08-21 04:54:04 +00:00
Brett Leslie Porter 7a8dd28f80 reformat before patch
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@567948 13f79535-47bb-0310-9956-ffa450edef68
2007-08-21 04:37:49 +00:00
Jason van Zyl 1bb845492e o now that i can get online, i can adjust for the movement of m-a
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@566927 13f79535-47bb-0310-9956-ffa450edef68
2007-08-17 06:01:00 +00:00
John Dennis Casey 8795579469 [MNG-3062] Provide access to MojoExecution instance from plugin parameter expression ${mojoExecution}.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@565811 13f79535-47bb-0310-9956-ffa450edef68
2007-08-14 15:33:33 +00:00
John Dennis Casey c5a74a8242 Fixing a few problems with the model-lineage builder, where it was stubbing models inappropriately and other minor logical problems.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@564761 13f79535-47bb-0310-9956-ffa450edef68
2007-08-10 20:49:14 +00:00
Dennis Lundberg 0ceae1b648 o Minor adjustment to error message.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@562096 13f79535-47bb-0310-9956-ffa450edef68
2007-08-02 12:34:04 +00:00
Jason van Zyl 69a491ba0b o don't ever let the components-api jar through as we have one jar now and this JAR causes CCE all over the place, this will p protect against it ever getting pulled in.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@561193 13f79535-47bb-0310-9956-ffa450edef68
2007-07-31 00:21:04 +00:00
Jason van Zyl 6583991465 o updating to the new version of plexus which is the unified JAR once again. I can now move on
to doxia and attempt to use the same container for the trunk and branch.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@560496 13f79535-47bb-0310-9956-ffa450edef68
2007-07-28 04:57:37 +00:00
John Dennis Casey a87abe2d26 more formats.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559218 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:20:40 +00:00
John Dennis Casey 9c8011386d formatting for the message...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559216 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:18:05 +00:00
John Dennis Casey 8fab1c218a Fixing NPE.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559215 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:17:20 +00:00
John Dennis Casey aaba2df26c Fixing error message coming from a plugin phase-binding that cannot be resolved, or is unspecified.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@559209 13f79535-47bb-0310-9956-ffa450edef68
2007-07-24 21:02:25 +00:00
John Dennis Casey f3f3c70321 Fixing infinite recursion when a mojo bound to the lifecycle forks a new phase that contains implies another phase that contains the bound mojo. This was triggered by the assembly:assembly mojo, and should look familiar.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@551696 13f79535-47bb-0310-9956-ffa450edef68
2007-06-28 20:53:55 +00:00
John Dennis Casey f479a38620 Adding a small comment about managed artifact versions in here.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@549970 13f79535-47bb-0310-9956-ffa450edef68
2007-06-22 22:09:22 +00:00
John Dennis Casey fda3badc24 Accumulate remote repositories when scanning for extensions, down the model lineage, starting with the original remote repositories passed in from outside.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@549968 13f79535-47bb-0310-9956-ffa450edef68
2007-06-22 22:02:10 +00:00