Commit Graph

681 Commits

Author SHA1 Message Date
Hervé Boutemy 3a80ae08aa [MNG-6799] deprecate StringSearchModelInterpolator and remove @Named 2019-11-07 13:30:45 +01:00
rfscholte 07ab962c85 [MNG-6765] tycho pom-less builds fails with 3.6.2 2019-10-19 18:23:57 +02:00
Enrico Olivelli d9a0eee7fe [maven-release-plugin] prepare for next development iteration 2019-08-27 16:59:23 +02:00
Enrico Olivelli 40f5233313 [maven-release-plugin] prepare release maven-3.6.2 2019-08-27 16:59:01 +02:00
tibordigana 829a2c9aae small refactoring in StringSearchModelInterpolator (removed unnecessary 'public' modifier in private class, inlined variable declaration in loop - not reachable after the loop) 2019-08-11 11:46:28 +02:00
tibordigana b893c3eca4 small refactoring in StringSearchModelInterpolator (removed unused variables, removed too open modifier 'protected') 2019-08-11 11:32:11 +02:00
tibordigana 203cfc67cc [MNG-6729] StringSearchModelInterpolator introspects objects from Java API 2019-08-09 16:00:03 +02:00
Guillaume Nodet 690841e9be [MNG-6697] New fast model interpolator not using reflection (#261)
* [MNG-6697] New fast model interpolator not using reflection

* [MNG-6697] Fix management key in case a field has been modified

* [MNG-6697] Remove the unused FIELDS_CACHE and make the InnerInterpolator private

* [MNG-6697] Clean up the code to remove a few warnings
2019-07-24 12:30:12 +10:00
Guillaume Nodet 53f04f03e3 [MNG-6705] Speep up Artifact version check and Parent interpolation
This closes #260
2019-07-10 21:29:23 +02:00
Guillaume Nodet 9b8ae7d528 [MNG-6702] Improve DefaultModelValidator performance:
Avoid tons of string concatenations that are done but usually not used

This closes #268
2019-07-10 21:27:36 +02:00
Joseph Walton 4fa882c30f [MNG-6703] DefaultUrlNormalizer doesn't normalize all relative URIs
* Switch behaviour on relative URIs to match Path#normalize()
* Adopt RFC 3986 behaviour for traversal past the root
* Add a test that this isn't applied to relative URI references

This closes #264
2019-07-10 11:56:42 +02:00
AElMehdi 8da81ce73c [MNG-6701] Document maven.repo.local property
This closes #265
2019-07-06 18:15:49 +02:00
Joseph Walton 353d3eaa8f [MNG-6685] Convert Maven Model Builder to JSR 330
This closes #256
2019-06-23 00:20:54 +02:00
Stefan Oehme 8f1cac0b1c [MNG-6671] Upgrade Modello to 1.11 2019-06-10 15:18:30 +02:00
Michael Osipov 92b5191726 Revert "Modello changes"
They weren't properly squashed and worded.

This reverts commit 5035837094.
This reverts commit 8aaeb8adf5.
2019-06-10 13:55:38 +02:00
Stefan Oehme 8aaeb8adf5 [MNG-6581] - Update to latest Modello plugin version 2019-06-10 11:08:29 +02:00
Stephen Connolly 01405a2d60
[MNG-6667] Enhance the error reporting when trying to build a modelVersion that the current Maven doesn't understand 2019-06-03 21:33:44 +01:00
Hervé Boutemy 5350ed8a1f [MNG-6644] don't fail if no input location tracking available
this can happen when the POM is not parsed by Maven core from XML
2019-04-28 19:42:25 +02:00
Stefan Oehme baed5a294f [MNG-6629] - Make ID validation faster
Use a simple list of allowed characters instead of a regex.
2019-04-27 18:03:20 +02:00
Karl Heinz Marbaise 5222f03d05
[maven-release-plugin] prepare for next development iteration 2019-04-04 20:56:37 +02:00
Karl Heinz Marbaise d66c9c0b31
[maven-release-plugin] prepare release maven-3.6.1 2019-04-04 20:56:16 +02:00
Hervé Boutemy 49c8f17ed4 [MNG-6601] add input location tracking for m-site-p converted reports 2019-03-11 23:44:32 +01:00
Hervé Boutemy 4bec5502d5 [MNG-6600] add inputlocation tracking for default lifecycle executions 2019-03-11 23:44:31 +01:00
Hervé Boutemy 37676a2617 [MNG-6599] use version from parent if necessary, like groupId 2019-03-11 23:44:31 +01:00
Hervé Boutemy bd4a3a0d22 [MNG-6593] track input location for super-pom content 2019-02-17 15:28:39 +01:00
Michael Osipov c674bcfb42 [MNG-6495] ModelResolver cannot be null 2019-02-16 22:37:27 +01:00
Hervé Boutemy 8e5ecf0622 fixed link (that goes to implementation in maven-core) 2019-01-12 18:36:44 +01:00
Michael Warnecke 9c946263fa [MNG-6213] Validate scope in dependencyManagement
This closes #131
2018-12-28 23:45:45 +01:00
Fabiano C. de Oliveira 9f07b0362f [MNG-6261] - using File apis to compare 2018-11-23 23:37:56 -02:00
Sylwester Lachiewicz 78f605e377 [MNG-6515] Fix Javadoc build errors 2018-11-12 17:23:56 +01:00
Hervé Boutemy 07bd5507ae [MNG-6505] tweaked distributionManagement.site inheritance
child.site.url.inherit.append.path is inherited independantly from
id/name/url
2018-11-11 19:30:31 +01:00
Hervé Boutemy f97316ceec [MNG-6505] inherit child.x.y.inherit.append.path values 2018-11-11 19:30:31 +01:00
Hervé Boutemy db462ae0b3 [MNG-6059] renamed attributes to get more flexibility for scm urls 2018-11-11 19:30:31 +01:00
Karl Heinz Marbaise 6e376d424e
[maven-release-plugin] prepare for next development iteration 2018-10-24 20:38:30 +02:00
Karl Heinz Marbaise 97c98ec64a
[maven-release-plugin] prepare release maven-3.6.0 2018-10-24 20:38:06 +02:00
HoaPhan ba74b96633
[MNG-6492] - Minor improvement on Array construction, conversion performance 2018-10-24 18:07:13 +02:00
Sylwester Lachiewicz e4b53d3f2c [MNG-6490] Maven shall not fail reporting circular dependency when the dependency is a classified secondary artifact 2018-10-20 21:27:25 +02:00
Christian Schulte 44826ab446 [MNG-6164] Collections inconsistently immutable
Make non-empty collections returned immutable just like those returned by
java.util.Collections.
2018-10-09 22:12:50 +02:00
Sylwester Lachiewicz 91fa89ea28 [MNG-6479] Upgrade XMLUnit to 2.2.1 (#183) 2018-09-17 07:33:54 +10:00
Hervé Boutemy 2e8e09f25b [MNG-5951] add an option to avoid path addition to inherited URLs
This is done as child.inherit.append.path XML attribute on 3 locations:
- project, for project.url
- project.distributionManagement.site for its url
- project.scm, for the 3 scm urls in one unique config
2018-09-16 16:44:12 +02:00
Phillip Webb 01f098efd1
[MNG-6475] Remove unused Guava dependencies 2018-09-13 20:45:25 +02:00
Karl Heinz Marbaise 396f49d75e
[MGN-6383] - ProjectBuilder unnecessarily rebuilds modules with ci-friendly versions
o Thanks to Christoph Kunze for offering the fix.
2018-07-31 22:13:20 +02:00
rfscholte 72dca39807 Replace org.apache.commons.lang3.Validate#notNull with java.util.Objects#requireNonNull 2018-07-15 10:36:08 +02:00
Stephen Connolly bf0bd6350e Master is now on 3.6.0-SNAPSHOT 2018-06-17 22:38:49 +01:00
Stephen Connolly 1efd571b0a [maven-release-plugin] prepare for next development iteration 2018-06-17 19:29:56 +01:00
Stephen Connolly 1edded0938 [maven-release-plugin] prepare release maven-3.5.4 2018-06-17 19:29:25 +01:00
Christian Schulte 5b4e173f7d [MNG-5940] Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
This closes #168
2018-06-10 13:12:53 +02:00
Michael Osipov 8e0efaa107 [MNG-6386] ${project.baseUri} is not a valid URI (according to RFC 3986)
File#toURI()#toString() produces a non-compliant URI making tools like
Subversion or Git to choke on those URIs. Whereas Path#toUri()#toASCIIString()
does the right job.
2018-05-07 22:35:43 +02:00
Stephen Connolly 85b4e3d8e8 [maven-release-plugin] prepare for next development iteration 2018-02-24 19:29:56 +00:00
Stephen Connolly 3383c37e1f [maven-release-plugin] prepare release maven-3.5.3 2018-02-24 19:29:21 +00:00
Sylwester Lachiewicz b8c06e61ab Remove Google Guava usage (move to Java7) 2018-02-11 11:54:17 +01:00
Sylwester Lachiewicz d925081794 Reduce number of global checkstyle rule violations
Fix code for following checkstyle rules:
ConstantName, FileLength, InnerAssignment, JavadocType, MagicNumber, MethodLength, MethodName, NewlineAtEndOfFile, ParameterNumber, RedundantThrows, VisibilityModifier

Fixes #149
2018-02-11 11:41:16 +01:00
Hervé Boutemy 0dc70cc691 upgrade m-site-p to 3.7 + Fluido 1.7 + edit button 2018-02-10 11:42:33 +01:00
Hervé Boutemy cf7b0a3ec0 fixed new issues reported by Checkstyle 6.18 2018-02-10 11:42:33 +01:00
Hervé Boutemy 085ee9f275 [MNG-5992] Upgrade default version of maven-release-plugin to 2.5.3
avoids exposing Git password during release
this fixes #152
2018-02-08 08:02:04 +01:00
Karl Heinz Marbaise 5988085525 [MNG-6342] Emit a WARNING about LATEST/RELEASE in parent 2018-01-19 23:43:59 +01:00
Karl Heinz Marbaise 6b83f7e6bb [MNG-6305] Validation of CI friendly version incorrect
o Followup removed unused declarations.
2017-12-30 22:09:02 +01:00
Karl Heinz Marbaise 2295c17b45 [MNG-6305] Validation of CI friendly version incorrect
o Checkin that only the three expression changelist,
   revision and sha1 are valid in a version.
 o Added some tests.
2017-12-30 21:41:18 +01:00
rfscholte df5169bdf9 [MNG-6330] Parents relativePath not verified anymore 2017-12-29 10:39:45 +01:00
Stephen Connolly 3d0efa3696 [maven-release-plugin] prepare for next development iteration 2017-10-18 08:55:05 +01:00
Stephen Connolly 138edd61fd [maven-release-plugin] prepare release maven-3.5.2 2017-10-18 08:54:47 +01:00
Stephen Connolly 312eb53502 [maven-release-plugin] prepare for next development iteration 2017-09-10 12:51:43 +01:00
Stephen Connolly 094e4e31a5 [maven-release-plugin] prepare release maven-3.5.1 2017-09-10 12:51:26 +01:00
Karl Heinz Marbaise 8f8c45c990 [MNG-6123] detect self references in POM and fail fast
o Added unit test and self referencing pom
2017-08-01 22:01:36 +02:00
dejan2609 12d6471337 [MNG-6207] Create WARNINGs in case of using system scope
o display deprecation build warning for dependencies with scope 'system' declaration
 o Note about tests: existing 'systemPath' related tests are reused/expanded
   (rationale: scope 'system' and 'systemPath' are mutually dependent)

Signed-off-by: Karl Heinz Marbaise <khmarbaise@apache.org>
2017-06-11 13:55:07 +02:00
dejan2609 eb6b212b56 [MNG-6206] display deprecation build warning in case when dependencies
use metaversions (LATEST or RELEASE)

Signed-off-by: Karl Heinz Marbaise <khmarbaise@apache.org>
2017-06-04 20:23:02 +02:00
Michael Osipov ecef59f1cb [MNG-6167] Clean up dependency mess (reported by dependency:analyze)
Clean up compile and runtime dependencies. Test dependencies have not been
touched because their seem to be false positives due to DI.
2017-05-16 15:27:22 +02:00
Stephen Connolly a4b0b63b62 [maven-release-plugin] prepare for next development iteration 2017-04-03 20:35:47 +01:00
Stephen Connolly ff8f5e7444 [maven-release-plugin] prepare release maven-3.5.0 2017-04-03 20:35:30 +01:00
Christian Schulte 8400984ac5 [MNG-6112] Central repository in the 4.0.0 super POM should declare update policy 'never'.
This reverts commit 13adc1bc2b *not changing
anything* just because someone did not react in time when this issue had been
lying around on a branch. If we would set pace for the industrie, everyone would
still be using 5.25" floppy disks and 8 bit hardware and we would tell them
that upgrading to be able to use new software would be too risky and they
better keep theire broken assembly routines until the machine goes up in
smoke.
2017-03-25 20:53:06 +01:00
Christian Schulte 0931bb2cc7 [MNG-6168] Fix unclosed streams 2017-03-24 22:04:37 +01:00
Christian Schulte 13adc1bc2b [MNG-6112] Central repository in the 4.0.0 super POM should declare update policy 'never'. 2017-03-21 00:30:28 +01:00
Christian Schulte d54e6f91a8 s/@since 3.5.0-alpha-2/@since 3.5.0/g 2017-03-21 00:21:43 +01:00
Stephen Connolly fd29ddebf9 [maven-release-plugin] prepare for next development iteration 2017-03-20 16:55:53 +00:00
Stephen Connolly 214540c2ae [maven-release-plugin] prepare release maven-3.5.0-beta-1 2017-03-20 16:55:36 +00:00
Hervé Boutemy 1638280261 [MNG-6189] warn if maven-site-plugin reportPlugins is configured 2017-03-19 21:51:53 +01:00
rfscholte 0e7e3eeb59 [MNG-6176] Javadoc errors prevent release with Java 8
Upgrade to modello-1.9.1
Fix javadoc errors in tests
2017-03-18 12:55:05 +01:00
Karl Heinz Marbaise 51cc76c326 [MNG-6090] CI friendly properties break submodule builds
[MNG-6057] Problem with CI friendly usage of ${..} reactor order is changed
 o Based on the missing replacement of the versions ${revision}
   ${changelist} or ${sha1} within the parent element the order
   of the reactor changes.
[MNG-5895] Problem with CI friendly usage of ${..} which is already
defined via property in pom file.
2017-03-13 22:08:51 +01:00
rfscholte 587317b009 [MNG-6176] Javadoc errors prevent release with Java 8
Upgrade modello to 1.9.0
Fix invalid Javadoc
2017-03-10 16:17:28 +01:00
Christian Schulte ab800b0cfa [MNG-6182] ModelResolver interface enhancements. 2017-03-08 18:24:18 +01:00
Hervé Boutemy 0db5e32cf5 fixed documentation errors 2017-02-23 19:07:58 +01:00
Hervé Boutemy 985b5985f3 fixed link 2017-02-18 18:13:06 +01:00
Michael Osipov b66bdb9cbc [MNG-6150] Javadoc improvements for 3.5.0
* Remove duplicate plugin configuration
* Add workaround for Javadoc locale
* Clean up errors reported by Javadoc 7

Note: Javadoc 8 fails immediately because Modello generates invalid
Javadoc
2017-02-15 17:30:46 +01:00
Christian Schulte 37fef3d762 [MNG-5967] Dependency updates 2017-02-11 16:36:46 +01:00
Alex Henrie 8d91726f78 [MNG-5934] String handling issues identified by PMD 2017-02-11 14:08:24 +01:00
Christian Schulte 0514c1b14e [MNG-2199] Support version ranges in parent elements
o Updated to fix parent version range resolution broken since 3.2.3 and to
  remove parent version range resolution logic obsolete since Maven
  3.2.3 which changed the initialization of MavenProject instances.
o Updated local parent resolution to behave the same way remote parent
  resolution behaves. When referencing a parent using version ranges,
  inheriting the version or using version expressions should not be supported.
  It has been implemented that way for remote parent resolution as it got
  introduced in Maven 3.2.2. For local parent resolution the version in parent
  declarations had been ignored completely as of Maven 3.3.0 due to commit
  be3fb20032 removing all local parent version
  validation. Work on fixing this is tracked by MNG-5840 released with Maven
  3.3.9. This commit adds the final missing bits to make local and remote parent
  resolution behave the same way as much as possible. As an exception, remote
  parent resolution still is a bit more strict than local parent resolution due
  to a different API in use. When resolving a parent from a repository using
  version ranges, the ModelBuilder verifies the range in use to declare an upper
  bound. When resolving a parent locally using version ranges, those ranges are
  not required to declare an upper bound because the API in use does not support
  querying that. Authoring a POM relying on this difference should be considered
  a bug.
o Added test cases to maven-core testing parent version range resolution for
  local and remote parent models.
2017-02-10 22:46:52 +01:00
Josh Soref 1be7ea893e [MNG-6165] Deprecate and replace incorrectly spelled public API
Spelling fixes:

* spelling: collector
* spelling: executions
* spelling: repositories
* spelling: workspace

This closes #101
2017-02-06 20:36:38 +01:00
Josh Soref 1740265984 [MNG-6146] Several small stylistic and spelling improvements to code and documentation
Spelling fixes:

* system
* tokenizer
* toolchain
* trailing
* transitive
* unsupported
* version
* artifact
* attachment
* codehaus
* colleagues
* comparison
* concurrency
* configure
* creation
* dependency
* descriptor
* downstream
* efficient
* e.g.
* elements
* encountered
* encounters
* environments
* executed
* explicitly
* happens
* hierarchical
* hierarchy
* ignore
* implemented
* implementers
* independence
* indicates
* inheritance
* inherited
* inherits
* install
* interface
* javascript
* laziness
* management
* maven
* metadata
* mgmt
* minimalist
* nonexistent
* objects
* overridden
* print
* project
* properties
* recessive
* referring
* repository
* representation
* retrieval
* retrieve
* rigorous
* should
* spontaneously
* subsequent

Literal fixes:

*  use static final values

Style fixes:

* use the proper term for char U+002D (-) hyphen(-minus) instead of dash

This closes #100
2017-02-03 10:12:28 +01:00
Hervé Boutemy 9b763cc002 [MNG-5878] added project.directory property to support module name !=
artifactId in every calculated URLs
2017-02-01 08:01:11 +01:00
Karl Heinz Marbaise 017dcaf22a [MNG-5993] Confusing error message in case of missing/empty
artifactId/groupId and version in pluginManagement
2017-01-29 21:12:49 +01:00
Guillaume Boué 5b4b8bd94c [MNG-6105] properties.internal.SystemProperties.addSystemProperties() is not really thread-safe
Refactoring the current code setting system properties to synchronize correctly on the given ones: avoids ConcurrentModificationException and NullPointerException if the properties is modified by another thread.
2017-01-28 14:07:59 +01:00
Hervé Boutemy 84085c0a9c updated urls (https, plexus) and license header formatting 2017-01-24 23:50:10 +01:00
Stephen Connolly bce33aa266 [MNG-6151] Set version to 3.5.0-SNAPSHOT 2017-01-04 09:12:47 +00:00
Jason van Zyl 737de43e39 [maven-release-plugin] prepare for next development iteration 2015-11-10 11:37:02 -05:00
Jason van Zyl bb52d8502b [maven-release-plugin] prepare release maven-3.3.9 2015-11-10 11:36:45 -05:00
Stephen Connolly 1953284925 [MNG-5840] A regression had crept in and was missed as the intergration tests were not running the MNG-5840 tests 2015-11-02 12:17:23 +00:00
Hervé Boutemy 2f7daeff58 [MNG-5871] refactoring: improved empty urls handling 2015-10-31 12:55:47 +01:00
Jason van Zyl 406a46fd83 [maven-release-plugin] prepare for next development iteration 2015-10-30 09:41:20 -07:00
Jason van Zyl cdd15915eb [maven-release-plugin] prepare release maven-3.3.8 2015-10-30 09:40:58 -07:00
Jason van Zyl f684761dee Fix for urls being empty in the POM and causing an out of bounds exception 2015-10-29 18:33:59 -07:00