Commit Graph

1200 Commits

Author SHA1 Message Date
Guillaume Nodet 415eaf31de
[MNG-7160] Ability to customize core extensions classloaders (#616) 2022-06-15 10:43:17 +02:00
Christoph Läubrich 2798ee9196 [MNG-7395] Support interpolation in extensions.xml
This adds support for property interpolation in extensions.xml to allow
advanced use cases where one wants to contribute certain things via the
commandline.

This closes #665
2022-02-19 22:01:10 +01:00
Giovanni van der Schelde 4476026c52 [MNG-7217] Update Commons CLI to version 1.5.0
Closes #605
2022-01-08 19:57:39 +01:00
Guillaume Nodet b4773576a8 [MNG-6326] Make the build fail if core extensions can not be loaded (#648) 2022-01-07 10:03:15 +01:00
Guillaume Nodet 3a06530dbc
Remove duplicate call to longOpt (#626) 2021-12-02 11:43:23 +01:00
Julian de Bruin 98a6c4f14c [MNG-7340] Option fail-on-severity takes one argument
Closes #620
2021-11-25 11:35:01 +01:00
Giovanni van der Schelde f43f9f8a3b [MNG-7332] No longer support --define
The reason is that it is broken in Commons CLI and -D just works.
We don't want to work around symptoms. Another point is that
java(1) does not have --define either so we'd like to keep that
consistent.

Closes #611.
2021-11-15 10:46:27 +01:00
Michael Osipov 2c37a7a38e Simplify args help 2021-10-17 12:44:14 +02:00
Hervé Boutemy f46a9131d5 fix javadoc errors 2021-10-17 12:07:50 +02:00
Arturo Bernal d61fcf7da1 [MNG-7288] Remove redundant local variables
Closes #569
2021-10-10 12:42:12 +02:00
Tamas Cservenak c3962c1a6c
[MNG-7278] Clean up core logging (#562)
We had all kind of Loggers in Core, some Plexus
injected, some acquired using SLF4J LoggerFactory,
some static, some final, etc.

This PR aligns all those uses to SLF4J finals.

Notices:
* maven-core does NOT use Plexus Logger anymore
* did not touch maven-compat
2021-10-02 20:33:55 +02:00
Guillaume Nodet 35e5a4d71d [MNG-5577] Use JSR 330 constructor injection
# Conflicts:
#	maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecyclePluginAnalyzer.java
2021-10-02 12:26:22 +02:00
Tamas Cservenak 406c525ec4 [MNG-7250] Upgrade Sisu Inject/Plexus to 0.3.5
Since we have replaced the old JSR 250 library with javax.annotation library we
go straight to 1.3.2 because Maven Resolver 1.7.0 introduced this already as a
transitive dependency in fc806a25eb.
The only difference between version 1.2 and 1.3.2 is a Java upgrade from 6 to 8.

This closes #539
2021-09-13 22:57:31 +02:00
Tamas Cservenak 067171d28a [MNG-7246] Upgrade Plexus Cipher and Sec Dispatcher to 2.0
Both plexus-cipher and plexus-sec-dispatcher have had a
groupId change, but plexus-cipher change was implemented
for 1.8 version.

Latest versions of artifacts are 2.0. This PR
ups plexus-cipher version and adds proper changes
for plexus-sec-dispatcher groupId change.

This closes #534
2021-09-11 10:52:20 +02:00
Michael Osipov a2a3df3d02 [MNG-7203] Introduce a long option --verbose and deprecate --debug
This closes #519
2021-08-01 22:33:33 +02:00
Michael Osipov 0696cf14ad [MNG-7131] maven.config doesn't handle arguments with spaces in them
Since we don't have a clear specification of the file format change
reading of the file to a one-arg-per-line basis just like Java's
@argfiles or Python's argparse would handle it.
Consider that jvm.config suffers from the same issue its parsing is not
portable between Bourne shell and Windows Command prompt.
2021-07-21 14:31:12 +02:00
Michael Osipov 1fc605dd69 [MNG-7181] Make --version support -q 2021-07-03 19:17:19 +02:00
Michael Osipov a70828c737 [MNG-7180] Make --color option behave more like BSD/GNU grep's --color option 2021-07-03 18:28:31 +02:00
Guillaume Nodet a20230829c [MNG-6915] Adapt the logging width to the terminal width, including sensible limits.
Slightly modified version of e47d647eee
2021-05-22 10:49:42 +02:00
Guillaume Nodet 3e917677e4 [MNG-7032] Evaluate --help and --version after configuring the logging/color 2021-05-06 09:54:43 +02:00
Guillaume Nodet 59c5466c40 [MNG-7080] Add a --color option to simplify color support 2021-05-06 09:54:03 +02:00
Guillaume Nodet 5d6c6e2537 [MNG-6915] Format help according to the terminal width 2021-05-05 08:34:32 +02:00
Martin Kanters 9c631ab286 Extend mvn -h for various features of Maven 4
Closes #463.
2021-04-05 19:41:28 +02:00
Carlos Chacin 276c6a8dc4 [MNG-7127] fix MavenCliTest.testStyleColors test in JDK 16
The MavenCliTest.testStyleColors is not failing when the build
is under JDK 8 or JDK 11.

After changing to JDK 16, the test fails, this commit is to fix
the NullPointerException.

Tested on JDK 8, 11 adn 16 with:

`mvn clean verify`
2021-03-27 19:15:18 +01:00
Maarten Mulders c3cf29438e [MNG-6511] Optional project selection
Closes #446.
2021-03-22 14:41:59 +01:00
Hervé Boutemy 441cf73c06 improve documentation 2021-02-20 19:34:43 +01:00
Guillaume Nodet 619973b91c [MNG-7063] Infinite loop using Shade plugin and JUnit 5 dependency
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-02-14 15:52:04 +01:00
boris-unckel 1e575a2bd7 [MNG-7068] Active dependency management for Google Guice/Guava
This closes #462
2021-02-02 14:17:43 +01:00
Maarten Mulders 8defd16965 [MNG-7051] Optionally skip non-existing profiles and break on missing required profiles. 2021-02-02 08:20:21 +01:00
Guillaume Nodet bb916d0784 [MNG-7035] Migrate unit tests to Unit 5
Signed-off-by: rfscholte <rfscholte@apache.org>
2021-01-15 15:07:06 +01:00
Sylwester Lachiewicz b877445cb9 [MNG-6909] Convert to JSR330 in tests - maven-core
Closes #346
2021-01-08 03:55:24 +01:00
Michael Osipov a6d5e86155 Use consistent static final loggers 2021-01-05 15:47:20 +01:00
Michael Osipov 2201698234 Apply consistent log argument quoting for sigle- and multi-valued args 2021-01-05 15:47:20 +01:00
Karl Heinz Marbaise 538de4d192 [MNG-6888] Remove deprecated command line options
This closes #418
2021-01-01 20:57:23 +01:00
Michael Osipov 31ad2ff43a Use system line separator wherever possible
This closes #424
2021-01-01 12:55:01 +01:00
Michael Osipov 673a7d1fef Trim trailing whitespace 2020-12-24 19:09:10 +01:00
rfscholte 3736be9c15 Updating version in preparation for Maven 4 2020-11-27 12:22:47 +01:00
Sylwester Lachiewicz 449e6dc9db [MNG-6873] update junit dependency to 4.13.1 - also in unit tests 2020-10-27 11:08:56 +01:00
Maarten Mulders df67c00fba [MNG-6991] Restore how the local repository is determined
The refactoring of MavenCli.populateRequest introduced
a subtle bug. It would select ~/.m2/repository as the
local repository instead of something that is configured
in ~/.m2/settings.xml.

Closes #378.
2020-09-29 20:33:25 +02:00
Maarten Mulders ac80f5c2b9 Refactor MavenCli.populateRequest 2020-09-20 11:33:53 +02:00
Martin Kanters 5739b12aa9 Resume from generates misleading hint when multiple projects fail.
Log the topologically sorted first failed project instead of the chronologically first failed project.
Resume from generates misleading hint when multiple projects fail.
Fixed a checkstyle finding.
Removed a trailing space in the -r hint
2020-07-24 10:07:25 +02:00
Maarten Mulders 117cfde44e [MNG-5760] Several fixes for the --resume feature.
BuildResumptionDataRepository is not used in MavenCli

Make setResume() on MavenExecutionRequest a traditional setter

Fix resolution of resume.properties file

Add unit test for DefaultBuildResumptionDataRepository#applyResumptionData

Avoid storing and using an empty excludedProjects field in the resume.properties file.

Avoid star imports

Don't create a unneeded Path when resolving resume.properties

Support the scenario where the first project was failed, but subsequent projects succeeded. (e.g. by fail-at-end or parallel builds)

Maven invocations without project shouldn't fail
2020-07-15 08:58:45 +02:00
rfscholte d35573e06c [MNG-5760] Add `-r/--resume` to automatically resume from the last failure point
Author: Martin Kanters <mkanters93@gmail.com>
2020-06-21 11:21:36 +02:00
huangkaifeng ba16eb1b39 [MNG-6873] Align JUnit version to 4.13
Closes #331
2020-06-21 11:16:50 +02:00
Olivier Lamy 24da558d5a [MNG-6886] upgrade plexus-cipher to 1.8 and update changed groupId (#335)
Signed-off-by: olivier lamy <olamy@apache.org>
2020-06-21 11:16:35 +02:00
Joseph Walton 0f519b4af4 [MNG-5577] Simplify tests to reduce use of wiring.
- Reduce the use of wiring in unit tests
- Enable class scanning for tests that require it.
- Remove test and wiring that's not used.
2020-06-21 11:16:28 +02:00
dependabot-preview[bot] 45e91f03b0 [MNG-6878] Bump guice from 4.2.2 to 4.2.3
Bumps [guice](https://github.com/google/guice) from 4.2.2 to 4.2.3.
- [Release notes](https://github.com/google/guice/releases)
- [Commits](https://github.com/google/guice/compare/4.2.2...4.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-22 10:09:35 +01:00
Michael Osipov 720e46d91d Revert "[MNG-5587] When the build fails emit any errors without the user having to specify -e or -X"
This reverts commit 838c196359.
2020-01-28 10:13:42 +01:00
Sylwester Lachiewicz cdb2cd0df3 [MNG-6071] Normalize relative paths for working directory 2020-01-26 17:25:38 +01:00
thelproad 96e11e1c84 [MNG-6855] Remove redundant code
Closes #280
2020-01-26 11:13:26 +01:00
Lipmanpoi e6c897efb6 [MNG-6855] Simplify some code
Closes #279
2020-01-26 11:13:18 +01:00
Rostislav Krasny ce35eff448 [MNG-6853] - Don't box primitives where it's not needed
Closes #318
2020-01-25 20:13:27 +01:00
Gabriel Belingueres 838c196359 [MNG-5587] When the build fails emit any errors without the user having to specify -e or -X
This closes #283
2020-01-13 22:28:26 +01:00
Artem Krosheninnikov 39492281b2 [MNG-6847] Explicit type can be replaced by the diamond operator
This closes #315
2020-01-13 20:57:35 +01:00
Artem Krosheninnikov 735b72fcf1 [MNG-6844] Use StandardCharsets and remove outdated @SuppressWarnings
This closes #312
2020-01-09 18:09:44 +01:00
Martin Kanters d2510749d8 [MNG-6065] Create option --fail-on-severity 2019-12-27 10:56:55 +01:00
Karl Heinz Marbaise 06842d6b96
[MNG-6826] - Remove condition check for JDK8+ in FileSizeFormatTest
- The conditions to check for JDK8+ in test cases is
   obsolete with the lift to JDK8.
2019-12-15 04:16:49 +01:00
Artem Krosheninnikov 3332f4dbcc [MNG-6816] Prefer System.lineSeparator() over system properties
This closes #300
2019-12-10 09:43:47 +01:00
Karl Heinz Marbaise 13c80d506f
[MNG-6815] - Upgrade guice 4.2.2 2019-12-08 19:18:55 +01:00
Karl Heinz Marbaise f7ca74da53
[MNG-6812] - Remove unused files from maven-embedder 2019-12-07 19:57:14 +01:00
Karl Heinz Marbaise b810f59fe7
[MNG-6811] - Remove unnecessary filtering configuration 2019-12-07 15:18:46 +01:00
rfscholte ead06d23d4 [maven-release-plugin] prepare for next development iteration 2019-11-19 20:17:36 +01:00
rfscholte cecedd3430 [maven-release-plugin] prepare release maven-3.6.3 2019-11-19 20:17:06 +01:00
Hervé Boutemy 53ccee3486 [MNG-6778] use https for schema location 2019-11-09 13:45:14 +01:00
Christian Wansart 0c7c69f78b [MNG-6778] - Use https for maven schemaLocations 2019-11-07 16:16:39 +01:00
Anatoly Zaretsky 877fcc9cd5
[MNG-6777] - Remove duplicate resolveFile methods
o MavenCli.resolveFile and
   configuration.SettingsXmlConfigurationProcessor.resolveFile
   utility methods are identical. Moving them into separate
   ResolveFile class.
2019-10-10 19:53:44 +02:00
Enrico Olivelli d9a0eee7fe [maven-release-plugin] prepare for next development iteration 2019-08-27 16:59:23 +02:00
Enrico Olivelli 40f5233313 [maven-release-plugin] prepare release maven-3.6.2 2019-08-27 16:59:01 +02:00
Michael Osipov 400e7e5979 [MNG-6747] Generalize 'resume from' message when build reactor fails 2019-08-27 09:08:57 +02:00
Hervé Boutemy f7b4a657db [MNG-6549] Remove unused transitive dependencies of Guava
while at it, did a little bit of cleanup:
- removed aopalliance (like done in maven-resolver-provider)
- removed guice dependency management that should be part of MNG-6475
2019-07-20 11:29:45 +02:00
Joseph Walton 353d3eaa8f [MNG-6685] Convert Maven Model Builder to JSR 330
This closes #256
2019-06-23 00:20:54 +02:00
Sylwester Lachiewicz 59bd396e6e [MNG-6686] Convert Maven Embedder to JSR 330
This closes #257
2019-06-21 23:57:49 +02:00
rfscholte ff8c5c8706 MNG-6069: unittest with compact and spaced -D options 2019-05-17 22:09:48 +02:00
Joseph Walton 658301276a [MNG-6069] Avoid (some) deprecated commons-cli methods
Switch from OptionBuilder to Option.Builder. Confirm by
inspection that the resulting Option objects are the same.

For now, leave GnuParser. Despite the upgrade advice in the GnuParser
Javadoc ("since 1.3, use the DefaultParser instead"), it behaves
differently.

Closes #247
2019-05-17 22:09:48 +02:00
Karl Heinz Marbaise 5222f03d05
[maven-release-plugin] prepare for next development iteration 2019-04-04 20:56:37 +02:00
Karl Heinz Marbaise d66c9c0b31
[maven-release-plugin] prepare release maven-3.6.1 2019-04-04 20:56:16 +02:00
Raymond Auge 95401cf7a6 [MNG-6605] Unable to suppress download/upload messages (in interactive mode)
This closes #239
2019-04-01 08:47:10 +02:00
Sylwester Lachiewicz b7249aff22 Revert [MNG-6069] Migrate to non deprecated parts of Commons CLI
This reverts commit 396291bba0 due to regression
2019-02-01 21:41:23 +01:00
Guy Brand 15c647182a [MNG-6558] ToolchainsBuildingResult event is not sent on EventSpy
Closes #231
2019-01-27 12:01:35 +01:00
Sylwester Lachiewicz 396291bba0 [MNG-6069] Migrate to non deprecated parts of Commons CLI (#153) 2019-01-13 21:19:39 +01:00
Karl Heinz Marbaise 6e376d424e
[maven-release-plugin] prepare for next development iteration 2018-10-24 20:38:30 +02:00
Karl Heinz Marbaise 97c98ec64a
[maven-release-plugin] prepare release maven-3.6.0 2018-10-24 20:38:06 +02:00
HoaPhan ba74b96633
[MNG-6492] - Minor improvement on Array construction, conversion performance 2018-10-24 18:07:13 +02:00
Karl Heinz Marbaise 23f5c88d11
[MNG-6391] - Printout version of last built module in reactor build 2018-10-20 10:12:45 +02:00
Christian Schulte 44826ab446 [MNG-6164] Collections inconsistently immutable
Make non-empty collections returned immutable just like those returned by
java.util.Collections.
2018-10-09 22:12:50 +02:00
Phillip Webb 01f098efd1
[MNG-6475] Remove unused Guava dependencies 2018-09-13 20:45:25 +02:00
rfscholte 72dca39807 Replace org.apache.commons.lang3.Validate#notNull with java.util.Objects#requireNonNull 2018-07-15 10:36:08 +02:00
Stephen Connolly bf0bd6350e Master is now on 3.6.0-SNAPSHOT 2018-06-17 22:38:49 +01:00
Stephen Connolly 1efd571b0a [maven-release-plugin] prepare for next development iteration 2018-06-17 19:29:56 +01:00
Stephen Connolly 1edded0938 [maven-release-plugin] prepare release maven-3.5.4 2018-06-17 19:29:25 +01:00
Łukasz Dywicki 864d180edf [MNG-6410] Add groupId to --resume-from suggestion if artifactId is not unique in reactor
This closes #166
2018-05-20 21:50:17 +02:00
Michael Osipov 9abfc88425 [MNG-5756] Java home output in mvn -v is misleading
The Java home displayed corresponds to the property 'java.home' which points to
the JRE installation running the given Maven instance. It is not the value of
$JAVA_HOME which causes confusion.

Ref: https://docs.oracle.com/javase/tutorial/essential/environment/sysprop.html

This closes #115 and #117.
2018-05-07 23:42:20 +02:00
Karl Heinz Marbaise 9c118d34c9
[MNG-6363] - Remove secret thread configuration property from code 2018-04-22 22:55:33 +02:00
Stephen Connolly 85b4e3d8e8 [maven-release-plugin] prepare for next development iteration 2018-02-24 19:29:56 +00:00
Stephen Connolly 3383c37e1f [maven-release-plugin] prepare release maven-3.5.3 2018-02-24 19:29:21 +00:00
Karl Heinz Marbaise 8f619acd3a [MNG-6352] - Printout version information at the end of the build 2018-02-17 19:27:52 +01:00
rfscholte cd34b08df1 Merge remote-tracking branch 'remotes/origin/MNG-6353' 2018-02-11 18:29:43 +01:00
Sylwester Lachiewicz b8c06e61ab Remove Google Guava usage (move to Java7) 2018-02-11 11:54:17 +01:00
Sylwester Lachiewicz d925081794 Reduce number of global checkstyle rule violations
Fix code for following checkstyle rules:
ConstantName, FileLength, InnerAssignment, JavadocType, MagicNumber, MethodLength, MethodName, NewlineAtEndOfFile, ParameterNumber, RedundantThrows, VisibilityModifier

Fixes #149
2018-02-11 11:41:16 +01:00
rfscholte 22f782aecd [MNG-6353] Upgrade maven-shared-utils to 3.2.1
Add o.a.m.s.u.logging.MessageUtils.registerShutdownHook() to prevent ANSI from staying active when killing an active process
2018-02-10 15:28:59 +01:00