John Dennis Casey
7eda955b1d
o Cleaned up a couple of things in repoclean that broke with the last update.
...
o Added concept of ErrorDiagnoser to help interpret errors and provide user feedback
o Added PluginParameterException to provide richer information than simply PluginConfigurationException (it's derived from PluginConfigurationException)
o Added implementations of ErrorDiagnoser for artifact resolution and plugin configuration handling.
o Modified DefaultMaven's logFailure(..) method to use errorDiagnosers Map (injected via Plexus)
I approached the plugin parameter expression/name feedback in this way, as it seems like a general pattern for interpreting errors without embedding this logic deep within the app itself. Feel free to rollback if this causes issues.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169379 13f79535-47bb-0310-9956-ffa450edef68
2005-05-09 23:30:01 +00:00
Brett Leslie Porter
05affa0a65
PR: MNG-192
...
Add "RELEASE" notation so that plugins without a version can be discovered
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169303 13f79535-47bb-0310-9956-ffa450edef68
2005-05-09 12:30:10 +00:00
John Dennis Casey
469f96a4f1
o Added '-e' switch, to allow error stacktraces without enabling DEBUG error level throughout.
...
o Added listing of error messages from getCause() chain in DefaultMaven rather than simply spitting out the (often useless) aggregator Exception's message.
o Added '-e' to the IT verifier's invocation of m2.
I'm trying to get visibility to errors here...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169230 13f79535-47bb-0310-9956-ffa450edef68
2005-05-09 04:25:56 +00:00
Brett Leslie Porter
8e6a8fa694
actually make the changes I said I had for MNG-372
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169202 13f79535-47bb-0310-9956-ffa450edef68
2005-05-09 00:22:11 +00:00
Brett Leslie Porter
46e32b8b90
PR: MNG-371
...
Submitted by: Kenney Westerhof
Reviewed by: Brett Porter
give the location of the plugin descriptor
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169201 13f79535-47bb-0310-9956-ffa450edef68
2005-05-09 00:21:33 +00:00
Brett Leslie Porter
0a7842482f
PR: MNG-372
...
Submitted by: Mark Hobson
Reviewed by: Brett Porter
deal better with spaces in paths on windows
(applied with modifications)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169184 13f79535-47bb-0310-9956-ffa450edef68
2005-05-08 22:50:01 +00:00
Brett Leslie Porter
6348de7143
comment out readonly check, as it breaks an integration test
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169172 13f79535-47bb-0310-9956-ffa450edef68
2005-05-08 21:47:31 +00:00
Emmanuel Venisse
dd4c6fb600
Add reports to the menu
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@169077 13f79535-47bb-0310-9956-ffa450edef68
2005-05-07 13:01:17 +00:00
John Dennis Casey
f1d5f829f2
Correcting module-path validation to error on '..' rather than '/'...'/' causes problems when modules are not direct subdirs of the current basedir.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168639 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 19:17:11 +00:00
Brett Leslie Porter
b90399de88
make sure debug really is debug by initialising before DefaultMaven gets looked up.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168635 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 18:56:34 +00:00
John Dennis Casey
76c4ceda28
o Added duplicate check for mojo descriptor Parameters
...
o changed the exception(s) throws during mojo descriptor extraction to be derivatives of InvalidPluginDescriptorException
o changed PluginConfigurationException in plugin.descriptor to InvalidPluginDescriptorException
o changed all "true".equals(something) to Boolean.valueOf(something).booleanValue()
o added validation of 'modelVersion' back to [Default]ModelValidator
o Fixed/added tests for new 'modelVersion' validation
o changed all requiresXXX in MojoDescriptor to XXXRequired, and getRequiresXXX():boolean to isXXXRequired():boolean to help maintain bean-ness for future use
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168630 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 17:41:03 +00:00
Brett Leslie Porter
216a640dd0
recognise prefix of plugins already loaded
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168605 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 14:21:00 +00:00
Brett Leslie Porter
d9ac5ea1e5
use consistent ordering for reactored projects
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168569 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 08:22:28 +00:00
Brett Leslie Porter
4f60e7e0a1
fix substitution in messages files
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168568 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 08:21:58 +00:00
Brett Leslie Porter
3f031d5722
avoid NPE if there are not report plugins defined in the POM when generating the site.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168565 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 08:05:52 +00:00
Brett Leslie Porter
d17b250fec
- allow multiple versions of a plugin to operate concurrently.
...
- allow specification of a mojo as groupId:artifactId:version:goal
- general removal of more hard coding
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168543 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 07:03:14 +00:00
Brett Leslie Porter
4b12bf0e6e
add (commented out) reports
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168514 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 03:57:48 +00:00
John Dennis Casey
acabb9d990
Added isXXXEnabled() methods to Log.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168486 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 01:00:37 +00:00
John Dennis Casey
5877385df1
Final pass on cleaning up the mojo api...collapsed MavenPluginDescriptor and PluginDescriptor in the same way as MavenMojoDescriptor/MojoDescriptor had been; eliminated the need for plugin.descriptor.Dependency and MavenPluginDependency (using ComponentDependencies instead); adjusted the MojoExtractors (name?) to return Lists instead of Sets; added duplicate checking to a new addMojo(MojoDescriptor) method on PluginDescriptor, so we catch it on all sides; changed the Generators to use execute(outputDirectory, pluginDescriptor) rather than the myriad pluginDescriptor-derived values; added an IT for checking that the build for a plugin will fail if multiple mojos are detected with the same goal; and, added a special case to PluginDescriptor.getGoalPrefixFromArtifactId() to handle maven-plugin-plugin. That should be about it. I'm not sure that I've gotten the IT for that failure test added to svn yet, so that may follow.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168481 13f79535-47bb-0310-9956-ffa450edef68
2005-05-06 00:32:08 +00:00
Brett Leslie Porter
c9d01daf19
remove erroneous TODO item
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168295 13f79535-47bb-0310-9956-ffa450edef68
2005-05-05 07:23:13 +00:00
Brett Leslie Porter
7363dbc843
PR: MNG-145
...
Implement and document repository download mirrors
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168292 13f79535-47bb-0310-9956-ffa450edef68
2005-05-05 07:16:07 +00:00
Brett Leslie Porter
6dca9007eb
a couple of notes
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168278 13f79535-47bb-0310-9956-ffa450edef68
2005-05-05 05:44:44 +00:00
John Dennis Casey
e095874576
Cleaned up plugin descriptor generation/reading to be more consistent, and to include some things that were being left out. Removed more deprecated behavior from annotations support and expression support. Wrote up the first pass on the mojo api and annotations spec. Fixed the mmld-mojo suppport to accommodate the new expression syntax and collisions with the default expression evaluator for mmld. Added an exception to plugin configuration in DefaultPluginManager to not look for a Field when the configurator == map-oriented.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168233 13f79535-47bb-0310-9956-ffa450edef68
2005-05-05 01:33:42 +00:00
Emmanuel Venisse
bd9a7f4f7b
Add some debug trace
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168221 13f79535-47bb-0310-9956-ffa450edef68
2005-05-05 00:40:46 +00:00
Brett Leslie Porter
e94fd427f3
improve error message if there is no expression
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168220 13f79535-47bb-0310-9956-ffa450edef68
2005-05-05 00:35:55 +00:00
Brett Leslie Porter
d4af503a5c
align error handling with that of m1
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168214 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 23:43:47 +00:00
Emmanuel Venisse
705f269567
Fix APT
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168185 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 20:40:04 +00:00
Brett Leslie Porter
acfba80edc
consolidate defaults injection
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168152 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 17:34:52 +00:00
Brett Leslie Porter
7f7a1049e6
improve the artifact ID parsing - any maven or plugin is removed to get the default prefix. If you want something different, use the configuration for plugin:descriptor
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168141 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 16:23:42 +00:00
Brett Leslie Porter
671b0828ec
remove unused function
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168135 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 14:55:57 +00:00
Brett Leslie Porter
24c6328ad3
declare the desired "prefix" inside the plugin descriptor instead of pulling apart the artifact ID (though that is how the default is created).
...
Currently, the reverse is not handled in anyway, so a non-default prefix may not work, but this makes the code easier to isolate.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168099 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 08:17:39 +00:00
Brett Leslie Porter
118a53927d
remove old style req, resp mojo support
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168082 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 05:52:55 +00:00
John Dennis Casey
5345ee5fc6
Removed backward compat for plugin class-level parameter annotations and '#' expressions.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168070 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 04:20:36 +00:00
John Dennis Casey
690bc67fb9
Added marmalade support back in...it's currently still using the libraries-shovelled-into-core method, but it now uses the new mojo mechanism that uses plexus ComponentConfigurators...had to make the lookup for configurators dynamic for the DefaultPluginManager, too.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168064 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 03:28:41 +00:00
Brett Leslie Porter
e12a025c81
remove unused component dependencies
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168053 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 02:42:43 +00:00
Brett Leslie Porter
19d96b6163
reduce the code duplication of the injection
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168052 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 02:38:39 +00:00
Brett Leslie Porter
e0b032ac0a
improve the structure of the lifecycle execution code
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168041 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 01:40:59 +00:00
Brett Leslie Porter
b5670bdcaa
start to clean up the plugin vs. goal name handling so the hardcoding can be reduced, and eventually removed
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168040 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 01:20:49 +00:00
Emmanuel Venisse
e9a7f3ce85
Initial version of site generation with repots.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@168031 13f79535-47bb-0310-9956-ffa450edef68
2005-05-04 00:47:01 +00:00
Brett Leslie Porter
6bb39db726
improve error message
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165604 13f79535-47bb-0310-9956-ffa450edef68
2005-05-02 08:19:01 +00:00
Brett Leslie Porter
95a1895b16
add integration test phase
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165598 13f79535-47bb-0310-9956-ffa450edef68
2005-05-02 07:22:47 +00:00
Brett Leslie Porter
8d4ca04b2d
fix bad expression handling
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165597 13f79535-47bb-0310-9956-ffa450edef68
2005-05-02 07:22:18 +00:00
John Dennis Casey
3966104e9c
Removed the need for MavenMojoDescriptor (collapsed to just MojoDescriptor)...also partially setup the possibility for container-injected configurations, provided we enhance as described in getting-to-container-configured-mojos.apt.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165378 13f79535-47bb-0310-9956-ffa450edef68
2005-04-30 03:50:47 +00:00
Brett Leslie Porter
36f970b652
don't fail if there is a default value and the parameter is set to required.
...
Reformat according to intelliJ settings.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165266 13f79535-47bb-0310-9956-ffa450edef68
2005-04-29 06:06:14 +00:00
John Dennis Casey
f5cd6adbe7
Cleaning up errors I introduced with search-and-replace, and with marmalade scripting support. I'm marking marmalade support out for now, until I can get that stuff dragged back into the present.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165242 13f79535-47bb-0310-9956-ffa450edef68
2005-04-29 00:29:04 +00:00
John Dennis Casey
a58632b9dd
Renamed Plugin.java, AbstractPlugin.java, PluginExecutionRe(quest|sponse) PluginExecutionException to Mojo*
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165238 13f79535-47bb-0310-9956-ffa450edef68
2005-04-29 00:12:09 +00:00
John Dennis Casey
ab91b7f4c2
o Cleaned up field-level annotation support (especially descriptor extraction, generation, and building)
...
o Converted all "core" plugins (including maven-core-it-plugin) to use field-level annotations
o Removed generation of parameter descriptors for ${/#component.* param specifications.
o Added @readonly for parameters that cannot be overridden by user configuration (List override was dangerous here)
o Added validation against pom-derived configuration for @readonly parameters
o Fixed @parameter alias="" support...now configuration of the mojo instance actually will work with either the real param name or the alias. Would be nice to support multiple aliases, but that might require @alias annotations...
o Added [temporary?] support for null editable attributes for parameters, to support pre-built mojos from the repo.
Annotation support should be just about ready to go...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165224 13f79535-47bb-0310-9956-ffa450edef68
2005-04-28 23:05:01 +00:00
Brett Leslie Porter
23ec733870
don't create dummy configuration for components
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165171 13f79535-47bb-0310-9956-ffa450edef68
2005-04-28 17:56:04 +00:00
Brett Leslie Porter
092c9b2423
fix typo in exclusion list
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@165074 13f79535-47bb-0310-9956-ffa450edef68
2005-04-28 00:42:33 +00:00
Brett Leslie Porter
3760f873a1
PR: MNG-167
...
Add the ability for a mojo to "fork" a phase execution, in a separate iteration of the lifecycle.
Add @executePhase generate-sources to idea:idea
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@164930 13f79535-47bb-0310-9956-ffa450edef68
2005-04-27 01:16:06 +00:00