Commit Graph

1670 Commits

Author SHA1 Message Date
Benjamin Bentmann b16942f162 o Fixed validation to happen ahead of project construction as this depends on proper repository information
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778411 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 12:43:40 +00:00
Benjamin Bentmann dbe356a8e6 o Generified code
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778408 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 12:39:30 +00:00
Benjamin Bentmann 9944592242 o Extended model validator to recognize two different validation levels to account for our different needs during local builds and metadata retrieval
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778404 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 12:22:32 +00:00
Benjamin Bentmann c063424f0a o Fixed repository mirroring
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778386 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 11:02:32 +00:00
Benjamin Bentmann 170eaca464 o Fixed test to account for fixed handling of optional dependencies
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778385 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 11:02:02 +00:00
Benjamin Bentmann 1bf3219293 o Removed unused imports
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778384 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 11:01:26 +00:00
Benjamin Bentmann 0e5b8e2bf3 o Fixed handling of optional dependencies
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778344 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 08:10:18 +00:00
Jason van Zyl 5b76c2c495 o created an execution plan which currently contains the mojos that will be executed and the phase of dependency resolution required, if needed
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778284 13f79535-47bb-0310-9956-ffa450edef68
2009-05-25 05:26:27 +00:00
Benjamin Bentmann c3f3d4c30c o Fixed plugin version resolution to consider plugin management, too
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778242 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 21:47:17 +00:00
Benjamin Bentmann c7461bf048 o Fixed resolution of system dependencies
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778223 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 20:41:14 +00:00
Benjamin Bentmann 1e35b2784e [MNG-2097] adding a phase called prepare-package
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778201 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 17:58:44 +00:00
Benjamin Bentmann c8151318c2 o Fixed processing of parameter aliases
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778197 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 17:39:34 +00:00
Benjamin Bentmann 88fc18ab6f o Fixed configuration for direct invocation of goals
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778173 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 15:13:55 +00:00
Benjamin Bentmann 9f4dcc0c53 o Fixed plugin validator to consider only the first plugin descriptor
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778142 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 13:17:47 +00:00
Benjamin Bentmann ca51f586cd o Improved error message
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778138 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 13:14:10 +00:00
Benjamin Bentmann 49b8b62ef1 o Fixed parent resolution from settings' repositories
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778127 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 12:12:38 +00:00
Benjamin Bentmann a2170b03c6 o Prevented NPEs in downstream code
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@778126 13f79535-47bb-0310-9956-ffa450edef68
2009-05-24 12:11:07 +00:00
Benjamin Bentmann 4bd0aad1dc o Deleted old profile matches
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777989 13f79535-47bb-0310-9956-ffa450edef68
2009-05-23 19:05:00 +00:00
Benjamin Bentmann ff7d13487d o Used more descriptive name for component
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777965 13f79535-47bb-0310-9956-ffa450edef68
2009-05-23 17:08:57 +00:00
Benjamin Bentmann c3f9346b47 o Introduced ProfileSelector component which will replace the profile manager (the new component is stateless and focuses on the task to determine the active profiles from a given input collection). The long term goal is to use the project builder configuration as the profile activation context as this holds basically all the bits required for profile activators.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777961 13f79535-47bb-0310-9956-ffa450edef68
2009-05-23 16:52:48 +00:00
Benjamin Bentmann ba57376e69 o Prevented NPEs in downstream code
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777957 13f79535-47bb-0310-9956-ffa450edef68
2009-05-23 16:37:46 +00:00
Jason van Zyl 677a6b59d6 o get rid of dead code
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777553 13f79535-47bb-0310-9956-ffa450edef68
2009-05-22 14:52:30 +00:00
Jason van Zyl 44c864a463 o workspace tests
Submitted by: Igor Fedorenko

git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777301 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 22:41:39 +00:00
Jason van Zyl b54a1b781b o large patch to rework the chained local repository implementations necessary for efficient reactor and IDE workspace resolution
Submitted by: Igor Fedorenko

I've asked Igor to fill out and send in a CLA and I will put him on the Sonatype CCLA



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777298 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 22:35:29 +00:00
Benjamin Bentmann 503cc60cc5 o Fixed explicit profile deactivation
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777246 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:34:33 +00:00
Benjamin Bentmann 40f654d529 o Added generics
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777242 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:26:51 +00:00
Benjamin Bentmann b2a3374ac6 o Added note about need to tighten model validator with regard to plugin version
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777240 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:14:26 +00:00
Jason van Zyl 48eb55f658 o project with plugin level configuration only
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777239 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 20:14:22 +00:00
Jason van Zyl e4d52d6c28 o missing classes
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777234 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 19:54:27 +00:00
Jason van Zyl a06ce9250d o fix for testitMNG4091_InvalidDescriptor(org.apache.maven.it.MavenITmng4091BadPluginDescriptorTest)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777230 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 19:42:11 +00:00
Benjamin Bentmann 6fe1debb60 o Fixed NPE in case of direct goal invocations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777228 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 19:24:32 +00:00
Benjamin Bentmann efb59873a5 [MNG-4129] Execution's inherited is not working as expected.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777205 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 18:19:22 +00:00
Jason van Zyl aaf01a7495 o another point about merging in the default plugin configuration
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777175 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:58:51 +00:00
Jason van Zyl b6cc908615 o notes on dealing with CLI invocations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777173 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:56:35 +00:00
Jason van Zyl fde34e8384 o get rid of extraneous goal matching
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777171 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:46:19 +00:00
Benjamin Bentmann b6d356acab o Removed dead code
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777167 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:25:27 +00:00
Jason van Zyl 9af145d0a7 o take the plugin update registry out of the lifecycle mapping for plugins
o change the way mojo executions are processed and match up the executions when extracting configuration
o give mojo executions originating from the CLI the "default-<goal>" execution id



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777166 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:18:53 +00:00
Benjamin Bentmann cad43e6b56 o Fixed precedence of plugin groups (request > settings > defaults)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777165 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:17:15 +00:00
Benjamin Bentmann 5eb52b5dee o Prevented duplicates
o Made execution request more robust with regard to NPEs


git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777163 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 16:04:57 +00:00
Benjamin Bentmann add87f5f56 o Ensured we eventually work with absolute paths
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777134 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 14:37:03 +00:00
Jason van Zyl 9aae6eaa67 o using mojo executions as the placeholders in the lifecycle instead of string representations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777120 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 14:00:34 +00:00
Benjamin Bentmann a7cbcb7b39 o Fixed ClassCastException
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777112 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 13:25:41 +00:00
Jason van Zyl 9024112b87 o adding test with multiple executions
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@777100 13f79535-47bb-0310-9956-ffa450edef68
2009-05-21 12:56:07 +00:00
Jason van Zyl 9efd21d0c9 o restoring several backward compat fixes all the way back to 2.0 ...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776895 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 23:28:39 +00:00
Jason van Zyl 397dc841a7 o have the build plan take into consideration multiple tasks, so the calculation of the build plan can take in any number lifecycle phases, or individual goals and you will get the fully fleshed out configurations
o one thing that's apparent is that it is not possible to only collect the metadata about the plugins that will execute. if the plugin.xml files were actually available in the repository outside of the plugin's JAR then the calculation could be made without having to crack open the JAR. i can't have a real plan per se when i have to grab the plugin JAR anywhere to open it and get the metadata. ideally someone should be able to see the build plan and optimize it and if plugins were removed they those will never have a requirement of being downloaded. Deploying the plugin metadata along side the plugin as an attached artifact or indexing the information and made available for querying would be very useful.

o now that the build plan is calculated and the project dependencies downloading has been decoupled from the plugin manager i can make a proper analysis of all he dependencies for all the project and start making optimized requests for downloading



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776690 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 13:23:56 +00:00
Jason van Zyl 8637701384 o don't need to store plugins
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776561 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 05:27:18 +00:00
Jason van Zyl d5459955f5 o put the plugin groups in the front-end request populator, the magic plugin groups are no longer buried in the core. could still be
moved from the code in the populator to a configuration file in the maven installation.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776556 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 05:16:09 +00:00
Jason van Zyl 9dfca575c7 o clean lifecycle is handled by defaults populator
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776540 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 04:25:59 +00:00
Jason van Zyl ed8dbbdc8d o test component implementations
git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776531 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 03:29:03 +00:00
Jason van Zyl 9be598d351 o injecting the metadata sources results in having to do some trickery to break the circular dependency between the components, this
is visible now in the metadata source which shows we need to do some work there as circular deps are pretty sure sign of poor design
o the ProjectClasspathTest has little stub components so I'm not even sure if it's a decent test but it requires a bunch of custom
  implementations as i tried to get rid of the hand written descriptor and have only annotated tests implementations but somewhere
  an incorrect implementations is being injected.

I'll work on breaking the circular dependency and we need a nicer way to inject test implementations, the way the Module works in
Guice is the way to go. We'll bridge the gap until we can switch over to Guice.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/branches/MNG-2766@776529 13f79535-47bb-0310-9956-ffa450edef68
2009-05-20 03:26:51 +00:00