Commit Graph

1210 Commits

Author SHA1 Message Date
John Dennis Casey fbb4833982 Cleaning up reporting some more.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604750 13f79535-47bb-0310-9956-ffa450edef68
2007-12-17 00:15:21 +00:00
John Dennis Casey b511c734a6 Fixing issues with reports used from the site plugin, where the reports' classloaders had been disconnected from the project/core parent realms, and so couldn't use maven libraries.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604685 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 20:09:43 +00:00
John Dennis Casey fa0cce4fdb Fixing case where pluginRealm == projectRealm to avoid setting parent realm == null. This would happen whenever the lifecycle forked, for instance, and would result in weird container classes not being found.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604643 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 16:11:18 +00:00
John Dennis Casey 45729dcafc Improving binding for PluginParameterException report.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604642 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 16:10:21 +00:00
John Dennis Casey 10a192dfc2 fixing error reporting for when pom file is missing, and adding deprecated-mojo and deprecated-mojo-param warnings.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604538 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 01:28:17 +00:00
John Dennis Casey 5159c0b4b6 Error reporting works properly now.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604401 13f79535-47bb-0310-9956-ffa450edef68
2007-12-15 08:17:21 +00:00
John Dennis Casey fe523d1151 Basic error reporting (tips aren't available for everything yet) is complete for everything the CLI typically handles directly.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603779 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 23:40:49 +00:00
John Dennis Casey 147f00077b Fixing broken tests.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603455 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 04:17:58 +00:00
John Dennis Casey 441b096e79 Mapping in most of the rest of the maven-core errors to the error reporter...just need to finish the ExtensionManagerException mappings, then write error reports for the new mappings from today, and we should be in good shape.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603431 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 00:52:26 +00:00
John Dennis Casey 3e081b677a Fixing the legacy lifecycle mappings back to compatibility with 2.0.x in terms of classname, then mapping them back to a field in the lifecycle executor so the enforcer plugin continues to function.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602972 13f79535-47bb-0310-9956-ffa450edef68
2007-12-10 17:22:33 +00:00
John Dennis Casey 1328959dca Working on the compat aspect, and changing the DefaultMaven class to implement LogEnabled directly so I can grab the logger instance inside the compat aspect...AbstractLogEnabled is beyond the grasp of this aspect.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602610 13f79535-47bb-0310-9956-ffa450edef68
2007-12-09 02:09:44 +00:00
John Dennis Casey a104251412 Fixing debug message that snuck in as info log-level.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602156 13f79535-47bb-0310-9956-ffa450edef68
2007-12-07 17:15:58 +00:00
John Dennis Casey b38e6e2fad Fixing compat aspect in cases where the Set being passed in is unmodifiable.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@601161 13f79535-47bb-0310-9956-ffa450edef68
2007-12-05 00:05:00 +00:00
John Dennis Casey 103a85a02b Fixing plugins-as-extensions when brought in from pluginManagement to a module-project's build. Unit test included.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@601013 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 17:22:28 +00:00
John Dennis Casey 1db3b755ab Fixing problem with new extensions manager code where custom lifecycle definitions are not used in build planning. Unit tests included.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@600792 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 04:32:13 +00:00
John Dennis Casey f55eb07bda Adding unit tests for plugin-as-extension in the extension scanner, cleaning up an unneeded call to registerWagons() (controlled by active collection now), and cleaning up a sysout in the embedder unit test.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599707 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 07:11:00 +00:00
John Dennis Casey 2ec256bab6 Removing pluginRepository use (finally), and fixing pluginGroups usage with profiles from the settings and super-POM without an accompanying pom.xml in the project directory...I know, something of a convoluted case.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599692 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 04:26:58 +00:00
John Dennis Casey b61bb393a8 Cleaning up error reporting some for project building, and attempting to make the error reporter instances propagate to the aspects binding them to the error sources.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599503 13f79535-47bb-0310-9956-ffa450edef68
2007-11-29 16:33:57 +00:00
John Dennis Casey 9732014c53 Fixing case where parent pom has pluginManagement, child does not refer to the plugin, and plugin is used directly on the command line...version from parent-pom pluginManagement should be used. Test case to follow.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599338 13f79535-47bb-0310-9956-ffa450edef68
2007-11-29 08:42:38 +00:00
John Dennis Casey 941a11381c Adding aspect-bound error reporting for BuildFailureException descendants.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@598900 13f79535-47bb-0310-9956-ffa450edef68
2007-11-28 08:11:49 +00:00
John Dennis Casey 249af52bb5 Wiring plugin-as-extension back into the new extension scanning stuff.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@598720 13f79535-47bb-0310-9956-ffa450edef68
2007-11-27 17:59:22 +00:00
Milos Kleint deca7349ff add maven-toolchain to the list of default excludes. necessary for proper retrieval from MavenSession's plugin context.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@597154 13f79535-47bb-0310-9956-ffa450edef68
2007-11-21 17:40:39 +00:00
John Dennis Casey 5fc3d35ce0 Removing maven-build-context, and replacing it with caching aspects for model-lineage stuff and project instances. Still needs caching for artifact resolution, and I have an aspect for this too, but it's not enabled yet, since it's still buggy.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@595215 13f79535-47bb-0310-9956-ffa450edef68
2007-11-15 05:37:55 +00:00
Vincent Siveton 643119482b o merged r594510 (fixed line size)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@594511 13f79535-47bb-0310-9956-ffa450edef68
2007-11-13 12:39:55 +00:00
Jason van Zyl 1a286e2325 o adding PomMetadataSource for the changes to maven-artifact
o adding in all the artifact handlers here as they are Maven specific and don't belong in maven-artifact


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593857 13f79535-47bb-0310-9956-ffa450edef68
2007-11-11 08:10:35 +00:00
John Dennis Casey 7fcf47aa8c formats.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593625 13f79535-47bb-0310-9956-ffa450edef68
2007-11-09 19:16:06 +00:00
John Dennis Casey 9c9bcde5f4 [MNG-3193] Adding pointcut and advice to provide backward compat on invalid lifecycle phase names (these bindings will be ignored).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593310 13f79535-47bb-0310-9956-ffa450edef68
2007-11-08 21:06:31 +00:00
John Dennis Casey 08947e7efb Working on cleaning up exceptions and reporting (these changes are from before the break I took to work on memory profiling in maven and plexus).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@593294 13f79535-47bb-0310-9956-ffa450edef68
2007-11-08 20:33:27 +00:00
John Dennis Casey ed568e725f Make reporting plugin configuration always used (even if mojo in question is not a report), as in 2.0.x
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@592949 13f79535-47bb-0310-9956-ffa450edef68
2007-11-07 23:28:45 +00:00
John Dennis Casey febce07c90 Adding more context information to existing exceptions, cleaning up construction in exceptions, and adjusting the inheritance hierarchy for exceptions to make them make a little more sense for error reporting. Also, adding improved (but not complete, yet) reporting for BuildFailureExceptions and ProjectBuildingExceptions, with some tests to make sure pertinent information is in the output.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@592859 13f79535-47bb-0310-9956-ffa450edef68
2007-11-07 19:24:30 +00:00
John Dennis Casey a1f995029a cleaning up NPE in the realm manager, and adding clear() method calls to the embedder to cleanup the realm manager after it's used, to try to keep the number of open realms to a minimum...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@592222 13f79535-47bb-0310-9956-ffa450edef68
2007-11-06 01:34:38 +00:00
Brian E Fox dbd357ffdf fixed windows test error
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@591922 13f79535-47bb-0310-9956-ffa450edef68
2007-11-05 09:08:40 +00:00
John Dennis Casey fe8c4071a6 Switching back to selectively import extensions into a project-specific ClassRealm, except this time extension realms will be shared (the origin of the aforementioned imports) to conserve memory tied up by classloading. Similarly, plugin realms are managed using a key produced from g🅰️v of the plugin, plus the hashcode of all g🅰️v of the plugin-level dependencies aggregated into one string, to distinguish the deploy plugin 2.0 with no deps from the deploy plugin 2.0 with a plugin-level dep on wagon-webdav. Plugin realms have their parent realms managed by the pluginManager now prior to lookup or execution of the mojo instance, and PluginDescriptor.(classRealm|artifacts) attributes are set for each execution. Likewise, the MavenPluginCollector now tracks plugin descriptors with their version information included, instead of just using g:a.
Had to bump the plexus-container-default version up to alpha-36 to fix a problem in ClassicSingletonComponentManager. All realms for extensions, plugins, and projects (which contain only imports from extensions) are now managed by the MavenRealmManager.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@591391 13f79535-47bb-0310-9956-ffa450edef68
2007-11-02 16:44:00 +00:00
John Dennis Casey f87308819f Bake compat-aspect weaving into the build for all profiles, to alleviate problems with the non-standard embedder creation.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@590803 13f79535-47bb-0310-9956-ffa450edef68
2007-10-31 19:52:38 +00:00
John Dennis Casey 27698689a8 Adding compat trailer to the maven version when it's printed via the cli.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@590758 13f79535-47bb-0310-9956-ffa450edef68
2007-10-31 17:26:37 +00:00
John Dennis Casey a1510ba220 Adding compat aspect to maven-core to give one-stop-shopping for backward compatibility measures and reduce pollution in main codebase.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@589908 13f79535-47bb-0310-9956-ffa450edef68
2007-10-29 23:31:27 +00:00
John Dennis Casey 00a1edc008 disable project-specific loading of extensions and plugins until we can figure out how to do it without causing OOME's.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@589904 13f79535-47bb-0310-9956-ffa450edef68
2007-10-29 23:15:23 +00:00
John Dennis Casey b97533f845 Fix Maven/DefaultMaven method signatures, push projectSessions map into request.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@589822 13f79535-47bb-0310-9956-ffa450edef68
2007-10-29 19:42:33 +00:00
John Dennis Casey 4f44eaddf3 Restoring ability to use webdav wagon by fixing WagonManager's use of new active collections in the container, and fixing the active collections to scan descendant realms for qualifying components.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588777 13f79535-47bb-0310-9956-ffa450edef68
2007-10-26 20:57:39 +00:00
John Dennis Casey bcb1ebe0e0 use managed versions when resolving project dependencies from the plugin manager before executing a mojo, and include system path in system-scoped artifacts within the managed version map.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588326 13f79535-47bb-0310-9956-ffa450edef68
2007-10-25 19:58:14 +00:00
John Dennis Casey b0cc7be1ac Improving the use of project sessions in the embedder, and exporting control over the project session map to the embedder instead of Maven.execute().
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588144 13f79535-47bb-0310-9956-ffa450edef68
2007-10-25 05:13:22 +00:00
John Dennis Casey b11111f75a Adding a couple unit tests for the project-level session, and fixing potential NPE when an extension is declared that already exists in the core distribution.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588136 13f79535-47bb-0310-9956-ffa450edef68
2007-10-25 04:04:04 +00:00
John Dennis Casey f4a9342c7f Exclusion for plexus-component-api on plexus-interactivity-api.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588110 13f79535-47bb-0310-9956-ffa450edef68
2007-10-25 01:51:17 +00:00
Carlos Sanchez Gonzalez 7ac246fd96 Store the pom File object in the execution request instead of its path, fix possible null values
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588058 13f79535-47bb-0310-9956-ffa450edef68
2007-10-24 22:24:45 +00:00
Carlos Sanchez Gonzalez 3571f9e2ac Do not return null collections, makes life easier for clients
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588053 13f79535-47bb-0310-9956-ffa450edef68
2007-10-24 22:08:01 +00:00
John Dennis Casey 9d94f8d310 Fixing NPE in execution request. Apparently, bootstrap was not run after these were changed.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588034 13f79535-47bb-0310-9956-ffa450edef68
2007-10-24 21:23:48 +00:00
John Dennis Casey 16c064c4bc Cleaning up extension and plugin realms for a project once the build completes.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@588029 13f79535-47bb-0310-9956-ffa450edef68
2007-10-24 21:14:27 +00:00
Carlos Sanchez Gonzalez 0d161a73a4 Store the pom File object in the execution request instead of its path
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587999 13f79535-47bb-0310-9956-ffa450edef68
2007-10-24 20:07:15 +00:00
Carlos Sanchez Gonzalez 990e9e880e Remove maven-monitor merged into maven-core
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587785 13f79535-47bb-0310-9956-ffa450edef68
2007-10-24 04:58:37 +00:00
Carlos Sanchez Gonzalez fa482c9b61 Remove maven-plugin-descriptor merged into maven-plugin-api
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587783 13f79535-47bb-0310-9956-ffa450edef68
2007-10-24 04:52:24 +00:00
John Dennis Casey 7c1b32bfc0 Cleanup the discovery realm/world after new extension components are found.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587690 13f79535-47bb-0310-9956-ffa450edef68
2007-10-23 23:14:28 +00:00
Jason van Zyl 7f8b8699a5 o for milos' test i am now adding the component to the container programmatically so we don't need to manually stuff an artifact handler into
the artifact handler manager


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587648 13f79535-47bb-0310-9956-ffa450edef68
2007-10-23 20:33:10 +00:00
Jason van Zyl def0ed7957 o use released version of plexus
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587419 13f79535-47bb-0310-9956-ffa450edef68
2007-10-23 08:23:35 +00:00
Carlos Sanchez Gonzalez cb5debaec2 Use new group for the reporting-api
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587275 13f79535-47bb-0310-9956-ffa450edef68
2007-10-22 21:58:14 +00:00
Jason van Zyl 60f9555333 o use the programmatic setup of the container
o use the new active collections in Pleuxus


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@587015 13f79535-47bb-0310-9956-ffa450edef68
2007-10-22 07:07:29 +00:00
Carlos Sanchez Gonzalez bd743a5c30 Rolling back last workaround, files must not be locked, test is right and code needs to be fixed
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586566 13f79535-47bb-0310-9956-ffa450edef68
2007-10-19 18:15:44 +00:00
Carlos Sanchez Gonzalez df8a7c75b9 Add missing super.tearDown, and ignore problem in windows where file is locked for deletion (needs investigation)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586564 13f79535-47bb-0310-9956-ffa450edef68
2007-10-19 18:06:48 +00:00
John Dennis Casey 38552dc100 shorter name may help more here?
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586544 13f79535-47bb-0310-9956-ffa450edef68
2007-10-19 17:13:57 +00:00
John Dennis Casey 0d32e6cc4a some documentation for new extension and project-level session stuff, and trying a fix for the extension manager test that may help things on windows where forceDelete(..) fails.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586543 13f79535-47bb-0310-9956-ffa450edef68
2007-10-19 17:13:20 +00:00
John Dennis Casey 4aeb99b92b Plugins now load per-project, which means they can have different plugin-level dependencies and configurations per-project, even if they're running in the same reactor.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586515 13f79535-47bb-0310-9956-ffa450edef68
2007-10-19 16:02:31 +00:00
Carlos Sanchez Gonzalez 2603a87757 Upgrade plexus-interactivity-api to prevent clashes with old groupIds
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586235 13f79535-47bb-0310-9956-ffa450edef68
2007-10-19 02:42:18 +00:00
John Dennis Casey 2ba9bbfd23 Fixing it0112 and it0115, and cleaning up extension isolation further. Also, adding a flag to tell whether an accompanying profiles.xml file is valid for any given POM file...when loaded from a repository (or stubbed), this flag should always be false.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586061 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 18:38:06 +00:00
Jason van Zyl 3979ed47d3 o removing jdom from the core for the embedder and we will soon have a different tool for writing out POMs, trying to slim
down the core


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@586044 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 18:05:59 +00:00
Herve Boutemy eecea0895e [MNG-2254] support XML file encoding when reading/writing settings and pom files
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@585265 13f79535-47bb-0310-9956-ffa450edef68
2007-10-16 21:26:43 +00:00
John Dennis Casey 89510079bb Adding a unit test for the extension loading (not testing isolation of the extension yet, though).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@585249 13f79535-47bb-0310-9956-ffa450edef68
2007-10-16 20:15:40 +00:00
John Dennis Casey ac8ff20611 Adding project-level ClassRealm, which serves as a nexus for extensions. Extensions are loaded into separate ClassRealm instances, then scanned for components. These ComponentDescriptors are then used to add an import from the extension realm back to the project-session realm, and then the descriptor is added to the container with the project realm as its RealmId. From here, the registerWagons() method has been changed to use the map of projectSessions, and iterates through each project-level realm, setting the lookup-realm, then calling findAndRegisterWagons(..) for each. Also, the plugin manager has been changed to use the project-realm for loading plugins if it exists (the plugin realm becomes a child of the project realm, which should allow plugins to vary by project within a single reactor, though I haven't tested that yet).
Also, shading the embedder to hide the jdom classes, and adjusting the assembly appropriately.

Final thing: I'm rolling back some changes I accidentally made to the CLIManager the other day, which breaks the release plugin because the long options were removed for some reason (save action in Eclipse; don't ask).


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@585012 13f79535-47bb-0310-9956-ffa450edef68
2007-10-16 02:59:05 +00:00
John Dennis Casey 0d0f7396b2 Cleaning up exception wrapping to allow better reporting of errors to end users. Also implementing the beginnings of a new error reporter, and bumping the version of plexus-container-default up to 1.0-alpha-33-SNAPSHOT to improve the accessibility to ClassRealm info for ComponentLookupException.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@584343 13f79535-47bb-0310-9956-ffa450edef68
2007-10-13 00:10:29 +00:00
John Dennis Casey dc6e7c8368 [MNG-3194] Fixing logging problems, but error diagnosis is still missing from CLI version of things...this should probably be replaced and/or restored. I'll commit unit tests for 3194 next.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@583314 13f79535-47bb-0310-9956-ffa450edef68
2007-10-09 22:28:02 +00:00
Jason van Zyl 112e69aa0e o adjusting the request to hold the upfront repositories that can be taken out of profiles
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@582071 13f79535-47bb-0310-9956-ffa450edef68
2007-10-05 04:03:10 +00:00
Jason van Zyl e6a6476ad7 o cleaning up the project builder, deprecating maven 1.x repository support, it will be 3 years by the time this is actually released
so tough noogies for people still trying to use Maven 1.x repositories with Maven 2.x.

  The next series of refactoring I will be doing with GIT.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@580609 13f79535-47bb-0310-9956-ffa450edef68
2007-09-29 17:25:19 +00:00
Brett Leslie Porter 63c8806450 handle a missing ~/.m2/settings.xml more gracefully
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@578641 13f79535-47bb-0310-9956-ffa450edef68
2007-09-24 04:01:44 +00:00
Jason van Zyl bf8d692a15 o reverting fix for MNG-1323, breaks trunk horribly when everything is clean. I ran the ITs after Piotr did but doing so with everything clean doesn't work. Time for Hudson.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@578582 13f79535-47bb-0310-9956-ffa450edef68
2007-09-23 16:57:46 +00:00
John Dennis Casey 21f1be77ff Allowing project-less builds...removing requiresProject.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@576603 13f79535-47bb-0310-9956-ffa450edef68
2007-09-17 22:05:54 +00:00
Brett Leslie Porter bd76a1966e [MNG-1323] remove bad import introduced in last commit
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@576019 13f79535-47bb-0310-9956-ffa450edef68
2007-09-16 01:25:25 +00:00
Jason van Zyl 2017c78e0a MNG-1323 making extensions work inside a reactor
Submitted by: Piotr Tabor


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@575987 13f79535-47bb-0310-9956-ffa450edef68
2007-09-15 21:28:38 +00:00
John Dennis Casey 84f0cdabdb [MNG-2878] Adding an import from the maven core classrealm into the plugin classrealm, to allow retrieval of default-report.xml using getClass().getResourceAsStream(..) which is used in maven-reporting-impl 2.0...which in turn is used from checkstyle (at least).
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@574392 13f79535-47bb-0310-9956-ffa450edef68
2007-09-10 22:34:28 +00:00
John Dennis Casey b1159725a5 fixing formats at top of file (may be other formatting changes...)
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@574387 13f79535-47bb-0310-9956-ffa450edef68
2007-09-10 22:20:31 +00:00
Jason van Zyl a05e9f9884 o we don't need to run processProjectLogic on the super pom but we do need to make sure the plugin repositories are populated
for plugins like archetype which have no POM to start with but need repositories.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573736 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 22:29:34 +00:00
Jason van Zyl d72b8bc88a o put the profile manager back into place as the project build is exposed in a ton of plugin. arrrg.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573718 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 21:29:08 +00:00
Jason van Zyl e9b6657f4c o scrub of the settings building, was able to reduce to the need of the build context and use the execution request
directly. eventually i will get it to be the session, along with the profile tools, then all the tools can also 
  share a common interpolator, which can then be shared by other components instead of having 5 interpolators lying
  around causing a great deal of inconsistency.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573494 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 07:54:11 +00:00
Jason van Zyl 28ac7d65cb o remove dead method, the embedder now takes care of all defaulting so we don't need this method anymore.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573478 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 06:42:31 +00:00
Jason van Zyl 357015041a o let the parsing exception surface
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573476 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 06:36:53 +00:00
Jason van Zyl a0439b3e05 o remove dead code, this is being done elsewhere and has been for a while
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573472 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 06:17:55 +00:00
Jason van Zyl 9c8903441f o profiles are now decoupled from settings. so that i don't do this is one huge commit i need to move settings stuff into the core
while i transform the settings components to take a MavenSession. Any component executing within Maven should be able to use
  a session. the session will contain everything required and any new component added to the system should only take the 
  session as a parameter. same pattern for all components. that's the goal. it will take a few hops.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573462 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 05:25:49 +00:00
Jason van Zyl beb0ab7d9a o removing deprecated methods
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573437 13f79535-47bb-0310-9956-ffa450edef68
2007-09-07 03:49:48 +00:00
Jason van Zyl 99bd5ac68f o trying to get a grasp of the entire profile mechanism, especially in relation to how they deal with repositories.
here i am just collecting all the profile code into one place as it's scattered over several packages and is
  hard to determine what the profile system as a whole is doing. the first task i would like to do is decouple
  the profile system from the Settings. this can be done at the front-end i.e the profile information from Settings
  can be fed into the profile manager up front.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573325 13f79535-47bb-0310-9956-ffa450edef68
2007-09-06 17:09:36 +00:00
Jason van Zyl 02d205134b o this is in the embedder module now
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@573089 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 22:50:17 +00:00
Jason van Zyl c1f56fc847 o cleaning up more dead code in the hunt for "why the release plugin doesn't work again"
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572877 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 05:30:26 +00:00
Jason van Zyl 4925ac9702 o removing deprecated code in the plugin mechanism
o removing dead code
o examining how plugin version resolution is done, and we have a mix of a desire to use snapshots locally and pull releases
  remotely. if the repositories are mixed a snapshot will be pull automagically. this doesn't happen in practice but snapshots
  for plugin versions should be limited to a local search only.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572872 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 04:38:49 +00:00
Jason van Zyl 8077fb59ac o Why would a plugin be executing in its own POM. I think this is a far out case and you shouldn't be testing your plugin with its own POM. The comment is "I guess...". I don't think this is right.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572868 13f79535-47bb-0310-9956-ffa450edef68
2007-09-05 03:44:55 +00:00
Jason van Zyl aaaed9cf00 o i'm reworking the error reporting mechanism. i am going to concretely deal with each error we can come up with instead of
the generalization we have.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572463 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 00:34:08 +00:00
Jason van Zyl ae1501b9f6 o collecting all logging/eventing into the core. i posted a list of possible errors that can occur in the core, the stuff we had was only
partially being use and we problems being emitted with messages like:

  NOTE: One or more purely derived expression elements were detected in this expression. 
  If you continue to get this error after any other expression elements are specified correctly
  please report this issue to the Maven development team.

  I think we have to make a very concerted effort to make useful messages because I'm tired of standing behind Maven
  users and being embarrassed when they look at me and ask "what does that mean?". "i actually have no idea."


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572456 13f79535-47bb-0310-9956-ffa450edef68
2007-09-04 00:05:04 +00:00
Jason van Zyl 2a241710f0 MNG-3182
MNG-3183

First cleanup of the logging code (it is still a mess), but all the console logging has been removed from the Maven component and pushed back
into the CLI code. As a result we now have a way to log to a file easily.



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572408 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 19:33:10 +00:00
Jason van Zyl 441b918f80 o try and start localizing the handling of -f, release poms, and normal poms to the embedder. just too much funk
going on in the core.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572388 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 16:52:37 +00:00
Jason van Zyl cc1ca10d74 o separating out the MavenEmbedderProjectWithExtensionReadingTest which shows that the artifacts handlers must be loaded up-front
in the readProjectWithDependencies method because it is not being done in the core unless projects are executed. So Milos' assertion
  is correct. I'm now looking at a layered approach for project resolution and then execution so that the readProjectWithDependencies
  (which is essential for IDE integration) will yield something that can be pushed into the lifecycle executor. Right now there
  is much duplication which makes the IDE integration crappy.

  Another result of this is trying to create a simple IDE import model that gives back client code the fully resolved, topo sorted
  set of projects which point to binary dependencies outside the reactor, and to source folders inside the reactor. The result will
  be a useful model for all IDE integration, right now everyone is doing their own thing. This model will need hooks for customization
  to take into account turning "workspace resolution" on/off and allow easy overriding of this process.

o Fixed IT0035



git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572366 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 15:42:29 +00:00
Jason van Zyl 08ed903945 MNG-1922: Making sure that CLI properties are processed first
o fixing IT0039


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572229 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 03:56:31 +00:00
Jason van Zyl 2425f945fb o adding a validation method to the lifecycle executor so that I can tell users what is wrong before actually trying
to execute the lifecycle. Trying to do this validation shows in detail how tangled some of our code is as I need
  to create the dispatcher in order to create the session which is required to make the reactorManager which 
  is required to get the project required to validate the goal name ... yah.


git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572214 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 02:35:05 +00:00
Jason van Zyl 5380116b79 MNG-2398: the lifecycle executor exception wasn't being propagated properly.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572210 13f79535-47bb-0310-9956-ffa450edef68
2007-09-03 01:39:28 +00:00
Jason van Zyl ed5868ebc7 MNG-3176 Adding a method to create the reactor manager as I want to use it for execution as well as the buildWithDependencies method.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572029 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:51:03 +00:00
Jason van Zyl 43dcac45b6 o get the information about whether a project is present from the request as per MNG-3177
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@572023 13f79535-47bb-0310-9956-ffa450edef68
2007-09-02 16:43:20 +00:00