John Dennis Casey
c9d88e6ce3
Fixing formatting on transitive resolution error.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617663 13f79535-47bb-0310-9956-ffa450edef68
2008-02-01 21:44:10 +00:00
John Dennis Casey
f838337b7a
Refactor the artifact-scanning logic from the realm manager and the plugin-artifact resolution logic in the plugin manager into two separate classes, one a component and one a static class, to allow the new PluginPrefixLoader to reuse some of both and create a lighter-weight approach to grabbing the PluginDescriptor for build-planning purposes...also avoids some needless error messages during build planning.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617293 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 23:29:18 +00:00
John Dennis Casey
e670bd3ea3
Adding the concept of recommended stacktrace hints for reported errors, and add the ability to directly access the list of exceptions that actually hit the error reporter (instead of having to use MavenExecutionResult.getExceptions() in conjunction with findReportedException(..) to unwrap them.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@617178 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 18:17:05 +00:00
John Dennis Casey
b7ce1b8c93
Fixing the case where there were exceptions in the build, but for whatever reason they didn't trigger a reactor-manager build failure flag...in cases where there isn't really a project against which to log the error, for instance.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616968 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 00:36:26 +00:00
John Dennis Casey
6c103fff87
Adding the build-plan instance for each project to the session and MavenExecutionResponse.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@616824 13f79535-47bb-0310-9956-ffa450edef68
2008-01-30 18:11:50 +00:00
John Dennis Casey
ba9624676d
Cleanup use of repositories for resolving plugin dependencies by using a LinkedHashSet to avoid duplicated repository defs (although two defs pointing to the same URL but with different id's will still look like two repos).
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@615004 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 21:29:12 +00:00
John Dennis Casey
48db18c81b
Cleanup on pointcuts to make them slightly more efficient.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614756 13f79535-47bb-0310-9956-ffa450edef68
2008-01-24 00:33:24 +00:00
John Dennis Casey
268d08b8a3
[MNG-3372] Improve error handling where a mojo is referenced but the plugin doesn't contain it (in direct-invocation cases), and fix plugin-version discovery where a plugin pom gives a maven prereq.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614708 13f79535-47bb-0310-9956-ffa450edef68
2008-01-23 22:18:23 +00:00
John Dennis Casey
22e2b4ab35
Commenting out debug pointcut because it causes class sizes to balloon.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614620 13f79535-47bb-0310-9956-ffa450edef68
2008-01-23 18:54:20 +00:00
John Dennis Casey
8d42ef1ce3
Fixing error-reporting pointcut that I broke.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614342 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 22:01:57 +00:00
John Dennis Casey
a23ed648fd
adding basic bootstrapping instructions to the README.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614337 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:52:28 +00:00
John Dennis Casey
f2ea396212
Widening the pointcut to catch more potential places where plugin-loading could be a problem.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614330 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 21:33:50 +00:00
John Dennis Casey
8b762300ef
Improve diagnosis when no goals are passed in via the request (the goals List is null, not just empty). This can happen when used via the embedder in a non-cli scenario.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614319 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:52:11 +00:00
John Dennis Casey
6d0563662c
Improve error reporting bindings for two exception cases, to get away from handler(..) pointcuts which are less versatile for later debugging aspects to manipulate.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614317 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 20:50:16 +00:00
Vincent Siveton
309fadbdcc
o fixed duplicate license header
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@614084 13f79535-47bb-0310-9956-ffa450edef68
2008-01-22 01:26:47 +00:00
Milos Kleint
c8b4b7294c
the reactorpoms modules need to be checked recursively to satisfy this case:
...
parent --> submodule -->subsubmodule --> subsubsubmodule where parent defines a plugin with extensions in pluginManagement section and the subsubmodule is the one using the plugin.
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613662 13f79535-47bb-0310-9956-ffa450edef68
2008-01-20 19:54:09 +00:00
Milos Kleint
863d1fcb8c
when version is defined in plugin-management section, we need to use it in mojo binding.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613256 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 20:20:46 +00:00
John Dennis Casey
b731e783fa
Adding new unit test for non-recursive run, where one of the modules that should NOT be read contains an invalid parent reference.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613254 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 20:14:44 +00:00
John Dennis Casey
facb56d1eb
Fixing compilation errors.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613035 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 01:38:37 +00:00
John Dennis Casey
89f482ac37
last of the error-reporting unit tests, and an additional error type to handle modules that are referenced but don't exist, which should stop the build. All tests pass.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@613032 13f79535-47bb-0310-9956-ffa450edef68
2008-01-18 01:27:23 +00:00
John Dennis Casey
724b3db3c4
Adding more error-reporting unit tests.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612920 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 18:26:35 +00:00
John Dennis Casey
4bcfd7c5a5
more unit tests for error reporting on plugins-as-extensions.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612895 13f79535-47bb-0310-9956-ffa450edef68
2008-01-17 18:01:29 +00:00
John Dennis Casey
0c61152546
More unit tests, this time for plugin-related error messages.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612592 13f79535-47bb-0310-9956-ffa450edef68
2008-01-16 22:17:56 +00:00
John Dennis Casey
ca169d0262
Refactor management of activated, deactivated, and default-activated profile ids, so the context tracks all of that stuff.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@612186 13f79535-47bb-0310-9956-ffa450edef68
2008-01-15 18:34:58 +00:00
John Dennis Casey
6e230d611a
two more unit tests, and a little simplification to take care of duplicated error reporting coverage.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611974 13f79535-47bb-0310-9956-ffa450edef68
2008-01-14 23:59:01 +00:00
John Dennis Casey
c3983894ab
Adding more error-reporting fixes and unit tests.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611945 13f79535-47bb-0310-9956-ffa450edef68
2008-01-14 21:44:59 +00:00
Milos Kleint
e10f025310
Add Thread.getId() to the realm identification, a simple trick to make DefaultMavenRealmManager lifecycle safe for paralel execution.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611615 13f79535-47bb-0310-9956-ffa450edef68
2008-01-13 18:19:35 +00:00
Milos Kleint
fc244926ca
comment on multithreading.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611548 13f79535-47bb-0310-9956-ffa450edef68
2008-01-13 08:41:12 +00:00
John Dennis Casey
25460922d5
More unit tests for error-reporting pointcuts, and some minor adjustments for duplicated handler methods.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@611014 13f79535-47bb-0310-9956-ffa450edef68
2008-01-11 01:57:27 +00:00
John Dennis Casey
dc770e321b
Adding some unit tests (mostly stubbed out at the moment) to start testing the pointcuts used to shunt build errors off to the appropriate error-reporter method.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@610618 13f79535-47bb-0310-9956-ffa450edef68
2008-01-10 00:07:48 +00:00
Brian E Fox
c754ccad3a
MNG-2166: enhanced missing goal error info. (fix from 587339:587340 in 2.0.x)
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@609085 13f79535-47bb-0310-9956-ffa450edef68
2008-01-05 02:49:42 +00:00
John Dennis Casey
40c84ecb79
Fixing for windows users everywhere.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@605125 13f79535-47bb-0310-9956-ffa450edef68
2007-12-18 07:58:45 +00:00
John Dennis Casey
fe4363a4c5
Removing the build overlay, as it was causing problems with path translation, and doesn't serve any real purpose.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@605095 13f79535-47bb-0310-9956-ffa450edef68
2007-12-18 05:36:03 +00:00
John Dennis Casey
fbb4833982
Cleaning up reporting some more.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604750 13f79535-47bb-0310-9956-ffa450edef68
2007-12-17 00:15:21 +00:00
John Dennis Casey
b511c734a6
Fixing issues with reports used from the site plugin, where the reports' classloaders had been disconnected from the project/core parent realms, and so couldn't use maven libraries.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604685 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 20:09:43 +00:00
John Dennis Casey
fa0cce4fdb
Fixing case where pluginRealm == projectRealm to avoid setting parent realm == null. This would happen whenever the lifecycle forked, for instance, and would result in weird container classes not being found.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604643 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 16:11:18 +00:00
John Dennis Casey
45729dcafc
Improving binding for PluginParameterException report.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604642 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 16:10:21 +00:00
John Dennis Casey
10a192dfc2
fixing error reporting for when pom file is missing, and adding deprecated-mojo and deprecated-mojo-param warnings.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604538 13f79535-47bb-0310-9956-ffa450edef68
2007-12-16 01:28:17 +00:00
John Dennis Casey
5159c0b4b6
Error reporting works properly now.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@604401 13f79535-47bb-0310-9956-ffa450edef68
2007-12-15 08:17:21 +00:00
John Dennis Casey
fe523d1151
Basic error reporting (tips aren't available for everything yet) is complete for everything the CLI typically handles directly.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603779 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 23:40:49 +00:00
John Dennis Casey
147f00077b
Fixing broken tests.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603455 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 04:17:58 +00:00
John Dennis Casey
441b096e79
Mapping in most of the rest of the maven-core errors to the error reporter...just need to finish the ExtensionManagerException mappings, then write error reports for the new mappings from today, and we should be in good shape.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@603431 13f79535-47bb-0310-9956-ffa450edef68
2007-12-12 00:52:26 +00:00
John Dennis Casey
3e081b677a
Fixing the legacy lifecycle mappings back to compatibility with 2.0.x in terms of classname, then mapping them back to a field in the lifecycle executor so the enforcer plugin continues to function.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602972 13f79535-47bb-0310-9956-ffa450edef68
2007-12-10 17:22:33 +00:00
John Dennis Casey
1328959dca
Working on the compat aspect, and changing the DefaultMaven class to implement LogEnabled directly so I can grab the logger instance inside the compat aspect...AbstractLogEnabled is beyond the grasp of this aspect.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602610 13f79535-47bb-0310-9956-ffa450edef68
2007-12-09 02:09:44 +00:00
John Dennis Casey
a104251412
Fixing debug message that snuck in as info log-level.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@602156 13f79535-47bb-0310-9956-ffa450edef68
2007-12-07 17:15:58 +00:00
John Dennis Casey
b38e6e2fad
Fixing compat aspect in cases where the Set being passed in is unmodifiable.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@601161 13f79535-47bb-0310-9956-ffa450edef68
2007-12-05 00:05:00 +00:00
John Dennis Casey
103a85a02b
Fixing plugins-as-extensions when brought in from pluginManagement to a module-project's build. Unit test included.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@601013 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 17:22:28 +00:00
John Dennis Casey
1db3b755ab
Fixing problem with new extensions manager code where custom lifecycle definitions are not used in build planning. Unit tests included.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@600792 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 04:32:13 +00:00
John Dennis Casey
f55eb07bda
Adding unit tests for plugin-as-extension in the extension scanner, cleaning up an unneeded call to registerWagons() (controlled by active collection now), and cleaning up a sysout in the embedder unit test.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599707 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 07:11:00 +00:00
John Dennis Casey
2ec256bab6
Removing pluginRepository use (finally), and fixing pluginGroups usage with profiles from the settings and super-POM without an accompanying pom.xml in the project directory...I know, something of a convoluted case.
...
git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@599692 13f79535-47bb-0310-9956-ffa450edef68
2007-11-30 04:26:58 +00:00