Apache
/
nifi
mirror of https://github.com/apache/nifi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
nifi/.github/PULL_REQUEST_TEMPLATE.md

35 lines
2.0 KiB
Markdown
Raw Normal View History

NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
Thank you for submitting a contribution to Apache NiFi.
NIFI-6296 Improved PR template messaging around commit process.
2019-05-13 22:35:01 -04:00
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
NIFI-1615 Removing Apache License header and adding exclusion for Pull Request template for RAT check as we cannot provide comments without cluttering PR dialog. This closes #1103. Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 11:00:29 -04:00
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
in the commit message?
NIFI-6296 Improved PR template messaging around commit process.
2019-05-13 22:35:01 -04:00
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
NIFI-6296 Improved PR template messaging around commit process.
2019-05-13 22:35:01 -04:00
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
NIFI-6296 Improved PR template messaging around commit process.
2019-05-13 22:35:01 -04:00
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
### For code changes:
NIFI-6296 Improved PR template messaging around commit process.
2019-05-13 22:35:01 -04:00
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
NIFI-1615 Removing Apache License header and adding exclusion for Pull Request template for RAT check as we cannot provide comments without cluttering PR dialog. This closes #1103. Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 11:00:29 -04:00
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
NIFI-6296 Improved PR template messaging around commit process.
2019-05-13 22:35:01 -04:00
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
### For documentation related changes:
NIFI-1615 Removing Apache License header and adding exclusion for Pull Request template for RAT check as we cannot provide comments without cluttering PR dialog. This closes #1103. Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 11:00:29 -04:00
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
NIFI-1615 - Add GitHbub pull request template to address some of the reocurring PR mistakes Signed-off-by: Aldrin Piri <aldrin@apache.org>
2016-10-05 09:52:54 -04:00
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.