Apache
/
nifi
mirror of https://github.com/apache/nifi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NIFI-13692 Catch All Exceptions in ResizeImage (#9213) 

Widening the scope of caught Exceptions for routing to failure ensures that the Processor can catch pretty much everything a user could throw at this processor.

Signed-off-by: David Handermann <exceptionfactory@apache.org>
This commit is contained in:
Mike 2024-08-29 10:29:15 -04:00 committed by GitHub
parent 71face8ea7
commit 2fc0ca1b7b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nifi-extension-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/image/ResizeImage.java
View File

@ -23,7 +23,6 @@ import java.awt.Image;
import java.awt.Transparency; import java.awt.Transparency;
import java.awt.image.BufferedImage; import java.awt.image.BufferedImage;
import java.io.BufferedInputStream; import java.io.BufferedInputStream;
import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.OutputStream; import java.io.OutputStream;
import java.util.ArrayList; import java.util.ArrayList;
@ -169,7 +168,7 @@ public class ResizeImage extends AbstractProcessor {
reader.setInput(iis, true); reader.setInput(iis, true);
image = reader.read(0); image = reader.read(0);
} }
} catch (final IOException | RuntimeException ex) { } catch (final Exception ex) {
getLogger().error("Failed to read {} due to {}", flowFile, ex); getLogger().error("Failed to read {} due to {}", flowFile, ex);
session.transfer(flowFile, REL_FAILURE); session.transfer(flowFile, REL_FAILURE);
return; return;
@ -188,8 +187,8 @@ public class ResizeImage extends AbstractProcessor {
height = finalDimension.height; height = finalDimension.height;
} }
} catch (final NumberFormatException nfe) { } catch (final Exception e) {
getLogger().error("Failed to resize {} due to {}", flowFile, nfe); getLogger().error("Failed to resize {} due to {}", flowFile, e);
session.transfer(flowFile, REL_FAILURE); session.transfer(flowFile, REL_FAILURE);
return; return;
} }
@ -216,7 +215,7 @@ public class ResizeImage extends AbstractProcessor {
} }
ImageIO.write(scaledBufferedImg, formatName, out); ImageIO.write(scaledBufferedImg, formatName, out);
} catch (final IOException | NegativeArraySizeException ex) { } catch (final Exception ex) {
getLogger().error("Failed to write {} due to {}", flowFile, ex); getLogger().error("Failed to write {} due to {}", flowFile, ex);
session.transfer(flowFile, REL_FAILURE); session.transfer(flowFile, REL_FAILURE);
return; return;