NIFI-587 moved checkstyle into profile with rat plugin. They were too unstable

This commit is contained in:
joewitt 2015-05-05 00:59:28 -04:00
parent 37e5548ac1
commit 41b21af576
1 changed files with 21 additions and 11 deletions

View File

@ -259,14 +259,6 @@
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId> <artifactId>maven-checkstyle-plugin</artifactId>
<executions>
<execution>
<id>check-style</id>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration> <configuration>
<checkstyleRules> <checkstyleRules>
<module name="Checker"> <module name="Checker">
@ -377,9 +369,15 @@
</build> </build>
<profiles> <profiles>
<profile> <profile>
<!-- Automatically check for licenses. Too slow to always run. <!--
Activate with -P check-licenses --> Checks style and licensing requirements. This is a good idea to
<id>check-licenses</id> run for contributions and for the release process. While it
would be nice to run always these plugins can considerably slow
the build and have proven to create unstable builds in our
multi-module project and when building using multiple threads.
The stability issues seen with Checkstyle in multi-module builds
include false-positives and false negatives.-->
<id>contrib-check</id>
<build> <build>
<plugins> <plugins>
<plugin> <plugin>
@ -394,6 +392,18 @@
</execution> </execution>
</executions> </executions>
</plugin> </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<executions>
<execution>
<id>check-style</id>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins> </plugins>
</build> </build>
</profile> </profile>