From 548561ed4ca54cb655b072aa7536249da88b1abf Mon Sep 17 00:00:00 2001
From: Joshi <rekhajoshm@gmail.com>
Date: Thu, 16 Jun 2016 19:49:00 -0700
Subject: [PATCH] NIFI-1955: Deprecate IntegerHolder, LongHolder, BooleanHolder

This closes #537
---
 .../java/org/apache/nifi/util/BooleanHolder.java  | 12 ++++++++++++
 .../java/org/apache/nifi/util/IntegerHolder.java  | 15 ++++++++++++---
 .../java/org/apache/nifi/util/LongHolder.java     |  9 ++++++++-
 3 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/BooleanHolder.java b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/BooleanHolder.java
index 92061e0875..8283389a2a 100644
--- a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/BooleanHolder.java
+++ b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/BooleanHolder.java
@@ -16,6 +16,18 @@
  */
 package org.apache.nifi.util;
 
+import java.util.concurrent.atomic.AtomicBoolean;
+
+/**
+ * @deprecated As of release 1.0.1. Please use {@link AtomicBoolean}
+ *
+ * Wraps an Boolean value so that it can be declared <code>final</code> and still be accessed from inner classes;
+ * the functionality is similar to that of an AtomicBoolean, but operations on this class
+ * are not atomic. This results in greater performance when the atomicity is not needed.
+ *
+ */
+
+@Deprecated
 public class BooleanHolder extends ObjectHolder<Boolean> {
 
     public BooleanHolder(final boolean initialValue) {
diff --git a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/IntegerHolder.java b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/IntegerHolder.java
index 213bbc0443..8abfdb153f 100644
--- a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/IntegerHolder.java
+++ b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/IntegerHolder.java
@@ -16,6 +16,18 @@
  */
 package org.apache.nifi.util;
 
+import java.util.concurrent.atomic.AtomicInteger;
+
+/**
+ * @deprecated As of release 1.0.1. Please use {@link AtomicInteger}
+ *
+ * Wraps an Integer value so that it can be declared <code>final</code> and still be accessed from inner classes;
+ * the functionality is similar to that of an AtomicInteger, but operations on this class
+ * are not atomic. This results in greater performance when the atomicity is not needed.
+ *
+ */
+
+@Deprecated
 public class IntegerHolder extends ObjectHolder<Integer> {
 
     public IntegerHolder(final int initialValue) {
@@ -48,7 +60,4 @@ public class IntegerHolder extends ObjectHolder<Integer> {
         return addAndGet(-1);
     }
 
-    public int getAndDecrement() {
-        return getAndAdd(-1);
-    }
 }
diff --git a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/LongHolder.java b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/LongHolder.java
index fa2d06333d..723463a135 100644
--- a/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/LongHolder.java
+++ b/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/LongHolder.java
@@ -16,10 +16,17 @@
  */
 package org.apache.nifi.util;
 
+import java.util.concurrent.atomic.AtomicLong;
+
 /**
- * Wraps a Long value so that it can be declared <code>final</code> and still be accessed from which inner classes; the functionality is similar to that of an AtomicLong, but operations on this class
+ * @deprecated As of release 1.0.1. Please use {@link AtomicLong}
+ *
+ * Wraps a Long value so that it can be declared <code>final</code> and still be accessed from inner classes;
+ * the functionality is similar to that of an AtomicLong, but operations on this class
  * are not atomic. This results in greater performance when the atomicity is not needed.
  */
+
+@Deprecated
 public class LongHolder extends ObjectHolder<Long> {
 
     public LongHolder(final long initialValue) {