Apache
/
nifi
mirror of https://github.com/apache/nifi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NIFI-305: Cleaning up for extensibility; final methods

This commit is contained in:
gresockj 2015-01-29 17:11:56 -05:00
parent ad40903458
commit 615794e77f
1 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/BinFiles.java
View File

@ -106,7 +106,7 @@ public abstract class BinFiles extends AbstractSessionFactoryProcessor {
private final Queue<Bin> readyBins = new LinkedBlockingQueue<>();
@Override
protected void init(final ProcessorInitializationContext context) {
protected final void init(final ProcessorInitializationContext context) {
final Set<Relationship> relationships = new HashSet<>();
relationships.add(REL_ORIGINAL);
@ -133,7 +133,7 @@ public abstract class BinFiles extends AbstractSessionFactoryProcessor {
}
@OnStopped
public void resetState() {
public final void resetState() {
binManager.purge();
Bin bin;
@ -145,12 +145,12 @@ public abstract class BinFiles extends AbstractSessionFactoryProcessor {
}
@Override
public Set<Relationship> getRelationships() {
public final Set<Relationship> getRelationships() {
return relationships;
}
@Override
protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
protected final List<PropertyDescriptor> getSupportedPropertyDescriptors() {
return descriptors;
}
@ -222,8 +222,20 @@ public abstract class BinFiles extends AbstractSessionFactoryProcessor {
List<FlowFileSessionWrapper> binContents, ProcessContext context,
ProcessSession session, ProcessorLog logger) throws Exception;
/**
* Allows additional custom validation to be done. This will be called from
* the parent's customValidation method.
*
* @param context
* The context
* @return Validation results indicating problems
*/
protected Collection<ValidationResult> additionalCustomValidation(final ValidationContext context) {
return new ArrayList<ValidationResult>();
}
@Override
public void onTrigger(final ProcessContext context, final ProcessSessionFactory sessionFactory) throws ProcessException {
public final void onTrigger(final ProcessContext context, final ProcessSessionFactory sessionFactory) throws ProcessException {
int binsAdded = binFlowFiles(context, sessionFactory);
getLogger().debug("Binned {} FlowFiles", new Object[] {binsAdded});
@ -336,7 +348,7 @@ public abstract class BinFiles extends AbstractSessionFactoryProcessor {
}
@OnScheduled
public void onScheduled(final ProcessContext context) throws IOException {
public final void onScheduled(final ProcessContext context) throws IOException {
binManager.setMinimumSize(context.getProperty(MIN_SIZE).asDataSize(DataUnit.B).longValue());
if (context.getProperty(MAX_BIN_AGE).isSet() ) {
@ -363,7 +375,7 @@ public abstract class BinFiles extends AbstractSessionFactoryProcessor {
}
@Override
protected Collection<ValidationResult> customValidate(final ValidationContext context) {
protected final Collection<ValidationResult> customValidate(final ValidationContext context) {
final List<ValidationResult> problems = new ArrayList<>(super.customValidate(context));
final long minBytes = context.getProperty(MIN_SIZE).asDataSize(DataUnit.B).longValue();
@ -383,6 +395,11 @@ public abstract class BinFiles extends AbstractSessionFactoryProcessor {
}
}
Collection<ValidationResult> otherProblems = this.additionalCustomValidation(context);
if (otherProblems != null) {
problems.addAll(otherProblems);
}
return problems;
}
}