NIFI-289:

- Added logging when error conditions occur in UpdateAttribute REST endpoints.
This commit is contained in:
Matt Gilman 2015-02-02 14:02:24 -05:00
parent 600a47be16
commit 93b78a7dd5
1 changed files with 13 additions and 3 deletions

View File

@ -70,6 +70,8 @@ import com.sun.jersey.api.NotFoundException;
import org.apache.nifi.update.attributes.FlowFilePolicy;
import org.apache.nifi.update.attributes.entity.EvaluationContextEntity;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
*
@ -77,6 +79,8 @@ import org.apache.nifi.update.attributes.entity.EvaluationContextEntity;
@Path("/criteria")
public class RuleResource {
private static final Logger logger = LoggerFactory.getLogger(RuleResource.class);
@Context
private ServletContext servletContext;
@ -612,7 +616,9 @@ public class RuleResource {
} catch (final InvalidRevisionException ire) {
throw new WebApplicationException(invalidRevision(ire.getMessage()));
} catch (final Exception e) {
throw new WebApplicationException(error(e.getMessage()));
final String message = String.format("Unable to get UpdateAttribute[id=%s] criteria: %s", contextConfig.getProcessorId(), e);
logger.error(message, e);
throw new WebApplicationException(error(message));
}
Criteria criteria = null;
@ -620,7 +626,9 @@ public class RuleResource {
try {
criteria = CriteriaSerDe.deserialize(processorInfo.getAnnotationData());
} catch (final IllegalArgumentException iae) {
throw new WebApplicationException(error("Unable to load existing rules. Deserialization error: " + iae.getMessage()));
final String message = String.format("Unable to deserialize existing rules for UpdateAttribute[id=%s]. Deserialization error: %s", contextConfig.getProcessorId(), iae);
logger.error(message, iae);
throw new WebApplicationException(error(message));
}
}
// ensure the criteria isn't null
@ -644,7 +652,9 @@ public class RuleResource {
} catch (final InvalidRevisionException ire) {
throw new WebApplicationException(invalidRevision(ire.getMessage()));
} catch (final Exception e) {
throw new WebApplicationException(error(e.getMessage()));
final String message = String.format("Unable to save UpdateAttribute[id=%s] criteria: %s", contextConfig.getProcessorId(), e);
logger.error(message, e);
throw new WebApplicationException(error(message));
}
}