Apache/nifi
1
0
Fork 0
mirror of https://github.com/apache/nifi.git synced 2025-02-07 18:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

NIFI-4967 - CSVRecordReader does not read header with specific formats

Browse Source 
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #2536
This commit is contained in:
Pierre Villard 2018-03-12 23:44:06 +01:00 committed by Matthew Burgess
parent c75604a564
commit 95e543d4cc
2 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVRecordReader.java
View File

@ -77,6 +77,8 @@ public class CSVRecordReader implements RecordReader {
if (ignoreHeader) { if (ignoreHeader) {
withHeader = withHeader.withHeader(schema.getFieldNames().toArray(new String[0])); withHeader = withHeader.withHeader(schema.getFieldNames().toArray(new String[0]));
} else {
withHeader = withHeader.withFirstRecordAsHeader();
} }
} else { } else {
withHeader = csvFormat.withHeader(schema.getFieldNames().toArray(new String[0])); withHeader = csvFormat.withHeader(schema.getFieldNames().toArray(new String[0]));

23
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/csv/TestCSVRecordReader.java
View File

@ -124,6 +124,29 @@ public class TestCSVRecordReader {
} }
} }
@Test
public void testExcelFormat() throws IOException, MalformedRecordException {
final List<RecordField> fields = new ArrayList<RecordField>();
fields.add(new RecordField("fieldA", RecordFieldType.STRING.getDataType()));
fields.add(new RecordField("fieldB", RecordFieldType.STRING.getDataType()));
final RecordSchema schema = new SimpleRecordSchema(fields);
final String headerLine = "fieldA,fieldB";
final String inputRecord = "valueA,valueB";
final String csvData = headerLine + "\n" + inputRecord;
final byte[] inputData = csvData.getBytes();
try (final InputStream bais = new ByteArrayInputStream(inputData);
final CSVRecordReader reader = createReader(bais, schema, CSVFormat.EXCEL)) {
final Object[] record = reader.nextRecord().getValues();
final Object[] expectedValues = new Object[] {"valueA", "valueB"};
Assert.assertArrayEquals(expectedValues, record);
assertNull(reader.nextRecord());
}
}
@Test @Test
public void testMultipleRecords() throws IOException, MalformedRecordException { public void testMultipleRecords() throws IOException, MalformedRecordException {
final List<RecordField> fields = getDefaultFields(); final List<RecordField> fields = getDefaultFields();