NIFI-3107: Unit test failure for DBCPServiceTest

H2 and Kafka broker uses the same default port 9092.
If an user is running Kafka broker on the same machine, or run the unit
tests in parallel, DBCPServiceTest can fail since some of its test
methods connects to port 9092.

This closes #1504.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
This commit is contained in:
Koji Kawamura 2017-02-14 14:29:02 +09:00 committed by Andy LoPresto
parent 7e97946c35
commit b2290b24a6
No known key found for this signature in database
GPG Key ID: 3C6EF65B2F7DEF69
1 changed files with 2 additions and 2 deletions

View File

@ -187,7 +187,7 @@ public class DBCPServiceTest {
final DBCPConnectionPool service = new DBCPConnectionPool(); final DBCPConnectionPool service = new DBCPConnectionPool();
runner.addControllerService("test-dropcreate", service); runner.addControllerService("test-dropcreate", service);
runner.setProperty(service, DBCPConnectionPool.DATABASE_URL, "jdbc:h2:tcp://localhost/~/test"); runner.setProperty(service, DBCPConnectionPool.DATABASE_URL, "jdbc:h2:tcp://localhost:" + server.getPort() + "/~/test");
runner.setProperty(service, DBCPConnectionPool.DB_DRIVERNAME, "org.h2.Driver"); runner.setProperty(service, DBCPConnectionPool.DB_DRIVERNAME, "org.h2.Driver");
runner.enableControllerService(service); runner.enableControllerService(service);
@ -238,7 +238,7 @@ public class DBCPServiceTest {
final DBCPConnectionPool service = new DBCPConnectionPool(); final DBCPConnectionPool service = new DBCPConnectionPool();
runner.addControllerService("test-dropcreate", service); runner.addControllerService("test-dropcreate", service);
runner.setProperty(service, DBCPConnectionPool.DATABASE_URL, "jdbc:h2:tcp://localhost/~/test"); runner.setProperty(service, DBCPConnectionPool.DATABASE_URL, "jdbc:h2:tcp://localhost:" + server.getPort() + "/~/test");
runner.setProperty(service, DBCPConnectionPool.DB_DRIVERNAME, "org.h2.Driver"); runner.setProperty(service, DBCPConnectionPool.DB_DRIVERNAME, "org.h2.Driver");
runner.setProperty(service, DBCPConnectionPool.VALIDATION_QUERY, "SELECT 5"); runner.setProperty(service, DBCPConnectionPool.VALIDATION_QUERY, "SELECT 5");
runner.enableControllerService(service); runner.enableControllerService(service);