From b96e402e78caca0dae58b7def37992cb56ee246e Mon Sep 17 00:00:00 2001 From: Mark Payne Date: Mon, 1 May 2017 22:48:48 -0400 Subject: [PATCH] NIFI-3768: This closes #1727. Avoid wrapping FlowFile Attributes Map in an UnmodifiableMap in the StandardFlowFileBuilder Signed-off-by: joewitt --- .../nifi/controller/repository/StandardFlowFileRecord.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-repository-models/src/main/java/org/apache/nifi/controller/repository/StandardFlowFileRecord.java b/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-repository-models/src/main/java/org/apache/nifi/controller/repository/StandardFlowFileRecord.java index a1d5173b8e..fd098eba33 100644 --- a/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-repository-models/src/main/java/org/apache/nifi/controller/repository/StandardFlowFileRecord.java +++ b/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-repository-models/src/main/java/org/apache/nifi/controller/repository/StandardFlowFileRecord.java @@ -319,7 +319,12 @@ public final class StandardFlowFileRecord implements FlowFile, FlowFileRecord { bLineageIdentifiers.clear(); bPenaltyExpirationMs = specFlowFile.getPenaltyExpirationMillis(); bSize = specFlowFile.getSize(); - bAttributes = specFlowFile.getAttributes(); + // If this is a StandardFlowFileRecord, access the attributes map directly. Do not use the + // getAttributes() method, because that will wrap the original in an UnmodifiableMap. As a result, + // a Processor that continually calls session.append() for instance will have a FlowFile whose attributes + // Map is wrapped thousands of times until it hits a StackOverflowError. We want the getter to return + // UnmodifiableMap, though, so that Processors cannot directly modify that Map. + bAttributes = specFlowFile instanceof StandardFlowFileRecord ? ((StandardFlowFileRecord) specFlowFile).attributes : specFlowFile.getAttributes(); bAttributesCopied = false; bClaim = specFlowFile.getContentClaim(); bClaimOffset = specFlowFile.getContentClaimOffset();