Apache
/
nifi
mirror of https://github.com/apache/nifi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details 

This closes #6264

Signed-off-by: David Handermann <exceptionfactory@apache.org>
This commit is contained in:
Matthew Burgess 2022-08-01 14:31:21 -04:00 committed by exceptionfactory
parent 71ba581fd8
commit d698e7af1a
No known key found for this signature in database
GPG Key ID: 29B6A52D2AAE8DBA
1 changed files with 44 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
View File

@ -1197,42 +1197,75 @@ public final class StandardProcessGroup implements ProcessGroup {
if (isInputPort(source)) { // if source is an input port, its destination must be in the same group unless it's an input port
if (isInputPort(destination)) { // if destination is input port, it must be in a child group.
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
throw new IllegalStateException("Cannot add Connection to Process Group because destination is an Input Port that does not belong to a child Process Group");
throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] because destination [" + destination.getIdentifier() +
"] is an Input Port that does not belong to a child Process Group");
}
} else if (sourceGroup != this || destinationGroup != this) {
throw new IllegalStateException("Cannot add Connection to Process Group because source and destination are not both in this Process Group");
throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] destination [" + destination.getIdentifier() +
"] because source and destination are not both in this Process Group");
}
} else if (isOutputPort(source)) {
// if source is an output port, its group must be a child of this group, and its destination must be in this
// group (processor/output port) or a child group (input port)
if (!processGroups.containsKey(sourceGroup.getIdentifier())) {
throw new IllegalStateException("Cannot add Connection to Process Group because source is an Output Port that does not belong to a child Process Group");
throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] destination [" + destination.getIdentifier() +
"] because source is an Output Port that does not belong to a child Process Group");
}
if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input Port that does not belong to a child Process Group");
throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] because destination [" + destination.getIdentifier() +
"] is an Input Port that does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
throw new IllegalStateException("Cannot add Connection to Process Group because its destination does not belong to this Process Group");
throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] because its destination [" + destination.getIdentifier() +
"] does not belong to this Process Group");
}
} else { // source is not a port
if (sourceGroup != this) {
throw new IllegalStateException("Cannot add Connection to Process Group because the source does not belong to this Process Group");
throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] because the source does not belong to this Process Group");
}
if (isOutputPort(destination)) {
if (destinationGroup != this) {
throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Output Port but does not belong to this Process Group");
throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] because its destination [" + destination.getIdentifier() +
"] is an Output Port that does not belong to this Process Group");
}
} else if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input "
+ "Port but the Input Port does not belong to a child Process Group");
throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] because its destination [" + destination.getIdentifier() +
"] is an Input Port but the Input Port does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
throw new IllegalStateException("Cannot add Connection between " + source.getIdentifier() + " and " + destination.getIdentifier()
+ " because they are in different Process Groups and neither is an Input Port or Output Port");
throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
"] from Process Group [" + sourceGroup.getIdentifier() +
"] to Process Group [" + destinationGroup.getIdentifier() +
"] destination " + destination.getConnectableType().name() + "[" + destination.getIdentifier() +
"] because they are in different Process Groups and neither is an Input Port or Output Port");
}
}