Apache
/
nifi
mirror of https://github.com/apache/nifi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NIFI-11581 Refactored JSON Validator Test from Groovy to Java 

This closes #7283

Signed-off-by: David Handermann <exceptionfactory@apache.org>
This commit is contained in:
dan-s1 2023-05-22 23:23:00 +00:00 committed by exceptionfactory
parent 57f5b518f8
commit e77835758c
No known key found for this signature in database
GPG Key ID: 29B6A52D2AAE8DBA
3 changed files with 105 additions and 107 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
nifi-commons/nifi-json-utils/pom.xml
View File

@ -32,11 +32,5 @@
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
<dependency>
<groupId>org.codehaus.groovy</groupId>
<artifactId>groovy-json</artifactId>
<version>${nifi.groovy.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
</project>

101
nifi-commons/nifi-json-utils/src/test/groovy/org/apache/nifi/processor/TestStandardValidators.groovy
View File

@ -1,101 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License") you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.nifi.processor
import org.apache.nifi.components.ValidationContext
import org.apache.nifi.components.ValidationResult
import org.apache.nifi.components.Validator
import org.apache.nifi.processor.util.JsonValidator
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test
import static groovy.json.JsonOutput.prettyPrint
import static groovy.json.JsonOutput.toJson
import static org.junit.jupiter.api.Assertions.assertFalse
import static org.junit.jupiter.api.Assertions.assertTrue
import static org.mockito.Mockito.mock
class TestStandardValidators {
final String DUMMY_JSON_PROPERTY = "JSONProperty"
Validator validator
ValidationContext context
@BeforeEach
void setup() {
validator = JsonValidator.INSTANCE
context = mock(ValidationContext.class)
}
@Test
void testFlat() {
def msg = prettyPrint(toJson([
Name: "Crockford, Douglas"
]))
ValidationResult validationResult = validator.validate(DUMMY_JSON_PROPERTY, msg, context)
assertTrue(validationResult.isValid())
}
@Test
void testNested() {
def msg = prettyPrint(toJson([
Name: "Crockford, Douglas",
ContactInfo: [
Mobile: 987654321,
Email: "mrx@xyz.zyx"
]
]))
ValidationResult validationResult = validator.validate(DUMMY_JSON_PROPERTY, msg, context)
assertTrue(validationResult.isValid())
}
@Test
void testObjectWithArray() {
def msg = prettyPrint(toJson([
name: "Smith, John",
age: 30,
cars: [ "Ford", "BMW", "Fiat" ]
]))
ValidationResult validationResult = validator.validate(DUMMY_JSON_PROPERTY, msg, context)
assertTrue(validationResult.isValid())
}
@Test
void testJSONArray() {
def msg = prettyPrint(toJson([
"one", "two", "three"
]))
ValidationResult validationResult = validator.validate(DUMMY_JSON_PROPERTY, msg, context)
assertTrue(validationResult.isValid())
}
@Test
void testEmpty() {
// Empty JSON
ValidationResult validationResult = validator.validate(DUMMY_JSON_PROPERTY, "{}", context)
assertTrue(validationResult.isValid())
}
@Test
void testInvalidJson() {
// Invalid JSON
ValidationResult validationResult = validator.validate(DUMMY_JSON_PROPERTY, "\"Name\" : \"Smith, John\"", context)
assertFalse(validationResult.isValid())
assertTrue(validationResult.getExplanation().contains("not a valid JSON representation"))
validationResult = validator.validate(DUMMY_JSON_PROPERTY, "bncjbhjfjhj", context)
assertFalse(validationResult.isValid())
}
}

105
nifi-commons/nifi-json-utils/src/test/java/org/apache/nifi/processor/TestJsonValidator.java Normal file
View File

@ -0,0 +1,105 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License") you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.nifi.processor;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.apache.nifi.components.ValidationContext;
import org.apache.nifi.components.ValidationResult;
import org.apache.nifi.components.Validator;
import org.apache.nifi.processor.util.JsonValidator;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import java.util.Arrays;
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.Map;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
@ExtendWith(MockitoExtension.class)
public class TestJsonValidator {
private static final String JSON_PROPERTY = "JSONProperty";
private static final ObjectMapper MAPPER = new ObjectMapper();
@Mock
ValidationContext context;
private final Validator validator = JsonValidator.INSTANCE;
@Test
public void testFlat() throws JsonProcessingException {
String msg = MAPPER.writeValueAsString(Collections.singletonMap("Name", "Crockford, Douglas"));
ValidationResult validationResult = validator.validate(JSON_PROPERTY, msg, context);
assertTrue(validationResult.isValid());
}
@Test
public void testNested() throws JsonProcessingException {
Map<String, Object> outer = new LinkedHashMap<>();
outer.put("Name", "Crockford, Douglas");
Map<String, Object> nested = new LinkedHashMap<>();
nested.put("Mobile", 987654321);
nested.put("Email", "mrx@xyz.zyx");
outer.put("ContactInfo", nested);
String msg = MAPPER.writeValueAsString(outer);
ValidationResult validationResult = validator.validate(JSON_PROPERTY, msg, context);
assertTrue(validationResult.isValid());
}
@Test
public void testObjectWithArray() throws JsonProcessingException {
Map<String, Object> outer = new LinkedHashMap<>();
outer.put("name", "Smith, John");
outer.put("age", 30);
outer.put("cars", Arrays.asList("Ford", "BMW", "Fiat"));
String msg = MAPPER.writeValueAsString(outer);
ValidationResult validationResult = validator.validate(JSON_PROPERTY, msg, context);
assertTrue(validationResult.isValid());
}
@Test
public void testJSONArray() throws JsonProcessingException {
String msg = MAPPER.writeValueAsString(Arrays.asList("one", "two", "three"));
ValidationResult validationResult = validator.validate(JSON_PROPERTY, msg, context);
assertTrue(validationResult.isValid());
}
@Test
public void testEmpty() {
ValidationResult validationResult = validator.validate(JSON_PROPERTY, "{}", context);
assertTrue(validationResult.isValid());
}
@ParameterizedTest
@ValueSource(strings = {"\"Name\" : \"Smith, John\"", "bncjbhjfjhj"})
public void testInvalidJson(String invalidJson) {
ValidationResult validationResult = validator.validate(JSON_PROPERTY, invalidJson, context);
assertFalse(validationResult.isValid());
assertTrue(validationResult.getExplanation().contains("not a valid JSON representation"));
}
}