Commit Graph

5208 Commits

Author SHA1 Message Date
SavtechSolutions cf7ab0ce18 NIFI-5790 removed the last test as it's causing a race condition intermittently (#3260)
Signed-off-by: Peter Wicks <patricker@gmail.com>
2019-01-10 12:13:35 -07:00
Mark Payne 706cf7dcff
NIFI-5944: When components are started on NiFi startup, if they are invalid, don't fail immediately and give up. Instead, keep attempting to start the component when it becomes valid.
This closes #3259
2019-01-10 11:15:17 -05:00
Alex Savitsky 3e52ae952d NIFI-5909 added optional settings for date, time, and timestamp formats used to write Records to Elasticsearch
NIFI-5909 added content checks to the unit tests

NIFI-5937 use explicit long value for test dates/times (to not depend on the timezone of test executor)

NIFI-5937 tabs to spaces

Fixing checkstyle violations introduced by https://github.com/apache/nifi/pull/3249 PR)

NIFI-5937 adjusted property descriptions for consistency; limited EL scope to variable registry; added an appropriate validator along with its Maven dependency; moved format initialization to @OnScheduled

NIFI-5909 tabs to spaces

Signed-off-by: Ed <edward.berezitsky@gmail.com>

This closes #3227
2019-01-09 21:55:09 -05:00
Alex Savitsky 1a443c73ec NIFI-5937 use processor-configured encoding instead of the system default
NIFI-5937 added tests to verify that accented characters are preserved correctly

NIFI-5937 unfolding starred imports

NIFI-5937 unfolding starred imports (now with statics)

Signed-off-by: Ed <edward.berezitsky@gmail.com>

This closes #3250
2019-01-08 23:28:23 -05:00
kei miyauchi e6e4175d71 NIFI-5841 Fix memory leak of PutHive3Streaming.
This closes #3249.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-01-09 12:06:27 +09:00
Koji Kawamura ae67346648 NIFI-5826 Fix back-slash escaping at Lexers
Adding unit test cases for escaped characters

Signed-off-by: Ed <edward.berezitsky@gmail.com>

This closes #3200
2019-01-08 16:50:20 -05:00
Matt Gilman 93efc2affc
NIFI-5935:
- Ensuring exceptions are handled in the ldap user/group sync background thread.
- Adding additional logging around what users/groups were discovered.

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3247.
2019-01-08 11:13:38 +01:00
Stephen Goodman a8e59e52af NIFI-5920: Tagging an object in S3
Unit tests and functionality for tagging an object in S3.

Set FlowFile attributes directly from tags retrieved from S3.

Add guard clauses to ensure evaluated properties are not blank.

This closes #3239.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-01-08 12:12:13 +09:00
Mark Payne cf41c10546 NIFI-5879: Fixed bug in FileSystemRepository that can occur if an InputStream is obtained, then more data is written to the Content Claim - the InputStream would end before allowing the sequential data to be read. Also fixed bugs in LimitedInputStream related to available(), mark(), and reset() and the corresponding unit tests. Additionally, found that one call to StandardProcessSession.read() was not properly flushing the output of any Content Claim that has been written to before attempting to read it.
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3207
2019-01-07 11:06:17 -05:00
Andy LoPresto b59fa5af1f NIFI-5854 Added skeleton logic to convert decimal time units.
Added helper methods.
Added unit tests.

NIFI-5854 [WIP] Cleaned up logic.
Resolved failing unit tests due to error message change.

NIFI-5854 [WIP] All helper method unit tests pass.

NIFI-5854 [WIP] FormatUtils#getPreciseTimeDuration() now handles all tested inputs correctly.
Added unit tests.

NIFI-5854 [WIP] FormatUtils#getTimeDuration() still using long.
Added unit tests.
Renamed existing unit tests to reflect method under test.

NIFI-5854 FormatUtils#getTimeDuration() returns long but now accepts decimal inputs.
Added @Deprecation warnings (will update callers where possible).
All unit tests pass.

NIFI-5854 Fixed unit tests (ran in IDE but not Maven) due to int overflows.
Fixed checkstyle issues.

NIFI-5854 Fixed typo in Javadoc.

NIFI-5854 Fixed typo in Javadoc.

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3193
2019-01-07 09:55:06 -05:00
Andy LoPresto c206c0fcf9
NIFI-5927 Added SECURITY.md to project root.
Removed reference to Jasypt from cryptography section of README.md.
Fixed JCraft link for Chrome browser.

This closes #3243.

Signed-off-by: Andrew Lim <andrewlim.apache@gmail.com>
2019-01-04 09:53:53 -08:00
Andy LoPresto c5c2b308ed
NIFI-5926 Added certificate commands to toolkit guide.
Applied formatting and organizational changes from PR review.

This closes #3242.

Signed-off-by: Andrew Lim <andrewlim.apache@gmail.com>
2019-01-04 09:38:58 -08:00
Pierre Villard 432ba8787f
NIFI-5921 - Timeout property for ConsumeJMS
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3245.
2019-01-04 12:28:13 +01:00
Ryan Whittington cd91197a45
NIFI-5921 - Added property to allow a user to define a timeout on the ConsumeJMS processor
Co-Authored-By: rwhittington <ryan.whittington@gmail.com>
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3240.
2019-01-04 10:32:12 +01:00
Mike Thomsen 6fa5deafc2
NIFI-5908 Inject locale info into JsonInjector object to make sure we don't lose that information.
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3226.
2019-01-03 18:10:08 +01:00
Mark Payne fea17d0ca8
NIFI-5919: Addressed a race condition that can exist if adding FlowFiles to a FlowFileQueue before adjusting the size of the queue to account for the FlowFiles
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3238.
2019-01-03 11:35:23 +01:00
Koji Kawamura 595a2decc6
NIFI-5917 Fix TestSelectHiveQL.testNoTimeLimit
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3237.
2019-01-03 11:31:38 +01:00
Otto Fowler 1330b92cfa NIFI-5892 Wait timestamp lingers, potentially messing up downstream wait-notify pairs
Clear the wait timestamp when transferring to failur or success

replace explicit attribute clear with function call, refactor and integrate into existing tests per review

This closes #3233.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-28 10:30:02 +09:00
Pierre Villard 2e4f002945
Merge pull request #3232 from patricker/NIFI-5913
NIFI-5913 - Standardize Definition of UUID in Documentation
2018-12-21 14:33:16 +01:00
Peter Wicks 8ccf890a55
NIFI-5913 - Standardize Definition of UUID in Documentation 2018-12-20 10:11:07 -07:00
SavtechSolutions f9f386b0f0 NIFI-5871 ignore UUID attribute when copying flow file attributes (#3203)
NIFI-5871 ignore UUID attribute when copying flow file attributes

Signed-off-by: Peter Wicks <patricker@gmail.com>
2018-12-20 10:05:25 -07:00
Pierre Villard f22a6c46ad
Merge pull request #3219 from zenfenan/NIFI-5893
NIFI-5893: AWS Endpoint Overriding now functions properly
2018-12-19 10:50:05 +01:00
Pierre Villard 590fa2063c NIFI-4892 - ValidateCSV: no doublequote escaping in invalid output
NIFI-4892 - ValidateCSV: no doublequote escaping in invalid output

NIFI-5907 - unit test

This closes #2481.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-19 11:20:55 +09:00
Pierre Villard e9cb915ca9
Merge pull request #3225 from ijokarumawak/nifi-5905
NIFI-5905 Secure S2S fails with NullPointerException
2018-12-18 10:21:29 +01:00
Pierre Villard c52f880cc1
Merge pull request #3224 from mattyb149/NIFI-5904
NIFI-5904: Fix PutHive3Streaming handling of RecordReaderFactoryException
2018-12-18 09:50:25 +01:00
Matthew Burgess 7548d7c859 NIFI-3988: Add fragment attributes to SplitRecord
This closes #3217.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-18 15:07:43 +09:00
Koji Kawamura 4b70465ea5 NIFI-5905 Secure S2S fails with NullPointerException
The constructor arguments should be set to instance variables so that
subsequent code can refer "this.*".
2018-12-18 15:03:31 +09:00
Jeff Storck cc47a8c0e1
NIFI-5748 Improved Proxy Header Support
- Fixed proxy header support to use X-Forwarded-Host instead of X-ForwardedServer
- Added support for the context path header used by Traefik when proxying a service (X-Forwarded-Prefix)
- Added tests to ApplicationResourceTest for X-Forwarded-Context and X-Forwarded-Prefix
- Updated administration doc to include X-Forwarded-Prefix
- Added NIFI_WEB_PROXY_CONTEXT_PATH env var to dockerhub and dockermaven start.sh scripts
- Added documentation for NIFI_WEB_PROXY_CONTEXT_PATH to dockerhub README.md
- Updated ApplicationResource to handle a port specified in X-ProxyPort and X-Forwarded-Port headers

This closes #3129.

Signed-off-by: Kevin Doran <kdoran@apache.org>
2018-12-17 17:32:06 -05:00
Andy LoPresto 7c9617a0ec
Merge pull request #3220 from zenfenan/NIFI-5898
NIFI-5898: Updated the display name for ACCESS_KEY & SECRET_KEY

Signed-off-by: Andy LoPresto <alopresto@apache.org>
2018-12-17 11:39:09 -08:00
Matthew Burgess d34789881b NIFI-5904: Fix PutHive3Streaming handling of RecordReaderFactoryException 2018-12-17 14:12:18 -05:00
zenfenan 10e29ee4d6 NIFI-5898: Updated the display name for ACCESS_KEY & SECRET_KEY 2018-12-16 17:05:52 +05:30
zenfenan ee24a593e9 NIFI-5893: AWS Endpoint Overriding now functions properly 2018-12-15 19:37:31 +05:30
Koji Kawamura 0efddf47d5 NIFI-4579: Fix ValidateRecord type coercing
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #2794
2018-12-13 16:10:41 -05:00
gkkorir c51512f5e3 NIFI-5891 fix handling of null logical types in Hive3Streaming processor
NIFI-5891: Fixed Checkstyle issues
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3216
2018-12-13 10:23:18 -05:00
zenfenan 9a1ab4c504 NIFI-5621: Added Cassandra connection provider service
NIFI-5621: Improvements on LICENSE & NOTICE files

This closes #3105

Signed-off-by: Mike Thomsen <mikerthomsen@gmail.com>
2018-12-12 09:59:32 -05:00
Pierre Villard 85cc5aa9eb NIFI-5889 - changed the wording about Destination URL in S2S RTs
This closes #3215.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-12 11:15:48 +09:00
Mike Thomsen 13a7f16860 NIFI-5890 Added a unit test that proves that 1.9 fixes a bug in the date conversion behavior in 1.8.
This closes #3214.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-12 11:08:18 +09:00
Wil Selwood 1a937b6511 NIFI-5875 Improve docs around the PriorityAttributePrioritizer
Clear up the documentation around the PriorityAttributePrioritizer to make it clearer that if the attributes are both number the largest wins but if they are not numbers they sort the other way around.

I had to go and look at the code to work out what was going on after reading the existing documentation.

Simplify PriorityAttributePrioritzer docs

Simplify the main section of documentation for PriorityAttributePrioritzer and then add a notes section with more details about the ordering.

Fix example.

Put back comment setting the priority attribute

Further improvements to the Priority ordering

This closes #3205.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-11 10:43:25 +09:00
Mark Payne 1ac5b93144
NIFI-5859: Added XML-based documentation writer that can be used to document a component.
- Found several instances of nifi-framework-api's ProviderException being thrown from processors. Changed those to IllegalStateException, as ProviderException is not an appropriate Exception in those cases, and extensions should not depend on nifi-framework-api.
- Performed some cleanup, moving Property Descriptors from Controller Service API's/specs into the implementations. Adding to the Service API results in bringing in nifi-utils to the nifi-standard-services-api-nar, which is a bad practice. The 'main' service api nar should not have a dependency on a util class.

NIFI-5859: Added javadocs. Fixed pom.xml that was left pointing to snapshot version of nar maven plugin

NIFI-5859: Addressing review feedback: adding component type, multiple additional details into separate file(s)

This closes #3192.

Signed-off-by: Bryan Bende <bbende@apache.org>
2018-12-10 11:16:01 -05:00
Koji Kawamura 4e7a856f77
NIFI-5885 ArrayOutOfBoundsException at EL 'or' and 'and' functions
EL 'or' and 'and' functions can be called multiple times within the same context using the same evaluator instance.
That happens if their subject is derived from an IteratingEvaluator such as 'anyDelineatedValues'.

And if the right hand side expression for such 'or' and 'and' contains another IteratingEvaluator,
then it can be evaluated more than the number of its candidates, ultimately an ArrayOutOfBoundsException is thrown.

This commit makes Or/AndEvaluator caching its right hand side result to prevent that happens.
For 'or' and 'and' functions, the right hand side expression is independant from their subject boolean value.
It's enough evaluating right hand side once, because it returns the same result even with different subjects.

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3212.
2018-12-10 11:47:58 +01:00
Pierre Villard a6f91a1975 NIFI-5872 - Added compression option to JsonRecordSetWriter
This closes #3208.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-10 16:25:59 +09:00
Bryan Bende 60064a9f68 NIFI-5884 Bumping hbase-client version from 1.1.2 to 1.1.13
This closes #3211.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-10 11:00:08 +09:00
Kemix Koo e76c54234d NIFI-5881: Enable to export the template for non-ascii name
This closes #3210.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-10 09:51:46 +09:00
Dan Levy ecbed6a782
NIFI-5883 - Update README.md
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3209.
2018-12-07 14:43:54 +01:00
Alexander Bukarev 84c32f9137
NIFI-5830 - RedisConnectionPoolService does not work with Standalone Redis using non-localhost deployment
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3176.
2018-12-06 23:31:25 +01:00
Bryan Bende f1e03b5ed5
NIFI-5877 Protecting against null values when obtaining master address
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3206.
2018-12-06 22:03:23 +01:00
Mark Payne 72ea93a657
NIFI-5868: Added instrumentation around ListFile such that all disk accesses are timed and any unusually long listing times or disk access operations can be logged. Additionally, information is logged at a debug level including significant amounts of troubleshooting information when configured to do so
This closes #3202.

Signed-off-by: Bryan Bende <bbende@apache.org>
2018-12-05 13:01:14 -05:00
Koji Kawamura 8ebb4d1974
NIFI-5863 Fixed AbstractFlowFileQueue logging
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3199.
2018-12-05 11:29:50 +01:00
Peter Wicks 6c1c9017e9 NIFI-5862 MockRecordParser Has Bad Logic for failAfterN
This closes #3195.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-05 10:09:31 +09:00
Pierre Villard 986a2a4842 NIFI-5838 - Improve the schema validation method in Kite processors
review

Add empty check

This closes #3182.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2018-12-05 09:53:52 +09:00