3536 Commits

Author SHA1 Message Date
Koji Kawamura
31463c5dad
NIFI-6160 Apply config error handling convention
What this PR changed:
- Standardized required name error message to 'The name of the xxxx must
be specified'
- Added nfErrorHandler.handleConfigurationUpdateAjaxError
    - Replaced existing custom error handling for 400 status code
    - Replaced handleAjxError with this where appropriate
- Standardized config error dialog title to 'Configuration Error'
- Close the configuration dialog when configuration is successfully
updated

Above convention applied to following components:
- ProcessGroup
- Input/OutputPort
- RemoteProcessGroup
    - RemoteGroupPort
- Template
- Connection
- ControllerService
- Label
- Processor
- ReportingTask
- NiFi Settings/GENERAL tab
- Variable
- User

NIFI-6170 Provide consistent UX at Connection config
Fixed Label.

Incorporated review comments
Removed unnecessary else block.
Disable canvas when the message pane is shown

This closes #3401
2019-04-24 16:47:11 -04:00
Jeff Storck
0e5a80d23f
NIFI-6224 Updated KerberosProvider to use the "Default Realm" property
Updated usage of deprecated FormatUtils.getTimeDuration to FormatUtils.getPreciseTimeDuration
  Implemented prioritized handling of appending the default realm
    A realm-qualified principal will not be modified before authentication
    A principal shortname will have Default Realm appended to it when it is not blank before authentication
    A principal shortname will not be modified if Default Realm is blank, and the underlying kerberos implementation will append the default_realm configured in krb5.conf
In nifi-security-util
  added KerberosPrincipalParser for determining the realm of a kerberos principal
  added tests for KerberosPrincipalParser
  updated pom with spock-core as a test dependency

This closes #3446.

Signed-off-by: Kevin Doran <kdoran@apache.org>
2019-04-24 14:55:41 -04:00
Peter Wicks
2b83b7d9e8
NIFI-6223 Expose Cluster Node Type to Controller Services
NIFI-6223 Enhance Mock Controller Service to allow specifying node type

This closes #3444.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-04-24 13:20:55 -04:00
Andrew Lim
e8174fb99f NIFI-6002 Corrected duplicated CSS class and capitalized REST API 2019-04-24 10:05:21 -04:00
Bryan Rosander
d429470cc1 NIFI-6226: Returning -1 for EmptyRecordReader.getMaxEventId() to prevent potential provenance repo corruption
This closes #3443.

Signed-off-by: Mark Payne <markap14@hotmail.com>
2019-04-23 13:14:47 -04:00
Mark Payne
5e2559db42
NIFI-6236: Update VolatileFlowFileRepository to decrement claimant counts when FlowFiles are deleted
This closes #3451.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-04-23 13:10:14 -04:00
Mark Payne
055b3cac54 NIFI-6220: If FlowFile is created by cloning a relationship, do not create an ATTRIBUTES_MODIFIED provenance event for it.
NIFI-6220: Updated test name and fixed typo

This closes #3438.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-04-23 17:08:26 +09:00
Koji Kawamura
c5d0643d1d NIFI-5792: Remember created versioned flow information
- Before this fix, NiFi loses information about created versioned flow in case of subsequent snapshot creation failure, and NiFi API returned an error response
- This commit makes:
  - The created versioned Flow information is stored even if subsequent snapshot creation fails
  - NiFi API to return a successful 200 response in that case, but return versioned flow status as SYNC_FAILURE with an explanation. NiFi UI shows a popup error dialog with the explanation.
  - Versioned flow status will be LOCALLY_MODIFIED if the latest version is 0.

This closes #3134.

Signed-off-by: Mark Payne <markap14@hotmail.com>
2019-04-22 13:27:40 -04:00
Sivaprasanna
94c2b1e76e NIFI-6049: Updated MoveHDFS to support FF Attribute for Output Directory (#3433)
NIFI-6049: Updated MoveHDFS to support FF Attribute for Output Directory
2019-04-22 10:12:16 -06:00
Dustin Rodrigues
161e4b5763 NIFI-6231 - fix source code permissions to be non-executable
This closes #3449.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-04-22 10:13:07 +09:00
aeaversa
512555dbb0 NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue (#3440)
NIFI-6221 Adding 'Download' and 'View' content icon buttons to slick grid actions column to improve end user navigation.
2019-04-19 16:25:15 -06:00
Rahul Patil
8411b6a46f
NIFI-6207: fixing 'partition' typos in AWS Kinesis processor and test as well as Kafka ConsumeLease classes.
This closes #3437.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
2019-04-16 11:00:48 -07:00
Matthew Burgess
d0224f7897 NIFI-6093: Add count and id fragment attributes to original FlowFile in SplitRecord
This closes #3435.

Signed-off-by: Mark Payne <markap14@hotmail.com>
2019-04-16 09:43:10 -04:00
Andy LoPresto
22563fcb9a
NIFI-6201 Suppressed stacktraces for expected error conditions (connection timeout, missing component bundle, etc.) in application startup when the stacktrace provides no additional helpful data.
NIFI-6201 Fixed existing checkstyle complaint on missing Javadoc element.

NIFI-6201 Restored "connection refused" text to relevant registry sync error message.

NIFI-6201 Simplified error logging for bundle not found issues and removed unused bundle coordinate methods.

This closes #3427.

Signed-off-by: Kevin Doran <kdoran@apache.org>
2019-04-15 16:52:13 -04:00
Mark Payne
7b945182af NIFI-6215: Ensure that when we are swapping FlowFiles back into nifi, that we consider forward slashes or back slashes as the same path separator when determining filename
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3434
2019-04-15 15:54:41 -04:00
Brandon Devries
cbc07eb663 NIFI-6157: Allowing configuration of concurrent tasks and transferred FlowFile count to Funnels and LocalPorts
This closes #3412
Signed-off-by: Brandon <devriesb@apache.org>
2019-04-15 14:13:11 +00:00
Rob Fellows
b5ff622118
NIFI-4230 - Use a better default location when pasting via keystokes and the original copied item is not fully in view.
- handle multi-select copy/paste better.
- remove dimension info from getOrigin function
- handle pasting better when pasted items should be centered and not offset from the original.
- fixed strict mode and removed console.logs
- Fixing pasting logic when trying to center the items on the canvas.

This closes #3383
2019-04-12 15:27:26 -04:00
Matthew Burgess
97690275ac
NIFI-6210: Applied NIFI-5134 Kerberos TGT renewal to Hive3ConnectionPool
This closes #3432.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-04-12 15:09:52 -04:00
Mark Payne
91b2283f49
NIFI-6183: Implemented base class for Framework-level integration tests that is responsible for instantiating the key components for integration tests, including FlowController, WriteAheadFlowFileRepository, WriteAheadProvenanceRepository, FileSystemRepository, FileSystemSwapManager, StandardFlowFileQueue, StandardProcessScheduler, etc. Implemented several integration tests to span different parts of the framework
This closes #3423.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-04-10 16:47:08 -04:00
Matthew Burgess
8d92a29fb9
NIFI-5238: Replaced Shift-F with Shift-Ctrl-F in Jolt Advanced UI for auto-format
This closes #3428
2019-04-10 14:28:15 -04:00
Mark Payne
0f10010683
NIFI-6199: Fixed problematic unit tests that did not properly wait for async tasks to complete before making assertions
This closes #3421.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-04-09 11:24:58 -04:00
Mark Payne
bf7e70e4c3
NIFI-6194: Fixed verification logic to determine whether or not a variable's value can be changed. Previously, the logic had a bug that resulted in a failure if any child group contained a running processor that references an overridden variable and the user attempts to change the overridden variable at the higher level. We should not include any components of descendent groups if the descendent group overrides the variable.
This closes #3420.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-04-09 11:15:45 -04:00
Mark Payne
38db4e97cd
NIFI-5464: Consider ports invalid unless they have both incoming and outgoing connections
This closes #3417.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-04-09 10:19:24 -04:00
Lars Francke
49e74b29db NIFI-6198 Infinite recursion in HBase*ClientService
This closes #3419.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-04-09 09:29:32 +09:00
Kourge
cded30b3d2 NIFI-5953 Manage GetTwitter connection retries on '420 Enhance Your Calm' exceptions
NIFI-5953 Manage GetTwitter connection retries on '420 Enhance Your Calm' exceptions

Update "Max Client Error Retries" parameter name.
reintriduce client.reconnect() on HTTP_ERROR 420

This closes #3276.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-04-09 09:14:44 +09:00
Rob Fellows
fb9f2af04a
NIFI-6136 - fix: UI - User and Template bug when page popped out
NIFI-6136 - return the appropriate value (false) when verifyDisconnectedCluster is called from a non-clustered environment.

This closes #3390
2019-04-08 15:45:19 -04:00
Matthew Burgess
8572852bdf
NIFI-6184: This closes #3413. Removed unnecessary test-jar dep from nifi-livy-processors causing race condition, added assertion to catch failures
Signed-off-by: Joe Witt <joewitt@apache.org>
2019-04-08 14:52:40 -04:00
Koji Kawamura
1c588f10b2 NIFI-5979 Add Line-by-Line Evaluation Mode to ReplaceText
Refactored to use functions to better handle strategy specific variables
via closure.
2019-04-08 16:19:48 +09:00
pushpavanthar
d222f14a9e NIFI-5979 : enhanced ReplaceText processor with "Number of Occurrences" and "Occurrence offset" configurations
Fixed indentation errors to pass checkstyle-checks

Added Evaluation Modes as per discussion in PR thread

Adding exclusions of test files on rat plugin

Added new property 'Line-by-Line Evaluation Mode' and refactored common code

This closes #3375.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-04-08 16:19:27 +09:00
Bryan Bende
25cb29e109
NIFI-6177 Refactor HBaseListLookupService tests to remove use of TestRecordLookupProcessor
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3400.
2019-04-06 14:31:50 +02:00
bdesert
75217b33d0
NIFI-6181 FetchSFTP and FetchFTP File Not Found fix
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #3407.
2019-04-06 14:27:39 +02:00
Alex Aversa
96279415a7 NIFI-6188 - Added 1s delay on Search control autocomplete query event to prevent premature results retrieval
This closes #3408.
Signed-off-by: Brandon Devries <devriesb@apache.org>
2019-04-05 12:32:40 -04:00
Mike Thomsen
4810f6d32e NIFI-6172 Fixed a bug that caused ElasticSearchStringLookupService to always return a value even when it should return Optional.empty().
NIFI-6172 Fixed broken integration test.

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3399
2019-04-05 11:12:30 -04:00
Lars Francke
d372318d47 NIFI-6191 HBase 2 ClientService documentation refers to HBase 1.x
This closes #3409.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-04-05 14:55:58 +09:00
Rob Fellows
e374d2cc30
NIFI-6140 - Incorrect title on the read only version of the Reporting Task detail dialog
This closes #3385
2019-04-04 13:40:14 -04:00
dnsbtchr
d36fa6a210 NIFI-6016 PutCassandraRecord batch size
Adds resetting the batch size to fix broken batch processing

Removes empty line

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3337
2019-04-04 11:26:08 -04:00
ambah
c93ee5ad59 NIFI-6186 Resolve handling of module paths in JythonScriptEngineConfigurator
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3406
2019-04-04 11:13:18 -04:00
Rob Fellows
cb4fdc2ae1
NIFI-6126 - throttle requests to refresh the canvas to prevent too many server requests when holding down CTRL-R
* Added lodash utility library to leverage its throttle capability (and many other useful functions in the future).
* Made lodash available in all JSP's so it could be imported into nf-common (or any component for that matter).
* Added a throttle function to nf-common that just wraps _.throttle

This closes #3393
2019-04-04 09:51:41 -04:00
Matthew Burgess
1b196ea213 NIFI-5338: Added SimpleScriptedLookupService controller service
This closes #3397

Signed-off-by: Mike Thomsen <mikerthomsen@gmail.com>
2019-04-04 08:41:34 -04:00
Lars Francke
73571ae309 NIFI-6185: ListDatabaseTables processor doesn't close ResultSets
This closes #3405.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-04-04 12:24:47 +09:00
Endre Zoltan Kovacs
3a63de2ae2 NIFI-6180: exposing firehose grace period to DruidTranquilityController
this allows for configuring `druidBeam.firehoseGracePeriod`
(https://github.com/druid-io/tranquility/blob/master/docs/configuration.md#properties)

NIFI-6180: Corrected typo in DruidTranquilityController
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3403
2019-04-03 12:31:57 -04:00
Endre Zoltan Kovacs
e907b689e8 NIFI-6179: minor changes to DruidTranquilityController
- hooking in property INDEX_RETRY_PERIOD to list of properties
- fixing property description

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #3402
2019-04-03 12:24:32 -04:00
Mark Payne
76392ee862
NIFI-6155: Ensure that any task submitted to FlowEngine catches Throwable so that the task doesn't die just die silently in the case of an unexpected error/exception
This closes #3395.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-03-29 10:09:35 -04:00
Craig Davidson
4de51fd3d5 NIFI-6148 - Added support for aggregation option 'allowDiskUse'
This closes #3389

Signed-off-by: Mike Thomsen <mikerthomsen@gmail.com>
2019-03-28 11:06:25 -04:00
Mark Payne
d3d43262db
NIFI-6150: Moved logic of decrementing content claims from ProcessSession.commit to the FlowFile Repository. Also updated load-balancing protocol and queue drop logic to no longer decrement content claims since the flowfile repo will handle the logic. This allows us ts to ensure that the claimant counts are decremented only if the repo is successfully updated and still before checking if the claim is still in use or not.
This closes #3391.

Signed-off-by: Bryan Bende <bbende@apache.org>
2019-03-27 10:22:01 -04:00
Pierre Villard
ead6a3b842 NIFI-6144 - Enable EL on listening port in HandleHttpRequest
This closes #3386.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-03-25 11:52:28 +09:00
Joe Witt
1bdab73201 NIFI-6121 Updated the easy dependencies to update
This closes #3374

Signed-off-by: Mike Thomsen <mikerthomsen@gmail.com>
2019-03-22 09:01:21 -04:00
Matthew Burgess
ce09b93ef1 NIFI-6139: Add fragment attributes to PartitionRecord
This closes #3382.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2019-03-22 10:41:10 +09:00
Ferenc Szabó
48a6c81fa2 NIFI-4735: ParseEVTX only outputs one event per chunk
This change is based on https://github.com/apache/nifi/pull/2489

I have reproduced the issue with some additional test cases and test files then applied the original fix.

commit message from the original change:
Updated the EVTX FileHeader class to correctly check if there are more chunks in the file. Previously this would not process the last chunk.

Updated the EVTX ChunkHeader class to correctly check if there are additional records in the chunk. Previously this would only process the first record of each chunk. It was using the fileLastRecordNumber where it should have been using the logLastRecordNumber value.

Updated the EVTX unit tests to have the correct expected number of events and use the logLastRecordNumber.

refactoring duplicated code and magic numbers

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #2489
This closes #3379
2019-03-20 14:12:03 -04:00
Matt Gilman
d35d15cdda
NIFI-6027
- Allowing user or group existence enforcement to be parameterized.
- Fixing error handling when loading user groups which may have resulted in stack trace leaking.

This closes #3377.

Signed-off-by: Kevin Doran <kdoran@apache.org>
2019-03-20 13:38:46 -04:00