Commit Graph

302 Commits

Author SHA1 Message Date
Matt Gilman 7d8dd27027
NIFI-2554: - Requiring READ permissions on the referenced controller service when creating/updating processors, controller services, and reporting tasks.
- Preventing client side selection of unauthorized controller services unless they were the previously configured value.

This closes #860.

Signed-off-by: Bryan Bende <bbende@apache.org>
2016-08-15 16:46:58 -04:00
Scott Aslan 2a92747046 [NIFI-2559] UI - Controller Service update missing icons
This closes #864
2016-08-15 16:27:12 -04:00
Matt Gilman d45114e48d NIFI-2501: - Ensuring users can access the controller service list regardless of permissions on the corresponding process group or controller. - Better handling the case where the user had write permissions but no read permissions. - Returning to the appropriate controller service listing after going to the usage page.
This closes #835

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-15 15:16:58 -04:00
Matt Gilman 0855cb9bd4
NIFI-2555:
- Addressing potential NullPointerException when an AccessDeniedException is thrown from an endpoint that isn't subject to the security filter chain.

This closes #846.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
2016-08-12 15:08:00 -07:00
Jeff Storck bbdd087d77 NIFI-1876 Implemented PropertyDescriptorDTO merging
NIFI-1876 Updated PermissionsDTO to use boolean primitives instead of Boolean objects for read and write permission
Removed ISE throwing from EntityFactory, it will rely on null checks instead

This closes #694

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-12 17:22:37 -04:00
Matt Gilman e81147c92a NIFI-1876: - Introducing entities for allowable values and process group status.
Signed-off-by: Jeff Storck <jtswork@gmail.com>
Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-12 17:22:26 -04:00
Jeff Storck 572dfed78a NIFI-1876 Implements merging of responses to successful requests based on authorization, returning the most restrictive response - Added StandardHttpResponseMergerSpec for testing response merging - Added Permissible interface - Added nifi-api/controller/archive to ProcessGroupEndpointMerger - Removed AbstractMultiEntityEndpoint.java, not used anymore - Implemented reponse merging for GET requests where there are some successful and problematic responses, returning most restrictive one. - Updated nf-settings.js with ControllerConfigurationEntity property rename from controllerConfiguration to component - Implemented merging of status DTOs based on read permission NIFI-2264 Implemented merging of status history results based on readability permissions - Added StatusHistoryEndpointMergerSpec to test merging of status history based on read permission
NIFI-1876 Added merging for labels, funnels, and controller service references.

NIFI-1876 Added Label and Funnel merging to FlowMerger.java

NIFI-1876 Added replication of request for process group controller services
 - Updated merging code for Status and Status History based on read permissions

NIFI-1876 Fixed issue with node status snapshots all looking like they came from one node
Updated ProcessGroupStatusSnapshotDTO to contain status snapshot entities to retain readability permission
Added entity classes for ConnectionStatusSnapshotDTO, PortStatusSnapshotDTO, ProcessGroupStatusSnapshotDTO, ProcessorStatusSnapshotDTO, and RemoteProcessGroupStatusSnapshotDTO
Updated PropertyDescriptorDTO to contain AllowableValueEntity to retain readability permission
Added entity class for AllowableValueDTO
Moved AllowableValueDTO to its own top-level class
Updated DtoFactory to get permissions for status snapshot entities
Updated StatusMerger to merge status snapshot entities

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-12 17:22:17 -04:00
Scott Aslan a9675552d9 [NIFI-2557] Enhance Modal Plugin. This closes #842 2016-08-12 11:40:45 -04:00
Matt Gilman e5e86cf07c NIFI-2548:
- Allowing selection of User/Cluster node when searching and encountering an exact match.

This closes #839

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
2016-08-12 20:41:49 +09:00
Matt Gilman fa639e2596 NIFI-2542: - Ensuring transitive referencing components are able to be returned. - Ensuring we can enable/disable services with transitive referencing components. - Ensuring we cannot enable/disable services with unauthorized referencing components.
NIFI-2543: - Ensuring we have permissions before attempting to reload a controller service.

This closes #837

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-11 20:42:35 -04:00
Matt Gilman fbb705e461
NIFI-2511: - Ensuring Process Group bulletins are bubbling up as expected.
This closes #822.

Signed-off-by: Bryan Bende <bbende@apache.org>
2016-08-09 16:28:57 -04:00
Matt Gilman 7a1f749f69 NIFI-2475: - Updating UI to better suggest that component specific administrators do not override higher level administrators.
This closes #813
2016-08-09 15:40:28 -04:00
Matt Gilman ae8045d99b
NIFI-2505: - Updating the user identity field in the ActionDTO.
This closes #800.

Signed-off-by: Bryan Bende <bbende@apache.org>
2016-08-09 13:07:50 -04:00
Matt Gilman aae6325603
NIFI-2237: - Reorganizing the refactored REST endpoints. - Tweaking message text.
This closes #788.

Signed-off-by: Bryan Bende <bbende@apache.org>
2016-08-09 12:04:31 -04:00
Joe Skora d094130a26 NIFI-2237:
Extend template handling to read only properties.
* Add read only property handling to type.hbs template.
* Add flag to ProcessorDTO.getRelationships to reflect read only nature of the property.
* Remove explicit "read only" message from ConnectionDTO.getAvailableRelationships to avoid duplicate text.
* This closes #806
2016-08-08 09:06:47 -04:00
Joe Skora 903b1fe465 NIFI-2494 Remove extraneous text that shows on banner line. This closes #793 2016-08-05 16:03:26 -04:00
Scott Aslan f2f070c5be
NIFI-2468: Improved UI consistency.
- Addressing comments from PR. Moving new service button below the tab pane. (+2 squashed commits)
Squashed commits:
[f746d09] NIFI-2468:
- Addressing numerous inconsistencies throughout the UI (button placement above tables, timestamp styles, etc)
[7d1fb09] addressing some inconsistencies

This closes #794.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
2016-08-05 12:32:06 -07:00
Mark Payne 8d34223265 NIFI-2472: Normalize coordinates for all components in a snippet, not just processors
This closes #786

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-04 19:46:39 -04:00
Matt Gilman c0a253568e NIFI-2486: - Authorizing individual bulletins being returned through the bulletin board.
This closes #792

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-04 18:41:18 -04:00
Matt Gilman 04147ac22a
NIFI-2458: - Fixing issue with timezone when the initial provenance result was cancelled.
This closes #773.

Signed-off-by: Bryan Bende <bbende@apache.org>
2016-08-04 17:09:21 -04:00
Matt Gilman 321a2398ba
NIFI-2467: - Resetting cached search term when closing the dialog to ensure the same search time works upon re-opening.
NIFI-2467: - Fixing issue preventing the selection of an autocomplete result.

This closes #784.

Signed-off-by: Bryan Bende <bbende@apache.org>
2016-08-04 11:22:01 -04:00
Mark Payne cda4310ad8 NIFI-2035: Verify existence of source and destination when creating a connection
Signed-off-by: Yolanda M. Davis <ymdavis@apache.org>

This closes #690
2016-08-04 09:11:25 -04:00
Scott Aslan ed5c44ba53 [NIFI-2053] update open/close palettes. This closes #775 2016-08-04 07:59:13 -04:00
Matt Gilman c26398eaba NIFI-2402: - Removing client side check component move eligibility and instead relaying on verification server side. Cannot check client side as the current user may not have permissions to inspect required fields.
This closes #750

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-03 19:08:25 -04:00
Matt Gilman 1511887a68 NIFI-2301: - Ensure all component specific policies are removed when the component is removed. - Allowing snippets to be created if the user has read or write access as we don't know what the intended snippet usage. When used the snippet is still authorized accordingly. - Ensuring actions involving Process Groups correctly authorize encapsulated components. - Not requiring read permissions when showing the delete button for Controller Services and Reporting Tasks.
This closes #757

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-03 18:06:30 -04:00
Matt Gilman 9338f102cb NIFI-2237:
- Updating Rest Endpoint documentation specifically regarding access policies.
- Ensuring the resource listing is accurate.
- Removing unnecessary code.
2016-08-03 16:18:30 -04:00
Mark Payne 16348b071d NIFI-2452: This closes #771. Ensure that we keep track of how many references we have to each lucene searcher and only close the underlying index reader if there are no references to the searcher. Also updated to prefer newer provenance events over older provenance events, and calculate FlowFile lineage based on an event id instead of a FlowFile UUID, as it's much more efficient 2016-08-03 08:05:26 -07:00
Matt Gilman 52d97f966d NIFI-2443: - Addressing issue where reload group deferred was being resolved prematurely.
This closes #756

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-02 17:06:25 -04:00
Matt Gilman ecca76099a NIFI-2427: - Only showing read/write data policies for applicable components. Disabling for labels, controller services, reporting tasks, and templates.
This closes #748

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-02 16:25:02 -04:00
Koji Kawamura aae2d27879 NIFI-2259: HTTP Site-to-Site can't handle DEST_FULL
HTTP Site-to-Site can't handle TRANSACTION_FINISHED_BUT_DESTINATION_FULL
scenario as expected.

That happens if the remote NiFi's input port destination relationship
becomes full during Site-to-Site client sends data. The data which has
already sent to the remote NiFi has to be committed successfully.
However, the remote NiFi returns 503 as a response of commit HTTP
request. Because it does check port availability.

The port availability check shouldn't be called at commit request, since
the session at source NiFi has already been committed. The remote NiFi
should commit its session as well, and return
TRANSACTION_FINISHED_BUT_DESTINATION_FULL response.

This fix makes a remote NiFi to keep the handshaken properties when it holds
transaction to be committed. Then if a transaction already has
handshaken properties, then use it, instead of doing a handshake process
again.
2016-08-02 09:08:00 -04:00
Koji Kawamura 809f042353 NIFI-2028: Fixed Site-to-Site Transit URI
Fixed Site-to-Site Transit URI for HTTP to be consistent with RAW socket.

- Removed url from CommunicationsSession since it's redundant as we have
  Peer.url, too. The value was not used from anywhere other than HTTP
Site-to-Site.
- Added createTransitUri method in Communicant interface, so that
  implementation can customize transitUri while providing consistent
interface.
2016-08-02 09:08:00 -04:00
Koji Kawamura 9a2f8c598e NIFI-2441 This closes #766. View state fails with a JS error
Removed permission check causing "Cannot read property 'canRead' of
undefined". A given user won't have record level permission
difference for component state. It's not required here.
2016-08-01 22:54:37 -04:00
joewitt 05a99a93cb NIFI-2208 This closes #754. refactored as per comments on JIRA. Reduced API expsosure and tightened lifecycle management. 2016-08-01 14:17:26 -04:00
Scott Aslan 7f45251bbd [NIFI-2426] Update visibility of New service/task button in Controller Settings
- Ensuring button is hidden when the user doesn't have permissions to modify the controller.
- This closes #759
2016-08-01 13:32:42 -04:00
Scott Aslan 5d63ba6a19 NIFI-2303 This closes #749. Update lineage styles 2016-08-01 13:30:58 -04:00
Matt Gilman 372a316deb NIFI-2401:
- Returning the enabled state of play and stop buttons in the palette. Allowing the user to always press if they have permissions to modify the selection.
 - Only attempting to schedule components that are not running, not disabled, and valid.

This closes #745

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-08-01 11:39:55 -04:00
Oleg Zhurakousky 1bf10944ea NIFI-2366 - Fixed ID generation semantics in clustered environment
- added SnippetUtilsTest
- renamed TypeOneUUIDGenerator to ComponentIdGenerator

- changed lsb part of ComponentIdGenerator back to long
- Fixed 'isCopy' condition for clustered environments

This closes #718.
2016-07-31 15:24:02 -04:00
Yolanda M. Davis 8412d2662a NIFI-2208 - initial commit Custom Property Expression Language support with Variable Registry, includes bug fix for NIFI-2057
This closes #529

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-07-29 17:10:20 -04:00
Scott Aslan 0c8fc25ba4 NIFI-2430 This closes #737. Update some tooltip text and context menu text/icon 2016-07-29 12:54:31 -04:00
Scott Aslan a8224edb8d [NIFI-2428] update modal glasspane to always close, even if the dialog we closed by user in close handler 2016-07-29 12:12:00 -04:00
Scott Aslan f5dfa580db [NIFI-2348] When processor is selected, can now copy id from palette 2016-07-29 12:12:00 -04:00
Scott Aslan da5e468489 [NIFI-2371] fix cluster page padding 2016-07-29 12:12:00 -04:00
Matt Gilman a73c8bba30 NIFI-2302: - Showing a message on the history page when in a cluster to indicate that only the actions from the current node are displayed.
This closes #740

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-07-29 11:27:09 -04:00
Matt Gilman da238b16ef NIFI-2122: - Merging responses for the current user and the flow configuration. - Returning whether NiFi is configured with a policy based authorizer in the flow configuration. - Only showing the users and policy icons when configured with a policy based authorizer. - Failing faster when invoking the users or policies endpoint when not configured with a configurable authorizer.
This closes #736

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-07-28 16:51:40 -04:00
Matt Gilman 01adb050f9 NIFI-2421: - Only attempting to clone policies when NiFI supports a configurable authorizer.
This closes #738

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-07-28 13:01:20 -04:00
Matt Gilman 09b124714e NIFI-2347: - Ensuring component specific policies are retained when using copy/paste. - This includes the policies for the component, data of the component, data transfers of the component, and policies of the component.
This closes #730

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-07-28 09:43:40 -04:00
Scott Aslan 25cadf5db1 [NIFI-2396] Update Bulletin Board shell header and filter control position. This closes #732 2016-07-28 09:09:25 -04:00
Bryan Bende dedd4fcda1 NIFI-2403
- Ensuring uniqueness on user identities and group names
- Ensure errors when updating a group are displayed.
- This closes #724
2016-07-28 08:45:47 -04:00
Matt Gilman ae344806c0 NIFI-2224: - Ensuring the template form is reset when the upload template dialog is closed. NIFI-2175: - Not submitting the template form is a template isn't choosen. NIFI-2176: - Ensuring a template is specified during creation. NIFI-2223: - Ensuring templates with the same name cannot be added. NIFI-2296: - Updating the tooltip for the upload template browse button.
- Cleaning up un-used parameters to REST endpoints.

This closes #725

Signed-off-by: jpercivall <joepercivall@yahoo.com>
2016-07-27 17:38:12 -04:00
Scott Aslan f3e49fefa0 [NIFI-2367] Overlapping links repositioned on error/login pages
[NIFI-2025] update birdseye after dragging/dropping element on the canvas
[NIFI-2367] update width of content viewer combo
[NIFI-2355] update table sorting based on auth efforts
[NIFI-2027] update EL editors
[NIFI-2387] update bulletin alert backgroud color to actually change the color of the icon not the div background
[NIFI-2141] Hide bulletin icon/background on processors unless a bulletin exists
[NIFI-2400] close any open combos contained within a shell when closing the shell
[NIFI-2404] remove extra scrollbar from #node-events
[NIFI-2027] account for min widths of EL editors
[NIFI-2025] update birdseye after changing color
[NIFI-2027] Update EL editor checkbox text
[NIFI-2027] update checkbox text
[NIFI-2355] update table sorting
[NIFI-2141] Hide bulletin icon/background on processors unless a bulletin exists
[NIFI-2027] update EL editors
[NIFI-2367] Overlapping links repositioned on error/login pages
This closes #715
2016-07-27 16:29:25 -04:00