Commit Graph

1168 Commits

Author SHA1 Message Date
Mark Payne 0bcb241db3 NIFI-4774: Implementation of SequentialAccessWriteAheadLog and updates to WriteAheadFlowFileRepository to make use of the new implementation instead of MinimalLockingWriteAheadLog.
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #2416
2018-02-19 09:26:01 -05:00
Mark Payne 14fef2de14 NIFI-4772: Refactored how the @OnScheduled methods of processors is invoked/monitored. The new method does away with the two previously created 8-thread thread pools and just uses the Timer-Driven thread pool that is used by other framework tasks.
NIFI-4772: Introduced a new thread-pool with 2 threads that will be used for monitoring lifecycle task. This means that if all threads in the timer-driven thead pool are blocked by processors that don't complete their @OnScheduled methods, we have a separate thread pool that at least gives us a chance of interrupting those threads

NIFI-4772: Remove unused import
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #2403
2018-02-19 09:19:53 -05:00
Bryan Bende b855d0acae
NIFI-4884 Fixing ordering during import from registry so that we set schedule strategy on a processor before setting scheduling duration. This closes #2472 2018-02-16 09:27:36 -05:00
Mark Payne 61c6f0305b
NIFI-4863: Bug fixes to the way that we handled Remote Group Ports when changing flow version / reverting local changes
- Everywhere that we ignore adding remote ports we should ignore removing remote ports as well in flow diffs

This closes #2462.

Signed-off-by: Bryan Bende <bbende@apache.org>
2018-02-09 15:45:54 -05:00
Bryan Bende 34b678d30d NIFI-4841 Fixing NPE when reverting local changes involving remote group ports. This closes #2454.
Signed-off-by: Mark Payne <markap14@hotmail.com>
2018-02-09 10:26:19 -05:00
Kevin Doran c4e2ac7cda
NIFI-4801 Fixes Swagger spec for uploadTemplate. This closes #2428 2018-01-25 10:02:56 -05:00
Peter G. Horvath 3ebfcd5ae5
NIFI-4424 Added functionality to allow NiFi to run in "embedded" mode for eventual integration test access.
This closes #2251.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
2018-01-22 12:00:33 -08:00
Matt Gilman 05e9e6eaa5 NIFI-4799:
- Ensure variable registry update request is marked completed.
This closes #2421.

Signed-off-by: Mark Payne <markap14@hotmail.com>
2018-01-22 12:53:23 -05:00
Kevin Doran 5d5edfa896
NIFI-4744 Detect incorrect authorizers config
Adds stricter checks in AuthorizerFactoryBean for unique ids within
a given type of provider and requires unique providers in composite
and composite-configurable user group providers. Failed validation
checks cause startup to fail. Adds test cases for these new rules.

This closes #2419.

Signed-off-by: Bryan Bende <bbende@apache.org>
2018-01-22 09:45:17 -05:00
sbouchex 94d0974003
NIFI-4795:
Fixed allowed values
This closes #2414
2018-01-19 12:58:36 -05:00
Matt Gilman e3c661daac
NIFI-4761 Fixing test case regression.
This closes #2418.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
2018-01-19 09:47:31 -08:00
Andy LoPresto 8cb09c301d
NIFI-4761
Added HostHeaderHandler regression unit tests before adding new functionality.
Added logic for parsing nifi.web.proxy.host property.
Added default property in nifi.properties and pom.xml.
Added logic for IPv6 and custom default hostnames.
Improved error messaging.
Added HostHeaderHandler unit tests.
Disabled HostHeaderSanitizationCustomizer in HTTP mode.
Fixed HTML escaping in error message.
Improved error message.
Added failing unit test for parsing custom hostnames.
Fixed custom hostname parsing.
Fixed unit tests.
Added TODO for IPv6 custom hostname parsing and unit test.
Added IPv6 custom hostname parsing and unit tests.
Fixed checkstyle issues.
Removed empty element in host list when no value defined.
Improved error message formatting.
Added unit tests.
Removed HostHeaderSanitizationCustomizer.
Removed InvalidPropertiesFormatException from NiFiProperties.
Removed InvalidPropertiesFormatException from HostHeaderHandler.
This closes #2415
2018-01-19 10:53:13 -05:00
sbouchex e4dda497bb
NIFI-4784: Fixed runStatus allowedValues. This closes #2407 2018-01-17 10:59:09 -05:00
Senthilannaswamy 790f14b8ef
NIFI-4781: Updated ClientAuthenticationMethod as optional field response from OpenID provider. This closes #2213 2018-01-17 10:55:11 -05:00
Mark Payne 28e1bcc9d0
NIFI-4782: Allow the value of a Required Property to be moved when changing version of a flow or reverting a flow
This closes #2406.

Signed-off-by: Bryan Bende <bbende@apache.org>
2018-01-16 14:14:25 -05:00
Mark Payne d93d538177
NIFI-4763: Ignore differences in components' Bundle Version when comparing a local flow to a flow in the registry
This closes #2393.

Signed-off-by: Bryan Bende <bbende@apache.org>
2018-01-16 12:48:17 -05:00
joewitt 41ce788812 NIFI-4751 changed to next minor release version snapshot 2018-01-12 15:15:32 -05:00
joewitt 42edfa75b7 Merge branch 'NIFI-4751-RC1' 2018-01-12 15:00:32 -05:00
Marco Gaido 39a484b631
NIFI-4764: Add tooltips to status bar icons
add tooltip to process groups
cleanup
This closes #2394
2018-01-11 12:25:33 -05:00
Mike Moser bcac2766bc NIFI-3648 removed message copying when not in debug mode. This closes #1637.
Signed-off-by: Mark Payne <markap14@hotmail.com>
2018-01-11 11:23:04 -05:00
Matt Gilman 674c9e4687 NIFI-4754:
- Only showing the import link in the new Process Group dialog when initiating from the toolbar.
This closes #2395.

Signed-off-by: Mark Payne <markap14@hotmail.com>
2018-01-11 10:34:46 -05:00
joewitt 36405e888c NIFI-4751-RC1 prepare for next development iteration 2018-01-08 23:39:49 -07:00
joewitt 46d30c7e92 NIFI-4751-RC1 prepare release nifi-1.5.0-RC1 2018-01-08 23:39:32 -07:00
Bryan Bende 4196140e4c
NIFI-4750 Ensuring preDestruction is called on authorizer and appropriate policy/user-group providers. This closes #2387 2018-01-08 16:40:40 -05:00
Matt Gilman 8f635f1c0d
NIFI-4436:
- Only enforcing the unique name check when the registry has a different identifier.

This closes #2385.

Signed-off-by: Bryan Bende <bbende@apache.org>
2018-01-08 15:13:31 -05:00
Matt Gilman 33b40fb87f NIFI-4739:
- Ensuring the logout action is using a relative link.

This closes #2374
2018-01-08 15:02:12 -05:00
Kevin Doran a8817e0238
NIFI-4708 Add Registry support to encrypt-config.
Adds support for NiFI Registry config files to the encrypt-config tool
in NiFi Toolkit.
Also adds decryption capability to encrypt-config tool.

This closes #2376.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
2018-01-08 11:17:21 -08:00
Mark Payne b6117743d4
NIFI-4436: Ensure that on save, we assign a Versioned Component Identifier to inner process groups that are tracking to remote flows, if they don't have one. This would occur, for instance, if a Process Group was imported into an existing group (or copied/moved into it) and then the existing group was saved.
NIFI-4436: Fixed a bug that caused a flow not to successfully change version if a connection is added to an existing component and that component is running at time of version change

NIFI-4436: Fixed bug with ordering of controller services being enabled and disabled

NIFI-4436: Fixed bug that prevented local input and output ports from being stopped and started as needed

NIFI-4436: Fixed bugs around referencing controller services that are at a higher level than the versioned flow

NIFI-4436: Ensure that we clear components from FlowController's cache when removed and that they are added to cache when created.

NIFI-4436: Fixed error message coming back if component is invalid when trying to be restarted/re-enabled

NIFI-4436: Addressed issue with children of a removed process group not being considered 'affected components' and as a result not being stopped/disabled/restarted/re-enabled

This closes #2219.

Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 13:10:13 -05:00
Matt Gilman fa996cd418
NIFI-4436:
- Minor tweak to when the max height for the options list is calculated per PR comments.
- Resolving logic issue in two phase commit when updating variable registry.
- Fixing variable visibility.
2018-01-08 12:44:57 -05:00
Mark Payne f702f808a7
NIFI-4436: Fixed bug that caused a Process Group to be 'dirty' if a processor that was referencing a non-existent controller service is updated to reference an externally available controller service
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:57 -05:00
Matt Gilman b3e1584ef4
NIFI-4436:
- Addressing PR feedback.
- Addressing two phase commit logic issue when changing the flow version.
2018-01-08 12:44:57 -05:00
Mark Payne 63544c880f
NIFI-4436: Fixed bug that caused in Process Groups' names not to be fixed when reverting changes
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:57 -05:00
Matt Gilman fd18eeb84e
NIFI-4436:
- Code clean up.
- Backing out incomplete fix for variable registry two phase commit to address in separate JIRA.
2018-01-08 12:44:57 -05:00
Mark Payne 118667a601
NIFI-4436: Bug fixes
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:56 -05:00
Matt Gilman 20b539aac3
NIFI-4436:
- Bumping registry version to 0.1.0.
- Addressing PR comments.
2018-01-08 12:44:56 -05:00
Mark Payne 0127b02617
NIFI-4436: Fixed bug that causes a deadlock when changing version of a PG. Before this patch, an update would obtain a write lock and then recurse downward through the child groups, obtaining write locks to update variable registries. At the same time, if a Processor is obtaining a Controller Service, it will obtain a Read Lock on the Process Group and then recurse upward through the ancestors, obtaining Read Lock. If the timing is right, we can have a group obtain a read lock, then try to obtain its parent's Read Lock. At the same time, an update to the group could hold the Write Lock on the Process Group and attempt to obtain a Write Lock on child (where the Processor lives), resulting in a deadlock.
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:56 -05:00
Matt Gilman c5b0931e55
NIFI-4436:
- Minor UX tweaks.
- Updating imports due to refactoring of Registry models.
- Fixing checkstyle issues.
2018-01-08 12:44:56 -05:00
Mark Payne 416b86145f
NIFI-4436: Bug fixes
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:56 -05:00
Matt Gilman f48808b1f4
NIFI-4436:
- Updating buckets permissions based on new model.
- Adding check to ensure that flow name is non null before checking the length.
- Adding versioned flow state to the Process Group tab in the Summary table.
- Fixing issue with navigating to Controller Services from the local changes dialog.
2018-01-08 12:44:56 -05:00
Mark Payne 181d6809c1
NIFI-4436: Bug fixes; ensure correct Exception types are thrown
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:55 -05:00
Matt Gilman 1266235c00
NIFI-4436:
- Code clean up.
- Improved error handling.
- Minor UX improvements.
- Always showing Process Group state to complement the aggregation counts.
- Adding the Process Group state to the top status bar.
2018-01-08 12:44:55 -05:00
Mark Payne fe8b30bf26
NIFI-4436: Removed isCurrent, isModified from VersionControlInformation and associated DTO. Bug fixes & code refactoring
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:55 -05:00
Matt Gilman db2cc9fec1
NIFI-4436:
- Code clean up.
- Improved error handling.
- Minor UX improvements.
- Adding message to indicate that variables do not support sensitive values.
- Preventing a user from changing the flow version to the current version.
- Only presenting buckets a user has appropriate permissions to.
- Adding basic auditing to the version control actions.
2018-01-08 12:44:55 -05:00
Mark Payne 014c542f48
NIFI-4436: Bug fix to ensure that RPG's ports are not removed until after connections are established to the ports; ensure that if a registry's name is changed that it is updated immediately in VersionControlInformation objects
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:55 -05:00
Matt Gilman 49aad2c3a8
NIFI-4436:
- Updating front end to use version control state/status.
- Fixing copy/paste issue during revert local changes.
- Code clean up in the breadcrumbs.
- Update VersionsResource authorization and two phase commit object usage.
2018-01-08 12:44:54 -05:00
Mark Payne fdef5b5605
NIFI-4436: More intelligently flag a ProcessGroup to indicate whether or not it has any local modifications compared to Versioned Flow - Bug fixes - Updated to include status of a Versioned Process Group to include VersionedFlowState and explanation
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:54 -05:00
Matt Gilman d34fb5e2ef
NIFI-4436:
- Addressing miscellaneous minor UX issues.
- Updating comments UX for all components.
- Updating the styling of PG and RPG to be more consistent.
- Adding the icons for nested versioned process groups.
- Calculating the number/states of nested versioned process groups.
2018-01-08 12:44:54 -05:00
Mark Payne e1606701c7
NIFI-4436, NIFI-4461: When copying and pasting an RPG, ensure that we copy Batch Settings for each Port. Bug fixes. Now works in clustered mode.
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:54 -05:00
Matt Gilman c92022dd60
NIFI-4436:
- Fixing default border radius.
- Code clean up.
- Ensuring component visibility is updated after updating/reverting.
- Fixing sort on component name in local changes dialog
NIFI-4526:
- Added front end controls for updating RPG target URL.
2018-01-08 12:44:54 -05:00
Mark Payne adacb204a8
NIFI-4436: Bug fixes - Checkpoint before allowing multiple Process Groups with same Versioned Component ID and same parent - Ensure that if flow update is cancelled while processors are being stopped/services disabled that we stop waiting for that to occur. Also ensure that if we fail to update flow that we re-enable/restart the processors and services - Updated verbiage to use a ConciseEvolvingDifferentDescriptor when getting local modifications for a versioned flow - Do not allow outer process group to be saved to flow registry or have local modifications reverted if it has a descendant process group that is under version control and is dirty. Fixed bug where ComponentDifferenceDTO was populated with wrong component id and group id
Signed-off-by: Matt Gilman <matt.c.gilman@gmail.com>
2018-01-08 12:44:53 -05:00