Commit Graph

327 Commits

Author SHA1 Message Date
Joseph Witt 67ba13796e
NIFI-12150 Restored NiFiRegistrySecurityConfig required for Registry
- NiFiRegistrySecurityConfig was removed mistakenly in NIFI-12147 and updating extractor to match changes in NIFI-12147 for DN extraction

This closes #7815

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-09-29 14:21:40 -05:00
Mark Payne db727aa419
NIFI-12142: This closes #7806. Deleted many methods, classes, and references that were deprecated.
Signed-off-by: Joseph Witt <joewitt@apache.org>
2023-09-28 14:07:48 -07:00
Pierre Villard 43cc5ad122
NIFI-12079 This closes #7750. Remove Variables / Variable Registry
Signed-off-by: Joseph Witt <joewitt@apache.org>
2023-09-25 09:39:53 -07:00
Pierre Villard 2aca08910c
NIFI-12103 Replaced deprecated usage of new URL(String)
This closes #7771

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-09-23 10:30:42 -05:00
Pierre Villard 4b9eb8361c
NIFI-12113 Replaced Validate.notNull() with Objects.requireNonNull()
This closes #7779

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-09-22 15:18:50 -05:00
mr1716 66524ab267
NIFI-12043 Upgraded MariaDB Java Client from 3.1.4 to 3.2.0
This closes #7747

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-09-19 08:03:19 -05:00
Joseph Witt 71bdbc080b
NIFI-12066 Upgraded framework and cloud provider dependencies
- Upgraded SLF4J from 2.0.7 to 2.0.9
- Upgraded Logback from 1.3.8 to 1.3.11
- Upgraded Testcontainers from 1.18.3 to 1.19.0
- Upgraded Fabric8 Kubernetes from 6.5.1 to 6.8.1
- Upgraded AspectJ from 1.9.19 to 1.9.20.1
- Upgraded Caffeine from 3.1.6 to 3.1.8
- Upgraded AWS SDK from 2.20.103 to 2.20.148
- Upgraded Guava from 32.0.1 to 32.1.2
- Upgraded Nimbus JOSE JWT from 9.31 to 9.33
- Upgraded Apache Tika from 2.8.0 to 2.9.0
- Upgraded gRPC from 1.57.2 to 1.58.0
- Upgraded Google Libraries from 26.17.0 to 26.22.0
- Upgraded Azure SDK from 1.2.13 to 1.2.16

This closes #7733

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-09-15 13:05:31 -05:00
Joseph Witt a1fca9b44e
NIFI-12064 Upgraded Maven Plugin versions
This closes #7731

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-09-14 19:35:51 -05:00
exceptionfactory aee9f2c65d
NIFI-12034 This closes #7729. Upgraded Apache Commons Compress from 1.23.0 to 1.24.0
Signed-off-by: Joseph Witt <joewitt@apache.org>
2023-09-14 13:21:17 -07:00
exceptionfactory 98fa7d0290
NIFI-12060 This closes #7694. Removed Groovy Tests using Spock Framework
- Added org.spockframework to the list of banned dependencies
- Removed several other Groovy tests and associated build profiles

Signed-off-by: Joseph Witt <joewitt@apache.org>
2023-09-14 11:22:54 -07:00
exceptionfactory 6841aa6e99
NIFI-12047 Added HTTP/2 to Default Application Protocols
- Changed default value of nifi.web.https.application.protocols to include both h2 and http/1.1
- Changed default value of nifi.registry.web.https.application.protocols to include both h2 and http/1.1
- Updated HostHeaderHandler logging

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #7684.
2023-09-14 13:50:01 +02:00
Ravinarayan Singh 56a65a5877
NIFI-11947 Support preserving created timestamp for Flow Snapshots
This closes #7610

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-08-30 12:19:59 -05:00
Tamas Palfy d4147ca442
NIFI-8650 Added Flow Analysis Rules
- Added new extensible Component Type: FlowAnalysisRule
- Added DisallowComponentType Rule implementation
- Flow Analysis Rules can be managed from the UI under Controller Settings -> Flow Analysis Rules
- Flow Analysis Rules can be set up with an enforcement policy of WARN or ENFORCE
- Flow Analysis Rules can evaluate an individual Component or a Process Group

This closes #7191

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-08-29 15:50:22 -05:00
ravisingh 6bb2d62ffd
NIFI-11946 Support preserving created timestamp for Registry Flows
This closes #7604

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-08-28 16:59:12 -05:00
exceptionfactory c08560447f NIFI-11518 Upgraded Jetty from 9.4.51 to 10.0.15
- Updated Jetty WebSocket components using Jetty 10 components
- Upgraded Solr components from 8.11.2 to 9.2.1 to align with Jetty 10 dependencies

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes #7622
2023-08-23 14:42:59 -04:00
mr1716 dcc2480cb5
NIFI-11956 Upgraded Frontend Maven Plugin from 1.12.1 to 1.13.4
This closes #7617

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-08-18 12:53:24 -05:00
mr1716 70c756ff78
NIFI-11953 Upgraded download-maven-plugin from 1.6.8 to 1.7.1
This closes #7613

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-08-16 21:03:41 -05:00
Mark Payne b3c620411a
NIFI-11556: Added ability to use a Process Group as a Stateless Flow
When shutting down FlowController, wait up to gracefulShutdownSeconds seconds for the components to stop before shutting down thread pools. This allows for asynchronous operations such as disableControllerServicesAsync to complete during shutdown. Updated StandardStatelessFlow so that on shutdown it catches more general Exception to ensure that shutdown succeeds

Ensure that Max Concurrent Tasks cannot be set less than 1 for stateless group; fixed typo in ProcessGroupDTO's docs; on shutdown, we may need to disable controller services asynchronously. At that point, the thread pool used to do so may already be shutdown. If so, catch this and create a new single-thread pool, disable the service, and immediately shutdown the pool. Also, if we fail to disable services on shutdown of a stateless flow, instead of throwing an Exception, just log it and move on - it doesn't make much sense for shutdown() to throw an Exception in that case.

Updated system tests so that when emptying a queue, we check the result and if the queue still has data (because a Processor hasn't acknowledged the data, for example) then continue issuing request until the queue fully becomes empty.

When shutting down input/output ports for stateless group, ensure that we wait for the ports' active threads to complete before returning

When stopping StatelessGroupNode, ensure that all the Processors, Controller Services (even those not executed by the Stateless Engine) are stopped/disabled before considering the Stateless Group to be fully STOPPED.

This closes #7253

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-08-09 12:08:22 -05:00
Mike Thomsen cba6b00271
NIFI-11383 Updated Java documentation links from 8 to 17
This closes #7581

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-08-09 09:17:48 -05:00
mr1716 a374ce67af
NIFI-11862 Upgraded mysql-connector-j from 8.0.33 to 8.1.0
This closes #7530

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-07-27 15:23:12 -05:00
Pierre Villard dbb2d6905f
NIFI-11842 - remove getTargetUri() and code cleanup
This closes #7511

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-07-24 13:53:17 -05:00
dependabot[bot] f5407fcbe8
NIFI-11831 Upgraded word-wrap from 1.2.3 to 1.2.4
This closes #7499

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-07-19 10:15:42 -05:00
dependabot[bot] 063ab5cba8
NIFI-11790 Upgraded stylelint from 14.2.0 to 15.10.1
- Upgraded stylelint-config-standard-scss from 3.0.0 to 10.0.0
- Updated stylelint configuration for Registry to ignore new warnings

This closes #7464

Co-authored-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-07-10 16:45:11 -05:00
exceptionfactory 50b01ffd63
NIFI-11714 Added Error Handler to Jetty Server
- Configured Error Handler with Stack Traces disabled for NiFi and Registry

Signed-off-by: Joe Gresock <jgresock@gmail.com>

This closes #7447.
2023-06-29 16:44:01 -04:00
timeabarna ba6797bb94
NIFI-3065 Per Process Group logging (#7315)
* NIFI-3065 Per Process Group logging
2023-06-23 21:14:34 -04:00
mr1716 05322fa8ce
NIFI-11730 Upgraded UnboundID LDAP SDK from 6.0.8 to 6.0.9
This closes #7412

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-06-20 17:12:05 -05:00
exceptionfactory 305277b833 NIFI-11709 Upgraded Guava from 32.0.0 to 32.0.1
- Added version override for Guava 27 to 32.0.1 in Hadoop and Hive modules

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes #7415
2023-06-20 16:22:00 -04:00
exceptionfactory 0ed1efc50a
NIFI-11712 Removed java.net.preferIPv4Stack from bootstrap.conf
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #7392.
2023-06-19 10:22:31 +02:00
exceptionfactory b6b621bf9e
NIFI-11717 Updated Required Java Version to 17.0.6
- Added Groovy Plugin Repository for groovy-eclipse-compiler

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #7397.
2023-06-19 10:19:55 +02:00
exceptionfactory 6b19ab8eaa NIFI-11696 Upgraded Bouncy Castle from 1.71 to 1.74
- Adjusted nifi-repository-encryption to remove dependency on Bouncy Castle Provider
- Updated Google Cloud Provider dependencies to remove exclusions and dependencies on Bouncy Castle that no longer apply to current versions

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes #7384
2023-06-15 16:33:20 -04:00
exceptionfactory ca6c7f7041 NIFI-11532 Removed JUnit 4 and Groovy Test from default dependencies
- Removed hamcrest-all from default dependencies
- Added groovy-test to selected modules with Groovy test classes
- Added junit-vintage-engine to selected modules with JUnit 4 test classes
- Corrected references to JUnit 4 assertions in JUnit 5 test classes
- Removed several unnecessary test classes from nifi-socket-utils
- Removed duplicative Registry toolkit test classes
- Removed Kudu integration tests

NIFI-11532 Corrected scope for junit-vintage-engine for Elasticsearch

Signed-off-by: Matt Burgess <mattyb149@apache.org>

This closes #7233
2023-06-13 15:36:23 -04:00
mr1716 02a34034fa
NIFI-11664 Upgraded WebDriverManager from 3.3.0 to 3.8.1
This closes #7359

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-06-08 16:18:45 -05:00
mr1716 054df20aed
NIFI-11665 Upgraded oauth2-oidc-sdk from 9.43.1 to 9.43.3
This closes #7358

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-06-08 16:18:44 -05:00
exceptionfactory c5c711c91d
NIFI-11645 This closes #7342. Upgraded Guava from 31.1 to 32.0.0
- Added selective overrides to upgrade transitive dependencies

Signed-off-by: Joe Witt <joewitt@apache.org>
2023-06-05 14:33:10 -07:00
siddr 0cd511f1aa
NIFI-11640 Upgraded download-maven-plugin from 1.2.1 to 1.6.8
This closes #7337

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-06-05 11:33:34 -05:00
mr1716 852ec9eefc
NIFI-11633 Upgraded MariaDB client from 3.1.3 to 3.1.4
This closes #7330

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-06-02 15:10:51 -05:00
Mark Payne 50811660d0
NIFI-11603 Refactored Socket-based tests to use Dynamic Ports
- Removed NetworkUtils methods for getting available ports
- Updated Socket-based components to support using 0 to listen on a random available port for improved test reliability

This closes #7299

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-06-01 13:33:06 -05:00
mr1716 d96f28b17a NIFI-11601 Update mysql-connector-java to 8.0.33
This closes #7303

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2023-05-29 08:01:42 -04:00
dependabot[bot] 1642315c0f
NIFI-11589 Upgraded socket.io-parser from 4.2.2 to 4.2.3
This closes #7288

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-05-24 09:07:19 -05:00
exceptionfactory 5bbde66f14
NIFI-11558 Applied Security Headers to All Registry Responses
- Refactored Registry Filters to shared HeaderWriterHandler
- Refactored Registry Jetty Server with delegated HandlerProvider

Signed-off-by: Joe Gresock <jgresock@gmail.com>

This closes #7258.
2023-05-23 06:43:16 -04:00
exceptionfactory c32bfd0557
NIFI-11568 Removed Apache DS Test Dependency
Signed-off-by: Joe Gresock <jgresock@gmail.com>

This closes #7264.
2023-05-21 07:17:52 -04:00
Jeyassri Balchandran 764cc9e9b0
NIFI-11467 Upgraded jjwt from 0.7.0 to 0.9.1
This closes #7256

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-05-17 09:39:11 -05:00
Tan Luu fcf2446bb5
NIFI-11485 Added Toolkit to Registry Docker Image
This closes #7197

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-05-16 08:21:15 -05:00
nathluu 0308b5b404
NIFI-11545 Fixed test-all-dbs for Registry integration tests
This closes #7244

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-05-15 10:30:24 -05:00
dependabot[bot] bfa93b2b9e
NIFI-11541 Upgraded engine.io from 6.4.1 to 6.4.2
This closes #7227

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-05-11 15:45:09 -05:00
timeabarna 3df8c9d2ac
NIFI-11327 Add Export/Import All - NiFi CLI - NiFi Registry (#7092)
* NIFI-11327 Add Export/Import All - NiFi CLI - NiFi Registry
* NIFI-11327 Addressing review comment, updating storage location, improving serialization
* NIFI-11327 Addressing review comments, updating Rest endpoints and storage location handling
* NIFI-11327 Restoring EventType to its original version
* NIFI-11327 Addressing review comments changing skipExisting, updating documentation, adding some more error handling
2023-04-19 13:27:41 -04:00
Pierre Villard 83d19a6e9d
NIFI-11413 Upgraded JUnit 5.9.1 to 5.9.2
- Upgraded JUnit 4.13.1 to 4.13.2

This closes #7144

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-04-10 08:42:24 -05:00
Pierre Villard 0160d6d6b9
NIFI-11410 Upgraded multiple integration dependencies
- Upgraded Spring Boot from 2.7.9 to 2.7.10

This closes #7141

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-04-10 08:40:09 -05:00
Pierre Villard 4a0b38f4dd
NIFI-11405 Upgraded multiple drivers and test dependencies
This closes #7134

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-04-07 15:54:51 -05:00
mr1716 3fa25b6f11
NIFI-11352 Upgraded PostgreSQL JDBC from 42.5.3 to 42.6.0
This closes #7114

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-04-03 14:28:39 -05:00
exceptionfactory f0c9f3f892
NIFI-11372 Removed unused javax.el dependency from Registry
- Removed unnecessary JSTL dependency and reference from Documentation JSP

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #7110.
2023-04-02 17:18:39 +02:00
exceptionfactory 7cb20d6f7f
NIFI-11356 This closes #7096. Upgraded Nimbus JOSE JWT to 9.31
- Upgraded NiFi Framework from 9.24.3
- Upgraded NiFi Registry from 8.20
- Upgraded transitive msal4j dependency from 9.22
- Upgraded transitive hadoop-auth dependency from 9.8.1

Signed-off-by: Joe Witt <joewitt@apache.org>
2023-03-28 14:22:12 -07:00
Joe Witt 58517e4dd0
NIFI-11329 Updated NAR Plugin to 1.5.0 and Commons Compress to 1.23.0
This closes #7077

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-03-23 12:28:40 -05:00
Mark Bean af3737e670
NIFI-11302 Corrected Registry version retrieval
- Updated Maven JAR plugin configuration for nifi-registry-data-model to include implementation version

This closes #7057

Co-authored-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-03-22 16:44:59 -05:00
Chris Sampson c7df46eefd
NIFI-11312 Rationalised Registry Docker scripts in one location
This closes #7064

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-03-22 09:45:20 -05:00
Chris Sampson d604c87247
NIFI-11311 Updated maven-antrun-plugin to 3.1.0 across all modules
This closes #7062

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-03-21 08:06:02 -05:00
simonbence 7954ff355c
NIFI-11213 Showing version change in older (pre 1.18.0) contained version flows properly (#7017) 2023-03-20 11:52:07 -04:00
Ryan Van Den Bos dfc031f0da
NIFI-11252 Added OIDC Client Secret to sensitive Registry properties
This closes #7044

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-03-15 15:37:19 -05:00
Scott Aslan 1f34b9cd99
[NIFI-11258] update nifi-registry frontend deps (#7025)
* [NIFI-11258] update nifi-registry frontend deps

* review feedback

Merged #7025.
2023-03-13 10:53:11 -07:00
exceptionfactory d3908dede8
NIFI-11253 Removed H2 1.4 database migration modules
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #7014
2023-03-07 10:35:21 -05:00
exceptionfactory c8b5c0ce7b
NIFI-11220 Removed nifi-bootstrap-utils
- Replaced OSUtils.getProcessId() with java.lang.Process.pid() available on Java 9 and following

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #6989.
2023-02-27 13:51:14 +01:00
Kevin Doran e7af4c10df
NIFI-11193 Improve GitFlowPersisenceProvider logging
This closes #6967

Co-authored-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-02-16 18:24:46 -06:00
mkalavala 0d0ba1ca41
NIFI-9131 Refactor nifi-ldap-iaa-providers-bundle to use JUnit 5
This closes #6946

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-02-14 16:03:31 -06:00
exceptionfactory 1156f4cbc5
NIFI-11165 This closes #6944. Removed optional jigsaw build profiles
- Removed jigsaw build profiles
- Removed Java 11 directories from assemblies

Signed-off-by: Joe Witt <joewitt@apache.org>
2023-02-13 13:01:58 -05:00
Pierre Villard 18ef2a57a5
NIFI-11164 Updated minimum Java version from 8 to 11.0.16
- Updated GitHub workflows from Java 8 to 11
- Updated Maven Compiler Source and Target version from 1.8 to 11
- Disabled JASN1 tests failing on Windows with Java 11

This closes #6940

Co-authored-by: David Handermann <exceptionfactory@apache.org>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-02-10 23:31:37 -06:00
Joe Witt 43eab4c81d
NIFI-11103 prepping for 2.0.0 line 2023-02-09 15:32:53 -07:00
Emilio Setiadarma 1395e22f0f
NIFI-11061 Added Registry properties for HTTPS network interfaces
This closes #6931

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-02-09 14:42:33 -06:00
mkalavala 889767683c
NIFI-11116 Refactored nifi-registry-core to use JUnit 5
This closes #6929

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-02-08 13:59:16 -06:00
Joe Witt efe7b7d30f
NIFI-11103 bumping version refs for 1.20 2023-02-06 11:20:34 -07:00
exceptionfactory a9ea659622
NIFI-11145 This closes #6928. Upgraded PostgreSQL JDBC from 42.4.3 to 42.5.3
Signed-off-by: Joe Witt <joewitt@apache.org>
2023-02-06 10:31:08 -07:00
Joe Witt 4f91420cc1
NIFI-11139 Updated multiple Maven Plugins
This closes #6925

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-02-03 16:07:02 -06:00
simonbence ae66ebdc22
NIFI-10973 Introduce differention of comparing embedded versioned flows for UI and synchronisation purposes (#6870)
* NIFI-10973 Introduce differention of comparing embedded versioned flows for UI and synchronisation purposes
2023-01-31 10:58:42 -05:00
exceptionfactory cd3323a8a7
NIFI-11093 This closes #6887. Removed unused superagent dependency from Registry
Signed-off-by: Joe Witt <joewitt@apache.org>
2023-01-25 10:00:26 -07:00
exceptionfactory 972667461b
NIFI-10580 This closes #6867. Upgraded SLF4J from 1.7.36 to 2.0.6
- Upgraded Logback from 1.2.11 to 1.3.5
- Updated Logback DelayingShutdownHook to DefaultShutdownHook
- Disabled Spring Boot Logging System in favor of standard Logback initialization
- Excluded logback-classic from ZooKeeper and other dependencies to avoid conflicts when running tests
- Excluded spring-boot-starter-logging to avoid failures related to Logback 1.2 and Spring Boot 2.7
- Removed ZooKeeperMigratorTest.groovy based on Apache Curator test server usage of Logback 1.2

NIFI-10580 Added logback-core as explicit dependency

- Set logback-core as provided in root configuration
- Added logback-core as compile dependency in assembly configurations

Signed-off-by: Joe Witt <joewitt@apache.org>
2023-01-23 11:38:10 -07:00
Nissim Shiman c1eeb05f7b
NIFI-11041 Convert nifi-registry to use JUnit5 - Part 1
This closes #6873

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-01-20 14:23:23 -06:00
mr1716 3fafb8798f
NIFI-11073 Update mysql-connector-java to 8.0.32
This closes #6864

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-01-19 14:13:21 -06:00
mr1716 977847b940
NIFI-11074 Update mariadb-java-client to 3.1.1
This closes #6862

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-01-19 14:10:28 -06:00
exceptionfactory 9067774237
NIFI-11051 Corrected handling of empty Registry host property
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #6842.
2023-01-19 12:40:32 +01:00
dependabot[bot] 58e3024db0
NIFI-11065 Upgraded decode-uri-component from 0.2.0 to 0.2.2
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

This closes #6771

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-01-17 16:08:09 -06:00
dependabot[bot] 9552929c8c
NIFI-11063 Upgraded express from 1.19.1 to 1.20.1
Bumps [qs](https://github.com/ljharb/qs), [body-parser](https://github.com/expressjs/body-parser) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `qs` from 6.9.6 to 6.11.0
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.9.6...v6.11.0)

Updates `body-parser` from 1.19.1 to 1.20.1
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](https://github.com/expressjs/body-parser/compare/1.19.1...1.20.1)

Updates `express` from 4.17.2 to 4.18.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.17.2...4.18.2)

This closes #6764

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-01-17 13:59:54 -06:00
Justin Rittenhouse de1d26d8bf
NIFI-10799 Add OIDC to Docker images for NiFi and NiFi Registry
This closes #6651

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2023-01-12 13:17:16 -06:00
exceptionfactory 1404a151a1 NIFI-11015 Corrected Registry Trust Store Type handling
Signed-off-by: Chris Sampson <chris.sampson82@gmail.com>

This closes #6815
2022-12-31 09:33:13 +00:00
Bryan Bende 6a149c3f34
NIFI-10984 Allow NAR to be uploaded to NiFi Registry without extension manifest (#6784)
This closes #6784 
Signed-off-by: Otto Fowler <otto@apache.org>
2022-12-20 14:20:10 -05:00
Mark Payne e1c8c96111 NIFI-10937, NIFI-10938, NIFI-10939: When restoring flow from XML, properly parse XML for registry clients, looking for 'id' tag instead of 'identifier' tag. Fixed typo in error message about Reporting Task for Registry Clients. Updated StandardFlowComparator so that we compare sub-process groups' contents only if the Flow Coordinates are different by more than their version
Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6752.
2022-12-02 18:37:47 -05:00
Emilio Setiadarma 844751cec0 NIFI-10177: Implemented ID token logout and revoke access token logout for NiFi Registry when using OIDC/OAuth 2.0 providers
NIFI-10177: Addressed latest PR reviews. Reworded comments in the logout endpoint, use nifi registry properties to configure HTTP client timeouts for OIDC logout request, used NiFiUserUtils.getNiFiUserIdentity to retrieve identity used to delete the key

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6637.
2022-11-30 14:19:11 -05:00
exceptionfactory de296b5e65 NIFI-10897 Replaced Spring Security Base64 with java.util.Base64
This closes #6728

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-11-29 12:20:16 -05:00
dependabot[bot] 95f5bea15d
NIFI-10886 Upgraded PostgreSQL JDBC Driver from 42.4.1 to 42.4.3
This closes #6713

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-11-28 11:03:46 -06:00
Joe Witt 75e7c9e47c
NIFI-10854-RC1 prepare for next development iteration 2022-11-22 19:22:47 -07:00
Joe Witt ec87bf93ad
NIFI-10854-RC1 prepare release nifi-1.19.0-RC1 2022-11-22 19:22:45 -07:00
exceptionfactory 5bc8e49c7a NIFI-10755 Refactored SSLContext creation using nifi-security-ssl
- Added TrustManagerBuilder to nifi-security-ssl
- Removed SslContextFactory and CertificateUtils from nifi-registry
- Refactored c2-client-http
- Refactored minifi-bootstrap
- Refactored nifi-site-to-site-client
- Refactored nifi-registry-client
- Refactored nifi-registry-framework
- Refactored nifi-toolkit-admin
- Refactored nifi-toolkit-cli

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6618.
2022-11-22 18:33:11 -05:00
Kevin Doran 78f206a811 NIFI-10820 Change Docker base image to eclipse-temurin
NIFI-9656 Change Docker images to use Java 11

This closes #6673

Signed-off-by: Chris Sampson <chris.sampson82@gmail.com>
Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-11-18 10:50:37 +00:00
exceptionfactory 9e3987d04e
NIFI-10826 Separated Maven Compile and Verify in ci-workflow
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #6666
2022-11-16 12:56:33 -05:00
Shawn Weeks e8774979de
NIFI-10751 Add Username to User and Group CRUD (#6614) 2022-11-14 13:49:07 -05:00
exceptionfactory 3a536e261f NIFI-10798 Added Deprecation Logging for Java 8 on Startup
- Added deprecation warnings for NiFi, Registry, and MiNiFi
- Added RuntimeVersionProvider for shared reference to deprecated and minimum versions

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6648.
2022-11-10 21:48:50 -05:00
Chris Sampson 2acfd1e496 NIFI-9398 add verification to ElasticSearchClientService (with integration tests) and Elasticsearch REST API processors
NIFI-9398 processor verification integration-tests for nifi-elasticsearch-restapi-processors using common nifi-elasticsearch-test-utils refactored from nifi-elasticsearch-client-service
NIFI-9398 fail index exists verification for Elasticsearch processors whose operations would not create the index if it doesn't already exist

This closes #6544

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-11-05 18:17:13 -04:00
Joe Witt c155d29658
NIFI-10614 Upgraded Bouncy Castle from 1.70 to 1.71
- Blocked Bouncy Castle jdk15on dependencies
- Forced jdk18on dependencies and validated across entire build

This closes #6498

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-10-20 19:35:02 -05:00
exceptionfactory b753c1c72d NIFI-10625 Added support for HTTP/2 in Registry
- Added nifi-security-ssl for generalized SSLContext creation
- Removed static keystore and truststore test files from nifi-registry-jetty

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6514.
2022-10-17 23:52:09 -04:00
UcanInfosec bede739af7
NIFI-10619 Upgraded mysql-connector-java from 8.0.29 to 8.0.30
This closes #6502

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-10-11 10:10:33 -04:00
Jeremy Snyder b862fff8f0
NIFI-10498 Added Cipher Suite configuration to NiFi Registry
This closes #6458

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-10-10 10:53:06 -05:00
dan-s1 5da9ce525c
NIFI-10565 Removed duplicated test dependencies
This closes #6482

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-10-07 09:07:51 -05:00
Joe Witt c6a9d70814
Merge branch 'NIFI-10521-RC4' 2022-10-06 14:13:30 -07:00
mr1716 01b2cda35c
NIFI-10590 Upgrade Groovy From 2.5.14 To 2.5.18
This closes #6485

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-10-05 12:16:33 -04:00
Joe Witt c9ebdd2025
NIFI-10521-RC4 prepare for next development iteration 2022-10-03 10:59:36 -07:00
Joe Witt 109e54cd58
NIFI-10521-RC4 prepare release nifi-1.18.0-RC4 2022-10-03 10:59:34 -07:00
Andrew Lim 422134c55d
NIFI-10501 Update User Guide and Registry Quick Start Guide for Management Controller Services, Registry Client and Replay last event updates
This closes #6471.

Signed-off-by: Joe Gresock <jgresock@gmail.com>
2022-10-03 05:47:24 -04:00
exceptionfactory 0dec6bfbe1
NIFI-10560 This closes #6459. Excluded Elasticsearch and Solr Auto Configuration from Registry
- Excluding these configurations avoids unexpected runtime behavior when running Registry with the Apache Ranger plugin

Signed-off-by: Joe Witt <joewitt@apache.org>
2022-09-28 16:32:35 -07:00
simonbence 94fdc794b0
NIFI-10497 Making RegistryClient an extension point (#6433)
- NIFI-10497 Mae FlowRegistryClient an extension point
2022-09-26 12:16:21 -04:00
dependabot[bot] e8dd601e53
NIFI-10519 Upgraded JavaScript terser library from 4.8.0 to 4.8.1
This closes #6232

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-09-16 16:37:17 -05:00
exceptionfactory 5b3601f50f
NIFI-10472 Upgraded SnakeYAML from 1.29 to 1.31
- Replaced module overrides with root managed dependency version

This closes #6389

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-09-09 20:38:01 -04:00
Joe Gresock de7793e69b
NIFI-9003 Added framework support for Parameter Providers
- Added Environment Variable and File Parameter Provider implementations
- Added Parameter Provider commands to CLI
- Added component search handling for Parameter Providers
- Added documentation for integrating Parameter Providers

This closes #5369

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-09-09 13:04:56 -05:00
nathluu 96c5bc80c5
NIFI-10376 Set log directory in run-nifi-registry.bat
This closes #6318

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-09-08 15:20:04 -05:00
exceptionfactory 6bfc798515 NIFI-10350 Corrected Registry User Authorization for OIDC
- Moved refresh of Registry Configuration to checkLogin functions
- Refreshing Registry Configuration allows the user interface to reflect the correct status for OIDC and other authentication strategies

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6295.
2022-08-22 16:01:28 -04:00
exceptionfactory 24cea2a93b
NIFI-10183 Upgraded swagger-annotations to 1.6.6
- Added managed dependency in root Maven configuration
- Removed different versions from other Maven configurations

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #6284.
2022-08-10 15:32:30 +02:00
exceptionfactory a4ea92ea3b NIFI-10217 Refactored Registry Spring Security Configuration
Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6196.
2022-08-08 16:23:37 -04:00
dependabot[bot] 7faa2df005
NIFI-10326 Upgraded PostgreSQL JDBC for Registry tests from 42.3.5 to 42.4.1
This closes #6274

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-08-08 09:14:52 -05:00
Kevin Doran 70b73f63fd
NIFI-10323 Switch Dockerfiles to use zip artifacts
This closes #6266

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-08-05 11:56:34 -05:00
Joe Witt ded48269fe
Merge branch 'NIFI-10272-RC2' 2022-08-01 06:10:25 -07:00
Emilio Setiadarma 296f308cdc
NIFI-10048 Corrected StandardFlowDifference.hashCode() to avoid NPE
- Added tests to TestFlowController for JSON flow configuration

This closes #6227

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-07-29 13:44:26 -05:00
Joe Witt 8c66bf948c
NIFI-10272-RC2 prepare for next development iteration 2022-07-27 13:24:09 -07:00
Joe Witt 8d256784d8
NIFI-10272-RC2 prepare release nifi-1.17.0-RC2 2022-07-27 13:24:06 -07:00
Mark Payne 92750c2746
NIFI-10261: Ensure that when comparing Sensitive Parameters during flow sync we decrypt values for the comparison
This closes #6231

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-07-25 10:52:46 -05:00
Nissim Shiman db11961026
NIFI-9440 Allow Controller Services to have configurable Bulletins
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #6035
2022-06-28 10:44:45 -04:00
exceptionfactory 4aee4546b9
NIFI-10135 Upgraded maven-surefire-plugin to 3.0.0-M7
- Removed duplicate plugin configuration in nifi-registry
- Removed maven-failsafe-plugin override in nifi-elasticsearch-client-service
- Removed failing test ResourceAuthorizationFilterSpec in nifi-registry-web-api

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #6132.
2022-06-18 09:43:46 +02:00
exceptionfactory bd45eb4995 NIFI-10100 Upgraded Jersey to 2.35
- Replaced individual version references with Jersey BOM dependency

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #6106.
2022-06-16 23:09:22 -04:00
mr1716 f08c971a89
NIFI-10090 Upgraded to Guava 31.1 in Toolkit and Registry
This closes #6120

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-06-14 09:24:09 -05:00
exceptionfactory f91d877043
NIFI-10114 This closes #6122. Removed Single Refresh from ShellUserGroupProvider
Signed-off-by: Joe Witt <joewitt@apache.org>
2022-06-13 14:38:19 -07:00
Joe Gresock 48de70a568
NIFI-10071: Adding support for HashiCorp Vault K/V version 2 Secrets Engine (#6087) 2022-06-01 15:09:01 -04:00
exceptionfactory 99be62be67
NIFI-9958 Add Framework Support for Sensitive Dynamic Properties (#6057)
* NIFI-9958 Implemented Sensitive Dynamic Properties

- Added SupportsSensitiveDynamicProperties annotation for components
- Added optional sensitive query parameter to Property Descriptor REST Resource methods
- Added system tests for components supporting sensitive dynamic properties
- Updated REST Resources to support Sensitive Dynamic Property Names
- Updated Documentation Writer to indicate component support for Sensitive Dynamic Properties
- Updated InvokeHTTP to support Sensitive Dynamic Properties
- Updated Auditor components to handle masking Sensitive Dynamic Properties

* Refactored Property Descriptor REST method handling

- Corrected AbstractDocumentationWriter evaluation of support for sensitive dynamic properties
- Refactored Controller Service Dynamic Properties system tests to new class

* Updated AbstractComponentNode.getProperties() to get canonical descriptor
2022-05-23 17:20:54 -04:00
markap14 88e53eae8c
NIFI-10001: Fixed bugs that caused some components to not have their scheduled state updated. (#6049)
* NIFI-10001: Fixed issue in which some components may fail to update the scheduled state when comparing flows

* NIFI-10001: Fixed bugs that caused some components to not have their scheduled state updated. When comparing two flows, now allow specifying how to determine a VersionedComponent's ID for comparison. When comparing local flow against flow from registry, use Versioned Component ID. But when comparing two instantiated flows, such as local flow vs. cluster flow, use the VersionedComponent's Instance ID instead. This ensures that we can properly compare two components even if there are several instances of a given flow
2022-05-18 13:53:36 -04:00
exceptionfactory eecdf38158
NIFI-10014 Upgraded Registry Test JDBC Drivers
- Upgraded MySQL from 8.0.15 to 8.0.29
- Upgraded MariabDB from 2.4.1 to 3.0.4
- Upgraded PostgreSQL from 42.2.19 to 42.3.5
- Removed unsupported database version references from project README.md
- Added MariaDB 10.3 to list of Registry examples

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #6033.
2022-05-12 22:41:00 +02:00
dependabot[bot] a038309ba4
NIFI-10006 Upgraded async from 2.6.3 to 2.6.4 for Registry
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

This closes #6007

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-05-09 14:02:05 -05:00
exceptionfactory 0c8305950c
NIFI-9987 Standardize Commons IO on version 2.11.0
- Removed version declarations from multiple modules
- Adjusted PutDynamoDB to remove catch for IOException not thrown in Commons IO 2.11.0

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #6015.
2022-05-09 12:06:37 +02:00
Matthieu Bertin 65dbbc9e76 NIFI-9966 Corrects the registry loading of large flowfiles from git
This closes #6012

Signed-off-by: Chris Sampson <chris.sampson82@gmail.com>
2022-05-07 13:37:28 +01:00
dependabot[bot] 3699d42116
NIFI-9932 Upgrade minimist from 1.2.5 to 1.2.6
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

This closes #5971

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-05-03 13:49:45 -05:00
exceptionfactory 4f423a59ba
NIFI-9952 Upgraded Jackson BOM to 2.13.2.20220328
- Removed unnecessary references to jackson.version property
- Removed unnecessary dependency management references to Jackson libraries

This closes #5992

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-04-23 08:23:39 -04:00
Bryan Bende 3a15d4fbe5 NIFI-9950 Identify MariaDB database type and use MySQL migration scripts
Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes 5989.
2022-04-21 22:43:34 -04:00
exceptionfactory 18a4182cb0
NIFI-9883 Refactor Property Protection using Isolated ClassLoader (#5972)
* NIFI-9883 Refactored property protection to isolated ClassLoader

- Added nifi-property-protection-loader for abstracting access to implementation classes using ServiceLoader
- Updated Authorizer and Login Identity Provider configuration using isolated ClassLoader
- Updated NiFi Properties Loader using isolated ClassLoader
- Updated nifi-assembly to place property protection dependencies in lib/properties directory
- Updated and refactored unit tests
- Corrected LoginIdentityProviderFactoryBean getObject() Type
2022-04-19 11:08:04 -04:00
Joe Witt 84340962d4
NIFI-9927 Initial Commit to clean up all extraneous version/group declarations.
This closes #5969

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-04-16 12:05:07 -04:00
exceptionfactory 15f7590f7a
NIFI-9901 Added nifi-xml-processing to nifi-commons
- Refactored XML parsing to use providers from nifi-xml-processing
- Configured spotbugs-maven-plugin with findsecbugs-plugin in nifi-xml-processing
- Disabled Validate DTD in default configuration for EvaluateXPath and EvaluateXQuery
- Replaced configuration of DocumentBuilder and streaming XML Readers with shared components
- Removed XML utilities from nifi-security-utils
- Moved Commons Configuration classes to nifi-lookup-services

This closes #5962
Signed-off-by: Paul Grey <greyp@apache.org>
2022-04-13 19:56:57 -04:00
dependabot[bot] 0a25f39410
Bump moment (#5952)
Bumps [moment](https://github.com/moment/moment) from 2.22.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.22.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This closes #5952
2022-04-12 11:44:58 -04:00
Joe Witt 873d25585c
NIFI-9780 Merge branch 'NIFI-9780-RC3' 2022-04-04 08:35:23 -07:00
Bryan Bende 3c10910fe2 NIFI-9845 Fix NiFi Registry database ITs
- remove unsupported DB test containers, update admin guide

This closes #5914.

Signed-off-by: Kevin Doran <kdoran@apache.org>
2022-03-31 13:42:25 -04:00
Jonathan Conti-Vock d09b828333
NIFI-9816 Added lang attribute to html tag for WCAG 2.1 Accessibility
This closes #5893

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-03-30 08:38:46 -05:00
Zoltán Kornél Török 2f501fcbe5
NIFI-9836: fix database selection during nifi registry startup (#5907) 2022-03-29 11:32:21 -04:00
Joe Witt 0419dc2939
NIFI-9780-RC3 prepare for next development iteration 2022-03-21 11:58:27 -07:00
Joe Witt b019a9191f
NIFI-9780-RC3 prepare release nifi-1.16.0-RC3 2022-03-21 11:58:09 -07:00
Mike Thomsen 2bb1a06a8c
NIFI-9788 Updated commons-codec to 1.15 across all modules.
This closes #5881

Signed-off-by: David Handermann <exceptionfactory@apache.org>
2022-03-21 09:13:05 -05:00
exceptionfactory 7823156606
NIFI-9815 Corrected log message formatting in multiple classes
This closes #5879

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-03-18 20:11:05 -04:00
exceptionfactory 412e21be97
NIFI-9281 Enabled building on Java 17
- Added Ubuntu Zulu JDK 17 GitHub build
- Adjusted MiNiFi C2 FileSystemConfigurationCache test to avoid using environment variables
- Adjusted MiNiFi StatusLogger and StatusLoggerTest to avoid overriding private logger
- Adjusted failure reason attribute check in TestGetIgniteCache
- Adjusted TestRangerAuthorizer and TestRangerNiFiAuthorizer to avoid checking nested exceptions
- Adjusted encrypt-config TestUtil to avoid unnecessary comparison of different types
- Disabled Javascript tests on Java 15 and higher
- Disabled several Hive 3 tests on Java 17 for StringInternUtils illegal access
- Refactored nifi-enrich-processors tests to use Mockito without Powermock
- Refactored nifi-toolkit-tls tests to avoid illegal reflective access
- Removed deprecated X509Certificate test in CertificateUtilsTest
- Removed kryo serialization from nifi-site-to-site-client test
- Updated TestHashContent to use SHA-1 instead of SHA for hash algorithm
- Upgraded maven-war-plugin from 2.5 to 3.3.2
- Upgraded nifi-graph-bundle dependencies from Groovy 2.5.14 to 3.0.8
- Upgraded QuestDB from 4.2.1 to 6.2.1 in nifi-framework-core

This closes #5870

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
2022-03-17 14:08:38 -04:00
Matthew Burgess a4a46d50c3
NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
NIFI-9316: Incorporated review comments
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #5496
2022-03-16 14:25:32 -04:00