Apache
/
olingo-odata4
mirror of https://github.com/apache/olingo-odata4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[OLINGO-206] TDD setup for URI Validator

This commit is contained in:
Stephan Klevenz 2014-03-14 15:56:13 +01:00
parent ec39fd600b
commit df675e15af
3 changed files with 192 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/server-core/src/main/java/org/apache/olingo/server/core/uri/validator/UriValidationException.java Normal file
View File

@ -0,0 +1,25 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.olingo.server.core.uri.validator;
public class UriValidationException extends Exception {
private static final long serialVersionUID = -3179078078053564742L;
}

37
lib/server-core/src/main/java/org/apache/olingo/server/core/uri/validator/Validator.java Normal file
View File

@ -0,0 +1,37 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.olingo.server.core.uri.validator;
import org.apache.olingo.commons.api.edm.Edm;
import org.apache.olingo.server.api.uri.UriInfo;
public class Validator {
public void validate(UriInfo uriInfo, Edm edm) throws UriValidationException {
switch (uriInfo.getKind()) {
case metadata:
if (uriInfo.getTopOption() != null) {
throw new UriValidationException();
}
break;
default:
}
}
}

130
lib/server-core/src/test/java/org/apache/olingo/server/core/uri/validator/UriEdmValidatorTest.java Normal file
View File

@ -0,0 +1,130 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.olingo.server.core.uri.validator;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.*;
import org.apache.olingo.commons.api.edm.Edm;
import org.apache.olingo.server.api.uri.UriInfo;
import org.apache.olingo.server.core.edm.provider.EdmProviderImpl;
import org.apache.olingo.server.core.testutil.EdmTechProvider;
import org.apache.olingo.server.core.uri.parser.Parser;
import org.apache.olingo.server.core.uri.parser.RawUri;
import org.apache.olingo.server.core.uri.parser.UriDecoder;
import org.apache.olingo.server.core.uri.parser.UriParserException;
import org.junit.Test;
public class UriEdmValidatorTest {
private Edm edm = new EdmProviderImpl(new EdmTechProvider());
String[] uris = {
"$crossjoin(ESKeyNav, ESTwoKeyNav)/invalid ",
"$crossjoin(invalidEntitySet) ",
"$entity ",
"$entity?$idfalse=ESKeyNav(1) ",
"ESAllPrim(PropertyInt16='1') ",
"ESCollAllPrim(null) ",
"ESTwoPrim(1)/com.sap.odata.test1.ETBase(1) ",
"ESTwoPrim/com.sap.odata.test1.ETBase(1)/com.sap.odata.test1.ETTwoBase(1) ",
"ESTwoPrim/com.sap.odata.test1.ETBase(1)/com.sap.odata.test1.ETTwoBase(1) ",
"FICRTCollCTTwoPrimParam(ParameterInt16='1',ParameterString='2') ",
"FICRTESTwoKeyNavParam(ParameterInt16=@invalidAlias)?@validAlias=1 ",
"FINRTESMixPrimCollCompTwoParam(ParameterInt16=1,ParameterString='2')/PropertyComplex ",
"FINRTESMixPrimCollCompTwoParam(ParameterInt16=1,ParameterString='2')/$count ",
"ESKeyNav(1)?$expand=NavPropertyETKeyNavOne/$ref ",
"ESKeyNav(1)?$expand=NavPropertyETKeyNavOne/$count ",
"ESKeyNav?$top=-3 ",
"ESAllPrim?$count=foo ",
"ESAllPrim?$skip=-3 "
};
@Test
public void foo() throws Exception {
for (String uri : uris) {
Parser parser = new Parser();
System.out.println(uri);
UriInfo uriInfo = parser.parseUri(uri.trim(), edm);
assertNotNull(uriInfo);
}
}
@Test
public void keyPredicateValidTypes() throws Exception {
String[] uris = { "/ESAllPrim" };
for (String uri : uris) {
parseAndValidate(uri);
}
}
@Test
public void keyPredicateInvalidTypes() throws UriParserException {
String[] uris = {};
for (String uri : uris) {
try {
parseAndValidate(uri);
fail("Validation Exception not thrown: " + uri);
} catch (UriValidationException e) {
assertTrue(e instanceof UriValidationException);
}
}
}
@Test
public void systemQueryOptionValid() throws Exception {
String[] uris = {
"/$metadata",
"/$metadata?$format=json"
};
for (String uri : uris) {
parseAndValidate(uri);
}
}
@Test
public void systemQueryOptionInvalid() throws Exception {
String[] uris = {
"/$metadata?$format=json&$top=3"
};
for (String uri : uris) {
try {
parseAndValidate(uri);
fail("Validation Exception not thrown: " + uri);
} catch (UriValidationException e) {
assertTrue(e instanceof UriValidationException);
}
}
}
private void parseAndValidate(String uri) throws UriParserException, UriValidationException {
UriInfo uriInfo = new Parser().parseUri(uri.trim(), edm);
Validator validator = new Validator();
validator.validate(uriInfo, edm);
}
}