Apache
/
openjpa
mirror of https://github.com/apache/openjpa.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OPENJPA-2348: Cache calculated hashcode in OpenJPAId. 

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1452884 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Richard G. Curtis 2013-03-05 16:25:55 +00:00
parent 8c23eb3f48
commit 1e2b753afa
1 changed files with 21 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
openjpa-kernel/src/main/java/org/apache/openjpa/util/OpenJPAId.java
View File

@ -29,16 +29,17 @@ import org.apache.openjpa.lib.util.concurrent.ConcurrentReferenceHashMap;
* @author Steve Kim * @author Steve Kim
*/ */
@SuppressWarnings("serial") @SuppressWarnings("serial")
public abstract class OpenJPAId public abstract class OpenJPAId implements Comparable, Serializable {
implements Comparable, Serializable {
public static final char TYPE_VALUE_SEP = '-'; public static final char TYPE_VALUE_SEP = '-';
// cache the types' generated hash codes // cache the types' generated hash codes
private static ConcurrentReferenceHashMap _typeCache = private static ConcurrentReferenceHashMap _typeCache =
new ConcurrentReferenceHashMap(ReferenceMap.WEAK, ReferenceMap.HARD); new ConcurrentReferenceHashMap(ReferenceMap.WEAK, ReferenceMap.HARD);
protected Class type; protected Class<?> type;
protected boolean subs = true; protected boolean subs = true;
private int _hc = -1;
// type hash is based on the least-derived non-object class so that // type hash is based on the least-derived non-object class so that
// user-given ids with non-exact types match ids with exact types // user-given ids with non-exact types match ids with exact types
@ -106,7 +107,8 @@ public abstract class OpenJPAId
* so that it doesn't have to be generated each time. * so that it doesn't have to be generated each time.
*/ */
public int hashCode() { public int hashCode() {
if (_typeHash == 0) { if (_hc == -1) {
if (_typeHash == 0 && type != null) {
Integer typeHashInt = (Integer) _typeCache.get(type); Integer typeHashInt = (Integer) _typeCache.get(type);
if (typeHashInt == null) { if (typeHashInt == null) {
Class base = type; Class base = type;
@ -120,8 +122,12 @@ public abstract class OpenJPAId
} else { } else {
_typeHash = typeHashInt.intValue(); _typeHash = typeHashInt.intValue();
} }
_hc = _typeHash ^ idHash();
} else {
_hc = idHash();
} }
return _typeHash ^ idHash(); }
return _hc;
} }
public boolean equals(Object o) { public boolean equals(Object o) {