From 2771cce607663ce19f87cf60f068bcc45eefe24d Mon Sep 17 00:00:00 2001 From: Jean-Louis Monteiro Date: Thu, 27 May 2021 15:26:09 +0200 Subject: [PATCH] Small fixes on the tests --- ...tPersistenceProviderFilteringTestCase.java | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/test/TestPersistenceProviderFilteringTestCase.java b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/test/TestPersistenceProviderFilteringTestCase.java index 9ee4946aa..8de39b752 100644 --- a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/test/TestPersistenceProviderFilteringTestCase.java +++ b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/test/TestPersistenceProviderFilteringTestCase.java @@ -47,30 +47,14 @@ public class TestPersistenceProviderFilteringTestCase extends SQLListenerTestCas public void testGenerateSchemaNoProvider() { final PersistenceProviderImpl ppi = new PersistenceProviderImpl(); final Map map = new HashMap<>(); - map.put("javax.persistence.jdbc.driver", "org.apache.derby.jdbc.EmbeddedDriver"); - map.put("javax.persistence.jdbc.url", "jdbc:derby:target/database/openjpa-test-provider-database;create=true"); - try { - ppi.generateSchema(persistenceUnitName, map); - fail("Should have fail because there is no pool or so to generate the schema"); - - } catch (final UserException e) { - // great - } + assertTrue(ppi.generateSchema(persistenceUnitName, map)); } public void testGenerateSchemaOpenJPAProvider() { final PersistenceProviderImpl ppi = new PersistenceProviderImpl(); final Map map = new HashMap<>(); map.put("javax.persistence.provider", PersistenceProviderImpl.class.getName()); - map.put("javax.persistence.jdbc.driver", "org.apache.derby.jdbc.EmbeddedDriver"); - map.put("javax.persistence.jdbc.url", "jdbc:derby:target/database/openjpa-test-provider-database;create=true"); - try { - ppi.generateSchema(persistenceUnitName, map); - fail("Should have fail because there is no pool or so to generate the schema"); - - } catch (final UserException e) { - // great - } + assertTrue(ppi.generateSchema(persistenceUnitName, map)); } public void testGenerateSchemaEclipseProvider() {