Apache
/
openjpa
mirror of https://github.com/apache/openjpa.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OPENJPA-900: Remove hint key ordering for performance overhead 

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@782782 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Pinaki Poddar 2009-06-08 21:04:00 +00:00
parent 2236c1833e
commit 43de09873b
1 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
openjpa-persistence/src/main/java/org/apache/openjpa/persistence/HintHandler.java
View File

@ -167,7 +167,7 @@ public class HintHandler extends FetchPlanHintHandler {
*/ */
public Set<String> getSupportedHints() { public Set<String> getSupportedHints() {
if (_supportedKeys == null) { if (_supportedKeys == null) {
_supportedKeys = new TreeSet<String>(new HintKeyComparator()); _supportedKeys = new TreeSet<String>();
_supportedPrefixes = new TreeSet<String>(); _supportedPrefixes = new TreeSet<String>();
_supportedKeys.addAll(Reflection.getFieldValues( _supportedKeys.addAll(Reflection.getFieldValues(
@ -176,7 +176,8 @@ public class HintHandler extends FetchPlanHintHandler {
String.class)); String.class));
_supportedKeys.addAll(addPrefix(PREFIX_FETCHPLAN, _supportedKeys.addAll(addPrefix(PREFIX_FETCHPLAN,
Reflection.getBeanStylePropertyNames(_fConfig.getClass()))); Reflection.getBeanStylePropertyNames(
owner.getFetchPlan().getClass())));
_supportedKeys.addAll(JavaxHintsMap.keySet()); _supportedKeys.addAll(JavaxHintsMap.keySet());
@ -284,24 +285,6 @@ public class HintHandler extends FetchPlanHintHandler {
return objectSet; return objectSet;
} }
public static class HintKeyComparator implements Comparator<String> {
public int compare(String s1, String s2) {
if (getPrefixOf(s1).equals(getPrefixOf(s2))) {
int n1 = countDots(s1);
int n2 = countDots(s2);
return (n1 == n2) ? s1.compareTo(s2) : (n1 - n2);
} else
return s1.compareTo(s2);
}
public int countDots(String s) {
if (s == null || s.length() == 0)
return 0;
int index = s.indexOf(DOT);
return (index == -1) ? 0 : countDots(s.substring(index + 1)) + 1;
}
}
protected String hintToKey(String key) { protected String hintToKey(String key) {
// Let superclass performs key transformation when fPlan.setHint() // Let superclass performs key transformation when fPlan.setHint()
// is called. // is called.
@ -316,3 +299,4 @@ public class HintHandler extends FetchPlanHintHandler {
return result; return result;
} }
} }