From 72ddd27a00ee5e345a69a081abcf19cdd3d83a96 Mon Sep 17 00:00:00 2001
From: Donald Woods <dwoods@apache.org>
Date: Tue, 15 Jun 2010 02:09:06 +0000
Subject: [PATCH] OPENJPA-1700 FindBugs - Suspicious reference comparison of
 Boolean values

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@954694 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/openjpa/lib/rop/ResultObjectProviderIterator.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java b/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java
index 72a8a8bb2..a0d0dd5a0 100644
--- a/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java
+++ b/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java
@@ -46,7 +46,7 @@ public class ResultObjectProviderIterator implements Iterator, Closeable {
      * Close the underlying result object provider.
      */
     public void close() {
-        if (_open == Boolean.TRUE) {
+        if (Boolean.TRUE.equals(_open)) {
             try {
                 _rop.close();
             } catch (Exception e) {
@@ -60,7 +60,7 @@ public class ResultObjectProviderIterator implements Iterator, Closeable {
     }
 
     public boolean hasNext() {
-        if (_open == Boolean.FALSE)
+        if (Boolean.FALSE.equals(_open))
             return false;
 
         if (_hasNext == null) {