From 857abde46c85239d472410f0c005877dd8632d30 Mon Sep 17 00:00:00 2001
From: Pinaki Poddar <ppoddar@apache.org>
Date: Tue, 27 Dec 2011 17:12:04 +0000
Subject: [PATCH] Wrong logic in setting default remote commit provider

git-svn-id: https://svn.apache.org/repos/asf/openjpa/trunk@1224948 13f79535-47bb-0310-9956-ffa450edef68
---
 .../openjpa/persistence/PersistenceProductDerivation.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/PersistenceProductDerivation.java b/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/PersistenceProductDerivation.java
index 4341dd435..e48321dc0 100644
--- a/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/PersistenceProductDerivation.java
+++ b/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/PersistenceProductDerivation.java
@@ -702,9 +702,9 @@ public class PersistenceProductDerivation
                 String dc = oconf.getDataCache();
                 String rcp = oconf.getRemoteCommitProvider();
                 // If the datacache is set and is something other than false
-                if (dc != null && dc.equals("false") == false) {
+                if (dc != null && !"false".equals(dc)) {
                     // If RCP is null or empty, set it to sjvm.
-                    if (rcp == null || (rcp != null && rcp.equals("") == false)) {
+                    if (rcp == null || "".equals(rcp)) {
                         oconf.setRemoteCommitProvider("sjvm");
                     }
                 }