diff --git a/openjpa-persistence-locking/src/test/java/org/apache/openjpa/persistence/lockmgr/LockEmployee.java b/openjpa-persistence-locking/src/test/java/org/apache/openjpa/persistence/lockmgr/LockEmployee.java index b816dc6f7..a58ea2a32 100644 --- a/openjpa-persistence-locking/src/test/java/org/apache/openjpa/persistence/lockmgr/LockEmployee.java +++ b/openjpa-persistence-locking/src/test/java/org/apache/openjpa/persistence/lockmgr/LockEmployee.java @@ -25,14 +25,18 @@ import java.io.ObjectOutput; import javax.persistence.Entity; import javax.persistence.Id; +import javax.persistence.LockModeType; +import javax.persistence.NamedQueries; import javax.persistence.NamedQuery; import javax.persistence.Version; -@NamedQuery( - name="findEmployeeById" - , query="SELECT c FROM LockEmployee c WHERE c.id = :id" - ) - +@NamedQueries( { + @NamedQuery(name = "findEmployeeById", + query = "SELECT c FROM LockEmployee c WHERE c.id = :id"), + @NamedQuery(name = "findEmployeeByIdWithLock", + query = "SELECT c FROM LockEmployee c WHERE c.id = :id", lockMode = LockModeType.PESSIMISTIC_READ), + @NamedQuery(name = "findEmployeeByIdWithNoLock", + query = "SELECT c FROM LockEmployee c WHERE c.id = :id", lockMode = LockModeType.NONE) }) @Entity public class LockEmployee implements Externalizable { diff --git a/openjpa-persistence-locking/src/test/java/org/apache/openjpa/persistence/lockmgr/TestNamedQueryLockMode.java b/openjpa-persistence-locking/src/test/java/org/apache/openjpa/persistence/lockmgr/TestNamedQueryLockMode.java new file mode 100644 index 000000000..c108abacc --- /dev/null +++ b/openjpa-persistence-locking/src/test/java/org/apache/openjpa/persistence/lockmgr/TestNamedQueryLockMode.java @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.openjpa.persistence.lockmgr; + +import javax.persistence.EntityManager; +import javax.persistence.Query; + +import org.apache.openjpa.persistence.TransactionRequiredException; +import org.apache.openjpa.persistence.test.AllowFailure; +import org.apache.openjpa.persistence.test.SQLListenerTestCase; + +/** + * Tests the lock mode on named query emits a FOR UPDATE clause in target SQL + * query. + * + * + */ +public class TestNamedQueryLockMode extends SQLListenerTestCase { + public void setUp() { + super.setUp(CLEAR_TABLES, LockEmployee.class, + "openjpa.LockManager", "pessimistic", + "openjpa.Optimistic", "false" + ); + } + + public void testForUpdateClausePresentInNamedQueryWithLockMode() { + EntityManager em = emf.createEntityManager(); + em.getTransaction().begin(); + assertClausePresentInSQL("FOR UPDATE", em.createNamedQuery("findEmployeeByIdWithLock").setParameter("id", 0)); + em.getTransaction().rollback(); + em.getTransaction().begin(); + assertClausePresentInSQL("FOR UPDATE", em.createNamedQuery("findEmployeeByIdWithLock").setParameter("id", 0)); + em.getTransaction().rollback(); + em.getTransaction().begin(); + assertClausePresentInSQL("FOR UPDATE", em.createNamedQuery("findEmployeeByIdWithLock").setParameter("id", 0)); + em.getTransaction().rollback(); + } + + @AllowFailure + public void testNamedQueryWithLockModeMustExecuteInTransaction() { + EntityManager em = emf.createEntityManager(); + // execute without a transaction + try { + em.createNamedQuery("findEmployeeByIdWithLock").setParameter("id", + 0).getResultList(); + fail("Expected " + TransactionRequiredException.class.getName()); + } catch (TransactionRequiredException e) { + // Expected + } + } + + public void testForUpdateClausePresentInQueryWithDefault() { + EntityManager em = emf.createEntityManager(); + em.getTransaction().begin(); + assertClausePresentInSQL("FOR UPDATE", em.createNamedQuery("findEmployeeById").setParameter("id", 0)); + assertClausePresentInSQL("FOR UPDATE", em.createNamedQuery("findEmployeeById").setParameter("id", 0)); + em.getTransaction().commit(); + } + + @AllowFailure + public void testForUpdateClauseAbsentInQueryWithExplictNoLock() { + EntityManager em = emf.createEntityManager(); + em.getTransaction().begin(); + assertClauseAbsentInSQL("FOR UPDATE", em.createNamedQuery("findEmployeeByIdWithNoLock").setParameter("id", 0)); + assertClauseAbsentInSQL("FOR UPDATE", em.createNamedQuery("findEmployeeByIdWithNoLock").setParameter("id", 0)); + em.getTransaction().commit(); + } + + String getLastSQL() { + String last = sql.get(getSQLCount() - 1); + assertNotNull("No last sql found", last); + return last; + } + + void assertClausePresentInSQL(String clause, Query q) { + q.getResultList(); + String last = getLastSQL(); + assertTrue(clause + " is not present in " + last, last.toUpperCase().indexOf(clause) != -1); + } + + void assertClauseAbsentInSQL(String clause, Query q) { + q.getResultList(); + String last = getLastSQL(); + assertTrue(clause + " is not absent in " + last, last.toUpperCase().indexOf(clause) == -1); + } +}